Ack with minor comment: there is no check for the return value from
sleep(), so sleep time may be shortened if interrupted by a signal.
Also, sleep() is an old function that according to man page may be
implemented using SIGALRM, which means there is a risk of interference
from other threads
Ack,
Thanks,
Hans
-Original Message-
From: praveen.malv...@oracle.com [mailto:praveen.malv...@oracle.com]
Sent: den 12 maj 2014 17:13
To: Hans Feldt; nagendr...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] amfnd : avoid multiple clean up of comps during
osaf/services/saf/amf/amfnd/susm.cc | 16 +---
1 files changed, 13 insertions(+), 3 deletions(-)
In case of npi su restart recovery, the condition to change su presence
state is not sufficient. If the component of the last csi in csi_list has been
restarted first due to
Summary: v3 amfnd: Not all npi-components are restarted during SuRestart
escalation [#885]
Review request for Trac Ticket(s): 885
Peer Reviewer(s): Hans F, Hans N, Nagendra, Praveen
Pull request to:
Affected branch(es): default
Development branch: default
Hi zoran,
Following are the comments:
1. The patch is not compatible at upgrade.
Eg: If one node having new release and other node having older release,
then following is the errors:
osafimmnd[15258]: ER Illegal IMMND message type:97
osafimmnd[15258]: ER Edu decode Failed
osafimmnd[15258]: ER
Ack.
Thanks
Praveen
On 15-May-14 3:00 PM, Minh Hon Chau wrote:
osaf/services/saf/amf/amfnd/susm.cc | 16 +---
1 files changed, 13 insertions(+), 3 deletions(-)
In case of npi su restart recovery, the condition to change su presence
state is not sufficient. If the component
Ok, keep a notice log. Ack.
Thanks
-Nagu
-Original Message-
From: Alex Jones [mailto:ajo...@genband.com]
Sent: 13 May 2014 20:29
To: Nagendra Kumar; hans.fe...@ericsson.com; Praveen Malviya
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1 of 1] amfd: allow change to
if (value_is_deleted)
sg-saAmfSGNumPrefActiveSUs = sg-saAmfSGNumPrefActiveSUs;
shouldn't it reset the value from the SgType?
Thanks,
Hans
-Original Message-
From: Nagendra Kumar [mailto:nagendr...@oracle.com]
Sent: den 15 maj 2014 13:56
To: Alex Jones; Hans Feldt; Praveen
There is no value corresponding to it in sgtype.
-Original Message-
From: Hans Feldt [mailto:hans.fe...@ericsson.com]
Sent: 15 May 2014 17:22
To: Nagendra Kumar; Alex Jones; Praveen Malviya
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [PATCH 1 of 1] amfd: allow change to
Some comments inlined with Nagu
Thanks
-Nagu
-Original Message-
From: Gary Lee [mailto:gary@dektech.com.au]
Sent: 08 May 2014 12:14
To: hans.fe...@ericsson.com; hans.nordeb...@ericsson.com; Nagendra
Kumar; Praveen Malviya
Cc: opensaf-devel@lists.sourceforge.net
Subject:
Yeah OK but the default is one(1). Should it be reverted to that or it so that
we can't allow to decrease this value?
/Hans
-Original Message-
From: Nagendra Kumar [mailto:nagendr...@oracle.com]
Sent: den 15 maj 2014 14:00
To: Hans Feldt; Alex Jones; Praveen Malviya
Cc:
Ack,
Thanks,
Hans
-Original Message-
From: Alex Jones [mailto:ajo...@genband.com]
Sent: den 12 maj 2014 21:06
To: Hans Feldt; nagendr...@oracle.com; praveen.malv...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] amfd: allow change to
osaf/services/saf/smfsv/smfd/SmfUpgradeProcedure.cc | 10 +-
1 files changed, 9 insertions(+), 1 deletions(-)
Without this patch a cluster reboot in state execution completed will put
the upgrade campaign in a fail state if the old unused versioned types are
removed in the campaign
Summary: smfd: campaign can be committed after cluster reboot in state completed
Review request for Trac Ticket(s): 906
Peer Reviewer(s): Anders W
Pull request to:
Affected branch(es): 4.3.x, 4.4.x, default
Development branch: default
Impacted area Impact
Summary: v4 amfnd: Not all npi-components are restarted during SuRestart
escalation [#885]
Review request for Trac Ticket(s): 885
Peer Reviewer(s): Hans F, Hans N, Nagendra, Praveen
Pull request to:
Affected branch(es): default
Development branch: default
Hi Neelakanta,
Find my answers inline.
Best regards,
Zoran
-Original Message-
From: Neelakanta Reddy [mailto:reddy.neelaka...@oracle.com]
Sent: den 15 maj 2014 11:49
To: Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 0 of 3] Review Request for imm: add
Hi zoran,
comments inline.
/Neel.
On Thursday 15 May 2014 08:09 PM, Zoran Milinkovic wrote:
Hi Neelakanta,
Find my answers inline.
Best regards,
Zoran
-Original Message-
From: Neelakanta Reddy [mailto:reddy.neelaka...@oracle.com]
Sent: den 15 maj 2014 11:49
To: Zoran
17 matches
Mail list logo
