[devel] [PATCH 0 of 2] Review Request for AMF SU refactoring #713

2014-06-12 Thread Hans Feldt
Summary: <> Review request for Trac Ticket(s): <> Peer Reviewer(s): <> Pull request to: <> Affected branch(es): <> Development branch: <> Impacted area Impact y/n Docsn Build systemn RPM/pack

[devel] [PATCH 1 of 2] amfd: remove unused applier related code [#713]

2014-06-12 Thread Hans Feldt
osaf/services/saf/amf/amfd/imm.cc| 47 osaf/services/saf/amf/amfd/include/imm.h | 1 - 2 files changed, 0 insertions(+), 48 deletions(-) diff --git a/osaf/services/saf/amf/amfd/imm.cc b/osaf/services/saf/amf/amfd/imm.cc --- a/osaf/services/saf/amf/amf

[devel] [PATCH 2 of 2] amfd: remove avd_su_get_or_create [#713]

2014-06-12 Thread Hans Feldt
osaf/services/saf/amf/amfd/ckpt_dec.cc | 8 +++- osaf/services/saf/amf/amfd/include/db_template.h | 4 +++- osaf/services/saf/amf/amfd/include/su.h | 2 -- osaf/services/saf/amf/amfd/su.cc | 21 - 4 files changed, 10 insertions(+),

Re: [devel] [PATCH 1 of 1] amfd: replace patricia tree with stl::maps in sirankedsu [#713]

2014-06-12 Thread praveen malviya
Ack. Thanks, Praveen On 13-Jun-14 10:10 AM, nagendr...@oracle.com wrote: > osaf/services/saf/amf/amfd/include/susi.h|7 +- > osaf/services/saf/amf/amfd/sg_nway_fsm.cc| 49 ++--- > osaf/services/saf/amf/amfd/sg_nwayact_fsm.cc | 30 +++--- > osaf/services/saf/amf/amfd/siass.

[devel] [PATCH 3 of 3] amfd: convert remaining macros in si.cc to functions [#713]

2014-06-12 Thread Gary Lee
osaf/services/saf/amf/amfd/include/si.h | 10 +- osaf/services/saf/amf/amfd/sg_nway_fsm.cc| 10 +- osaf/services/saf/amf/amfd/sg_nwayact_fsm.cc | 10 +- osaf/services/saf/amf/amfd/si.cc | 20 4 files changed, 35 insertions(+), 1

[devel] [PATCH 0 of 3] Review Request for amfd: SI refactoring part 4

2014-06-12 Thread Gary Lee
Summary: amfd: SI refactoring part 4 [#713] Review request for Trac Ticket(s): 713 Peer Reviewer(s): AMF maintainers Pull request to: Affected branch(es): default Development branch: default Impacted area Impact y/n Docs

[devel] [PATCH 1 of 3] amfd: move svctype and svctypecstype declarations to separate files [#713]

2014-06-12 Thread Gary Lee
osaf/services/saf/amf/amfd/include/si.h| 34 +-- osaf/services/saf/amf/amfd/include/svctype.h | 38 ++ osaf/services/saf/amf/amfd/include/svctypecstype.h | 35 3 files changed, 75 insertions(+), 32 deletions(-) Move de

[devel] [PATCH 2 of 3] amfd: Move sirankedsu declarations to its own header file [#713]

2014-06-12 Thread Gary Lee
osaf/services/saf/amf/amfd/include/si.h | 7 +-- osaf/services/saf/amf/amfd/include/sirankedsu.h | 25 + 2 files changed, 26 insertions(+), 6 deletions(-) diff --git a/osaf/services/saf/amf/amfd/include/si.h b/osaf/services/saf/amf/amfd/include/si.h --- a/

[devel] [PATCH 0 of 1] Review Request for amfd: replace patricia tree with stl::maps in sirankedsu [#713]

2014-06-12 Thread nagendra . k
Summary: amfd: replace patricia tree with stl::maps in sirankedsu [#713] Review request for Trac Ticket(s): #713 Peer Reviewer(s): Hans F, Hans N, Praveen Pull request to: <> Affected branch(es): Default Development branch: Default Impacted area Impact y/n --

[devel] [PATCH 1 of 1] amfd: replace patricia tree with stl::maps in sirankedsu [#713]

2014-06-12 Thread nagendra . k
osaf/services/saf/amf/amfd/include/susi.h|7 +- osaf/services/saf/amf/amfd/sg_nway_fsm.cc| 49 ++--- osaf/services/saf/amf/amfd/sg_nwayact_fsm.cc | 30 +++--- osaf/services/saf/amf/amfd/siass.cc | 24 ++--- osaf/services/saf/amf/amfd/sirankedsu.cc | 125 +++-

Re: [devel] [PATCH 1 of 4] amfd: remove mds copy support [#713]

2014-06-12 Thread praveen malviya
Ack for patches 2,3 and 4. Patch 1 has compilation problem. Thanks Praveen On 10-Jun-14 7:19 PM, Hans Feldt wrote: > And the rest of the series then? > > I will look into this one but the other ones should be ok I hope. > Thanks, > Hans > >> -Original Message- >> From: praveen malviya [ma

[devel] [PATCH 1 of 1] AMF: support immediate effect when changing hc-type attributes V4 [#819]

2014-06-12 Thread Hans Nordeback
osaf/libs/common/amf/include/amf_defs.h |7 + osaf/services/saf/amf/amfd/hlttype.cc | 72 - osaf/services/saf/amf/amfd/include/node.h |2 + osaf/services/saf/amf/amfd/node.cc|8 + osaf/services/saf/amf/amfnd/di.cc |3 + osaf/s

[devel] [PATCH 0 of 1] Review Request for AMF: support immediate effect when changing hc-type attributes V4 [#819]

2014-06-12 Thread Hans Nordeback
Summary: AMF: support immediate effect when changing hc-type attributes V4 Review request for Trac Ticket(s): #819 Peer Reviewer(s): HansF, Nagu, Praveen Pull request to: Affected branch(es): default Development branch: default Impacted area Impact y/n -

Re: [devel] [PATCH 0 of 1] Review Request for IMM: Add config attribute opensafLongDnsAllowed to class OpensafImm [#897]

2014-06-12 Thread Anders Björnerstedt
Thanks Neel, I will do according to your comments before pushing. /AndersBj -Original Message- From: Neelakanta Reddy [mailto:reddy.neelaka...@oracle.com] Sent: den 12 juni 2014 13:47 To: Anders Björnerstedt Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [PATCH 0 of 1] Review Requ

Re: [devel] [PATCH 0 of 1] Review Request for IMM: Add config attribute opensafLongDnsAllowed to class OpensafImm [#897]

2014-06-12 Thread Neelakanta Reddy
Hi AndersBj, Reviewed and tested the patch. Ack with minor comments. Comments: 1. OpensafImm.xml name may be changed like OpensafImm_UPgrade_4.5.xml 2. IMM README must be updated, regarding opensafLongDnsAllowed . /Neel. On Monday 09 June 2014 11:47 AM, Anders Bjornerstedt wrote: > Summary: