Hi Mathi,
I attach two pictures from the output of:
$./trace2dot -t osafamfd -f saClmDispatch -d amfd_trace.dot
$ dotty amfd_trace.dot
and
$./trace2dot -t osafamfd -d amfd_trace.dot
$ dotty amfd_trace.dot
/Thanks HansN
On 09/10/2015 10:59 AM, Mathivanan Naickan Palanivelu wrote:
Hi Hans,
Ack
Thanks
Lennart
-Original Message-
From: giang do [mailto:giang.t...@dektech.com.au]
Sent: den 8 september 2015 06:57
To: mathi.naic...@oracle.com; Vu Nguyen M; Lennart Lund
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] log: Log Service configuration changes are
Hi Hans N,
I tested with combination of SU/Node lock/locked-in with pres state inst
fail/term fail.
So, when node is locked/locked-in, even if su goes into term fail, the alarm is
not sent because the pres state becomes uninst before update_ass_state gets
called. Hope this is ok.
Ack with the
Hi Hans,
I do appreciate the idea of suggesting dotty, good thought!
I did run dotty as mentioned in the patch. We could place the trace2dot with
'execute'
permissions and place it under tools/devel/dot directory.
Also, the output i get after running dotty doesn't looks intuitive to me.
So, for
Ack
Regards,
Vu
>-Original Message-
>From: giang do [mailto:giang.t...@dektech.com.au]
>Sent: Tuesday, September 08, 2015 11:57 AM
>To: mathi.naic...@oracle.com; vu.m.ngu...@dektech.com.au;
>lennart.l...@ericsson.com
>Cc: opensaf-devel@lists.sourceforge.net
>Subject: [PATCH 0 of 1]
Looks Good unlike what i see :-). It must be some problem with the dotty
version or something.
My graphviz version is 2.26.3, what would be yours?
Anyways, ACK from me.
Cheers,
Mathi.
- hans.nordeb...@ericsson.com wrote:
> Hi Mathi,
>
> I attach two pictures from the output of:
>
>
Hi Mathi,
I use graphviz version 2.36.0. Can you send me your dot file(s), I can
have a look to see if
something is wrong. Anyhow I'll push the patch. /Thanks HansN
On 09/10/2015 11:13 AM, Mathivanan Naickan Palanivelu wrote:
> Looks Good unlike what i see :-). It must be some problem with the
Forgot to provide comments in the previous email. Please find comments inlined
with [Nagu].
Thanks
-Nagu
> -Original Message-
> From: Nagendra Kumar
> Sent: 10 September 2015 15:58
> To: Hans Nordeback; Praveen Malviya; gary@dektech.com.au
> Cc: opensaf-devel@lists.sourceforge.net
>
Ack,
Mathi.
- giang.t...@dektech.com.au wrote:
> osaf/services/saf/logsv/lgs/lgs_imm.c | 91
> +-
> 1 files changed, 34 insertions(+), 57 deletions(-)
>
>
> Remove checking that peer version is equal or bigger than version 3
> before allow changes in
Hi Mathi,
It may also be the case that your trace file(s) includes some
TRACE_ENTER without matching TRACE_LEAVE or vice versa.
The trace2dot can also be used to do "rudimentary" checks for missing
TRACE_ENTER/TRACE_LEAVE by using -c as argument.
With this info the files with mismatched
Hi Anders,
Thanks for pointing out. Please find my responses inlined with
[Nagu].
Thanks
-Nagu
> -Original Message-
> From: Anders Widell [mailto:anders.wid...@ericsson.com]
> Sent: 08 September 2015 15:44
> To: Nagendra Kumar; hans.nordeb...@ericsson.com; Praveen
Hi Nagu,
please see comment below. /Thanks HansN
On 09/10/2015 12:30 PM, Nagendra Kumar wrote:
> Forgot to provide comments in the previous email. Please find comments
> inlined with [Nagu].
>
> Thanks
> -Nagu
>> -Original Message-
>> From: Nagendra Kumar
>> Sent: 10 September 2015
Hi Nagu,
Please see comment inlined/Thanks HansN
-Original Message-
From: Nagendra Kumar [mailto:nagendr...@oracle.com]
Sent: den 10 september 2015 13:04
To: Hans Nordebäck; Praveen Malviya; Gary Lee
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [devel] [PATCH 1 of 1] amfd: Don't
Hi Nagu,
you mean the patch is acked and it can be pushed?
/Thanks HansN
On 09/10/2015 01:40 PM, Nagendra Kumar wrote:
> Hi Hans N,
> Comments inlined.
>
> Thanks
> -Nagu
>
>> -Original Message-
>> From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com]
>> Sent: 10
Hi Hans N,
Please find comment inlined.
Thanks
-Nagu
> -Original Message-
> From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com]
> Sent: 10 September 2015 16:17
> To: Nagendra Kumar; Praveen Malviya; gary@dektech.com.au
> Cc: opensaf-devel@lists.sourceforge.net
> Subject:
osaf/services/saf/amf/amfd/node.cc | 55 ++---
1 files changed, 50 insertions(+), 5 deletions(-)
allow node to be removed if it is also removed from all nodegroups
diff --git a/osaf/services/saf/amf/amfd/node.cc
b/osaf/services/saf/amf/amfd/node.cc
---
osaf/services/saf/amf/amfd/su.cc | 45 +--
1 files changed, 33 insertions(+), 12 deletions(-)
allow SU to be created on a non-existent node, as long as that node is also
created in the same CCB
diff --git a/osaf/services/saf/amf/amfd/su.cc
osaf/services/saf/amf/amfd/nodegroup.cc | 24 +++-
1 files changed, 15 insertions(+), 9 deletions(-)
allow node to be deleted from a nodegroup, even if there are SUs hosted on that
nodegroup
as long as these SUs are also removed in the same CCB
diff --git
osaf/services/saf/amf/amfd/nodeswbundle.cc | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
allow all nodeswbundles to be deleted if the node is absent
diff --git a/osaf/services/saf/amf/amfd/nodeswbundle.cc
b/osaf/services/saf/amf/amfd/nodeswbundle.cc
---
osaf/services/saf/amf/amfd/nodegroup.cc | 4
1 files changed, 4 insertions(+), 0 deletions(-)
Currently, if a nodegroup and a member node is created in the same CCB, and
the nodegroup is modified to include this new node, amfd will crash.
This change will reject the change instead of
Summary: amfd: not possible to add/remove configuration for one node in single
CCB V2 [#1458]
Review request for Trac Ticket(s): 1458
Peer Reviewer(s): AMF devs
Pull request to:
Affected branch(es): opensaf-4.6.x, default
Development branch: default
Ack with comment
Remove function lgs_is_peer_v3(). Is no longer used
Thanks
Lennart
-Original Message-
From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au]
Sent: den 9 september 2015 04:48
To: Lennart Lund; mathi.naic...@oracle.com; Giang Do T
Cc:
Hi Hans N,
Comments inlined.
Thanks
-Nagu
> -Original Message-
> From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com]
> Sent: 10 September 2015 16:54
> To: Nagendra Kumar; Praveen Malviya; Gary Lee
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: RE: [devel]
Ack from me, with the following comments:
* Correct the copyright year and authors
* It would be good if you run the "2to3" tool on this one so that it is
compatible with both python2 and python 3 (python 3 will soon be the
default version in some Linux distributions).
/ Anders Widell
On
osaf/services/saf/amf/amfd/comp.cc |5 +-
osaf/services/saf/amf/amfd/include/su.h|1 +
osaf/services/saf/amf/amfd/sgproc.cc | 18 +
osaf/services/saf/amf/amfd/su.cc | 10 +-
osaf/services/saf/amf/amfnd/clc.cc | 223 +-
Hi
See my replies marked with [AndersW] inline.
thanks,
Anders Widell
On 09/10/2015 01:27 PM, Nagendra Kumar wrote:
> Hi Anders,
> Thanks for pointing out. Please find my responses inlined with
> [Nagu].
>
> Thanks
> -Nagu
>> -Original Message-
>> From: Anders Widell
Summary: Review request for #315, #334 and #1455 v1 [#315,#334, #1455].
Review request for Trac Ticket(s): #315 #334 and #1455
Peer Reviewer(s): AMF contributors.
Pull request to: <>
Affected branch(es): default for #334 and #1455 and 4.5 for #315.
Development branch: <>
27 matches
Mail list logo
