Re: [devel] [PATCH 1 of 1] log: write_log_record_hdl get bad file descriptor [#2028]

ACK -AVM On 9/13/2016 4:19 PM, Vu Minh Nguyen wrote: > osaf/services/saf/logsv/lgs/lgs_filehdl.cc | 16 +++- > osaf/services/saf/logsv/lgs/lgs_stream.cc | 6 ++ > 2 files changed, 17 insertions(+), 5 deletions(-) > > > logsv did pass the WRITE request to file handle

Re: [devel] [PATCH 1 of 1] log: fix logtest fails when run after immomtest [#2028]

HI Vu, I did ACK some time back can you please push . -AVM On 10/5/2016 3:56 PM, A V Mahesh wrote: > Hi Vu, > > Can you please push this ? > > -AVM > > > On 9/20/2016 9:50 AM, A V Mahesh wrote: >> ACK, >> >> Not tested. >> >> -AVM >> >> >> On 9/13/2016 4:50 PM, Vu Minh Nguyen wrote: >>>

Re: [devel] [PATCH 1 of 1] log: fix cppcheck with performance severity [#1975]

Thanks Lennart, I will add this before pushing code. Regards, Canh. -Original Message- From: Lennart Lund [mailto:lennart.l...@ericsson.com] Sent: Tuesday, October 11, 2016 8:51 PM To: Canh Van Truong; Vu Minh Nguyen; mahesh.va...@oracle.com Cc: opensaf-devel@lists.sourceforge.net

Re: [devel] [PATCH 1 of 1] log: fix cppcheck with performance severity [#1975]

Hi Canh, ACK . -AVM On 9/1/2016 12:22 PM, Canh Truong wrote: > Hi Mahesh, > > I run cppcheck with latest version 1.75. I got from: > https://sourceforge.net/projects/cppcheck/files/cppcheck/1.75/ > And build, then run with option --enable=performance. > > Regards, > Canh. > > -Original

[devel] [PATCH 0 of 1] Review Request for imm: Return error string when object is being created in another CCB [#2111]

Summary: imm: Return error string when object is being created in another CCB [#2111] Review request for Trac Ticket(s): 2111 Peer Reviewer(s): Zoran, Neel Pull request to: Affected branch(es): 5.2 Development branch: 5.2 Impacted area Impact y/n

[devel] [PATCH 0 of 3] Review Request for dtm: Use inotify to improve response time for transport monitor process [#2091]

Summary: dtm: Use inotify to improve response time for transport monitor process Review request for Trac Ticket(s): [#2091] Peer Reviewer(s): Ramesh, AndersW, Mahesh Pull request to: Affected branch(es): default Development branch: default Impacted area

[devel] [PATCH 3 of 3] dtm: Use inotify to improve response time for transport monitor process [#2091]

osaf/services/infrastructure/dtms/transport/tests/Makefile.am | 3 +- osaf/services/infrastructure/dtms/transport/tests/transport_monitor_test.cc | 4 +- osaf/services/infrastructure/dtms/transport/transport_monitor.cc| 41 + 3 files changed, 27

[devel] [PATCH 1 of 3] base: Use inotify to improve response time for transport monitor process [#2091]

osaf/libs/core/cplusplus/base/Makefile.am|2 + osaf/libs/core/cplusplus/base/file_notify.cc | 163 +++ osaf/libs/core/cplusplus/base/file_notify.h | 84 + 3 files changed, 249 insertions(+), 0 deletions(-) diff --git

[devel] [PATCH 1 of 1] plm: log entity path for failed HPI calls [#2109]

osaf/libs/common/plmsv/include/plms_hsm.h | 2 +- osaf/services/saf/plmsv/plms/hpi_intf/plms_epath_util.c | 8 +- osaf/services/saf/plmsv/plms/hpi_intf/plms_hrb.c| 7 +- osaf/services/saf/plmsv/plms/hpi_intf/plms_hsm.c| 89 ++-- 4 files changed, 86

[devel] [PATCH 0 of 1] Review Request for plm: log entity path for failed HPI calls [#2109]

Summary: plm: log entity path for failed HPI calls Review request for Trac Ticket(s): 2109 Peer Reviewer(s): Mathi Pull request to: Affected branch(es): default, 5.1, 5.0 Development branch: Impacted area Impact y/n Docs

Re: [devel] [PATCH 1 of 1] base: Add timer tool to osaf_time and base/time [#2090]

Ack with minor comments. See comments inline below, marked [AndersW]. regards, Anders Widell On 10/07/2016 09:47 AM, Lennart Lund wrote: > osaf/libs/core/common/include/osaf_time.h | 51 > osaf/libs/core/common/tests/Makefile.am |1 + >

Re: [devel] [PATCH 1 of 1] log: fix cppcheck with performance severity [#1975]

Hi Canh, Ack with comment 1) Why not initialize all variables in the structs in initialization list? At least for the lists where some variables are. More consistent Example: struct file_communicate { bool request_f; /* True if pending request */ bool answer_f; /* True if pending answer */

Re: [devel] [PATCH 1 of 1] log: write_log_record_hdl get bad file descriptor [#2028]

Yes. That wrong review request is for #1986. It was pushed. Quoting Lennart Lund : > Ack > > Note: There seems to be another review request tagged with the same > ticket number? > > Thanks > Lennart > >> -Original Message- >> From: Vu Minh Nguyen

Re: [devel] [PATCH 1 of 1] log: write_log_record_hdl get bad file descriptor [#2028]

Ack Note: There seems to be another review request tagged with the same ticket number? Thanks Lennart > -Original Message- > From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] > Sent: den 13 september 2016 12:50 > To: Lennart Lund ;

[devel] [PATCH 0 of 1] Review Request for cpnd: use shared memory based on ckpt name length [#2108]

Summary: cpnd: use shared memory based on ckpt name length [#2108] Review request for Trac Ticket(s): 2108 Peer Reviewer(s): mahesh.va...@oracle.com; anders.wid...@ericsson.com Pull request to: mahesh.va...@oracle.com Affected branch(es): default Development branch: default

[devel] [PATCH 1 of 1] cpnd: use shared memory based on ckpt name length [#2108]

osaf/libs/common/cpsv/include/cpsv_shm.h |9 +- osaf/services/saf/cpsv/cpnd/cpnd_res.c | 565 -- 2 files changed, 536 insertions(+), 38 deletions(-) problem: In the case of CKPT osafckptnd increased 3,5Mb - 240 percent on all nodes CKPT_INFO size inscrease

Re: [devel] [PATCH 1 of 1] immtool: Don't finalize admo if it hasn't been initialized [#2107]

Hi Hung, Reviewed, but not tested. Ack from me. Thanks, Zoran -Original Message- From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au] Sent: den 11 oktober 2016 05:57 To: Zoran Milinkovic ; reddy.neelaka...@oracle.com Cc: