Re: [devel] [PATCH 1/1] log: fix log supported maximum 2047 characters for long DN [#2525]

Ack with one following minor comment. Consider use C++ google coding rule or Linux Kernel coding rule for naming these functions: encodeSaNameT()/decodeSaNameT() e.g: EncodeSaNameT() or encode_sanamet() And as you do refactor for SaNameT encode/decode, I hope you have run valgrind/upgrade tests.

Re: [devel] [PATCH 1/1] log: fix cppcheck, cpplint and reorganize headers - part 1 [#2445]

Hi Canh Van, ACK, with Same comment as Lennart: Change `SaAisErrorT om_rc` similar in `static void read_logsv_config_obj_2()` , as you already did in `static SaAisErrorT amf_quiescing_state_handler()` in this patch it self.

Re: [devel] [PATCH 1/1] dtmd: fix uninitialized memory errors and crashes when deleting nodes [#2545]

Hi Alex , ACK, Not tested. -AVM On 8/9/2017 12:02 AM, Alex Jones wrote: ==27393== Thread 4: ==27393== Conditional jump or move depends on uninitialised value(s) ==27393==at 0x4C2F336: __memcmp_sse4_1 (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==27393==by 0x4E64ADF:

Re: [devel] [PATCH 1/1] dtmd: change log wording [#2030]

Hi Alex, You removed osafassert(0); and event `rc` is not updated to NCSCC_RC_FAILURE; why you what proceed for when node_id=0. node->node_id can be zero because of other factors, please check. -AVM On 8/8/2017 11:42 PM, Alex Jones wrote: Sep 13 14:00:52 SC-2 local0.err osafdtmd[378]:

Re: [devel] [PATCH 1/1] log: fix referring to uninitialized variable caused assertion failed [#2546]

Hi Vu, ACK. -AVM On 8/8/2017 3:01 PM, Vu Minh Nguyen wrote: Log application got coredump due to failed assertion in Log agent. The problem was caused by referring to uninitialized variable `bool updated`. Previously, `updated` variable was initialized when the method

Re: [devel] [PATCH 1/1] amfd: honor PrefAssignedSU in nway and nway active model during assignments [#2269]

Hi Praveen, ack, code review only, minor comments below. /Regards HansN On 07/27/2017 07:36 AM, Praveen wrote: SG attribute saAmfSGNumPrefAssignedSUs is applicable to N-Way and N-Way Active model. AMF is assigning more than saAmfSGNumPrefAssignedSUs in both N-Way and N-Way Active model.

Re: [devel] [PATCH 1/1] log: fix referring to uninitialized variable caused assertion failed [#2546]

Ack /Lennart > -Original Message- > From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] > Sent: den 8 augusti 2017 11:31 > To: mahesh.va...@oracle.com; Lennart Lund ; > Canh Van Truong > Cc:

Re: [devel] [PATCH 0/1] Review Request for rde: Avoid sending messages to peers that are not up [#2488]

Hi! I intend to push this patch tomorrow, unless there are any comments? thanks, Anders Widell On 08/02/2017 12:51 PM, Anders Widell wrote: Summary: rde: Avoid sending messages to peers that are not up [#2488] Review request for Ticket(s): 2488 Peer Reviewer(s): *** LIST THE TECH

[devel] [PATCH 1/1] log: fix referring to uninitialized variable caused assertion failed [#2546]

Log application got coredump due to failed assertion in Log agent. The problem was caused by referring to uninitialized variable `bool updated`. Previously, `updated` variable was initialized when the method `FetchAndIncreaseRefCounter` or `FetchAndDecreaseRefCounter` was called. The value of

[devel] [PATCH 0/1] Review Request for log: fix referring to uninitialized variable caused assertion failed [#2546]

Summary: log: fix referring to uninitialized variable caused assertion failed [#2546] Review request for Ticket(s): 2546 Peer Reviewer(s): Lennart, Canh, Mahesh Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop, release Development branch: ticket-2546

Re: [devel] [PATCH 1/1] amf: add option for controller status in amfclusterstatus [#2536]

ack, code review only. Minor comments below marked with [HansN] /Regards HansN On 08/04/2017 11:18 AM, Praveen wrote: --- src/amf/tools/amf_cluster_status.cc | 190 +++- 1 file changed, 167 insertions(+), 23 deletions(-) diff --git