Hi Gary,
I have started reviewing it.
Thanks
Praveen
On 15-Aug-17 7:02 AM, Gary Lee wrote:
Hi
I would like to push this in a week's time if no one has comments.
Thanks
Gary
On 05/07/17 18:45, Gary Lee wrote:
---
src/amf/amfnd/avnd_cb.h | 3 +-
src/amf/amfnd/avnd_di.h | 36
Ack.
Thanks
Praveen
On 16-Aug-17 1:56 PM, Nguyen Luu wrote:
Summary: amf: update PR doc compliance report for
saAmfComponentErrorClear_4() [#2540]
Review request for Trac Ticket(s): #2540
Peer Reviewer(s): AMF devs
Pull request to: AMF maintainers
Affected branch(es): default
Development
Ack, code review only.
Thanks
Praveen
On 16-Aug-17 1:44 PM, Nguyen Luu wrote:
When called with a non-existing component name, saAmfComponentErrorClear_4
should return SA_AIS_ERR_NOT_EXIST instead of SA_AIS_ERR_BAD_OPERATION
as previously done.
---
src/amf/amfnd/err.cc | 17 +++--
Hi Anders Widell,
ACK, over all changes looks good .
Patch can be pushed now , if we found any issues on top of this patch
can be addressable later .
-AVM
On 8/16/2017 3:49 PM, Anders Widell wrote:
Re-factor the inter-node poll loop by replacing the 100 entry fixed size poll
vector with
Re-factor the inter-node poll loop by replacing the 100 entry fixed size poll
vector with a epoll event processing. This allows dtm to scale to clusters
larger than 100 nodes.
---
src/dtm/dtmnd/dtm.h | 7 +-
src/dtm/dtmnd/dtm_cb.h | 14 +-
src/dtm/dtmnd/dtm_inter_trans.c
Summary: dtm: Support clusters with more than one hundred nodes [#2240]
Review request for Ticket(s): 2240
Peer Reviewer(s): Mahesh, Alex
Pull request to:
Affected branch(es): develop
Development branch: ticket-2240
Base revision: deb8bea9703ef121c9c7324bcf6c94628fa0d7d1
Personal repository:
My guess is that this problem will be much easier to reproduce if you
remove this logic:
if (initial_discovery_phase == true) {
if (node.node_id < dtms_cb->node_id) {
TRACE(
"DTM: received node_id is less than local node_id
dropping message cluster_id:
Hi Anders,
I did try to reproduce quickly , not successful in reproducing ,
It looks to me some network interfaces boot order and openSAF start
related issue,
I will try to reproduce the problem and update you.
Hi Praveen,
Thank you for your comment. I have sent the AMF PR document update for
review.
Thanks,
Nguyen
On 8/14/2017 12:17 PM, praveen malviya wrote:
Hi,
Both ErrorReport() and ErrorClear() APIs can be called for any
component hosted anywhere.
Since amfnd only maintains local
Here are the logs from SC-1. It seems to be starting at the same time as
PL-4:
2017-08-15 10:41:20.262 SC-1 opensafd: Starting OpenSAF Services(5.17.10
- 5302e11d528a33cce150a1583b829452b96b440d) (Using TCP)
2017-08-15 10:41:20.263 SC-1 opensafd[113]: /etc/init.d/opensafd: 113:
Hi Zoran ,
ACK , not tested.
-AVM
On 8/14/2017 6:08 PM, Zoran Milinkovic wrote:
In verifyClassPBE(), the patch makes distinguish between IMM issue and database
corruption.
For IMM issue, PBE will not be regenerated, while for database corruption, PBE
will be regenerated.
---
It is quite easy to reproduce the "dtm_node_add failed" log message,
which leads to a reboot. I have only seen the core dump once, though.
Here is the log from the time when I got the core dump:
2017-08-15 10:41:15.218 PL-4 systemd[1]: Started LSB: ping controllers.
2017-08-15 10:41:15.219
Summary: amfa: Fix saAmfComponentErrorClear_4 to return ERR_NOT_EXIST for
non-exist comp [#2540]
Review request for Ticket(s): 2540
Peer Reviewer(s): AMF devs
Pull request to: AMF maintainers
Affected branch(es): develop, release
Development branch: ticket-2540
Base revision:
When called with a non-existing component name, saAmfComponentErrorClear_4
should return SA_AIS_ERR_NOT_EXIST instead of SA_AIS_ERR_BAD_OPERATION
as previously done.
---
src/amf/amfnd/err.cc | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git
The problem seems to happen with a low probability when I reboot a node.
Presumably, it can happen when two nodes try to establish TCP
connections towards each other at approximately the same time.
regards,
Anders Widell
On 08/16/2017 06:21 AM, A V Mahesh wrote:
Hi Anders ,
On 8/15/2017
Hi Zoran,
Reviewed and tested the patch.
Ack from me.
BR,
Hung Nguyen - DEK Technologies
From: Zoran Milinkovic zoran.milinko...@ericsson.com
Sent: Monday, August 14, 2017 7:38PM
To: Mahesh Valla
Hi Mahesh,
immnd_cb->clm_hdl should be cleared when CLM invalidates the handle. CLM handle
should not be closed when the node goes headless.
immnd_cb->clm_hdl is set to 0 in main() function when CLM handle is invalidated
and selected object closed. That's the last line in the patch where
17 matches
Mail list logo
