Re: [devel] [PATCH 1/1] log: Handling of IMM OI BAD HANDLE in log server is incorrect [#2799]

Hi Lennart, Please see my comments with tag [Canh] Thanks Canh -Original Message- From: Lennart Lund [mailto:lennart.l...@ericsson.com] Sent: Tuesday, April 3, 2018 9:59 PM To: vu.m.ngu...@dektech.com.au; canh.v.tru...@dektech.com.au Cc: opensaf-devel@lists.sourceforge.net;

Re: [devel] [PATCH 1/1] imm: fix memory leaked in immnd [#2825]

Hi Hans, Anders, Please see my responses inline, with [Vu]. P.s: Please ignore previous email. I pressed wrong keys... Regards, Vu > -Original Message- > From: Anders Widell [mailto:anders.wid...@ericsson.com] > Sent: Tuesday, April 3, 2018 7:07 PM > To: Hans Nordebäck

Re: [devel] [PATCH 1/1] imm: fix memory leaked in immnd [#2825]

Hi Hans, Anders, Please see my responses inline, with [Vu]. Regards, Vu > -Original Message- > From: Anders Widell [mailto:anders.wid...@ericsson.com] > Sent: Tuesday, April 3, 2018 7:07 PM > To: Hans Nordebäck ; Vu Minh Nguyen >

[devel] [PATCH 1/1] log: Handling of IMM OI BAD HANDLE in log server is incorrect [#2799]

Recovery of OI handle shall be started in all places where BAD HANDLE can be returned. Creation of OI must be done in background thread. Ongoing creation must be possible to stop e.g if server is becoming standby --- src/log/Makefile.am | 3 + src/log/logd/lgs.h | 24 ---

[devel] [PATCH 0/1] Review Request for log: Handling of IMM OI BAD HANDLE in log server is incorrect [#2799]

Summary: log: Handling of IMM OI BAD HANDLE in log server is incorrect [#2799] Review request for Ticket(s): 2799 Peer Reviewer(s): canh.v.tru...@dektech.com.au, vu.m.ngu...@dektech.com.au Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development

Re: [devel] [PATCH 1/1] log: Handling of IMM OI BAD HANDLE in log server is incorrect [#2799]

Hi Canh + // [Canh] How about the return of immutil_update_one_rattr() is BAD_HANDLE? + // There are many times that this function is called in lgs Yes, this is missing in conf_runtime_obj_handler() +// [Canh] Should not call 'lgsOiCreateBackground' here because this function

Re: [devel] [PATCH 1/1] log: Handling of IMM OI BAD HANDLE in log server is incorrect [#2799]

Hi Vu, See my comments/answers below [Lennart] Thanks Lennart > -Original Message- > From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] > Sent: den 30 mars 2018 10:27 > To: Lennart Lund ; Canh Van Truong > > Cc:

Re: [devel] [PATCH 1/1] imm: fix memory leaked in immnd [#2825]

Ack with comments. There is actually a second memory leak further down in this function:     char* newFmtError = (char*)realloc(fmtError, len);     if (newFmtError == nullptr) {   TRACE_5("realloc error ,No memory ");   return;     } else { When realloc returns nullptr, the original

Re: [devel] [PATCH 1/1] imm: fix memory leaked in immnd [#2825]

Hi Vu, few minor comments below. /Thanks HansN On 04/03/2018 11:43 AM, Vu Minh Nguyen wrote: The allocated memory is not freed before returning from the function ImmModel::setCcbErrorString(). --- src/imm/immnd/ImmModel.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff

[devel] [PATCH 1/1] build: Add support for google gmock framework V2 [#2823]

--- 00-README.unittest | 24 ++-- src/ais/Makefile.am | 5 - src/amf/Makefile.am | 7 +-- src/base/Makefile.am| 21 + src/base/tests/mock_turtle.cc | 20

[devel] [PATCH 0/1] Review Request for build: Add support for google gmock framework V2 [#2823]

Summary: build: Add support for google gmock framework V2 [#2823] Review request for Ticket(s): 2823 Peer Reviewer(s): AndersW Pull request to: Affected branch(es): develop Development branch: ticket-2823 Base revision: b6539a3c61115c33f049a905fc05a899b30191b2 Personal repository:

[devel] [PATCH 0/1] Review Request for build: Add support for google gmock framework [#2823]

Summary: build: Add support for google gmock framework [#2823] Review request for Ticket(s): 2823 Peer Reviewer(s): AndersW Pull request to: Affected branch(es): develop Development branch: ticket-2823 Base revision: 5a1d1c4c16a5959a3434089fadac67c6dce92226 Personal repository:

[devel] [PATCH 1/1] build: Add support for google gmock framework [#2823]

--- 00-README.unittest | 24 ++-- src/ais/Makefile.am | 5 - src/amf/Makefile.am | 7 +-- src/base/Makefile.am| 21 + src/base/tests/mock_turtle.cc | 20

[devel] [PATCH 1/1] msg: updated the assert condition , to avoid core [#2802]

--- src/msg/apitest/test_MetaDataSize.cc | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/msg/apitest/test_MetaDataSize.cc b/src/msg/apitest/test_MetaDataSize.cc index f99b02b..16efe69 100644 --- a/src/msg/apitest/test_MetaDataSize.cc +++

[devel] [PATCH 0/1] Review Request for msg: updated the assert condition , to avoid core [#2802]

Summary: msg: updated the assert condition ,to avoid core [#2802] Review request for Ticket(s): 2802 Peer Reviewer(s): Alex Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2802 Base revision:

[devel] [PATCH 0/1] Review Request for imm: fix memory leaked in immnd [#2825]

Summary: imm: fix memory leaked in immnd [#2825] Review request for Ticket(s): 2825 Peer Reviewer(s): Hans, Anders, Lennart, Ravi Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop, release Development branch: ticket-2825 Base revision:

[devel] [PATCH 1/1] imm: fix memory leaked in immnd [#2825]

The allocated memory is not freed before returning from the function ImmModel::setCcbErrorString(). --- src/imm/immnd/ImmModel.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/imm/immnd/ImmModel.cc b/src/imm/immnd/ImmModel.cc index f7c8fc0..e01ff8c 100644 ---

Re: [devel] [PATCH 0/1] Review Request for ntf: fix to avoid core dump of osafntfimcnd processs [#2806]

Ack, but I have not done any testing Thanks Lennart > -Original Message- > From: srinivas [mailto:srinivas.mangip...@oracle.com] > Sent: den 28 mars 2018 11:44 > To: Lennart Lund ; Vu Minh Nguyen > ; Canh Van Truong >

Re: [devel] [PATCH 1/1] log: Handling of IMM OI BAD HANDLE in log server is incorrect [#2799]

Hi Lennart, Please see my comments in attached file Thanks Canh -Original Message- From: Lennart Lund [mailto:lennart.l...@ericsson.com] Sent: Thursday, March 29, 2018 9:04 PM To: vu.m.ngu...@dektech.com.au; canh.v.tru...@dektech.com.au Cc: opensaf-devel@lists.sourceforge.net; Lennart