Re: [devel] [PATCH 1/1] smfd: Fix incorrect handling of SMFND NCSMDS_UP/DOWN events [#2821]

Hi Lennart, Thank you for your comment. You suggested that the changed files be reformatted following Google Coding Style (i.e space-indented); but according to OpenSAF Coding Rules , C code shall follow Linux kernel Coding Style (i.e

[devel] [PATCH 0/1] Review Request for imma: Do not finalize previously instialized privateOmHandle in saImmOiAugmentCcbInitialize [#2827]

Summary: imma: Do not finalize previously instialized privateOmHandle in saImmOiAugmentCcbInitialize [#2827] Review request for Ticket(s): 2827 Peer Reviewer(s): Ravi, Vu, Zoran Pull request to: Ravi, Vu, Zoran Affected branch(es): develop, release Development branch: ticket-2827 Base revision:

[devel] [PATCH 1/1] imma: Do not finalize previously instialized privateOmHandle in saImmOiAugmentCcbInitialize [#2827]

Currently in saImmOiAugmentCcbInitialize, if OI augmented ccb handle initialization request does not result in OK or TRY_AGAIN, the privateOmHandle will be finalized and the private OM will be destroyed. That is fine if the privateOmHandle is initialized in the current session. But if the

Re: [devel] [PATCH 1/1] msg: updated the assert condition , to avoid core [#2802]

Ack. Alex On 04/03/2018 06:46 AM, srinivas wrote: __ NOTICE: This email was received from an EXTERNAL sender __ ---

Re: [devel] [PATCH 1/1] smfd: Fix incorrect handling of SMFND NCSMDS_UP/DOWN events [#2821]

Hi Nguyen, Ack with comments. See below [Lennart] Thanks Lennart > -Original Message- > From: Nguyen Luu [mailto:nguyen.tk@dektech.com.au] > Sent: den 28 mars 2018 10:08 > To: Lennart Lund ; vijay@oracle.com > Cc: opensaf-devel@lists.sourceforge.net;

[devel] [PATCH 0/1] Review Request for log: Handling of IMM OI BAD HANDLE in log server is incorrect [#2799]

Summary: log: Handling of IMM OI BAD HANDLE in log server is incorrect [#2799] Review request for Ticket(s): 2799 Peer Reviewer(s): canh.v.tru...@dektech.com.au, vu.m.ngu...@dektech.com.au Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development

[devel] [PATCH 1/1] log: Handling of IMM OI BAD HANDLE in log server is incorrect [#2799]

Recovery of OI handle shall be started in all places where BAD HANDLE can be returned. Creation of OI must be done in background thread. Ongoing creation must be possible to stop e.g if server is becoming standby --- src/log/Makefile.am | 3 + src/log/logd/lgs.h | 24 ---

Re: [devel] [PATCH 1/1] log: Handling of IMM OI BAD HANDLE in log server is incorrect [#2799]

Hi Canh, A. +++ b/src/log/logd/lgs_config.cc @@ -1810,18 +1810,20 @@ void conf_runtime_obj_handler(SaImmOiHandleT immOiHandle, } else { TRACE("%s: unknown attribute %s", __FUNCTION__, attributeName); } +// [Canh] I see that you remove lgsOiCreateBackground() here in case

Re: [devel] [PATCH 1/1] amfnd: unlock before releasing the monitoring thread to avoid deadlock [#2818]

Hi Ravi, ack, review only. (I agree, NCS_TASK_RELEASE should not be called with the mutex taken as pthread_mutex_lock is not a cancellation point). /Regards HansN On 03/29/2018 07:59 AM, ravi-sekhar wrote: --- src/amf/amfnd/mon.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[devel] [PATCH 1/1] imm: make version parameter in immutil_xxx non-const [#2830]

The version in saImmO{m,i}Initialize is input/output parameter and is declared as non-constant for both IMM OM and OI API according to SAF spec. But in immutil wrapper library, some are declared as constant and don't update the in/out version before returning from such wrappers. This patch makes

[devel] [PATCH 0/1] Review Request for imm: make version parameter in immutil_xxx non-const [#2830]

Summary: imm: make version parameter in immutil_xxx non-const [#2830] Review request for Ticket(s): 2830 Peer Reviewer(s): Hans, Anders W, Lennart, Ravi Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop, release Development branch: ticket-2830 Base

[devel] [PATCH 0/1] Review Request for base: Check return code from unlink in nid_create_ipc [#2829]

Summary: base: Check return code from unlink in nid_create_ipc [#2829] Review request for Ticket(s): 2829 Peer Reviewer(s): AndersW, Ravi Pull request to: Affected branch(es): develop Development branch: ticket-2829 Base revision: b3c8028c3312ffe13c815dbe0249947a5c4947dc Personal repository:

[devel] [PATCH 1/1] base: Check return code from unlink in nid_create_ipc [#2829]

--- src/nid/agent/nid_ipc.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/nid/agent/nid_ipc.c b/src/nid/agent/nid_ipc.c index 4f43cd309..1a77fd8e2 100644 --- a/src/nid/agent/nid_ipc.c +++ b/src/nid/agent/nid_ipc.c @@ -28,6 +28,7 @@ #include #include

[devel] [PATCH 0/1] Review Request for imm: have try again handling in apitest [#2828]

Summary: imm: have try again handling in apitest [#2828] Review request for Ticket(s): 2828 Peer Reviewer(s): Hans, Anders W, Lennart, Ravi Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2828 Base revision: