Hi,
If you have time, can you please review the patch?
I have done self review, a few things I think it needs to update
- The redundant headers file in mds_log.cc that were needed for MdsLog
class should be removed
- The TraceLog::Init needs to return if the Init() has been already done.
-
Hi Anders,
I see you have provided an alternate implementation based on AIS TMR API
instead of legacy NCS Timer API, this is good.
I hope you have completely taken care of backward compatibility, cases like in
the current OpenSAF Services we are using NCS Timer API, can I use new AIS TMR
API
