Hi Alex
I modified AppConfig-container.xml and changed saAmfSgtRedundancyModel
from 4 (NwayAct) to 1 (2N).
The xml still loads and I could unlock, resulting in:
root@SC-1:/var/log# immlist safVersion=1,safSgType=Container
Name Type Value(s)
Hi Gary,
I just resubmitted a new patch which breaks out the different
components, and addresses the other comments here. But, #2 (rejecting
all but NWay-active for container) should already be in there. Is there
a specific test you ran that didn't work?
Alex
On
This ticket adds support for container/contained in amfd.
---
src/amf/amfd/comp.cc | 65 ++--
src/amf/amfd/comp.h | 4 +-
src/amf/amfd/comptype.cc | 6 +-
src/amf/amfd/csi.cc | 6 ++
src/amf/amfd/csi.h | 3 +
src/amf/amfd/ndproc.cc | 14 +
Add support for container/contained amf common.
---
src/amf/common/amf_amfparam.h | 22 ++
src/amf/common/amf_d2nmsg.h | 11 +++
src/amf/common/amf_defs.h | 2 ++
src/amf/common/amf_util.h | 3 ++-
src/amf/common/d2nedu.c | 22 +-
Add support for container/contained samples.
---
samples/amf/Makefile.am | 2 +-
samples/amf/container/AppConfig-contained-2N.xml | 327 +
samples/amf/container/AppConfig-container.xml| 331 ++
samples/amf/container/Makefile.am| 45
Summary: amfd: add support for container/contained [#70]
Review request for Ticket(s): 70
Peer Reviewer(s): Gary, Ravi, Nagu, Hans
Pull request to:
Affected branch(es): develop
Development branch: ticket-70
Base revision: e46d29e47ebf328f9bab041064070341ab94848f
Personal repository:
This ticket adds support for container/contained.
---
src/amf/amfnd/amfnd.cc| 5 ++-
src/amf/amfnd/avnd_cb.h | 2 +
src/amf/amfnd/avnd_comp.h | 64 +
src/amf/amfnd/avnd_evt.h | 1 +
src/amf/amfnd/avnd_mds.h | 4 +-
src/amf/amfnd/avnd_proc.h | 2 +
Hi Canh,
I'm not sure if my comment still is unclear so I have written comments in the
code to further explain how the changes I suggest below can be done.
As usual I have attached a diff that can be applied on the review branch. Look
for [Lennart]
Note that I have not tested anything and there
Hi Alex
Some initial comments:
0. Is it possible to split up the patch into amfd / amfnd / common / samples.
Just makes it easier to reply inline.
1. Please compile the container demo by default, and make amf_container_script
world executable.
Eg.
diff --git a/samples/amf/Makefile.am