Re: [devel] [PATCH 1/1] log: Update level of printout info in syslog from ER to WA [#2990]
Hi Canh,
Ack for the patch. However, I think the ticket slogan should be updated to
reflect the case. Thanks.
Regards, Vu
> -Original Message-
> From: Canh Van Truong
> Sent: Thursday, December 27, 2018 3:10 PM
> To: vu.m.ngu...@dektech.com.au
> Cc: opensaf-devel@lists.sourceforge.net; Canh Van Truong
>
> Subject: [PATCH 1/1] log: Update level of printout info in syslog from ER
to
> WA [#2990]
>
> ---
> src/log/logd/lgs_evt.cc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/log/logd/lgs_evt.cc b/src/log/logd/lgs_evt.cc
> index 589cb262b..35d939a4b 100644
> --- a/src/log/logd/lgs_evt.cc
> +++ b/src/log/logd/lgs_evt.cc
> @@ -1523,7 +1523,7 @@ static uint32_t process_api_evt(lgsv_lgs_evt_t
> *evt) {
>}
>
>if (lgs_lga_api_msg_dispatcher[api_type](lgs_cb, evt) !=
> NCSCC_RC_SUCCESS) {
> -LOG_ER("lgs_lga_api_msg_dispatcher FAILED type: %d", evt-
> >info.msg.type);
> +LOG_WA("lgs_lga_api_msg_dispatcher FAILED type: %d", evt-
> >info.msg.type);
>}
>
> done:
> --
> 2.15.1
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
[devel] [PATCH 0/1] Review Request for log: Update level of printout info in syslog from ER to WA [#2990]
Summary: log: Update level of printout info in syslog from ER to WA [#2990] Review request for Ticket(s): 2990 Peer Reviewer(s): Vu Pull request to: Vu Affected branch(es): develop Development branch: ticket-2990 Base revision: 9fa36fdd9aecedeb4867b293d1cbf0ea6903e36e Personal repository: git://git.code.sf.net/u/canht32/review Impacted area Impact y/n Docsn Build systemn RPM/packaging n Configuration files n Startup scripts n SAF servicesn OpenSAF servicesn Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): - *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** revision 14d81a9e0644b49bbc03dcccd46b6ec9bce28011 Author: Canh Van Truong Date: Thu, 27 Dec 2018 14:42:09 +0700 log: Update level of printout info in syslog from ER to WA [#2990] Complete diffstat: -- src/log/logd/lgs_evt.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Testing Commands: - *** LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES *** Testing, Expected Results: -- *** PASTE COMMAND OUTPUTS / TEST RESULTS *** Conditions of Submission: - *** HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC *** Arch Built StartedLinux distro --- mipsn n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: --- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ___ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
[devel] [PATCH 1/1] log: Update level of printout info in syslog from ER to WA [#2990]
---
src/log/logd/lgs_evt.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/log/logd/lgs_evt.cc b/src/log/logd/lgs_evt.cc
index 589cb262b..35d939a4b 100644
--- a/src/log/logd/lgs_evt.cc
+++ b/src/log/logd/lgs_evt.cc
@@ -1523,7 +1523,7 @@ static uint32_t process_api_evt(lgsv_lgs_evt_t *evt) {
}
if (lgs_lga_api_msg_dispatcher[api_type](lgs_cb, evt) != NCSCC_RC_SUCCESS) {
-LOG_ER("lgs_lga_api_msg_dispatcher FAILED type: %d", evt->info.msg.type);
+LOG_WA("lgs_lga_api_msg_dispatcher FAILED type: %d", evt->info.msg.type);
}
done:
--
2.15.1
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
