[devel] [PATCH 04 of 12] amfd: convert list_of_su to std::vector [#1142]

osaf/services/saf/amf/amfd/nodegroup.cc | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/osaf/services/saf/amf/amfd/nodegroup.cc b/osaf/services/saf/amf/amfd/nodegroup.cc --- a/osaf/services/saf/amf/amfd/nodegroup.cc +++ b/osaf/services/saf/amf/amfd/nodegroup.cc @@

[devel] [PATCH 1 of 1] amfd: convert list_of_si to std::vector [#1142]

osaf/services/saf/amf/amfd/comp.cc | 2 +- osaf/services/saf/amf/amfd/csi.cc| 3 +- osaf/services/saf/amf/amfd/include/sg.h | 9 ++- osaf/services/saf/amf/amfd/include/si.h | 2 +- osaf/services/saf/amf/amfd/ndproc.cc | 3 +-

Re: [devel] [PATCH 01 of 12] amfd: convert list_of_su to std::vector [#1142]

;> -Original Message- >> From: Gary Lee [mailto:gary@dektech.com.au] >> Sent: 17 September 2015 10:53 >> To: hans.nordeb...@ericsson.com; Praveen Malviya; Nagendra Kumar; >> minh.c...@dektech.com.au; gary@dektech.com.au >> Cc: opensaf-devel@lists.s

[devel] [PATCH 5 of 5] amfd: don't crash if nodegroup is added with node in the same CCB [#1458]

osaf/services/saf/amf/amfd/nodegroup.cc | 4 1 files changed, 4 insertions(+), 0 deletions(-) Currently, if a nodegroup and a member node is created in the same CCB, and the nodegroup is modified to include this new node, amfd will crash. This change will reject the change instead of

[devel] [PATCH 4 of 5] amfd: allow SU to be created [#1458]

osaf/services/saf/amf/amfd/su.cc | 45 +-- 1 files changed, 33 insertions(+), 12 deletions(-) allow SU to be created on a non-existent node, as long as that node is also created in the same CCB diff --git a/osaf/services/saf/amf/amfd/su.cc

[devel] [PATCH 2 of 5] amfd: allow nodegroup to be modified [#1458]

osaf/services/saf/amf/amfd/nodegroup.cc | 20 +--- 1 files changed, 13 insertions(+), 7 deletions(-) allow node to be deleted from a nodegroup, even if there are SUs hosted on that nodegroup as long as these SUs are also removed in the same CCB diff --git

[devel] [PATCH 0 of 5] Review Request for amfd: not possible to add/remove configuration for one node in one single CCB V3 [#1458]

bf13f7e1b3 Author: Gary Lee <gary@dektech.com.au> Date: Mon, 14 Sep 2015 11:57:20 +1000 amfd: allow node to be removed [#1458] allow node to be removed if it is also removed from all nodegroups changeset 42c368ce31191161eeb8a194aedb7c95a3113b59 Author: Gary Lee <gary

[devel] [PATCH 1 of 5] amfd: allow node to be removed [#1458]

osaf/services/saf/amf/amfd/node.cc | 55 ++--- 1 files changed, 50 insertions(+), 5 deletions(-) allow node to be removed if it is also removed from all nodegroups diff --git a/osaf/services/saf/amf/amfd/node.cc b/osaf/services/saf/amf/amfd/node.cc ---

Re: [devel] [PATCH 3 of 3] amf: support RESTART admin op on su [#1455]

Hi Praveen ack (review only) with minor comments, please see [GL] > On 11 Sep 2015, at 12:03 am, praveen.malv...@oracle.com wrote: > > osaf/services/saf/amf/amfd/include/su.h |6 +- > osaf/services/saf/amf/amfd/ndproc.cc| 77 ++- >

Re: [devel] [PATCH 1 of 3] amf: fix spec deviation of surestart escalation [#315]

HI Praveen I noticed some minor indentation issues. Please see [GL]. > On 28 Sep 2015, at 5:01 pm, Gary Lee <gary@dektech.com.au> wrote: > > > Hi Praveen > > Some minor comments so far. Please see [GL]. > > Thanks > Gary > >> From: <pr

Re: [devel] [PATCH 1 of 3] amf: fix spec deviation of surestart escalation [#315]

Hi Praveen Some minor comments so far. Please see [GL]. Thanks Gary > From: > > Date: 11 September 2015 at 00:03 > Subject: [devel] [PATCH 1 of 3] amf: fix spec deviation of surestart > escalation [#315] > To:

Re: [devel] [PATCH 1 of 1] amfd: segv in get_comp_capability [#1502]

ack from me too (review only) > On 25 Sep 2015, at 8:13 pm, Nagendra Kumar wrote: > > Ack, please push it. > > Thanks > -Nagu >> -Original Message- >> From: Hans Nordeback [mailto:hans.nordeb...@ericsson.com] >> Sent: 25 September 2015 14:39 >> To: Praveen

Re: [devel] [PATCH 0 of 3] Review Request for AMF: Coverity issues in amfd/amfnd [#680]

Hi Hans ack for the series (review only) > On 2 Dec 2015, at 6:49 PM, Hans Nordeback wrote: > > Summary: AMF: Coverity issues in amfd/amfnd > Review request for Trac Ticket(s): #680 > Peer Reviewer(s): Nagu, Praveen, Gary > Pull request to: > Affected branch(es):

[devel] [PATCH 2 of 2] amfd: use simple encode/decode for si_trans [#1544]

osaf/services/saf/amf/amfd/ckpt_dec.cc| 68 ++ osaf/services/saf/amf/amfd/ckpt_edu.cc| 55 --- osaf/services/saf/amf/amfd/ckpt_enc.cc| 63 ++--- osaf/services/saf/amf/amfd/include/ckpt.h | 3 +

[devel] [PATCH 1 of 2] amfd: use simple encode/decode for siass [#1544]

osaf/services/saf/amf/amfd/ckpt_dec.cc| 68 +++- osaf/services/saf/amf/amfd/ckpt_edu.cc| 59 -- osaf/services/saf/amf/amfd/ckpt_enc.cc| 77 +++--- osaf/services/saf/amf/amfd/include/ckpt.h | 3 +

[devel] [PATCH 0 of 2] Review Request for amfd: use simple encode/decode [#1544]

n Comments (indicate scope for each "y" above): - changeset 3e9c38fb204ebd378e8e83139fab40371d1961f7 Author: Gary Lee <gary@dektech.com.au> Date: Fri, 04 Dec 2015 16:32:44 +1100 amfd: use simple encode/decode

[devel] [PATCH 1 of 2] clma: send BAD_HANDLE to all clients if both controller nodes are unavailable [#1646]

osaf/libs/agents/saf/clma/clma.h | 2 ++ osaf/libs/agents/saf/clma/clma_api.c | 30 +++--- osaf/libs/agents/saf/clma/clma_mds.c | 27 --- osaf/libs/agents/saf/clma/clma_util.c | 2 ++ 4 files changed, 51 insertions(+), 10 deletions(-)

[devel] [PATCH 0 of 2] Review Request for clm: support simultaneous reboot of both controller nodes [#1646]

Other n Comments (indicate scope for each "y" above): - changeset 44df7b651431e306911e9b327d182e86ce3022fb Author: Gary Lee <gary@dektech.com.au> Date: Thu, 07 Jan 2016 15:27:12 +1100 clma: send B

[devel] [PATCH 2 of 2] clm nodeagent: send nodeup again when clms is available after both controllers are down [#1646]

osaf/services/saf/clmsv/nodeagent/main.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/osaf/services/saf/clmsv/nodeagent/main.c b/osaf/services/saf/clmsv/nodeagent/main.c --- a/osaf/services/saf/clmsv/nodeagent/main.c +++

Re: [devel] [PATCH 1 of 1] amfd: Convert struct avd_sirankedsu_t to class [#1543]

Hi Hans Some comments below. Thanks Gary > On 18 Dec 2015, at 8:59 PM, Hans Nordeback > wrote: > > osaf/services/saf/amf/amfd/include/si.h |6 +- > osaf/services/saf/amf/amfd/include/sirankedsu.h | 19 ++- > osaf/services/saf/amf/amfd/sg_nway_fsm.cc

[devel] [PATCH 2 of 4] amfd: use simple decode [#1544]

osaf/services/saf/amf/amfd/ckpt_dec.cc | 309 1 files changed, 120 insertions(+), 189 deletions(-) use simple decode for cluster, node and compcstype data diff --git a/osaf/services/saf/amf/amfd/ckpt_dec.cc b/osaf/services/saf/amf/amfd/ckpt_dec.cc ---

[devel] [PATCH 1 of 4] corelibs: add simple encode and decode routines for SaClmNodeAddressT [#1544]

osaf/libs/core/include/ncsencdec_pub.h | 3 +++ osaf/libs/core/leap/hj_enc.c | 20 2 files changed, 23 insertions(+), 0 deletions(-) diff --git a/osaf/libs/core/include/ncsencdec_pub.h b/osaf/libs/core/include/ncsencdec_pub.h ---

[devel] [PATCH 3 of 4] amfd: use simple encode [#1544]

osaf/services/saf/amf/amfd/ckpt_enc.cc | 232 +--- 1 files changed, 97 insertions(+), 135 deletions(-) use simple encode for cluster, node and compcstype data diff --git a/osaf/services/saf/amf/amfd/ckpt_enc.cc b/osaf/services/saf/amf/amfd/ckpt_enc.cc ---

[devel] [PATCH 0 of 4] Review Request for amfd: use simple encode and decode [#1544]

n Comments (indicate scope for each "y" above): - changeset 3438fda0d2866d3232f7fbe00507de9539be6357 Author: Gary Lee <gary@dektech.com.au> Date: Fri, 08 Jan 2016 13:56:34 +1100 corelibs: add simple e

[devel] [PATCH 4 of 4] amfd: remove unused encode and decode routines [#1520]

osaf/services/saf/amf/amfd/ckpt_edu.cc| 215 -- osaf/services/saf/amf/amfd/include/ckpt_edu.h | 12 - 2 files changed, 0 insertions(+), 227 deletions(-) diff --git a/osaf/services/saf/amf/amfd/ckpt_edu.cc b/osaf/services/saf/amf/amfd/ckpt_edu.cc ---

[devel] [PATCH 1 of 2] amfd: use simple encode/decode for siass [#1544]

osaf/services/saf/amf/amfd/ckpt_dec.cc| 68 +++- osaf/services/saf/amf/amfd/ckpt_edu.cc| 59 -- osaf/services/saf/amf/amfd/ckpt_enc.cc| 77 +++--- osaf/services/saf/amf/amfd/include/ckpt.h | 3 +

[devel] [PATCH 0 of 2] Review Request for amfd: use simple encode/decode V2 [#1544]

eclaration of avsv_edp_ckpt_msg_siass() - use SA_FALSE in place of static_casts(false) changeset 02e9b85395aaa88e8301cacd707a7b281398f691 Author: Gary Lee <gary@dektech.com.au> Date: Fri, 18 Dec 2015 13:32:59 +1100 amfd: use simple encode/decode for siass [#

[devel] [PATCH 2 of 2] amfd: use simple encode/decode for si_trans [#1544]

osaf/services/saf/amf/amfd/ckpt_dec.cc| 68 ++ osaf/services/saf/amf/amfd/ckpt_edu.cc| 53 -- osaf/services/saf/amf/amfd/ckpt_enc.cc| 63 ++--- osaf/services/saf/amf/amfd/include/ckpt.h | 3 +

[devel] [PATCH 1 of 1] amfd: use simple decode/encode for AVD_CL_CB [#1544]

osaf/services/saf/amf/amfd/ckpt_dec.cc| 51 ++- osaf/services/saf/amf/amfd/ckpt_edu.cc| 54 - osaf/services/saf/amf/amfd/ckpt_enc.cc| 38 +-- osaf/services/saf/amf/amfd/include/ckpt.h | 2 +

[devel] [PATCH 0 of 1] Review Request for amfd: use simple decode/encode for AVD_CL_CB [#1544]

Other n Comments (indicate scope for each "y" above): - Note: must be applied on top of Han's previous patches for simple decode/encode of AVD_COMP. changeset c7c987f0f495fa9552b562a9422d8066f139f751 Author: Gar

Re: [devel] [PATCH 1 of 1] amfd: use simple decode/encode for AVD_CL_CB [#1544]

Hi Praveen I did it mainly for consistency. A few of the decode functions require peer version so I thought maybe all of them can have the same signature format? Thanks Gary Quoting praveen malviya <praveen.malv...@oracle.com>: > Ack with minor comment. > > > On 25-Nov

Re: [devel] [PATCH 1 of 1] amfnd: skip config reload if CompType has not changed [#1602]

Hi Hans Thanks, I think db_template.h only exists under amfd. Thanks Gary On 18/11/15 20:13, Hans Nordebäck wrote: > ack, code review only, one comment below. /Thanks HansN > > On 11/18/2015 04:36 AM, Gary Lee wrote: >> osaf/services/saf/amf/amfnd/compdb.cc

[devel] [PATCH 0 of 1] Review Request for amfd: ignore change to saAmfCompType if it is set to the same value [#1602]

n Other n Comments (indicate scope for each "y" above): - <> changeset a4dd92831e7406217a6311f35dc06f9e0a131d08 Author: Gary Lee <gary@dektech.com.au> Date: Wed, 18 Nov 2015 22:30:26 +1100

[devel] [PATCH 1 of 1] amfd: ignore change to saAmfCompType if it is set to the same value [#1602]

osaf/services/saf/amf/amfd/comp.cc | 7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/osaf/services/saf/amf/amfd/comp.cc b/osaf/services/saf/amf/amfd/comp.cc --- a/osaf/services/saf/amf/amfd/comp.cc +++ b/osaf/services/saf/amf/amfd/comp.cc @@ -1227,6 +1227,13 @@ static

Re: [devel] [PATCH 0 of 3] Review Request for amfd: Remove use of EDU and do direct encode/decode of AVD_COMP [#1544]

ack for the series Thanks Gary > On 20 Nov 2015, at 6:42 PM, Hans Nordeback > wrote: > > Summary: AMFD: Remove use of EDU and do direct encode/decode > Review request for Trac Ticket(s): #1544 > Peer Reviewer(s): Nagu, Praveen, Gary > Pull request to: > Affected

Re: [devel] [PATCH 2 of 4] amfd: use simple decode [#1544]

Hi Hans Please see reply below. > On 11 Jan 2016, at 8:44 PM, Hans Nordebäck > wrote: > > ack, code review only. One question below/Thanks HansN > >> >> @@ -2769,14 +2715,10 @@ >> static uint32_t dec_comp_cs_type_config(AVD_CL_CB *cb, NCS_MBCSV_CB_DEC >> *dec)

[devel] [PATCH 0 of 1] Review Request for amfnd: reboot node immediately if local amfd goes down [#1861]

Other n Comments (indicate scope for each "y" above): - changeset b2c57ca4d34257b67e28866b231942f7e121dce4 Author: Gary Lee <gary@dektech.com.au> Date: Fri, 03 Jun 2016 11:05:34 +1000 amfd: reboot node immediat

[devel] [PATCH 1 of 1] amfd: reboot node immediately if local amfd goes down [#1861]

osaf/services/saf/amf/amfnd/di.cc | 5 - 1 files changed, 4 insertions(+), 1 deletions(-) Reboot the node immediately if local amfd goes down, even if headless mode is enabled. Otherwise we need to wait for the AMF heartbeat timeout to occur before rebooting the node, which is unnecessary.

Re: [devel] [PATCH 1 of 1] AMFD: Update RTA saAmfSUHostedByNode after headless [#1720] V2

Hi Minh ack Thanks Gary > On 7 Jun 2016, at 10:47 AM, Minh Hon Chau wrote: > > osaf/services/saf/amf/amfd/siass.cc | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > > After being headless, the RTA saAmfSUHostedByNode of SU has not been updated. >

[devel] [PATCH 0 of 1] Review Request for libs/core: add support for long DN in sanamet encode & decode functions V2 [#1674]

n Tests n Other n Comments (indicate scope for each "y" above): - Removed unused function declaration and #include from V1 changeset 1bb86038a1611d59b67721c0c87bffa5e4a72290 Author: Gary Lee <gary.

[devel] [PATCH 1 of 1] libs/core: add support for long DN in sanamet encode & decode functions V2 [#1674]

osaf/libs/core/common/saf_edu.c| 33 + osaf/libs/core/include/ncsencdec_pub.h |2 + osaf/libs/core/leap/hj_enc.c | 100 ++-- 3 files changed, 100 insertions(+), 35 deletions(-) Currently, ncs_edp_sanamet encodes a SaNameT by storing

[devel] [PATCH 1 of 1] libs/core: add support for long DN in sanamet encode & decode functions [#1674]

osaf/libs/core/common/saf_edu.c| 34 ++ osaf/libs/core/include/ncsencdec_pub.h |3 + osaf/libs/core/leap/hj_enc.c | 100 ++-- 3 files changed, 102 insertions(+), 35 deletions(-) Currently, ncs_edp_sanamet encodes a SaNameT by storing

[devel] [PATCH 0 of 1] Review Request for libs: add support for long DN in sanamet encode & decode functions [#1674]

ts n Other n Comments (indicate scope for each "y" above): - <> changeset fc9d1fc9f6a4000ca63fa713d1fdd8f62db54931 Author: Gary Lee <gary@dektech.com.au> Date: Thu, 23 Jun 2016 15

Re: [devel] [PATCH 1 of 1] amfnd: do not repair su without AMFD request in su-failover escalation [#1863]

HI Praveen ack (review only) Thanks Gary > On 14 Jun 2016, at 6:59 PM, praveen.malv...@oracle.com wrote: > > osaf/services/saf/amf/amfnd/clc.cc | 5 - > osaf/services/saf/amf/amfnd/err.cc | 2 -- > osaf/services/saf/amf/amfnd/susm.cc | 5 - > 3 files changed, 8 insertions(+), 4

[devel] [PATCH 0 of 1] Review Request for amf: fix errors reported by cppcheck [#1882]

n Comments (indicate scope for each "y" above): - changeset ec88575df48a1c7cdf794f06f722f3afabca906c Author: Gary Lee <gary@dektech.com.au> Date: Fri, 17 Jun 2016 13:24:16 +1000 amf: fix errors reported by cppch

[devel] [PATCH 1 of 1] amf: fix errors reported by cppcheck [#1882]

osaf/libs/common/amf/d2nmsg.c | 1 + osaf/services/saf/amf/amfnd/clc.cc | 6 -- osaf/services/saf/amf/amfnd/sidb.cc | 7 --- 3 files changed, 9 insertions(+), 5 deletions(-) diff --git a/osaf/libs/common/amf/d2nmsg.c b/osaf/libs/common/amf/d2nmsg.c ---

[devel] [PATCH 1 of 5] corelibs: add simple encode and decode routines for SaClmNodeAddressT [#1544]

osaf/libs/core/include/ncsencdec_pub.h | 3 +++ osaf/libs/core/leap/hj_enc.c | 20 2 files changed, 23 insertions(+), 0 deletions(-) diff --git a/osaf/libs/core/include/ncsencdec_pub.h b/osaf/libs/core/include/ncsencdec_pub.h ---

[devel] [PATCH 4 of 5] amfd: remove unused encode and decode routines [#1520]

osaf/services/saf/amf/amfd/ckpt_edu.cc| 215 -- osaf/services/saf/amf/amfd/include/ckpt_edu.h | 12 - 2 files changed, 0 insertions(+), 227 deletions(-) diff --git a/osaf/services/saf/amf/amfd/ckpt_edu.cc b/osaf/services/saf/amf/amfd/ckpt_edu.cc ---

[devel] [PATCH 2 of 5] amfd: use simple decode [#1544]

osaf/services/saf/amf/amfd/ckpt_dec.cc | 312 1 files changed, 121 insertions(+), 191 deletions(-) use simple decode for cluster, node and compcstype data diff --git a/osaf/services/saf/amf/amfd/ckpt_dec.cc b/osaf/services/saf/amf/amfd/ckpt_dec.cc ---

[devel] [PATCH 0 of 5] Review Request for amfd: use simple encode and decode V2 [#1544]

T() as per Hans's comment 4/5: no change 5/5: added * added unit test case changeset c280a91ea5d2bee125bee59de83226ac341e17d1 Author: Gary Lee <gary@dektech.com.au> Date: Thu, 14 Jan 2016 17:13:30 +1100 corelibs: add simple encode and decode routines for SaClmNodeAddress

[devel] [PATCH 3 of 5] amfd: use simple encode [#1544]

osaf/services/saf/amf/amfd/ckpt_enc.cc | 236 +--- 1 files changed, 98 insertions(+), 138 deletions(-) use simple encode for cluster, node and compcstype data diff --git a/osaf/services/saf/amf/amfd/ckpt_enc.cc b/osaf/services/saf/amf/amfd/ckpt_enc.cc ---

[devel] [PATCH 5 of 5] amfd: add unit test for node config decode & encode [#1520]

osaf/services/saf/amf/amfd/include/ckpt.h | 4 + osaf/services/saf/amf/amfd/tests/test_ckpt_enc_dec.cc | 71 +++ 2 files changed, 75 insertions(+), 0 deletions(-) diff --git a/osaf/services/saf/amf/amfd/include/ckpt.h b/osaf/services/saf/amf/amfd/include/ckpt.h

Re: [devel] [PATCH 1 of 1] amfd: Remove redundant declarations in util.h and msg.h [#1662]

Hi Hans ack (review only) Thanks Gary > On 15 Jan 2016, at 11:22 PM, Hans Nordeback > wrote: > > osaf/services/saf/amf/amfd/comptype.cc| 1 + > osaf/services/saf/amf/amfd/dmsg.cc| 1 + > osaf/services/saf/amf/amfd/hlt.cc | 1 + >

Re: [devel] [PATCH 02 of 15] leap: add function to encode SaNameT from SaConstString [#1537]

LENGTH length limitation will be removed from the function. Thanks Gary > On 27 Jan 2016, at 6:35 PM, Hans Nordebäck <hans.nordeb...@ericsson.com> > wrote: > > ack, code review only. See questions below. /Thanks HansN > > On 01/25/2016 05:35 AM, Gary Lee wro

Re: [devel] [PATCH 0 of 1] Review Request for amfa: Divide amf api functions in a thin C layer and use C++ for implementation [#1673]

Hi Hans I think it would be very, very nice if we got rid of SaNameT in libs/common/osaf, and replaced it with std::string. As you know, the data structures defined here are used by the agent, director and node director. There is a lot of code that copies and frees various messages (both in

[devel] [PATCH 0 of 1] Review Request for amfd: ensure su is in su_oper_list before deleting [#1675]

n Comments (indicate scope for each "y" above): - changeset 173845fb9b17c3f832918e4a1f93fdf07270fe71 Author: Gary Lee<gary@dektech.com.au> Date: Tue, 02 Feb 2016 17:45:38 +1100 amfd: ensure su is in su_

[devel] [PATCH 1 of 1] amfd: ensure su is in su_oper_list before deleting [#1675]

osaf/services/saf/amf/amfd/sg_nored_fsm.cc | 19 ++- 1 files changed, 10 insertions(+), 9 deletions(-) failed SU is not necessarily involved in the SG realignment diff --git a/osaf/services/saf/amf/amfd/sg_nored_fsm.cc b/osaf/services/saf/amf/amfd/sg_nored_fsm.cc ---

[devel] [PATCH 1 of 1] amf: Add support for cloud resilience [#1620] V3

osaf/services/saf/amf/README-HEADLESS | 143 ++ 1 files changed, 143 insertions(+), 0 deletions(-) Update README-HEADLESS diff --git a/osaf/services/saf/amf/README-HEADLESS b/osaf/services/saf/amf/README-HEADLESS new file mode 100644 --- /dev/null +++

[devel] [PATCH 0 of 1] Review Request for amf: Add support for cloud resilience [#1620] V3

Other n Comments (indicate scope for each "y" above): - changeset 689569bc10f0a1856d04a164897a40feb85fd11d Author: Gary Lee <gary@dektech.com.au> Date: Tue, 23 Feb 2016 11:59:15 +1100 amf: Add support for cloud

[devel] [PATCH 15 of 15] amfd: update unit tests to use std::string [#1537]

osaf/services/saf/amf/amfd/tests/test_ckpt_enc_dec.cc | 33 -- 1 files changed, 15 insertions(+), 18 deletions(-) diff --git a/osaf/services/saf/amf/amfd/tests/test_ckpt_enc_dec.cc b/osaf/services/saf/amf/amfd/tests/test_ckpt_enc_dec.cc ---

[devel] [PATCH 09 of 15] amfd: change SaNameT to std::string [#1537]

osaf/services/saf/amf/amfd/ndfsm.cc| 12 +- osaf/services/saf/amf/amfd/ndproc.cc | 32 +-- osaf/services/saf/amf/amfd/node.cc | 227 +--- osaf/services/saf/amf/amfd/nodegroup.cc| 215 ++

[devel] [PATCH 01 of 15] amd libs: move avsv_saname_init to amfd [#1537]

osaf/libs/common/amf/include/amf_util.h | 1 - osaf/libs/common/amf/util.c | 17 - 2 files changed, 0 insertions(+), 18 deletions(-) this is only used in amfd diff --git a/osaf/libs/common/amf/include/amf_util.h b/osaf/libs/common/amf/include/amf_util.h ---

[devel] [PATCH 03 of 15] amfd: added wrapper class for SaNameT [#1537]

osaf/services/saf/amf/amfd/include/db_template.h | 39 +++- 1 files changed, 38 insertions(+), 1 deletions(-) SaNameTWrapper allows easy conversion from std::string to SaNameT required by many API functions diff --git a/osaf/services/saf/amf/amfd/include/db_template.h

[devel] [PATCH 04 of 15] amfd: change SaNameT variables to std::string in include directory [#1537]

osaf/services/saf/amf/amfd/include/app.h | 6 +- osaf/services/saf/amf/amfd/include/apptype.h | 8 +- osaf/services/saf/amf/amfd/include/cb.h| 4 +- osaf/services/saf/amf/amfd/include/ckpt.h | 4 +- osaf/services/saf/amf/amfd/include/cluster.h |

[devel] [PATCH 11 of 15] amfd: change SaNameT to std::string in SI related code [#1537]

osaf/services/saf/amf/amfd/si.cc | 233 ++- osaf/services/saf/amf/amfd/si_dep.cc | 297 +++--- osaf/services/saf/amf/amfd/siass.cc | 107 ++-- 3 files changed, 303 insertions(+), 334 deletions(-) diff --git

[devel] [PATCH 14 of 15] amfd: change SaNameT to std::string in util.cc [#1537]

osaf/services/saf/amf/amfd/util.cc | 205 ++-- 1 files changed, 126 insertions(+), 79 deletions(-) diff --git a/osaf/services/saf/amf/amfd/util.cc b/osaf/services/saf/amf/amfd/util.cc --- a/osaf/services/saf/amf/amfd/util.cc +++

[devel] [PATCH 06 of 15] amfd: change SaNameT to std::string [#1537]

osaf/services/saf/amf/amfd/app.cc| 68 osaf/services/saf/amf/amfd/apptype.cc| 61 --- osaf/services/saf/amf/amfd/clm.cc| 14 +- osaf/services/saf/amf/amfd/cluster.cc|2 +- osaf/services/saf/amf/amfd/comp.cc | 169 ++--

[devel] [PATCH 00 of 15] Review Request for amfd: replace internal use of SaNameT with std::string [#1537]

t messages are still encoded as SaNameT for backwards compatibility with existing amfd version * messages between d and nd have not been changed changeset 4390a3d3b078620d9a9cfc05b600992a79ea5a3f Author: Gary Lee <gary@dektech.com.au> Date: Mon, 25 Jan 2016 11:18:17 +1100

[devel] [PATCH 07 of 15] amfd: change SaNameT to std::string [#1537]

osaf/services/saf/amf/amfd/hlt.cc | 14 +++--- osaf/services/saf/amf/amfd/hlttype.cc | 18 -- 2 files changed, 15 insertions(+), 17 deletions(-) diff --git a/osaf/services/saf/amf/amfd/hlt.cc b/osaf/services/saf/amf/amfd/hlt.cc ---

[devel] [PATCH 02 of 15] leap: add function to encode SaNameT from SaConstString [#1537]

osaf/libs/core/include/ncsencdec_pub.h | 1 + osaf/libs/core/leap/hj_enc.c | 17 + 2 files changed, 18 insertions(+), 0 deletions(-) diff --git a/osaf/libs/core/include/ncsencdec_pub.h b/osaf/libs/core/include/ncsencdec_pub.h ---

[devel] [PATCH 05 of 15] afmd: change SaNameT to std::string in ckpt related files [#1537]

osaf/services/saf/amf/amfd/ckpt_dec.cc | 134 --- osaf/services/saf/amf/amfd/ckpt_enc.cc | 121 +--- osaf/services/saf/amf/amfd/ckpt_updt.cc | 94 +++--- 3 files changed, 191 insertions(+), 158 deletions(-) diff --git

[devel] [PATCH 12 of 15] amfd: change SaNameT to std::string in sirankedsu.cc [#1537]

osaf/services/saf/amf/amfd/sirankedsu.cc | 143 -- 1 files changed, 57 insertions(+), 86 deletions(-) diff --git a/osaf/services/saf/amf/amfd/sirankedsu.cc b/osaf/services/saf/amf/amfd/sirankedsu.cc --- a/osaf/services/saf/amf/amfd/sirankedsu.cc +++

[devel] [PATCH 08 of 15] amfd: change SaNameT to std::string [#1537]

osaf/services/saf/amf/amfd/imm.cc | 281 ++--- 1 files changed, 138 insertions(+), 143 deletions(-) diff --git a/osaf/services/saf/amf/amfd/imm.cc b/osaf/services/saf/amf/amfd/imm.cc --- a/osaf/services/saf/amf/amfd/imm.cc +++

Re: [devel] [PATCH 02 of 15] leap: add function to encode SaNameT from SaConstString [#1537]

Hi Sorry, just realised I should have done this better. > On 25 Jan 2016, at 3:35 PM, Gary Lee <gary@dektech.com.au> wrote: > > osaf/libs/core/include/ncsencdec_pub.h | 1 + > osaf/libs/core/leap/hj_enc.c | 17 + > 2 files changed, 18 inser

Re: [devel] [PATCH 02 of 15] leap: add function to encode SaNameT from SaConstString [#1537]

äck <hans.nordeb...@ericsson.com> > wrote: > > Hi Gary, > > I missed that mail, yes it's enough, what about the name of the function? > /Thanks HansN > > On 01/27/2016 08:46 AM, Gary Lee wrote: >> Hi Hans >> >> Good point, I commented on this

Re: [devel] [PATCH 03 of 15] amfd: added wrapper class for SaNameT [#1537]

Hi Hans Thanks, please see my reply below. > On 27 Jan 2016, at 11:45 PM, Hans Nordebäck <hans.nordeb...@ericsson.com> > wrote: > > ack, code review only. Minor question below. /Thanks HansN > > On 01/25/2016 05:35 AM, Gary Lee wrote: >> osaf/services/saf/amf/am

Re: [devel] [PATCH 0 of 5] Review Request for amf: Add support for cloud resilience [#1620] V2

Hi Nagu Just wanted to confirm that when you attach gdb to a process, the process is amf_demo, and not amfnd? Thanks Gary > On 13 Feb 2016, at 1:35 AM, Nagendra Kumar wrote: > > TC #27: Same configuration as TC #24: > Add a new Csi in running demo appl: Keep gdb in SU1

Re: [devel] [PATCH 0 of 5] Review Request for amf: Add support for cloud resilience [#1620] V2

016, at 4:00 PM, Gary Lee <gary@dektech.com.au> wrote: > > Hi Nagu > > Just wanted to confirm that when you attach gdb to a process, the process is > amf_demo, and not amfnd? > > Thanks > Gary > >> On 13 Feb 2016, at 1:35 AM, Nagendra Kumar <nage

Re: [devel] [PATCH 0 of 5] Review Request for amf: Add support for cloud resilience [#1620] V2

Hi Nagu Please ignore fix.patch Minh previously sent, and replace with this version. Thanks Gary > On 19 Feb 2016, at 8:09 PM, minh chau wrote: > > Hi Nagu, > > Thanks for your testing. > Below is our investigation from TC1 - TC31 which seem to be important, plus

Re: [devel] [PATCH 0 of 2] Review Request for clm: support simultaneous reboot of both controller nodes [#1646]

HI Mathi Any comments regarding this series? Can we push it? Thanks Gary > On 19 Jan 2016, at 11:29 PM, Anders Widell <anders.wid...@ericsson.com> wrote: > > Ack for the series (code review only). > > regards, > Anders Widell > > On 01/07/2016 05:38 AM, G

Re: [devel] [PATCH 0 of 5] Review Request for amf: Add support for cloud resilience [#1620] V2

It seems the file wasn't attached properly. Take #2. Quoting Gary Lee <gary@dektech.com.au>: Hi Nagu Please ignore fix.patch Minh previously sent, and replace with this version. Thanks Gary On 19 Feb 2016, at 8:09 PM, minh chau <minh.c...@dektech.com.au> wrote: Hi N

Re: [devel] [PATCH 1 of 1] amfd: handle cases where a checkpoint arrives after an object is deleted [#1693]

Hi I will push this tomorrow (1 Apr) if there are no more comments. Thanks Gary On 11/03/2016, 7:19 PM, "Hans Nordebäck" <hans.nordeb...@ericsson.com> wrote: >ack, code review only/Thanks HansN > >On 03/07/2016 06:31 AM, Gary Lee wrote: >> osaf/services/

Re: [devel] [PATCH 1 of 1] amfd: ensure su is in su_oper_list before deleting [#1675]

Sure, will fix before pushing. Thanks! On 31/03/2016, 5:11 PM, "praveen malviya" <praveen.malv...@oracle.com> wrote: >Ack code reivew only. >I think commit message must include Red model name. > >Thanks, >Praveen > > >On 31-Mar-16 9:05 AM, Gary Lee wrot

[devel] [PATCH 1 of 1] amf: send extra state information from nd to d after headless state [#1723]

osaf/libs/common/amf/d2nedu.c | 11 +-- osaf/libs/common/amf/include/amf_d2nmsg.h | 3 ++ osaf/libs/common/amf/include/amf_si_assign.h | 19 + osaf/services/saf/amf/amfd/csi.cc | 3 ++ osaf/services/saf/amf/amfd/include/mds.h | 7

[devel] [PATCH 0 of 1] Review Request for amf: send extra state information from nd to d after headless state [#1723]

Tests n Other n Comments (indicate scope for each "y" above): - changeset 226a473224096ae0a09635bb740b71c6e87bc6a2 Author: Gary Lee <gary@dektech.com.au> Date: Thu, 07 Apr 2016 13:27:29 +1000

[devel] [PATCH 0 of 1] Review Request for amfnd: return TRY_AGAIN for saAmfProtectionGroupTrack and saAmfProtectionGroupTrackStop while headless [#1718]

amples n Tests n Other n Comments (indicate scope for each "y" above): - changeset 0b577273443bb6b03b4e50196cd29262c63f86f7 Author: Gary Lee <gary@dektech.com.au> Date: Thu

[devel] [PATCH 1 of 1] amfnd: return TRY_AGAIN for saAmfProtectionGroupTrack and saAmfProtectionGroupTrackStop while headless [#1718]

osaf/services/saf/amf/amfnd/pg.cc | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) return TRY_AGAIN for saAmfProtectionGroupTrack and saAmfProtectionGroupTrackStop while headless, since protection group tracking requires amfd's presence diff --git

Re: [devel] CLM PR update for #1646

Hi Mathi Thanks, we can go with your version. Thanks Gary On 7/04/2016, 3:54 PM, "Mathivanan Naickan Palanivelu" <mathi.naic...@oracle.com> wrote: >Comment inline: >Mathi. > >> -Original Message- >> From: Gary Lee [mailto:gary@dektech.com.au

Re: [devel] [PATCH 1 of 1] amfd: respond to IMM for admin op status when SG becomes stable [#1740]

Ack (review only) Thanks Gary On 12/04/2016, 3:18 PM, "praveen.malv...@oracle.com" wrote: > osaf/services/saf/amf/amfd/sgproc.cc | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > >If unlock admin operation on SU1 is timed just after cluster timer

Re: [devel] [PATCH 1 of 1] amfd: Remove dead-code detected by Coverity [#680]

Hi Hans Ack (review only) Thanks Gary On 11/04/2016, 4:55 PM, "Hans Nordeback" wrote: > osaf/services/saf/amf/amfd/apptype.cc | 6 -- > osaf/services/saf/amf/amfd/csiattr.cc | 8 +--- > osaf/services/saf/amf/amfd/ctcstype.cc| 7 --- >

[devel] [PATCH 0 of 1] Review Request for amfd: handle cases where a checkpoint arrives after an object is deleted [#1693]

n Other n Comments (indicate scope for each "y" above): - changeset 6cc1f9edfa377497f670394a1ed7798c1899e723 Author: Gary Lee<gary@dektech.com.au> Date: Mon, 07 Mar 2016 16:29:09 +1100 amfd: ha

[devel] [PATCH 1 of 1] amfd: handle cases where a checkpoint arrives after an object is deleted [#1693]

osaf/services/saf/amf/amfd/ckpt_dec.cc | 25 - osaf/services/saf/amf/amfd/ckpt_updt.cc | 6 +++--- osaf/services/saf/amf/amfd/su.cc| 8 ++-- 3 files changed, 29 insertions(+), 10 deletions(-) Sometimes a mbc checkpoint may arrive after an object has

Re: [devel] [PATCH 04 of 15] amfnd: Add support for cloud resilience at node director [#1620]

Hi Mathi I think Minh has previously said "delayed failover" isn't the best description of what patch 6 is doing. Minh has previously described it better as "adjust HA assignment"; moving transient states to states that realign() can work with. The transient states aren't necessarily caused

[devel] [PATCH 1 of 1] amf: add README_HEADLESS [#1620]

osaf/services/saf/amf/README_HEADLESS | 150 ++ 1 files changed, 150 insertions(+), 0 deletions(-) diff --git a/osaf/services/saf/amf/README_HEADLESS b/osaf/services/saf/amf/README_HEADLESS new file mode 100644 --- /dev/null +++

Re: [devel] [PATCH 1 of 1] amf: add README_HEADLESS [#1620]

gets supported.] OK >4. The following lines is incomplete: > +SA_AMF_HA_STATE of a SI may change from "" to <> This is intended. The initial text is blank. Thanks Gary > >Thanks >-Nagu > >> -Original Message- >> From: Gary Lee [mailto:gary..

[devel] [PATCH 0 of 1] Review Request for amf: send extra state information from nd to d after headless state [#1620]

n Tests n Other n Comments (indicate scope for each "y" above): - changeset abedc429029d4a1baaa2cc18b3ee47f6c2ab815a Author: Gary Lee <gary@dektech.com.au> Date: Mon, 04 Apr 2016 14:23:25 +1

[devel] [PATCH 1 of 1] amf: send extra state information from nd to d after headless state [#1620]

osaf/libs/common/amf/d2nedu.c | 11 +-- osaf/libs/common/amf/include/amf_d2nmsg.h | 3 ++ osaf/libs/common/amf/include/amf_si_assign.h | 19 + osaf/services/saf/amf/amfd/csi.cc | 3 ++ osaf/services/saf/amf/amfd/include/mds.h | 7

[devel] [PATCH 1 of 1] amfnd: reset rcv_msg_id on AVD down [#1728]

osaf/services/saf/amf/amfnd/di.cc | 1 - osaf/services/saf/amf/amfnd/mds.cc | 1 + 2 files changed, 1 insertions(+), 1 deletions(-) This patch reverts the change in behaviour introduced in changeset 3451e8a8ba90, where rcv_msg_id reset was moved from avnd_evt_mds_avd_dn_evh() to

[devel] [PATCH 0 of 1] Review Request for amfnd: reset rcv_msg_id on AVD down [#1728]

Other n Comments (indicate scope for each "y" above): - changeset 120a36b759ef77ec3a0b39f1a00bbcbfffe9eae7 Author: Gary Lee <gary@dektech.com.au> Date: Sat, 23 Apr 2016 22:17:45 +1000 amfnd: reset rcv_msg

[devel] [PATCH 0 of 1] Review Request for amfnd: reset rcv_msg_id on AVD down V2 [#1728]

n Comments (indicate scope for each "y" above): - <> changeset 48a81d8043356d133105c69a8780d3a1c04775ab Author: Gary Lee <gary@dektech.com.au> Date: Mon, 25 Apr 2016 15:39:35 +1000 amfnd: r

<    1   2   3   4   5   6   7   8   9   10   >