osaf/libs/common/immsv/include/immutil.h | 10 ++
osaf/tools/safimm/src/immutil.c | 28
2 files changed, 38 insertions(+), 0 deletions(-)
Add wrapper functions for saImmOmCcbValidate and saImmOmCcbAbort.
diff --git
n
Other n
Comments (indicate scope for each y above):
-
changeset 1b6bb9861f04f294255d6546b246e2640ac5bbae
Author: Hung Nguyen hung.d.ngu...@dektech.com.au
Date: Mon, 17 Nov 2014 15:00:48 +0700
immtools: Add
osaf/tools/safimm/immcfg/imm_cfg.c | 60 -
1 files changed, 57 insertions(+), 3 deletions(-)
The option is only available in explicit commit mode.
Add ccb_validate() function.
Add saImmOmCcbGetErrorStrings() for ccb_apply() and ccb_validate().
diff --git
osaf/libs/common/immsv/include/immutil.h | 10 ++
osaf/tools/safimm/src/immutil.c | 28
2 files changed, 38 insertions(+), 0 deletions(-)
Add wrapper functions for saImmOmCcbValidate and saImmOmCcbAbort.
diff --git
n
Other n
Comments (indicate scope for each y above):
-
changeset 1b6bb9861f04f294255d6546b246e2640ac5bbae
Author: Hung Nguyen hung.d.ngu...@dektech.com.au
Date: Mon, 17 Nov 2014 15:00:48 +0700
immtools: Add
n
Tests n
Other n
Comments (indicate scope for each y above):
-
changeset 5835b54b7f7954f56709efb6657af612a0863cbd
Author: Hung Nguyen hung.d.ngu...@dektech.com.au
Date: Wed, 03 Dec 2014 18:04:55 +0700
osaf/services/saf/immsv/immnd/immnd_proc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
If IMMSV_MAX_WAIT is set to more than 50 seconds, IMMND will not give up and
restart after 50 seconds.
diff --git a/osaf/services/saf/immsv/immnd/immnd_proc.c
Tests n
Other n
Comments (indicate scope for each y above):
-
changeset 0ecbcc0bfd200dbc4e31918a6b3eb287ffd0
Author: Hung Nguyen hung.d.ngu...@dektech.com.au
Date: Fri, 05 Dec 2014 17:28:07 +0700
imm
osaf/services/saf/immsv/immnd/ImmModel.cc | 16
1 files changed, 16 insertions(+), 0 deletions(-)
When the implementer transiently detaches, cached values of cached RTAs are
still available for Object Search API and Object Access API.
The timeout is hard-coded to 6s
n
Other n
Comments (indicate scope for each y above):
-
changeset 4bede0028f9a50f924ba13b1d002435a9fa2b729
Author: Hung Nguyen hung.d.ngu...@dektech.com.au
Date: Fri, 12 Dec 2014 18:51:11 +0700
immtools: Support
osaf/libs/common/immsv/immpbe_dump.cc | 130 +++-
osaf/libs/common/immsv/include/immpbe_dump.hh |4 +
osaf/tools/safimm/immdump/imm_dumper.cc | 105 +++--
osaf/tools/safimm/immdump/imm_dumper.hh |7 +-
osaf/tools/safimm/immdump/imm_xmlw_dump.cc| 290
n
Other n
Comments (indicate scope for each y above):
-
changeset aaa0c98ab7dae004502f6dfb14cfcfbf634ca2dd
Author: Hung Nguyen hung.d.ngu...@dektech.com.au
Date: Thu, 11 Dec 2014 11:08:05 +0700
Remove SaNameT
osaf/libs/common/immsv/include/immsv_api.h | 1 +
osaf/services/saf/immsv/immnd/ImmModel.cc | 34 -
osaf/services/saf/immsv/immnd/ImmModel.hh | 1 +
osaf/services/saf/immsv/immnd/immnd_init.h | 1 +
4 files changed, 35 insertions(+), 2 deletions(-)
Add
osaf/libs/agents/saf/imma/imma_oi_api.c | 18 +-
osaf/libs/agents/saf/imma/imma_proc.c| 16 -
osaf/libs/common/immsv/immsv_evt.c | 78 ++-
osaf/libs/common/immsv/include/immsv_evt_model.h | 2 +-
osaf/libs/agents/saf/imma/imma_om_api.c |8 +-
osaf/libs/common/immsv/immsv_evt.c | 328 ++
osaf/libs/common/immsv/include/immsv_evt.h |4 +
osaf/libs/common/immsv/include/immsv_evt_model.h |5 +-
osaf/services/saf/immsv/immnd/ImmModel.cc | 28 +++-
osaf/services/saf/immsv/immnd/ImmModel.hh | 2 +-
osaf/services/saf/immsv/immnd/immnd_evt.c | 24 ++--
osaf/services/saf/immsv/immnd/immnd_init.h | 6 +++---
4 files changed, 33
osaf/libs/agents/saf/imma/imma_oi_api.c | 24
1 files changed, 12 insertions(+), 12 deletions(-)
Return BAD_OPERATION for OiRtObject operations whith no implementer.
Print error message to syslog to notify users.
diff --git a/osaf/libs/agents/saf/imma/imma_oi_api.c
tests/immsv/implementer/test_saImmOiRtObjectCreate_2.c | 8
tests/immsv/implementer/test_saImmOiRtObjectDelete.c | 2 +-
tests/immsv/implementer/test_saImmOiRtObjectUpdate_2.c | 2 +-
3 files changed, 6 insertions(+), 6 deletions(-)
Change expected return code from
Tests y
Other n
Comments (indicate scope for each y above):
-
changeset 9511311acb95fdbbf554c7b8293a287e768b997b
Author: Hung Nguyen hung.d.ngu...@dektech.com.au
Date: Tue, 23 Dec 2014 14:48:03 +0700
imm
osaf/libs/common/immsv/immpbe_dump.cc | 12
1 files changed, 12 insertions(+), 0 deletions(-)
Add missing functions for non-pbe section in immpbe_dump.cc
diff --git a/osaf/libs/common/immsv/immpbe_dump.cc
b/osaf/libs/common/immsv/immpbe_dump.cc
---
n
Other n
Comments (indicate scope for each y above):
-
changeset 3569154185463586ef5f9c1eb3b40195f3e084a5
Author: Hung Nguyen hung.d.ngu...@dektech.com.au
Date: Thu, 08 Jan 2015 11:53:38 +0700
immtools: Support
Hi Neel,
Attached is the patches.
Best Regards,
Hung Nguyen
DEK Technologies
*From:* Reddy Neelakanta Reddy Peddavandla
*Sent:* Wednesday, March 18, 2015 4:37PM
*To:* Hung Nguyen, Anders Bjornerstedt
*Cc:* opensaf
osaf/libs/agents/saf/imma/imma_oi_api.c | 18 ++-
osaf/libs/agents/saf/imma/imma_proc.c| 20 ++-
osaf/libs/common/immsv/immsv_evt.c | 82 +++-
osaf/libs/common/immsv/include/immsv_evt.h |4 +
n
Other n
Comments (indicate scope for each y above):
-
changeset 9aee43d9d2476b07993c81c16fa0592835dea2c5
Author: Hung Nguyen hung.d.ngu...@dektech.com.au
Date: Tue, 17 Mar 2015 09:23:22 +0700
imm
osaf/libs/agents/saf/imma/imma_db.c | 2 +-
osaf/libs/agents/saf/imma/imma_proc.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
Change log severity from ERror to WArning for PBE missmatch on op-count.
diff --git a/osaf/libs/agents/saf/imma/imma_db.c
n
Tests n
Other n
Comments (indicate scope for each y above):
-
changeset 9cc5c9ada17565d8c955537968d4eb5e477786db
Author: Hung Nguyen hung.d.ngu...@dektech.com.au
Date: Tue, 10 Mar 2015 13:52
osaf/libs/agents/saf/imma/imma_oi_api.c | 21 +++-
osaf/libs/agents/saf/imma/imma_proc.c| 20 ++-
osaf/libs/common/immsv/immsv_evt.c | 72 ++-
osaf/libs/common/immsv/include/immsv_evt.h |4 +
n
Other n
Comments (indicate scope for each y above):
-
changeset 728ba0de31a2d6ed19fa97a4e47da311a0124c68
Author: Hung Nguyen hung.d.ngu...@dektech.com.au
Date: Tue, 24 Mar 2015 15:15:21 +0700
imm: Remove use
osaf/libs/agents/saf/imma/imma_oi_api.c | 13 -
osaf/libs/agents/saf/imma/imma_om_api.c | 13 -
2 files changed, 24 insertions(+), 2 deletions(-)
Ensure strings sent to IMM server are null terminated.
diff --git a/osaf/libs/agents/saf/imma/imma_oi_api.c
n
Other n
Comments (indicate scope for each y above):
-
changeset c12a657ff7fadeb596fb3cf0ad5bec2d424f50d5
Author: Hung Nguyen hung.d.ngu...@dektech.com.au
Date: Mon, 23 Mar 2015 20:13:15 +0700
imm: Ensure
n
Other n
Comments (indicate scope for each y above):
-
changeset b0009424039a9edffe250a5ad49731c62adb1e81
Author: Hung Nguyen hung.d.ngu...@dektech.com.au
Date: Wed, 04 Mar 2015 15:19:45 +0700
immpbe: Create
'objectName' instead of creating 'objectRdn'
variable.
Just replace 'objectRdn' with 'objectName' and clear 'objectName' after
adding RDN attribute to 'req-attrValues'.
Best Regards,
Hung Nguyen
DEK Technologies
*From
samples/immsv/immutils/immutil.c | 28
samples/immsv/immutils/immutil.h | 10 ++
2 files changed, 38 insertions(+), 0 deletions(-)
Add wrapper functions for saImmOmCcbValidate and saImmOmCcbAbort.
diff --git a/samples/immsv/immutils/immutil.c
n
Other n
Comments (indicate scope for each y above):
-
changeset 429e2e58ba8e23e71afc15ba5bcb84e73885bda1
Author: Hung Nguyen hung.d.ngu...@dektech.com.au
Date: Fri, 27 Feb 2015 10:05:22 +0700
immtools: Add
appropriated error code.
The 'version' returned from IMM service is only used to determine
proto47 (TRUE or FALSE). It will not affect the version of the library
like isImmA2b, isImmA2d...
Best Regards,
Hung Nguyen
DEK Technologies
Hi Neel,
The new member isProto47 of IMMA_CLIENT_NODE is not the same with the
members like isImmA2b, isImmA2d...
It is used to check if the proto47 is enabled at handle initialization.
Since only IMMND knows about proto47 so clients have to get that from IMMND.
Best Regards,
Hung Nguyen
DEK
n
Other n
Comments (indicate scope for each y above):
-
changeset f71cf86bfefaea3ab1d2cc15895a9fca4e906f31
Author: Hung Nguyen hung.d.ngu...@dektech.com.au
Date: Mon, 13 Apr 2015 13:23:45 +0700
imm
osaf/libs/agents/saf/imma/imma_oi_api.c | 10 -
osaf/libs/agents/saf/imma/imma_proc.c| 16 ++-
osaf/libs/common/immsv/immsv_evt.c | 47
osaf/libs/common/immsv/include/immsv_evt.h | 3 +
osaf/libs/agents/saf/imma/imma_cb.h| 1 +
osaf/libs/agents/saf/imma/imma_oi_api.c| 6 ++
osaf/libs/agents/saf/imma/imma_om_api.c| 6 ++
osaf/libs/common/immsv/immsv_evt.c | 24
osaf/libs/common/immsv/include/immsv_evt.h | 1 +
osaf/libs/agents/saf/imma/imma_om_api.c |8 +-
osaf/libs/common/immsv/immsv_evt.c | 265 --
osaf/libs/common/immsv/include/immsv_evt.h |4 +
osaf/libs/common/immsv/include/immsv_evt_model.h |1 +
osaf/services/saf/immsv/immd/immd_evt.c
osaf/libs/common/immsv/include/immsv_api.h | 1 +
osaf/services/saf/immsv/immnd/ImmModel.cc | 30 ++
osaf/services/saf/immsv/immnd/ImmModel.hh | 1 +
osaf/services/saf/immsv/immnd/immnd_init.h | 1 +
4 files changed, 33 insertions(+), 0 deletions(-)
Add
osaf/services/saf/immsv/immnd/ImmModel.cc | 22 +-
osaf/services/saf/immsv/immnd/ImmModel.hh | 2 +-
osaf/services/saf/immsv/immnd/immnd_evt.c | 24 ++--
osaf/services/saf/immsv/immnd/immnd_init.h | 6 +++---
4 files changed, 27 insertions(+), 27
n
Other n
Comments (indicate scope for each y above):
-
changeset 7a8f6e4c5454d9eb90b46eeea02c689910fcf3d2
Author: Hung Nguyen hung.d.ngu...@dektech.com.au
Date: Fri, 05 Jun 2015 11:14:41 +0700
imm: Check
osaf/services/saf/immsv/immnd/ImmModel.cc | 12 +++-
1 files changed, 11 insertions(+), 1 deletions(-)
In commitModify() IMM_CREATE_LOCK flag is used to test to avoid adding
duplicated no-dangling references.
When an IMM_CREATE mutation is committed, the IMM_CREATE_LOCK flag is also
' defined but not used
[-Werror=unused-variable]
static int pbeAuditNoDangling(sqlite3 *dbHandle) {
^
Best Regards,
Hung Nguyen
DEK Technologies
*From:* Zoran Milinkovic
*Sent:* Thursday, June 04, 2015 7
Hi Zoran,
I will make that change.
Thanks and Best Regards,
Hung Nguyen
DEK Technologies
*From:* Zoran Milinkovic
*Sent:* Friday, June 05, 2015 10:34AM
*To:* Hung Nguyen, Reddy Neelakanta Reddy Peddavandla
*Cc
tests/immsv/management/test_saImmOmCcbInitialize.c | 10 +
tests/immsv/management/test_saImmOmCcbObjectDelete.c | 170 +
tests/immsv/management/test_saImmOmCcbObjectModify_2.c | 32 +++
3 files changed, 212 insertions(+), 0 deletions(-)
New testcases check if reffered
Other n
Comments (indicate scope for each y above):
-
changeset e2d1766a17054a45e5c995cc08005164fa0bc1bf
Author: Hung Nguyen hung.d.ngu...@dektech.com.au
Date: Thu, 11 Jun 2015 15:39:59 +0700
imm: Add testcases for NO_DANGLING
n
Other n
Comments (indicate scope for each y above):
-
changeset 52e3b95f145590ac54549100fe75e05b97e1f4d7
Author: Hung Nguyen hung.d.ngu...@dektech.com.au
Date: Mon, 01 Jun 2015 13:56:23 +0700
imm: Ensure
osaf/services/saf/immsv/immnd/ImmModel.cc | 65 +-
1 files changed, 36 insertions(+), 29 deletions(-)
When an IMM_CREATE mutation is committed, the IMM_CREATE_LOCK flag is also
cleared in commitCreate().
If the CCB has IMM_MODIFY mutations that add references to
are not removed so the object can't be deleted.
# immcfg -d testClass=1
error - saImmOmCcbApply FAILED: SA_AIS_ERR_FAILED_OPERATION (21)
# immcfg -d testClass=2
error - saImmOmCcbApply FAILED: SA_AIS_ERR_FAILED_OPERATION (21)
Best Regards,
Hung Nguyen
DEK Technologies
the mOpType.
We have to free the memory in another loop.
Attached is the patch.
Best Regards,
Hung Nguyen
DEK Technologies
*From:* Hung Nguyen
*Sent:* Tuesday, June 02, 2015 10:03AM
*To:* Zoran Milinkovic, Reddy Neelakanta
n
Other n
Comments (indicate scope for each y above):
-
changeset 671ffb3dc5e13da04670645fa569e8ab8477ac0d
Author: Hung Nguyen hung.d.ngu...@dektech.com.au
Date: Thu, 20 Aug 2015 15:49:45 +0700
imm: Discard CCB when
osaf/services/saf/immsv/immnd/immnd_evt.c | 17 +++--
1 files changed, 15 insertions(+), 2 deletions(-)
If IMMND gets IMMA DOWN event before receiving IMMND_EVT_D2ND_CCBINIT,
immnd_client_node_get() will return NULL cl_node in
immnd_evt_proc_ccbinit_rsp().
In that case, on the
n
Other n
Comments (indicate scope for each y above):
-
changeset fb244bf811e06271c43e0a518c6bd411ca71d786
Author: Hung Nguyen hung.d.ngu...@dektech.com.au
Date: Thu, 20 Aug 2015 15:46:42 +0700
imm: Discard
osaf/services/saf/immsv/immnd/immnd_evt.c | 17 +++--
1 files changed, 15 insertions(+), 2 deletions(-)
If IMMND gets IMMA DOWN event before receiving IMMND_EVT_D2ND_ADMINIT,
immnd_client_node_get() will return NULL cl_node in
immnd_evt_proc_adminit_rsp().
In that case, on the
Hi Zoran,
With this fix I think it's now safe to remove the 1 sec sleep for #1261.
Best Regards,
Hùng Nguyễn
DEK Technologies
*From:* Zoran Milinkovic
*Sent:* Friday, August 14, 2015 4:26PM
*To:* Neelakanta Reddy
osaf/services/saf/immsv/immnd/immnd_evt.c | 20 ++--
1 files changed, 18 insertions(+), 2 deletions(-)
If IMMND gets IMMA DOWN event before receiving IMMND_EVT_D2ND_IMPLSET_RSP,
IMMND will fail to discard the implementer because the implementer is not added
to immModel. That
n
Other n
Comments (indicate scope for each y above):
-
changeset c5c704253010988d4634cfeb040f01403f7b739b
Author: Hung Nguyen hung.d.ngu...@dektech.com.au
Date: Thu, 30 Jul 2015 17:05:47 +0700
imm: Discard
Hi Johan,
Tested the patch.
Ack from me.
Best Regards,
Hùng Nguyễn
DEK Technologies
*From:* Johan Mårtensson O
*Sent:* Wednesday, August 05, 2015 7:24PM
*To:* Hans Nordeback, Mathivanan Naickan, Hung Nguyen, Srikanth
*From:* Johan Mårtensson O
*Sent:* Wednesday, July 15, 2015 9:41PM
*To:* Hans Nordeback, Anders Bjornerstedt, Mathivanan Naickan, Hung
Nguyen, Srikanth Revanuru
*Cc:* Opensaf-devel
*Subject:* [PATCH 1 of 1] pyosaf: (updated) Add method to
pyosaf.utils.immom.ccb.Ccb
Naickan, Hung
Nguyen, Srikanth Revanuru
*Cc:* Opensaf-devel
*Subject:* [PATCH 1 of 1] pyosaf: Add parameter to
pyosaf.utils.immom.ccb.Ccb constructor to specify exact CCB flags [#1417]
python/pyosaf/saImm.py | 1 +
python/pyosaf/utils/immom/ccb.py | 9 ++---
2 files changed, 7
Hi Johan,
For delete operation, you don't have to release admin owner for deleted
objects.
object_name should only be appended to objects_to_clear list when
saImmOmCcbObjectDelete() failed.
Best Regards,
Hung Nguyen
DEK Technologies
Hi Johan,
Ack from me.
Tested the patch.
Best Regards,
Hung Nguyen
DEK Technologies
*From:* Johan Mårtensson O
*Sent:* Thursday, July 09, 2015 9:51PM
*To:* Hans Nordeback, Anders Bjornerstedt, Mathivanan Naickan
*Cc
Hi Johan,
Ack from me.
Tested the patch.
Best Regards,
Hung Nguyen
DEK Technologies
*From:* Johan Mårtensson O
*Sent:* Friday, July 10, 2015 5:00PM
*To:* Hans Nordeback, Anders Bjornerstedt, Mathivanan Naickan
*Cc
y
Comments (indicate scope for each "y" above):
-
<>
changeset f480c48a2fc00bdbb875f3f5d66acc401f9f21b0
Author: Hung Nguyen <hung.d.ngu...@dektech.com.au>
Date: Wed, 28 Oct 2015 15:16:10 +0700
pyosaf:
python/pyosaf/saImm.py | 7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
Missing flags:
SA_IMM_ATTR_NO_DUPLICATES 0x0100 /* OpenSaf 4.3 */
SA_IMM_ATTR_NOTIFY0x0200 /* OpenSaf 4.3 */
SA_IMM_ATTR_NO_DANGLING 0x0400 /* OpenSaf
y
Comments (indicate scope for each "y" above):
-
<>
changeset 333290613ec332d9dd64ebef010c424ad694f747
Author: Hung Nguyen <hung.d.ngu...@dektech.com.au>
Date: Wed, 28 Oct 2015 15:27:13 +0700
pyosaf: Add mi
python/pyosaf/saImm.py | 6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
Missing flags:
SA_IMM_ATTR_NO_DUPLICATES 0x0100 /* OpenSaf 4.3 */
SA_IMM_ATTR_NOTIFY0x0200 /* OpenSaf 4.3 */
SA_IMM_ATTR_NO_DANGLING 0x0400 /* OpenSaf
y
Comments (indicate scope for each "y" above):
-
<>
changeset 1f07f8ce98479ac70597ee398934a23d35ee8648
Author: Hung Nguyen <hung.d.ngu...@dektech.com.au>
Date: Wed, 28 Oct 2015 15:33:04 +0700
pyosaf: Add mi
python/pyosaf/saImm.py | 5 +
1 files changed, 5 insertions(+), 0 deletions(-)
Missing flags:
SA_IMM_ATTR_NO_DUPLICATES 0x0100 /* OpenSaf 4.3 */
SA_IMM_ATTR_NOTIFY0x0200 /* OpenSaf 4.3 */
SA_IMM_ATTR_NO_DANGLING 0x0400 /* OpenSaf
clear this way.
We can also avoid declaring 'isValidationErrString' and 'if' block inside 'if'
block.
BR,
Hung Nguyen - DEK Technologies
From: Zoran Milinkovic zoran.milinko...@ericsson.com
Sent: Monday, October 26, 2015 6:4
Hi Johan,
Reviewed and tested the patch. Ack from me.
BR,
Hung Nguyen - DEK Technologies
From: Johan Martensson johan.o.martens...@ericsson.com
Sent: Monday, November 09, 2015 1:30PM
To: Hans Nordeback
osaf/services/saf/immsv/immnd/ImmModel.cc | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
Clear sImplDetachTime when aborting sync.
diff --git a/osaf/services/saf/immsv/immnd/ImmModel.cc
b/osaf/services/saf/immsv/immnd/ImmModel.cc
--- a/osaf/services/saf/immsv/immnd/ImmModel.cc
+++
Hi Johan,
Reviewed and tested the patch.
Ack from me with some minor comments. Please see them inline.
BR,
Hung Nguyen - DEK Technologies
From: Johan Martensson johan.o.martens...@ericsson.com
Sent: Wednesday
Hi Johan,
Reviewed the patch. Ack from me.
BR,
Hung Nguyen - DEK Technologies
From: Johan Martensson johan.o.martens...@ericsson.com
Sent: Wednesday, November 04, 2015 3:03PM
To: Hans Nordeback, Mathivanan
mapping.
Do you think we should consider adding some 'protection' to
ImmModel::classImplementerSet (and 3 other similar functions)?
In those functions, if it's from remote nodes, we just return and do nothing.
BR,
Hung Nguyen - DEK Technologies
Hi,
I will push this tomorrow if there's no more comments.
BR,
Hung Nguyen - DEK Technologies
From: Hung Nguyen hung.d.ngu...@dektech.com.au
Sent: Wednesday, November 04, 2015 5:22PM
To: Srikanth Revanuru, Johan
tests/immsv/common/immtest.c |4 +-
tests/immsv/implementer/test_saImmOiRtObjectCreate_2.c |6 +
tests/immsv/implementer/test_saImmOiRtObjectUpdate_2.c | 173 +
tests/immsv/management/test_saImmOmCcbInitialize.c |6 +
osaf/services/saf/immsv/immloadd/imm_loader.cc | 11 +-
osaf/services/saf/immsv/immloadd/imm_pbe_load.cc |2 +-
osaf/services/saf/immsv/immnd/ImmModel.cc | 82 +-
osaf/services/saf/immsv/immnd/immnd_evt.c | 12 +
osaf/libs/common/immsv/include/immsv_api.h | 1 +
osaf/services/saf/immsv/immnd/ImmModel.cc | 34 ++
osaf/services/saf/immsv/immnd/ImmModel.hh | 1 +
osaf/services/saf/immsv/immnd/immnd_init.h | 1 +
4 files changed, 37 insertions(+), 0 deletions(-)
Add
opensaf.spec.in | 1 +
osaf/libs/agents/saf/imma/imma_cb.h | 1 +
osaf/libs/agents/saf/imma/imma_def.h | 2 +-
osaf/libs/agents/saf/imma/imma_oi_api.c | 3 +
osaf/libs/agents/saf/imma/imma_om_api.c | 18 +++
doesn't have the applier mapping, they should not do
the ccb interference check.
In the ccb check of ImmModel::implementerSet(), 'if(isApplier)' should be
changed to 'if(isApplier && conn)'.
I also have some inline comments for the patch, please find them below.
Best Regards,
Hung Nguye
Hi Zoran,
Reviewed and tested the patch.
Ack from me.
Best Regards,
Hung Nguyen - DEK Technologies
From: Zoran Milinkovic zoran.milinko...@ericsson.com
Sent: Thursday, October 08, 2015 11:13AM
To: Neelakanta
inal design/protocol, class/obj-applier mapping is synced to remote
nodes, so the remote nodes shouldn't do any check related to the mapping.
Best Regards,
Hung Nguyen - DEK Technologies
From: Neelakanta Reddy reddy.n
Hi Zoran,
Please find my comments started with [Hung_2].
Best Regards,
Hung Nguyen - DEK Technologies
From: Zoran Milinkovic zoran.milinko...@ericsson.com
Sent: Wednesday, October 07, 2015 6:10PM
To: Hung
Tests n
Other n
Comments (indicate scope for each "y" above):
-
changeset 61b895fdec363933d1f357042e6d6c584293b15c
Author: Hung Nguyen <hung.d.ngu...@dektech.com.au>
Date: Fri, 09 Oct 201
osaf/services/saf/immsv/immnd/ImmModel.cc | 27 +++
1 files changed, 27 insertions(+), 0 deletions(-)
This patch modifies the content of incoming IMMND_EVT_A2ND_OBJ_MODIFY messages.
If the modType is SA_IMM_ATTR_VALUES_ADD or SA_IMM_ATTR_VALUES_DELETE,
it will be
Technologies
*From:* Johan Mårtensson O
*Sent:* Thursday, August 20, 2015 6:25PM
*To:* Hans Nordeback, Mathivanan Naickan, Hung Nguyen, Srikanth Revanuru
*Cc:* Opensaf-devel
*Subject:* [PATCH 1 of 1] pyosaf: Add Python imm oi utils
Hi Zoran,
I have some inline comments, please see below for details.
Best Regards,
Hung Nguyen
DEK Technologies Vietnam
*From:*Zoran Milinkovic
*Sent:*Friday, August 28, 2015 9:06PM
*To:*Neelakanta Reddy
*Cc:*Opensaf
---
*From:* Zoran Milinkovic
*Sent:* Sunday, September 13, 2015 12:48AM
*To:* Hung Nguyen, Neelakanta Reddy
*Cc:* Opensaf-devel
*Subject:* RE: [devel] [PATCH 1 of 1] imm: fix memory leak in display
resources [#1477]
Hi Hung,
Find my comments inline.
*From:*Hung Nguyen [mailto:hung.d.ngu...@dekt
Hi Johan,
Please see inline comments below.
BR,
Hùng Nguyễn - DEK Technologies
*From:* Johan Martensson
*Sent:* Thursday, September 03, 2015 10:25PM
*To:* Hans Nordeback, Mathivanan Naickan, Hung Nguyen, Srikanth
n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
changeset 75e2f41f627d63866dc8c54ef1c843c8d2614d16
Author: Hung Nguyen <hung.d.ngu...@dektech.com.au>
Dat
osaf/services/saf/immsv/immnd/ImmModel.cc | 31 +--
1 files changed, 29 insertions(+), 2 deletions(-)
Default values are not allowed to be defined with NO_DANGLING flag when
creating classes.
Existing classes with that kind of definition are still able to be loaded
n
Other n
Comments (indicate scope for each "y" above):
-
changeset 3522f6b18b77c14bce6298123a911aa469d31091
Author: Hung Nguyen <hung.d.ngu...@dektech.com.au>
Date: Fri, 11 Sep 2015 15:54:27 +0700
tests/immsv/common/immtest.c |4 +-
tests/immsv/management/test_saImmOmClassCreate_2.c | 661 +
2 files changed, 663 insertions(+), 2 deletions(-)
Add test cases for default value removal.
diff --git a/tests/immsv/common/immtest.c
paramName.
Best Regards,
Hùng Nguyễn - DEK Technologies
*From:* Johan Martensson
*Sent:* Monday, September 14, 2015 9:31PM
*To:* Hans Nordeback, Mathivanan Naickan, Hung Nguyen, Srikanth Revanuru
(srikanth.revan...@oracle.com
ine comments for details.
Best Regards,
Hùng Nguyễn - DEK Technologies
*From:* Johan Martensson
*Sent:* Monday, September 14, 2015 9:31PM
*To:* Hans Nordeback, Mathivanan Naickan, Hung Nguyen, Srikanth Revanuru
(sr
Hi Zoran,
Please see inline comments below.
Best Regards,
Hùng Nguyễn - DEK Technologies
*From:* Zoran Milinkovic
*Sent:* Wednesday, September 16, 2015 9:28PM
*To:* Neelakanta Reddy
*Cc:* Opensaf-devel
*Subject:*
osaf/services/saf/immsv/immnd/ImmModel.cc | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
Add SA_IMM_ATTR_DN to excluded list when checking for unknown attribute flags.
diff --git a/osaf/services/saf/immsv/immnd/ImmModel.cc
b/osaf/services/saf/immsv/immnd/ImmModel.cc
---
1 - 100 of 450 matches
Mail list logo
