[devel] [PATCH 1/1] amf: remove hard-coding in amfnd [#3205]

From: Anand Sundararaj --- src/amf/amfnd/amfnd.conf | 3 +++ src/amf/amfnd/main.cc| 9 - 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/src/amf/amfnd/amfnd.conf b/src/amf/amfnd/amfnd.conf index 07bc0ba..4e8b07a 100644 --- a/src/amf/amfnd/amfnd.conf +++ b/src/amf/amfnd

[devel] [PATCH 0/1] Review Request for amf: remove hard-coding from amfnd [#3205]

: 59ded7cdf6a431e59afd5ecb989e4a61c7d8 Personal repository: git://git.code.sf.net/u/s-anand-has/review Impacted area Impact y/n Docsn Build systemy RPM/packaging n Configuration

[devel] [PATCH 1/1] amf: implement node repair admin command [#3204]

From: Anand Sundararaj --- src/amf/amfd/node.cc| 56 +++- src/amf/amfd/node.h | 2 ++ src/amf/amfd/sgproc.cc | 18 ++ src/amf/amfnd/avnd_su.h | 1 + src/amf/amfnd/di.cc | 62 + src/

[devel] [PATCH 0/1] Review Request for amf: implement node repair admin command [#3204]

: 59ded7cdf6a431e59afd5ecb989e4a61c7d8 Personal repository: git://git.code.sf.net/u/s-anand-has/review Impacted area Impact y/n Docsn Build systemn RPM/packaging n Configuration files n Startup

[devel] [PATCH 0/1] Review Request for amf: support error report on non local component [#109]

: 59ded7cdf6a431e59afd5ecb989e4a61c7d8 Personal repository: git://git.code.sf.net/u/s-anand-has/review Impacted area Impact y/n Docsn Build systemn RPM/packaging n Configuration files n

[devel] [PATCH 1/1] amf: support error report on non local component [#109]

From: Anand Sundararaj --- src/amf/amfnd/amfnd.cc| 22 -- src/amf/amfnd/avnd_cb.h | 2 + src/amf/amfnd/avnd_comp.h | 2 + src/amf/amfnd/clm.cc | 33 - src/amf/amfnd/err.cc | 182 +- 5 files changed, 228 insertions(+),

Re: [devel] [PATCH 1/1] amf: implement node repair admin command [#3204]

Hi Minh, Good catch. The following patch will solve the issue, please confirm: diff --git a/src/amf/amfd/clm.cc b/src/amf/amfd/clm.cc index cfbe36a..743a6c2 100644 --- a/src/amf/amfd/clm.cc +++ b/src/amf/amfd/clm.cc @@ -24,10 +24,12 @@ #include "amf/amfd/node.h" #include "base/osaf_time.h" -sta

Re: [devel] [PATCH 1/1] amf: implement node repair admin command [#3204]

Thanks Minh for your comment and your time to review. Hi Minh/Thang/Nagendra/Paul, I am planning to push the patch by 30th July(thursday). Please kindly find some time to review by 29th July(tomorrow) and send your comments or Ack. Thanks Anand Sundararaj Senior Solutions Architect | +1 480 686 4

Re: [devel] [PATCH 1/1] amf: implement node repair admin command [#3204]

Hi Minh, Please ignore the second patch. Since recvr_fail_sw was not checkpointed in the code, so wrote the code to checkpoint and then everything worked fine. Please take the first published patch and then apply node-repair-upgrade.patch(attached in the ticket #3204) on top of it and then do th

[devel] [PATCH 1/1] amf: implement node repair admin command [#3204] V2

From: Anand Sundararaj --- src/amf/amfd/chkop.cc | 9 +++ src/amf/amfd/ckpt.h | 3 ++- src/amf/amfd/ckpt_dec.cc | 49 - src/amf/amfd/ckpt_enc.cc | 38 - src/amf/amfd/ckpt_msg.h | 1 + src/amf/amfd/ckpt_updt.cc |

[devel] [PATCH 0/1] Review Request for amf: implement node repair admin command [#3204] V2

: 59ded7cdf6a431e59afd5ecb989e4a61c7d8 Personal repository: git://git.code.sf.net/u/s-anand-has/review Impacted area Impact y/n Docsn Build systemn RPM/packaging n Configuration files n Startup

Re: [devel] [PATCH 1/1] amf: implement node repair admin command [#3204]

Awesome Minh! Thank you so much for your great help in testing and providing reviews comments. V2 version is sent with all the earlier published changes, please review. If you are good, then please push the patch and share the change-set, I will close the ticket. Sounds good, Minh ? Thanks Ana

Re: [devel] [PATCH 1/1] amf: support error report on non local component [#109]

Hi Minh, Thanks for your comments. For #1: We are only using amf_saImmOmAccessorGet_o2() api, so shouldn't be any issue. But, I am working on it to read the information in imm thread, will publish it shortly, Minh. For #2: No, you didn't miss it, Minh. Since, this is internal to Amf and not expo

[devel] [PATCH 1/1] amf: support error report on non local component [#109] V2

From: Anand Sundararaj --- src/amf/amfnd/amfnd.cc| 22 ++-- src/amf/amfnd/avnd_cb.h | 2 + src/amf/amfnd/avnd_comp.h | 2 + src/amf/amfnd/clm.cc | 33 +- src/amf/amfnd/err.cc | 23 - src/amf/amfnd/imm.cc | 258 -- 6

[devel] [PATCH 0/1] Review Request for amf: support error report on non local component [#109] V2

: 59ded7cdf6a431e59afd5ecb989e4a61c7d8 Personal repository: git://git.code.sf.net/u/s-anand-has/review Impacted area Impact y/n Docsn Build systemn RPM/packaging n Configuration files n

Re: [devel] [PATCH 1/1] amf: support error report on non local component [#109] V2

Hi Minh, Many thanks for your response and comments. I will check cpplint/cppcheck errors. Also, can you please share these errors, just to see if they are matching with mine (to avoid the versions issues). Please check my responses with [Anand] below. Thanks Anand Sundararaj Senior Solutions Arc

Re: [devel] [PATCH 1/1] amf: support error report on non local component [#109] V2

Hi Minh, Thank you so much, appreciated ! Can you please help with the steps : how did you get the errors added by the patch. I run the following commands on opensaf directory(with the patch): 1. make cpplint > /tmp/cpplint 2>&1 ==> This gives lots of errors. This command didn't work in amfnd

[devel] [PATCH 0/1] Review Request for amf: support error report on non local component [#109] V3

Base revision: 59ded7cdf6a431e59afd5ecb989e4a61c7d8 Personal repository: git://git.code.sf.net/u/s-anand-has/review Impacted area Impact y/n Docsn Build systemn RPM/packaging n

[devel] [PATCH 1/1] amf: support error report on non local component [#109] V3

From: Anand Sundararaj --- src/amf/amfnd/amfnd.cc| 28 -- src/amf/amfnd/avnd_cb.h | 2 + src/amf/amfnd/avnd_comp.h | 2 + src/amf/amfnd/clm.cc | 47 +++-- src/amf/amfnd/err.cc | 31 +- src/amf/amfnd/imm.cc | 238 +++-

Re: [devel] [PATCH 1/1] amf: support error report on non local component [#109] V2

Hi Minh, I have incorporated all of your comments and also cpplint error(applicable to my changes only) and cppcheck, you had reported. The patch V3 has been floated. Please push the patch if you find no further issues. Thanks Anand Sundararaj Senior Solutions Architect | +1 480 686 4772 www.GetH