[devel] [PATCH 1/1] smf: return false instead of empty string [#2993]

2019-01-08 Thread thang.d.nguyen
Return false instead of return empty string. --- src/smf/smfd/SmfExecControlHdl.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/smf/smfd/SmfExecControlHdl.cc b/src/smf/smfd/SmfExecControlHdl.cc index ded24f1..715dd07 100644 --- a/src/smf/smfd/SmfExecControlHdl.cc ++

[devel] [PATCH 0/1] Review Request for smf: return false instead of empty string [#2993]

2019-01-08 Thread thang.d.nguyen
servicesn Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): - revision b08f0c1cfe01d5f1a8f90adbb11f54483c74c876 Author: thang.d.ng

[devel] [PATCH 0/1] Review Request for clmd: not send sync respond to client if node down [#3004]

2019-01-29 Thread thang.d.nguyen
195 Author: thang.d.nguyen Date: Tue, 29 Jan 2019 04:32:25 +0700 clmd: not send sync respond to client if node down [#3004] clmd will not send sync respond to client if the node that client resided on down. This will avoid timeout when clmd send via mds. Complete diffstat: -- src/clm/clmd

[devel] [PATCH 1/1] clmd: not send sync respond to client if node down [#3004]

2019-01-29 Thread thang.d.nguyen
clmd will not send sync respond to client if the node that client resided on down. This will avoid timeout when clmd send via mds. --- src/clm/clmd/clms_cb.h| 5 src/clm/clmd/clms_evt.cc | 35 ++- src/clm/clmd/clms_evt.h | 1 + src/clm/clmd/clms_main.cc | 4 +

[devel] [PATCH 0/1] Review Request for clmd: not send sync respond to client if node down V1 [#3004]

2019-01-31 Thread thang.d.nguyen
b6d Author: thang.d.nguyen Date: Wed, 30 Jan 2019 00:58:24 +0700 clmd: not send sync respond to client if node down [#3004] Clmd will not send sync respond to client if the node that client resided on down. This will avoid timeout when clmd send via mds. Complete diffstat: -- sr

[devel] [PATCH 1/1] clmd: not send sync respond to client if node down [#3004]

2019-01-31 Thread thang.d.nguyen
Clmd will not send sync respond to client if the node that client resided on down. This will avoid timeout when clmd send via mds. --- src/clm/clmd/clms_cb.h | 3 +++ src/clm/clmd/clms_evt.cc | 22 +- src/clm/clmd/clms_mds.cc | 2 +- 3 files changed, 21 insertions(+), 6 del

[devel] [PATCH 1/1] amf: disallow delete csi that another csi is dependent on [#2969]

2019-02-20 Thread thang.d.nguyen
Disallow delete a csi that another csi is dependent on. If allowing it caused AMFD crashed or fallen in cyclic restart. Allow if csi(s) are deleted in same ccb. --- src/amf/amfd/csi.cc | 23 +++ 1 file changed, 23 insertions(+) diff --git a/src/amf/amfd/csi.cc b/src/amf/amfd/c

[devel] [PATCH 0/1] Review Request for amf: disallow delete csi that another csi is dependent on V2 [#2969]

2019-02-20 Thread thang.d.nguyen
218 Author: thang.d.nguyen Date: Thu, 14 Feb 2019 16:04:32 +0700 amf: disallow delete csi that another csi is dependent on [#2969] Disallow delete a csi that another csi is dependent on. If allowing it caused AMFD crashed or fallen in cyclic restart. Allow if csi(s) are deleted in same ccb. Complet

[devel] [PATCH 0/1] Review Request for smf: clear old attributes before re-filling if ccb abort to sync [#3010]

2019-02-24 Thread thang.d.nguyen
9b6 Author: thang.d.nguyen Date: Mon, 25 Feb 2019 10:44:38 +0700 smf: clear old attributes before re-filling if ccb abort to sync [#3010] During single step install, the ccb is aborted to sync. The old attributes in object creator must be erased before re-filling. Complet

[devel] [PATCH 1/1] smf: clear old attributes before re-filling if ccb abort to sync [#3010]

2019-02-24 Thread thang.d.nguyen
During single step install, the ccb is aborted to sync. The old attributes in object creator must be erased before re-filling. --- src/smf/smfd/SmfImmOperation.h | 5 + src/smf/smfd/SmfUtils.cc | 3 +++ 2 files changed, 8 insertions(+) diff --git a/src/smf/smfd/SmfImmOperation.h b/src/s

[devel] [PATCH 1/1] smf: clear old attributes before re-filling if ccb abort to sync [#3010]

2019-02-24 Thread thang.d.nguyen
During single step install, the ccb is aborted to sync. The old attributes in object creator/modifier must be erased before re-filling. --- src/smf/smfd/SmfImmOperation.h | 6 ++ src/smf/smfd/SmfUtils.cc | 3 +++ 2 files changed, 9 insertions(+) diff --git a/src/smf/smfd/SmfImmOperation

[devel] [PATCH 0/1] Review Request for smf: clear old attributes before re-filling if ccb abort to sync [#3010] V1

2019-02-24 Thread thang.d.nguyen
70f Author: thang.d.nguyen Date: Mon, 25 Feb 2019 13:02:00 +0700 smf: clear old attributes before re-filling if ccb abort to sync [#3010] During single step install, the ccb is aborted to sync. The old attributes in object creator/modifier must be erased before re-filling. Complet

[devel] [PATCH 1/1] amfd: increase mds priority of amfnd down event [#3015]

2019-03-01 Thread thang.d.nguyen
To avoid the issue a node can not join the cluster when the PBE hung. --- src/amf/amfd/mds.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amf/amfd/mds.cc b/src/amf/amfd/mds.cc index 108f9b8..41b9325 100644 --- a/src/amf/amfd/mds.cc +++ b/src/amf/amfd/mds.cc @@ -457,7 +4

[devel] [PATCH 0/1] Review Request for amfd: increase mds priority of amfnd down event [#3015]

2019-03-01 Thread thang.d.nguyen
servicesn Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): - revision e81b6874f37e9761594f7ee3328486062fcbddb3 Author: thang.d.ng

[devel] [PATCH 0/2] Review Request for amf: disallow delete csi that another csi is dependent on [#2969] V2

2019-04-09 Thread thang.d.nguyen
0e7 Author: thang.d.nguyen Date: Tue, 9 Apr 2019 05:08:51 +0700 amf: disallow delete csi that another csi is dependent on [#2969] - Disallow delete sponsor csi if there is dependent csi. - Allow delete sponsor csi if it and dependent csi in same ccb. - Disallow if all csi(s) are deleted in same ccb.

[devel] [PATCH 2/2] amf: disallow delete csi that another csi is dependent on [#2969]

2019-04-09 Thread thang.d.nguyen
- Disallow delete sponsor csi if there is dependent csi. - Allow delete sponsor csi if it and dependent csi in same ccb. - Disallow if all csi(s) are deleted in same ccb. --- src/amf/amfd/csi.cc | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/src/amf

[devel] [PATCH 1/2] amf: disallow delete csi that another csi is dependent on [#2969]

2019-04-09 Thread thang.d.nguyen
Disallow delete a csi that another csi is dependent on. If allowing it caused AMFD crashed or fallen in cyclic restart. Allow if csi(s) are deleted in same ccb. --- src/amf/amfd/csi.cc | 23 +++ 1 file changed, 23 insertions(+) diff --git a/src/amf/amfd/csi.cc b/src/amf/amfd/c

[devel] [PATCH 0/1] Review Request for amfd: ignore amfnd down event if node state is absent [#3015] V2

2019-05-07 Thread thang.d.nguyen
73e Author: thang.d.nguyen Date: Tue, 7 May 2019 02:16:09 +0700 amfd: ignore amfnd down event if node state is absent [#3015] When the PBE hung, amfd can process the events with below order when a node was started then stop then started - clm_track_cb for node down event - clm_track_cb for second nod

[devel] [PATCH 1/1] amfd: ignore amfnd down event if node state is absent [#3015]

2019-05-07 Thread thang.d.nguyen
When the PBE hung, amfd can process the events with below order when a node was started then stop then started - clm_track_cb for node down event - clm_track_cb for second node up event - avd_mds_avnd_down_evh was called to process amfnd down event And it cause the node can not join the cluster. -

[devel] [PATCH 1/1] fmd: Standby do not failover to ACTIVE if ACIVE exist [#3017]

2019-05-07 Thread thang.d.nguyen
In roaming SC, shutdown standby SC to make another takes STANDBY role. AMFD on standby was hung before shutdown. So during the new node change to STANDBY, it receives the AMFD up/down event from the old STANDBY and it default set role to ACTIVE instead of the ACTIVE already exist. The fix is to ig

[devel] [PATCH 0/1] Review Request for fmd: Standby do not failover to ACTIVE if ACIVE exist [#3017]

2019-05-07 Thread thang.d.nguyen
0a6 Author: thang.d.nguyen Date: Tue, 7 May 2019 03:27:06 +0700 fmd: Standby do not failover to ACTIVE if ACIVE exist [#3017] In roaming SC, shutdown standby SC to make another takes STANDBY role. AMFD on standby was hung before shutdown. So during the new node change to STANDBY, it receives the AMFD up/

[devel] [PATCH 1/1] amfnd: reboot to recovery if msg id received by amfd mismatch with msg id sent by amfnd [#3040]

2019-05-16 Thread thang.d.nguyen
During SC failover, message received on ACTIVE AMFD can not be checked point to AMFD on STANDBY SC. But the AMFND still process the message ack for that message then it remove from queue. STANDBY SC takes ACTIVE and mismatch message id b/w AMFD and AMFND on new ACTIVE. As consequence, clm track sta

[devel] [PATCH 0/1] Review Request for amfnd: reboot to recovery if msg id received by amfd mismatch with msg id sent by amfnd [#3040]

2019-05-16 Thread thang.d.nguyen
revision f8bb951980532726a91a158efd6bb2b9452c70e4 Author: thang.d.nguyen Date: Tue, 14 May 2019 20:48:06 +0700 amfnd: reboot to recovery if msg id received by amfd mismatch with msg id sent by amfnd [#3040] During SC failover, message received on ACTIVE AMFD can not be checked point to AMFD on STANDBY SC. But the A

[devel] [PATCH 0/1] Review Request for amf: reboot to recover from lost msgs [#3040] V2

2019-05-20 Thread thang.d.nguyen
servicesn Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): - revision e9906973dc3b19dc97dc429ede58c684f1c8a007 Author: thang.d.ng

[devel] [PATCH 1/1] amf: reboot to recover from lost msgs [#3040]

2019-05-20 Thread thang.d.nguyen
During SC failover, message received on ACTIVE AMFD can not be checked point to AMFD on STANDBY SC. But the AMFND still process the message ack for that message then it remove from queue. STANDBY SC takes ACTIVE and mismatch message id b/w AMFD and AMFND on new ACTIVE. As consequence, clm track sta

[devel] [PATCH 1/1] amf: remove SUSI assignemnt of dependent SI during failover [#3049]

2019-06-06 Thread thang.d.nguyen
When lock node invokes on active assignment. The dependent SI follow with sponsor SI move to QUIESCED. There is a case that the active assignment for sponsor is happening on remain SC node. And that remaining node was down. The remove SISU only happen for sponsor SI. The fix is to remove SUSI of de

[devel] [PATCH 0/1] Review Request for remove SUSI assignemnt of dependent SI during failover [#3049]

2019-06-06 Thread thang.d.nguyen
dbf Author: thang.d.nguyen Date: Thu, 6 Jun 2019 18:07:00 +0700 amf: remove SUSI assignemnt of dependent SI during failover [#3049] When lock node invokes on active assignment. The dependent SI follow with sponsor SI move to QUIESCED. There is a case that the active assignment for sponsor is happening on

[devel] [PATCH 1/1] amf: remove SUSI assignemnt of dependent SI during failover [#3049]

2019-06-11 Thread thang.d.nguyen
When lock node invokes on active assignment. The dependent SI follow with sponsor SI move to QUIESCED. There is a case that the active assignment for sponsor is happening on remain SC node. And that remaining node was down. The remove SISU only happen for sponsor SI. The fix is to remove SUSI of de

[devel] [PATCH 0/1] Review Request for amf: remove SUSI assignemnt of dependent SI during failover [#3049] v2

2019-06-11 Thread thang.d.nguyen
8fc Author: thang.d.nguyen Date: Wed, 12 Jun 2019 08:41:10 +0700 amf: remove SUSI assignemnt of dependent SI during failover [#3049] When lock node invokes on active assignment. The dependent SI follow with sponsor SI move to QUIESCED. There is a case that the active assignment for sponsor is happening on

[devel] [PATCH 1/1] amf: controller issue reboot if amf director not synced with active yet [#3051]

2019-06-17 Thread thang.d.nguyen
The controller come up after reboot. The nored ncs SU was assigned but it can not be done by active amfd due to reboot. At that time, the amfd on this controller are not ready to take failover so it will request again for nored ncs SU to amfnd. It will be failed due to already assigned. As conseque

[devel] [PATCH 0/1] Review Request for amf: controller issue reboot if amf director not synced with active yet [#3051]

2019-06-17 Thread thang.d.nguyen
ed61d6217b Author: thang.d.nguyen Date: Mon, 17 Jun 2019 13:33:53 +0700 amf: controller issue reboot if amf director not synced with active yet [#3051] The controller come up after reboot. The nored ncs SU was assigned but it can not be done by active amfd due to reboot. At that time, the am

[devel] [PATCH 0/1] Review Request for imm: immnd respawns if it exits during startup [#3053]

2019-06-19 Thread thang.d.nguyen
OpenSAF servicesn Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): - revision e4c19f52f0f312a20325071cec2235b9c7031614 Author: than

[devel] [PATCH 1/1] imm: immnd respawns if it exits during startup [#3053]

2019-06-19 Thread thang.d.nguyen
During start up, the immnd was exited due to sync interrupted. It should send the error respond to nid. --- src/imm/immnd/immnd_evt.c | 4 1 file changed, 4 insertions(+) diff --git a/src/imm/immnd/immnd_evt.c b/src/imm/immnd/immnd_evt.c index adae1e1..3bd56fe 100644 --- a/src/imm/immnd/imm

[devel] [PATCH 0/1] Review Request for amf: reject in ccb object delete callback if not synced [#3055]

2019-06-26 Thread thang.d.nguyen
edc Author: thang.d.nguyen Date: Wed, 26 Jun 2019 01:58:16 +0700 amf: reject in ccb object delete callback if not synced [#3055] During controller goes up, it creats config object from IMM. In case the object was deleted but comming up amfd still receives ccb object delete callback. And it validates and

[devel] [PATCH 1/1] amf: reject in ccb object delete callback if not synced [#3055]

2019-06-26 Thread thang.d.nguyen
During controller goes up, it creats config object from IMM. In case the object was deleted but comming up amfd still receives ccb object delete callback. And it validates and crash due to access to null pointer. --- src/amf/amfd/imm.cc | 21 - 1 file changed, 16 insertions(+),

[devel] [PATCH 0/1] Review Request for amf: check null before access to config objects [#3055] V2

2019-07-01 Thread thang.d.nguyen
servicesn Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): - revision 24da64783b5c3b61200fab6845c9343de89f85a4 Author: thang.d.ng

[devel] [PATCH 1/1] amf: check null before access to config objects [#3055]

2019-07-01 Thread thang.d.nguyen
During controller goes up, it creats config object from IMM. In case the object was deleted but comming up amfd still receives ccb object delete callback. And it validates and crash due to access to null pointer. --- src/amf/amfd/app.cc | 17 ++--- src/amf/amfd/apptype.cc | 13 ++

[devel] [PATCH 1/1] amf: realign sg if si_dep_state of si in FAILOVER_UNDER_PROGRESS [#3054]

2019-07-02 Thread thang.d.nguyen
With SI dependency, when failover happen the failover is processed on SU had sponsor SI first. It also update the si_dep_state of dependent SI to FAILOVER_UNDER_PROGRESS. Then failover is processed on SU had dependent SI. But failover is deferred as sponsors role failover is under going. Amfd cras

[devel] [PATCH 0/1] Review Request for amf: realign sg if si_dep_state of si in FAILOVER_UNDER_PROGRESS [#3054]

2019-07-02 Thread thang.d.nguyen
92c Author: thang.d.nguyen Date: Tue, 2 Jul 2019 21:53:31 +0700 amf: realign sg if si_dep_state of si in FAILOVER_UNDER_PROGRESS [#3054] With SI dependency, when failover happen the failover is processed on SU had sponsor SI first. It also update the si_dep_state of depen

[devel] [PATCH 1/1] smf: retry if ccb is aborted at init proc [#3061]

2019-07-22 Thread thang.d.nguyen
Retry if ccb is aborted at init proc. Retry when the model modification will return TRY_AGAIN or NOT_EXIST. --- src/smf/smfd/SmfUpgradeAction.cc | 73 +++- 1 file changed, 65 insertions(+), 8 deletions(-) diff --git a/src/smf/smfd/SmfUpgradeAction.cc b/src/smf/

[devel] [PATCH 0/1] Review Request for smf: retry if ccb is aborted at init proc [#3061]

2019-07-22 Thread thang.d.nguyen
n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): - revision 6a0900061ecbbff810cc668eda080fe2f0611241 Author: thang.d.nguyen Date:

[devel] [PATCH 0/1] Review Request for smf: retry if ccb is aborted at init proc [#3061] V1

2019-07-22 Thread thang.d.nguyen
servicesn Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): - revision 09e812e3f97300b368526a85fd9285ecf9cc8adf Author: thang.d.ng

[devel] [PATCH 1/1] smf: retry if ccb is aborted at init proc [#3061]

2019-07-22 Thread thang.d.nguyen
Retry if ccb is aborted at init proc. Retry when the model modification will return TRY_AGAIN or NOT_EXIST. --- src/smf/smfd/SmfUpgradeAction.cc | 73 +++- src/smf/smfd/SmfUpgradeStep.cc | 2 +- 2 files changed, 66 insertions(+), 9 deletions(-) diff --git a/

[devel] [PATCH 0/1] Review Request for amf: not set sg stable if si_dep_state of si in FAILOVER_UNDER_PROGRESS [#3054] V2

2019-08-02 Thread thang.d.nguyen
8a0b9e84b8 Author: thang.d.nguyen Date: Fri, 2 Aug 2019 15:13:39 +0700 amf: not set sg stable if si_dep_state of si in FAILOVER_UNDER_PROGRESS [#3054] With SI dependency, when failover happen the failover is processed on SU had sponsor SI first. It also update the si_dep_state of depen

[devel] [PATCH 1/1] amf: not set sg stable if si_dep_state of si in FAILOVER_UNDER_PROGRESS [#3054]

2019-08-02 Thread thang.d.nguyen
With SI dependency, when failover happen the failover is processed on SU had sponsor SI first. It also update the si_dep_state of dependent SI to FAILOVER_UNDER_PROGRESS. Then failover is processed on SU had dependent SI. But failover is deferred as sponsors role failover is under going. Amfd crash

[devel] [PATCH 0/1] Review Request for smf: retry if ccb is aborted at init proc [#3061] V2

2019-08-12 Thread thang.d.nguyen
servicesn Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): - revision 60bd4bbc774bff2a5ab500cf4230e24cc107f7bc Author: thang.d.ng

[devel] [PATCH 1/1] smf: retry if ccb is aborted at init proc [#3061]

2019-08-12 Thread thang.d.nguyen
Retry if ccb is aborted at init proc. Retry when imm init action returned TRY_AGAIN or NOT_EXIST. --- src/smf/smfd/SmfUpgradeAction.cc | 85 ++-- src/smf/smfd/SmfUpgradeStep.cc | 2 +- 2 files changed, 71 insertions(+), 16 deletions(-) diff --git a/src/smf/smfd/SmfU

[devel] [PATCH 1/1] smf: improve ccb handler rules for recovery [#3071]

2019-08-26 Thread thang.d.nguyen
Retryin ccb handler when ccb aborted to sync. --- src/smf/smfd/SmfUpgradeAction.cc | 83 +--- src/smf/smfd/SmfUpgradeStep.cc | 77 -- src/smf/smfd/imm_modify_config/immccb.cc | 32 +++-- 3 files changed, 57 insertions(+), 135 deletions(

[devel] [PATCH 0/1] Review Request for smf: improve ccb handler rules for recovery [#3071]

2019-08-26 Thread thang.d.nguyen
servicesn Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): - revision afd0deb989b9e276a91a34910e626fef2688ee9c Author: thang.d.nguyen D

[devel] [PATCH 0/1] Review Request for amfd: accept NOT_EXIST errror during standby controller come up [#3082]

2019-09-12 Thread thang.d.nguyen
210 Author: thang.d.nguyen Date: Fri, 13 Sep 2019 11:34:57 +0700 amfd: accept NOT_EXIST errror during standby controller come up [#3082] During the standby controller come up, amfd is busy and take a lot of time to create data base from IMM. And at the time, some AMF objects deleted from active

[devel] [PATCH 1/1] amfd: accept NOT_EXIST errror during standby controller come up [#3082]

2019-09-12 Thread thang.d.nguyen
During the standby controller come up, amfd is busy and take a lot of time to create data base from IMM. And at the time, some AMF objects deleted from active controller. In consequence, the amfd on stanby will be rebooted due to objects NOT_EXIST error. --- src/amf/amfd/app.cc| 24 ++

[devel] [PATCH 1/1] amfd: correct handling complete/apply callback on standby sc [#3082]

2019-09-15 Thread thang.d.nguyen
During stanby SC comes up, AMF config objects are deleted on active SC. It causes NOT_EXIST error on standby node. AMFD on standby should ignore this error in this case. --- src/amf/amfd/app.cc| 29 - src/amf/amfd/comp.cc | 18 +++--- src/amf/a

[devel] [PATCH 0/1] Review Request for amfd: correct handling complete/apply callback on standby sc [#3082]

2019-09-15 Thread thang.d.nguyen
4598b638ee Author: thang.d.nguyen Date: Mon, 16 Sep 2019 13:18:23 +0700 amfd: correct handling complete/apply callback on standby sc [#3082] During stanby SC comes up, AMF config objects are deleted on active SC. It causes NOT_EXIST error on standby node. AMFD on standby should ignore this error in

[devel] [PATCH 1/1] amfd: not accept lock-in admin op if presence msg not processed [#3121]

2019-11-24 Thread thang.d.nguyen
AMFD should not accept lock-in admin op on SU if the presence msg has already sent to that SU. --- src/amf/amfd/sgproc.cc | 1 + src/amf/amfd/su.cc | 13 + src/amf/amfd/su.h | 2 ++ 3 files changed, 16 insertions(+) diff --git a/src/amf/amfd/sgproc.cc b/src/amf/amfd/sgproc.

[devel] [PATCH 0/1] Review Request for amfd: not accept lock-in admin op if presence msg not processed [#3121]

2019-11-24 Thread thang.d.nguyen
6ea Author: thang.d.nguyen Date: Mon, 25 Nov 2019 12:03:43 +0700 amfd: not accept lock-in admin op if presence msg not processed [#3121] AMFD should not accept lock-in admin op on SU if the presence msg has already sent to that SU. Complete diffstat: -- src/amf/amfd/sgpr

[devel] [PATCH 1/1] amfd: not accept lock-in if su is reparing [#3121]

2019-12-01 Thread thang.d.nguyen
AMFD should not accept lock-in admin op on SU if the SU is repairing. --- src/amf/amfd/chkop.cc | 9 + src/amf/amfd/ckpt.h | 3 ++- src/amf/amfd/ckpt_dec.cc | 42 +-- src/amf/amfd/ckpt_enc.cc | 30 +++- src/amf/amfd/

[devel] [PATCH 0/1] Review Request for amfd: not accept lock-in if su is reparing [#3121]

2019-12-01 Thread thang.d.nguyen
servicesn Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): - revision cda2e505cb7a018a70cb9179a0b9eed5de9ee1a4 Author: thang.d.nguyen D

[devel] [PATCH 1/1] amfd: one adm op activa on SU at a time [#3132]

2019-12-24 Thread thang.d.nguyen
Not allow admin op on SU if other is activating. --- src/amf/amfd/su.cc | 26 +- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/src/amf/amfd/su.cc b/src/amf/amfd/su.cc index e1da8f726..6223cd9e4 100644 --- a/src/amf/amfd/su.cc +++ b/src/amf/amfd/su.cc @@ -13

[devel] [PATCH 0/1] Review Request for amfd: one adm op activa on SU at a time [#3132]

2019-12-24 Thread thang.d.nguyen
revision d6682ea8b806b95b1c35617536b13b6a9f98fa2d Author: thang.d.nguyen Date: Wed, 25 Dec 2019 09:03:43 +0700 amfd: one adm op activa on SU at a time [#3132] Not allow admin op on SU if other is activating. Complete diffstat: -- src/amf/amfd/su.cc | 26 +- 1 file changed, 17

[devel] [PATCH 0/1] Review Request for amfnd: reset restart flag in failover context [#3135]

2019-12-29 Thread thang.d.nguyen
revision a8498cee22c643260b8505c913e93ffb0176d78e Author: thang.d.nguyen Date: Mon, 30 Dec 2019 08:45:07 +0700 amfnd: reset restart flag in failover context [#3135] When SU reStart is escalated to component failoverReset the restart flag need resetting. Complete diffstat: -- src/amf/amfnd/e

[devel] [PATCH 1/1] amfnd: reset restart flag in failover context [#3135]

2019-12-29 Thread thang.d.nguyen
When SU reStart is escalated to component failoverReset the restart flag need resetting. --- src/amf/amfnd/err.cc | 4 +++- src/amf/amfnd/susm.cc | 3 ++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/amf/amfnd/err.cc b/src/amf/amfnd/err.cc index db3baabc7..65cc3a5c3 100644 -

[devel] [PATCH 1/1] amfd: not allow unlock if su is under restarting [#3132]

2019-12-29 Thread thang.d.nguyen
Not allow unlock if su is under restarting. --- src/amf/amfd/su.cc | 9 + 1 file changed, 9 insertions(+) diff --git a/src/amf/amfd/su.cc b/src/amf/amfd/su.cc index e1da8f726..82e2b457f 100644 --- a/src/amf/amfd/su.cc +++ b/src/amf/amfd/su.cc @@ -1337,6 +1337,15 @@ static void su_admin_op

[devel] [PATCH 0/1] Review Request for amfd: not allow unlock if su is under restarting [#3132] V2

2019-12-29 Thread thang.d.nguyen
revision 7be474c47b904a023e08b3e50ec1e29d2cf44f7d Author: thang.d.nguyen Date: Mon, 30 Dec 2019 13:47:52 +0700 amfd: not allow unlock if su is under restarting [#3132] Not allow unlock if su is under restarting. Complete diffstat: -- src/amf/amfd/su.cc | 9 + 1 file changed, 9

[devel] [PATCH 1/1] amfd: not allow unlock/lock if su is under restarting [#3132]

2020-01-01 Thread thang.d.nguyen
Not allow unlock/lock if su is under restarting. --- src/amf/amfd/su.cc | 9 + 1 file changed, 9 insertions(+) diff --git a/src/amf/amfd/su.cc b/src/amf/amfd/su.cc index e1da8f726..5a6c69c33 100644 --- a/src/amf/amfd/su.cc +++ b/src/amf/amfd/su.cc @@ -1479,6 +1479,15 @@ static void su_adm

[devel] [PATCH 0/1] Review Request for amfd: not allow unlock/lock if su is under restarting V3 [#3132]

2020-01-01 Thread thang.d.nguyen
revision da8436ae6f043d50d41e54095a6553fb2c99308c Author: thang.d.nguyen Date: Thu, 2 Jan 2020 09:37:06 +0700 amfd: not allow unlock/lock if su is under restarting [#3132] Not allow unlock/lock if su is under restarting. Complete diffstat: -- src/amf/amfd/su.cc | 9 + 1 file

[devel] [PATCH 0/1] Review Request for imm: imm_adm tool accepts NOT_EXIST [#3141]

2020-01-14 Thread thang.d.nguyen
revision 82b3eb9f807abf42baccfef9c8df60bc2abaaf9f Author: thang.d.nguyen Date: Wed, 15 Jan 2020 12:00:03 +0700 imm: imm_adm tool accepts NOT_EXIST [#3141] In case 2 adm ops invoked on the same object with the same adm owner name. These adm op used imm_adm tool. Adm op 1 is interuptted. IMM will delete adm owne name when hard f

[devel] [PATCH 1/1] imm: imm_adm tool accepts NOT_EXIST [#3141]

2020-01-14 Thread thang.d.nguyen
In case 2 adm ops invoked on the same object with the same adm owner name. These adm op used imm_adm tool. Adm op 1 is interuptted. IMM will delete adm owne name when hard finalize of adm op 1. Then adm op 2 done, imm_adm tool needs accept err NOT_EXIST when release admin owner release. --- src/im

[devel] [PATCH 0/1] Review Request for rde: correct promote node to active [#3108]

2020-02-03 Thread thang.d.nguyen
b41631b917 Author: thang.d.nguyen Date: Tue, 4 Feb 2020 09:00:18 +0700 rde: correct to promote node to active [#3108] If relaxed node promotion is enabled, allow this node to be promoted active if it can see a peer SC and this node has the lowest node ID. Complete diffstat: -- sr

[devel] [PATCH 1/1] rde: correct to promote node to active [#3108]

2020-02-03 Thread thang.d.nguyen
If relaxed node promotion is enabled, allow this node to be promoted active if it can see a peer SC and this node has the lowest node ID. --- src/rde/rded/role.cc | 14 +- src/rde/rded/role.h | 1 + 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/src/rde/rded/role.cc b

[devel] [PATCH 1/1] amfnd: trigger SU FSM [#3152]

2020-02-13 Thread thang.d.nguyen
With SU contains more 2 components. During start up, if component_1 is instanted and component_2 is in instantiating. Restart adm op is invoked on component_1. Then component_2 is instantiated following by component_1 re-instantiated. The SU will be stuc in INSTANTIATING presence state. --- src/am

[devel] [PATCH 0/1] Review Request for amfnd: trigger SU FSM [#3152]

2020-02-13 Thread thang.d.nguyen
3a2 Author: thang.d.nguyen Date: Fri, 14 Feb 2020 11:06:14 +0700 amfnd: trigger SU FSM [#3152] With SU contains more 2 components. During start up, if component_1 is instanted and component_2 is in instantiating. Restart adm op is invoked on component_1. Then component_2 is instantiated fo

[devel] [PATCH 0/1] Review Request for amfnd: trigger SU FSM [#3152] V2

2020-02-14 Thread thang.d.nguyen
a09 Author: thang.d.nguyen Date: Fri, 14 Feb 2020 16:17:08 +0700 amfnd: trigger SU FSM [#3152] With SU contains more 2 components. During start up, if component_1 is instanted and component_2 is in instantiating. Restart adm op is invoked on component_1. Then component_2 is instantiated fo

[devel] [PATCH 1/1] amfnd: trigger SU FSM [#3152]

2020-02-14 Thread thang.d.nguyen
With SU contains more 2 components. During start up, if component_1 is instanted and component_2 is in instantiating. Restart adm op is invoked on component_1. Then component_2 is instantiated following by component_1 re-instantiated. The SU will be stuc in INSTANTIATING presence state. --- src/am

[devel] [PATCH 1/1] amfnd: handle comp instantiate event with SU in terminating presence state [#3160]

2020-02-26 Thread thang.d.nguyen
- When component is instantiated with SU in terminating presence state, need trigger SU fsm with instantiate event if all components are either uninstantiated or instantiated. - Need informing error recovery when amfnd fails to send callback parameters to component when component already exited. --

[devel] [PATCH 0/1] Review Request for amfnd: handle comp instantiate event with SU in terminating presence state [#3160]

2020-02-26 Thread thang.d.nguyen
uot; above): - revision 0c65622a56f0b3dc10690707e4024eede9c00221 Author: thang.d.nguyen Date: Thu, 27 Feb 2020 12:43:01 +0700 amfnd: handle comp instantiate event with SU in terminating presence state [#3160] - When component is instantiated with SU in terminating presence state, need trigger S

[devel] [PATCH 0/1] Review Request for amfnd: handle comp instantiate event with SU in terminating presence state [#3160] V2

2020-03-01 Thread thang.d.nguyen
uot; above): - revision 67576391cb01774348931f7f75f4a424fd151de9 Author: thang.d.nguyen Date: Mon, 2 Mar 2020 14:37:20 +0700 amfnd: handle comp instantiate event with SU in terminating presence state [#3160] - When component is instantiated with SU in terminating presence state, need trigger S

[devel] [PATCH 1/1] amfnd: handle comp instantiate event with SU in terminating presence state [#3160]

2020-03-01 Thread thang.d.nguyen
- When component is instantiated with SU in terminating presence state, need trigger SU fsm with instantiate event. - Need informing error recovery when amfnd fails to send callback parameters to component when component already exited. --- src/amf/amfnd/comp.cc | 23 ++- src/a

[devel] [PATCH 1/1] amfnd: reset component register once it is terminated [#3160]

2020-03-03 Thread thang.d.nguyen
Reset component register once it is terminated to avoid process instantiate event in late. --- src/amf/amfnd/err.cc | 4 1 file changed, 4 insertions(+) diff --git a/src/amf/amfnd/err.cc b/src/amf/amfnd/err.cc index 65cc3a5c3..3c612b65a 100644 --- a/src/amf/amfnd/err.cc +++ b/src/amf/amfnd/e

[devel] [PATCH 0/1] Review Request for amfnd: reset component register once it is terminated [#3160] V3

2020-03-03 Thread thang.d.nguyen
revision 3bc1021f6516d5180f69f1095a2584303c808f87 Author: thang.d.nguyen Date: Wed, 4 Mar 2020 08:44:34 +0700 amfnd: reset component register once it is terminated [#3160] Reset component register once it is terminated to avoid process instantiate event in late. Complete diffstat: -- src

[devel] [PATCH 0/1] Review Request for fm: ignore unexpected event on standby node [#3017]

2020-03-05 Thread thang.d.nguyen
revision a7d8df9097113b363138ff85479f95d1d837feb1 Author: thang.d.nguyen Date: Thu, 5 Mar 2020 14:21:48 +0700 fm: ignore unexpected event on standby node [#3017] In roaming sc, when the standby SC down, the new standby is selected. But the amfd on the old standby is stuck. And the new standby receives the amfd down ev

[devel] [PATCH 1/1] fm: ignore unexpected event on standby node [#3017]

2020-03-05 Thread thang.d.nguyen
In roaming sc, when the standby SC down, the new standby is selected. But the amfd on the old standby is stuck. And the new standby receives the amfd down event of old standby. In this case, FM should ignore events from old standby SC. --- src/fm/fmd/fm_mds.cc | 8 1 file changed, 8 inser

[devel] [PATCH 1/1] amfnd: correct update su-si assignment flag [#3176]

2020-04-08 Thread thang.d.nguyen
Update su-si assignment flag in case SU restart from error escalation. --- src/amf/amfnd/susm.cc | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/amf/amfnd/susm.cc b/src/amf/amfnd/susm.cc index 86811f1e4..0d2896e31 100644 --- a/src/amf/amfnd/susm.cc +++ b/src/amf/amfnd/susm.cc

[devel] [PATCH 0/1] Review Request for amfnd: correct update su-si assignment flag [#3176]

2020-04-08 Thread thang.d.nguyen
revision 36dbff1d976d09c03a420a75dd82eeebf2e6abb9 Author: thang.d.nguyen Date: Thu, 9 Apr 2020 07:01:01 +0700 amfnd: correct update su-si assignment flag [#3176] Update su-si assignment flag in case SU restart from error escalation. Complete diffstat: -- src/amf/amfnd/susm.cc | 11 +++ 1 file c

[devel] [PATCH 0/1] Review Request for amfnd: correct update su-si assignment flag [#3176] V2

2020-04-08 Thread thang.d.nguyen
revision 23427906edc1edda3568cb45133926ab5b140331 Author: thang.d.nguyen Date: Thu, 9 Apr 2020 08:09:04 +0700 amfnd: correct update su-si assignment flag [#3176] Su-si assigment flag only is set when amfnd receives request from amfd. In SU restart escalation, the re-assignment is handled by amfnd internally. And this flag is

[devel] [PATCH 1/1] amfnd: correct update su-si assignment flag [#3176]

2020-04-08 Thread thang.d.nguyen
Su-si assigment flag only is set when amfnd receives request from amfd. In SU restart escalation, the re-assignment is handled by amfnd internally. And this flag is not set in this situation. When SU is in assigning after SU restart due to escalation. The component failed and amfnd escalate it to c

[devel] [PATCH 1/1] amfnd: correct checking su assignement pending flag [#3176]

2020-04-14 Thread thang.d.nguyen
Su-si assigment flag only is set when amfnd receives request from amfd. In SU restart escalation, the re-assignment is handled by amfnd internally. And this flag is not set in this situation. When SU is in assigning after SU restart due to escalation. The component failed and amfnd escalate it to c

[devel] [PATCH 0/1] Review Request for amfnd: correct checking su assignement pending flag [#3176] V2

2020-04-14 Thread thang.d.nguyen
revision a041a62e8a01c7ea4fb2eccc967120e48fee3844 Author: thang.d.nguyen Date: Tue, 14 Apr 2020 20:57:02 +0700 amfnd: correct checking su assignement pending flag [#3176] Su-si assigment flag only is set when amfnd receives request from amfd. In SU restart escalation, the re-assignment is handled by amfnd internally

[devel] [PATCH 0/1] Review Request for ntf: restart ntfimcnd if it fails to get operation invoke name [#3178]

2020-04-15 Thread thang.d.nguyen
revision bf075764d5ca05d7fb9e1d549caac2ac7752161a Author: thang.d.nguyen Date: Wed, 15 Apr 2020 14:15:24 +0700 ntf: restart ntfimcnd if it fails to get operation invoke name [#3178] If ntfimcnd is restarted during ccb modify, it will initialize ccbUtilCcbData that not contain operation invoke name. T

[devel] [PATCH 1/1] ntf: restart ntfimcnd if it fails to get operation invoke name [#3178]

2020-04-15 Thread thang.d.nguyen
If ntfimcnd is restarted during ccb modify, it will initialize ccbUtilCcbData that not contain operation invoke name. This causes ntfimcnd crashed due to operation invoke name not existed. The fix is to restart ntfimcnd instead of raising the coredump. --- src/ntf/ntfimcnd/ntfimcn_imm.c | 4 ++--

[devel] [PATCH 1/1] ntf: set operation invoke name to unknown if failed to get it [#3178]

2020-04-21 Thread thang.d.nguyen
If ntfimcnd is restarted during ccb modify, the modify callback will not contain the invoke name( implementer name or admin owner name). In this case, the invoke name will be set to "unknown" and the ntfimcnd can continue with sending notification. The notification will contain only op that receiv

[devel] [PATCH 0/1] Review Request for ntf: set operation invoke name to unknown if failed to get it [#3178] V2

2020-04-21 Thread thang.d.nguyen
revision d3941269c63b116ee28309b82f8dca9af0b540ff Author: thang.d.nguyen Date: Tue, 21 Apr 2020 16:19:49 +0700 ntf: set operation invoke name to unknown if failed to get it [#3178] If ntfimcnd is restarted during ccb modify, the modify callback will not contain the invoke name( implementer name or admin

[devel] [PATCH 1/1] ntf: set operation invoke name to unknown if failed to get it [#3178]

2020-04-21 Thread thang.d.nguyen
If ntfimcnd is restarted during ccb modify, the modify callback will not contain the invoke name( implementer name or admin owner name). In this case, the invoke name will be set to "unknown" and the ntfimcnd can continue with sending notification. The notification will contain only op that receiv

[devel] [PATCH 0/1] Review Request for ntf: set operation invoke name to unknown if failed to get it [#3178] V3

2020-04-21 Thread thang.d.nguyen
revision 990b4afca938eeae9391cb77a55a8a62c2ca8c22 Author: thang.d.nguyen Date: Wed, 22 Apr 2020 10:21:16 +0700 ntf: set operation invoke name to unknown if failed to get it [#3178] If ntfimcnd is restarted during ccb modify, the modify callback will not contain the invoke name( implementer name or admin

[devel] [PATCH 0/1] Review Request for lgs: update time in queue every node is active [#3180]

2020-04-24 Thread thang.d.nguyen
revision 7c3e276778e446b9093f20434e11fb4074a282a1 Author: thang.d.nguyen Date: Fri, 24 Apr 2020 15:15:04 +0700 lgs: update time in queue every node is active [#3180] When NFS is unavailable, client try to write to log. Lgs server will put it into the queue with the time. This info will check point with stand

[devel] [PATCH 1/1] lgs: update time in queue every node is active [#3180]

2020-04-24 Thread thang.d.nguyen
When NFS is unavailable, client try to write to log. Lgs server will put it into the queue with the time. This info will check point with standby. Switch-over happens, and NFS is available again. New active will get the diffent time b/w current time and the time put into the queue. The timer on nod

[devel] [PATCH 1/1] amfnd: avoid crash during start up [#3186]

2020-05-15 Thread thang.d.nguyen
During SC starts up, the remain SC is down. At that time, amfnd try to convert clm node to amf node. Immnd will unregister with MDS in 1 second before register again. Amfnd will failed asap in initialize search clmNode. Amfnd crashes due to amf_nodeName is empty. Amfnd need to exit failure to reco

[devel] [PATCH 0/1] Review Request for amfnd: avoid crash during start up [#3186]

2020-05-15 Thread thang.d.nguyen
87e19c83d9 Author: thang.d.nguyen Date: Fri, 15 May 2020 20:04:26 +0700 amfnd: avoid crash during start up [#3186] During SC starts up, the remain SC is down. At that time, amfnd try to convert clm node to amf node. Immnd will unregister with MDS in 1 second before register again. Amfnd will fail

[devel] [PATCH 1/1] amfd: process IMM evt higher than MBCSV evt in polling [#3190]

2020-05-20 Thread thang.d.nguyen
Amfd on standby somehow busy/stuck in a while. The si object was removed and added again. Then this SI was assigned. Then amfd on standby continue working again. But it will process event from MBCSV first (e.g, saAmfSINumCurrActiveAssignments) and it will due to the SI not created in data based yet

[devel] [PATCH 0/1] Review Request for amfd: process IMM evt higher than MBCSV evt in polling [#3190]

2020-05-20 Thread thang.d.nguyen
revision 1b2b6f0406ac092696ac160dae8e9eaac12b0107 Author: thang.d.nguyen Date: Wed, 20 May 2020 14:32:07 +0700 amfd: process IMM evt higher than MBCSV evt in polling [#3190] Amfd on standby somehow busy/stuck in a while. The si object was removed and added again. Then this SI was assigned. Then amfd on standb

[devel] [PATCH 1/1] lgs: fix memory leak reeported by valgrind [#3195]

2020-06-01 Thread thang.d.nguyen
Fix definitely lost reported by valgrind. --- src/base/daemon.c | 2 -- src/log/logd/lgs_imm.cc | 8 src/log/logd/lgs_mbcsv.cc | 1 + 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/src/base/daemon.c b/src/base/daemon.c index 48a0665f2..56f5aa8ff 100644 --- a/src/

  1   2   3   >