[devel] [PATCH 1/1] smf: Increase cbk count before post the evt to client [#2882]

2018-06-25 Thread thuan.tran
Sometimes, callback agent dispatch and fail at saSmfReponse() because cbk list is empty, agent by somehow handle evt before increase cbk count. To avoid this, increase cbk count before post the evt. --- src/smf/agent/smfa_utils.c | 38 -- 1 file changed, 20 inse

[devel] [PATCH 0/1] Review Request for smf: Increase cbk count before post the evt to client [#2882]

2018-06-25 Thread thuan.tran
OpenSAF servicesn Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): - revision 84b8bcd1edc7a0aefe392efb612f0ec23f70c718 Author: thuan.

[devel] [PATCH 0/1] Review Request for amf: Recover node that disconnnect from active AMFD [#2880]

2018-06-25 Thread thuan.tran
OpenSAF servicesn Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): - revision 62f78de1ef7e84d31ba62d42f60296c0b7dbd55e Author:

[devel] [PATCH 1/1] amf: Recover node that disconnnect from active AMFD [#2880]

2018-06-25 Thread thuan.tran
There is a abnormal state that AMFND on remote node keep sending message to active AMFD but active AMFD see that node already left. The msg_id expected is not matched and the remote node keep stuck as out of control of active AMFD. In this case, active AMFD can trigger remote fencing for that node

[devel] [PATCH 1/1] amf: amfd should reset msg_id counter to avoid message ID mismatch [#2891]

2018-07-05 Thread thuan.tran
There is a case that after AMFD send reboot order due to “out of sync window”. AMFD receive CLM track callback but node is not member yet and delete node. Later AMFND MDS down will not reset msg_id counter since it cannot find node. When node reboot up, AMFD continue use current msg_id counter send

[devel] [PATCH 0/1] Review Request for amf: amfd should reset msg_id counter to avoid message ID mismatch [#2891]

2018-07-05 Thread thuan.tran
c7957e7cdb Author: thuan.tran Date: Fri, 6 Jul 2018 11:08:00 +0700 amf: amfd should reset msg_id counter to avoid message ID mismatch [#2891] There is a case that after AMFD send reboot order due to “out of sync window”. AMFD receive CLM track callback but node is not member yet and delete node. L

[devel] [PATCH 0/1] Review Request for amf: amfd should reset msg_id counter to avoid message ID mismatch v2 [#2891]

2018-07-06 Thread thuan.tran
a90b748348 Author: thuan.tran Date: Fri, 6 Jul 2018 14:55:11 +0700 amf: amfd should reset msg_id counter to avoid message ID mismatch [#2891] There is a case that after AMFD send reboot order due to “out of sync window”. AMFD receive CLM track callback but node is not member yet and delete node. L

[devel] [PATCH 1/1] amf: amfd should reset msg_id counter to avoid message ID mismatch [#2891]

2018-07-06 Thread thuan.tran
There is a case that after AMFD send reboot order due to “out of sync window”. AMFD receive CLM track callback but node is not member yet and delete node. Later AMFND MDS down will not reset msg_id counter since it cannot find node. When node reboot up, AMFD continue use current msg_id counter send

[devel] [PATCH 0/1] Review Request for amf: Recover node that disconnnect from active AMFD [#2880] V2

2018-07-08 Thread thuan.tran
OpenSAF servicesn Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): - revision e3f4cfbf736e8af3667d797160f79895b0606012 Author:

[devel] [PATCH 1/1] amf: Recover node that disconnnect from active AMFD [#2880]

2018-07-08 Thread thuan.tran
There is a abnormal state that AMFND on remote node keep sending message to active AMFD but active AMFD see that node already left. The msg_id expected is not matched and the remote node keep stuck as out of control of active AMFD. In this case, active AMFD can trigger remote fencing for that node

[devel] [PATCH 0/1] Review Request for smf: use cb_lock to sync cbk count access between threads [#2882] V2

2018-07-10 Thread thuan.tran
OpenSAF servicesn Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): - revision cc06372dd5c34f5cc28c7d0babb59e7519ed068f Author:

[devel] [PATCH 1/1] smf: use cb_lock to sync cbk count access between threads [#2882]

2018-07-10 Thread thuan.tran
Sometimes, callback agent dispatch and fail at saSmfReponse() because cbk list is empty, agent by somehow handle evt before increase cbk count. To avoid this, use cb_lock to sync cbk count acess between threads. --- src/smf/agent/smfa_mds.c | 7 ++- src/smf/agent/smfa_utils.c | 1 + 2 files

[devel] [PATCH 0/1] Review Request for amf: amfd should not delete node in CLM callback [#2891] V3

2018-07-10 Thread thuan.tran
OpenSAF servicesn Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): - revision 9f5e6caf140b28dc203f95c933e220304efb6760 Author:

[devel] [PATCH 1/1] amf: amfd should not delete node in CLM callback [#2891]

2018-07-10 Thread thuan.tran
There is a case that after AMFD send reboot order due to “out of sync window”. AMFD receive CLM track callback but node is not AMF member yet and delete node. Later AMFND MDS down will do nothing since it cannot find the node. When node reboot up, AMFD continue use old msg_id counter send to AMFND

[devel] [PATCH 0/1] Review Request for smf: use cb_lock to sync cbk count access between threads [#2882] V3

2018-07-10 Thread thuan.tran
revision 93db991854d6d1ec148152a418db36064b802b7c Author: thuan.tran Date: Wed, 11 Jul 2018 13:36:34 +0700 smf: use cb_lock to sync cbk count access between threads [#2882] Sometimes, callback agent dispatch and fail at saSmfReponse() because cbk list is empty, agent by somehow handle evt before increase cbk count. To avoid

[devel] [PATCH 1/1] smf: use cb_lock to sync cbk count access between threads [#2882]

2018-07-10 Thread thuan.tran
Sometimes, callback agent dispatch and fail at saSmfReponse() because cbk list is empty, agent by somehow handle evt before increase cbk count. To avoid this, use cb_lock to sync cbk count acess between threads. --- src/smf/agent/smfa_mds.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(

[devel] [PATCH 1/1] amf: change the way amfd handle amfnd down [#2891]

2018-07-11 Thread thuan.tran
There is a case that after AMFD send reboot order due to “out of sync window”. AMFD receive CLM track callback but node is not AMF member yet and delete node. Later AMFND MDS down will do nothing since it cannot find the node. When node reboot up, AMFD continue use old msg_id counter send to AMFND

[devel] [PATCH 0/1] Review Request for amf: change the way amfd handle amfnd down [#2891] V4

2018-07-11 Thread thuan.tran
3d214d7799 Author: thuan.tran Date: Wed, 11 Jul 2018 14:29:07 +0700 amf: change the way amfd handle amfnd down [#2891] There is a case that after AMFD send reboot order due to “out of sync window”. AMFD receive CLM track callback but node is not AMF member yet and delete node. Later AMFND MDS do

[devel] [PATCH 1/1] amf: change the way amfd handle amfnd down [#2891]

2018-07-12 Thread thuan.tran
There is a case that after AMFD send reboot order due to “out of sync window”. AMFD receive CLM track callback but node is not AMF member yet and delete node from node_id_db. Later AMFND down handler will do nothing since it cannot find the node. When node reboot up, AMFD continue use old msg_id co

[devel] [PATCH 0/1] Review Request for amf: change the way amfd handle amfnd down [#2891] V5

2018-07-12 Thread thuan.tran
579c582ca1 Author: thuan.tran Date: Thu, 12 Jul 2018 17:07:22 +0700 amf: change the way amfd handle amfnd down [#2891] There is a case that after AMFD send reboot order due to “out of sync window”. AMFD receive CLM track callback but node is not AMF member yet and delete node from node_id_db. Later

[devel] [PATCH 0/1] Review Request for smf: Increase cbk count before post the evt to client [#2882] V4

2018-07-12 Thread thuan.tran
revision da5129d214f496f40b7cddb2db9426c10f498d54 Author: thuan.tran Date: Fri, 13 Jul 2018 10:42:17 +0700 smf: Increase cbk count before post the evt to client [#2882] Sometimes, callback agent dispatch and fail at saSmfReponse() because cbk list is empty, agent by somehow handle evt before increase cbk count. To

[devel] [PATCH 1/1] smf: Increase cbk count before post the evt to client [#2882]

2018-07-12 Thread thuan.tran
Sometimes, callback agent dispatch and fail at saSmfReponse() because cbk list is empty, agent by somehow handle evt before increase cbk count. To avoid this, increase cbk count before post the evt. --- src/smf/agent/smfa_utils.c | 40 +- 1 file changed, 22 inse

[devel] [PATCH 1/1] smf: Increase cbk count before post the evt to client [#2882]

2018-07-19 Thread thuan.tran
Sometimes, callback agent dispatch and fail at saSmfReponse() because cbk list is empty, agent by somehow handle evt before increase cbk count. To avoid this, increase cbk count before post the evt. --- src/smf/agent/smfa_utils.c | 41 +- 1 file changed, 23 inse

[devel] [PATCH 0/1] Review Request for smf: Increase cbk count before post the evt to client [#2882] V5

2018-07-19 Thread thuan.tran
revision b4376d1313d9ccf269cd8edc04bfb2c513cf1543 Author: thuan.tran Date: Thu, 19 Jul 2018 17:20:56 +0700 smf: Increase cbk count before post the evt to client [#2882] Sometimes, callback agent dispatch and fail at saSmfReponse() because cbk list is empty, agent by somehow handle evt before increase cbk count. To

[devel] [PATCH 0/1] Review Request for smf: improve CcbApplyCallback() to avoid NULL access [#2927]

2018-09-17 Thread thuan.tran
revision 253c9e11a570c25a1090b38d5b7adec69e9a3b53 Author: thuan.tran Date: Mon, 17 Sep 2018 17:58:29 +0700 smf: improve CcbApplyCallback() to avoid NULL access [#2927] Current CcbApplyCallback() is not safe, may access NULL pointer cause SMFD crash and node restart. Complete diffstat: -- sr

[devel] [PATCH 1/1] smf: improve CcbApplyCallback() to avoid NULL access [#2927]

2018-09-17 Thread thuan.tran
Current CcbApplyCallback() is not safe, may access NULL pointer cause SMFD crash and node restart. --- src/smf/smfd/SmfImmApplierHdl.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/smf/smfd/SmfImmApplierHdl.cc b/src/smf/smfd/SmfImmApplierHdl.cc index 25b52eb93..cddc279

[devel] [PATCH 0/1] Review Request for smf: campaign is executing forever until cluster reset [#1353]

2018-09-25 Thread thuan.tran
THE PATCH SERIES HERE *** revision 28f3c4f070ae5dac12e75f2979f410c7d08c603d Author: thuan.tran Date: Tue, 25 Sep 2018 13:47:53 +0700 smf: campaign is executing forever until cluster reset [#1353] The function getNodeDestination() reset elapsedTime to zero cause the node reboot

[devel] [PATCH 1/1] smf: campaign is executing forever until cluster reset [#1353]

2018-09-25 Thread thuan.tran
The function getNodeDestination() reset elapsedTime to zero cause the node reboot timeout at waitForNodeDestination() never reach. If scenario that node reboot cannot come back then campaign is stuck in executing forever until cluster reset. --- src/smf/smfd/SmfUpgradeStep.cc | 1 + src/smf/smfd/

[devel] [PATCH 1/1] smf: campaign is executing forever until cluster reset [#1353]

2018-09-27 Thread thuan.tran
The function getNodeDestination() reset elapsedTime to zero cause the node reboot timeout at waitForNodeDestination() never reach. If scenario that node reboot cannot come back then campaign is stuck in executing forever until cluster reset. --- src/smf/smfd/SmfUpgradeStep.cc | 1 + src/smf/smfd/

[devel] [PATCH 0/1] Review Request for smf: campaign is executing forever until cluster reset [#1353] V2

2018-09-27 Thread thuan.tran
revision f9f84a01d0b48cc518550aded3d485c9bdda5901 Author: thuan.tran Date: Fri, 28 Sep 2018 10:17:23 +0700 smf: campaign is executing forever until cluster reset [#1353] The function getNodeDestination() reset elapsedTime to zero cause the node reboot timeout at waitForNodeDestination() never reach. If sce

[devel] [PATCH 0/1] Review Request for smf: campaign is executing forever until cluster reset [#1353] V3

2018-09-27 Thread thuan.tran
revision 961f704ec53536f8a0a730b78bd451e59bd72113 Author: thuan.tran Date: Fri, 28 Sep 2018 10:53:42 +0700 smf: campaign is executing forever until cluster reset [#1353] The function getNodeDestination() reset elapsedTime to zero cause the node reboot timeout at waitForNodeDestination() never reach. If sce

[devel] [PATCH 1/1] smf: campaign is executing forever until cluster reset [#1353]

2018-09-27 Thread thuan.tran
The function getNodeDestination() reset elapsedTime to zero cause the node reboot timeout at waitForNodeDestination() never reach. If scenario that node reboot cannot come back then campaign is stuck in executing forever until cluster reset. --- src/smf/smfd/SmfUpgradeStep.cc | 1 + src/smf/smfd/

[devel] [PATCH 1/1] smf: campaign is executing forever until cluster reset [#1353]

2018-09-28 Thread thuan.tran
The function getNodeDestination() reset elapsedTime to zero cause the node reboot timeout at waitForNodeDestination() never reach. If scenario that node reboot cannot come back then campaign is stuck in executing forever until cluster reset. --- src/smf/smfd/SmfUpgradeStep.cc | 1 + src/smf/smfd/

[devel] [PATCH 0/1] Review Request for smf: campaign is executing forever until cluster reset [#1353] V4

2018-09-28 Thread thuan.tran
revision ad644e97e9c7970939e779b64775432f1e8681a9 Author: thuan.tran Date: Fri, 28 Sep 2018 15:38:39 +0700 smf: campaign is executing forever until cluster reset [#1353] The function getNodeDestination() reset elapsedTime to zero cause the node reboot timeout at waitForNodeDestination() never reach. If sce

[devel] [PATCH 0/1] Review Request for imm: fix incorrect set isCoord for both SCs [#2933]

2018-10-01 Thread thuan.tran
revision 27ac70fc91b8a5c19767c924141a48e6f778884d Author: thuan.tran Date: Tue, 2 Oct 2018 09:29:27 +0700 imm: fix incorrect set isCoord for both SCs [#2933] When current coordinator on payload crash and both SCs are ready with SC-2 active, the current code may set both SCs isCoord true. Complete diffstat: -

[devel] [PATCH 1/1] imm: fix incorrect set isCoord for both SCs [#2933]

2018-10-01 Thread thuan.tran
When current coordinator on payload crash and both SCs are ready with SC-2 active, the current code may set both SCs isCoord true. --- src/imm/immd/immd_proc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/imm/immd/immd_proc.c b/src/imm/immd/immd_proc.c index b28506b

[devel] [PATCH 0/1] Review Request for amf: active amfd should check nodes after reinit with imm [#2949]

2018-10-30 Thread thuan.tran
revision 35ce6a8a55eb8b73eb819d95b016b3bc2b952bda Author: thuan.tran Date: Tue, 30 Oct 2018 15:47:18 +0700 amf: active amfd should check nodes after reinit with imm [#2949] Complete diffstat: -- src/amf/amfd/imm.cc | 2 ++ src/amf/amfd/node.cc | 26 ++ src/amf/a

[devel] [PATCH 1/1] amf: active amfd should check nodes after reinit with imm [#2949]

2018-10-30 Thread thuan.tran
--- src/amf/amfd/imm.cc | 2 ++ src/amf/amfd/node.cc | 26 ++ src/amf/amfd/node.h | 1 + 3 files changed, 29 insertions(+) diff --git a/src/amf/amfd/imm.cc b/src/amf/amfd/imm.cc index 82d2b13..03a91cc 100644 --- a/src/amf/amfd/imm.cc +++ b/src/amf/amfd/imm.cc @@ -41,6

[devel] [PATCH 1/1] amf: active amfd should check nodes after reinit with imm [#2949]

2018-10-31 Thread thuan.tran
--- src/amf/amfd/imm.cc | 2 + src/amf/amfd/node.cc | 114 ++- src/amf/amfd/node.h | 1 + 3 files changed, 71 insertions(+), 46 deletions(-) diff --git a/src/amf/amfd/imm.cc b/src/amf/amfd/imm.cc index 82d2b13..03a91cc 100644 --- a/src/amf/amf

[devel] [PATCH 0/1] Review Request for amf: active amfd should check nodes after reinit with imm [#2949] V2

2018-10-31 Thread thuan.tran
revision e6ebc302103ba485f6edace8083745301b4e4d15 Author: thuan.tran Date: Wed, 31 Oct 2018 13:25:31 +0700 amf: active amfd should check nodes after reinit with imm [#2949] Complete diffstat: -- src/amf/amfd/imm.cc | 2 + src/amf/amfd/nod

[devel] [PATCH 0/1] Review Request for amf: active amfd should check nodes after reinit with imm [#2949] V3

2018-10-31 Thread thuan.tran
revision 304319eeecef57854ffea2713fac82021fbe7daa Author: thuan.tran Date: Thu, 1 Nov 2018 13:07:03 +0700 amf: active amfd should check nodes after reinit with imm [#2949] - When AMFD got IMM BAD_HANDLE, it will try to finalize current OI and reinit new OI, it make some callbacks are removed without executi

[devel] [PATCH 1/1] amf: active amfd should check nodes after reinit with imm [#2949]

2018-10-31 Thread thuan.tran
- When AMFD got IMM BAD_HANDLE, it will try to finalize current OI and reinit new OI, it make some callbacks are removed without execution. Try to dispatch OI before finalize it to reinit. - After reinit OI, check node db to find out node which is not exist in IMM (in case ccb apply delete node mis

[devel] [PATCH 1/1] base: fix memleak in ncs_os_task() case NCS_OS_TASK_JOIN [#2955]

2018-11-04 Thread thuan.tran
--- src/base/os_defs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/base/os_defs.c b/src/base/os_defs.c index fbca376..da38cd7 100644 --- a/src/base/os_defs.c +++ b/src/base/os_defs.c @@ -307,9 +307,11 @@ unsigned int ncs_os_task(NCS_OS_TASK *task, NCS_OS_TASK_REQUEST request)

[devel] [PATCH 0/1] Review Request for base: fix memleak in ncs_os_task() case NCS_OS_TASK_JOIN [#2955]

2018-11-04 Thread thuan.tran
revision 38b12ef7abb180f17f2b5aaee00acd48a6256bce Author: thuan.tran Date: Mon, 5 Nov 2018 14:20:09 +0700 base: fix memleak in ncs_os_task() case NCS_OS_TASK_JOIN [#2955] Complete diffstat: -- src/base/os_defs.c | 2 ++ 1 file changed, 2 insertions(+) Testing Commands: ---

[devel] [PATCH 1/1] amf: active amfd should check nodes after reinit with imm [#2949]

2018-11-12 Thread thuan.tran
- When AMFD got IMM BAD_HANDLE, it will try to finalize current OI and reinit new OI, it make some callbacks are removed without execution. Try to dispatch OI before finalize it to reinit. - After reinit OI, check node db to find out node which is not exist in IMM (in case ccb apply delete node mis

[devel] [PATCH 0/1] Review Request for amf: active amfd should check nodes after reinit with imm [#2949] V4

2018-11-12 Thread thuan.tran
revision b977065a3257758e7b043d60174487504dfba70c Author: thuan.tran Date: Mon, 12 Nov 2018 15:17:54 +0700 amf: active amfd should check nodes after reinit with imm [#2949] - When AMFD got IMM BAD_HANDLE, it will try to finalize current OI and reinit new OI, it make some callbacks are removed without executi

[devel] [PATCH 0/1] Review Request for amf: check nodes again before handling event in failover state [#2971]

2018-11-22 Thread thuan.tran
revision 7e3f54405e47eb1eb722ae75612d981b4b8e8b48 Author: thuan.tran Date: Fri, 23 Nov 2018 08:20:46 +0700 amf: check nodes again before handling event in failover state [#2971] - Standby amfd may miss node delete apply callback by somehow. Then it will crash when handling event in failover state due to:

[devel] [PATCH 1/1] amf: check nodes again before handling event in failover state [#2971]

2018-11-22 Thread thuan.tran
- Standby amfd may miss node delete apply callback by somehow. Then it will crash when handling event in failover state due to: Assertion 'avnd->list_of_ncs_su.empty() != true' failed in function avd_node_down_mw_susi_failover(). --- src/amf/amfd/main.cc | 4 1 file changed, 4 insertions(+)

[devel] [PATCH 1/1] amf: should not run check_nodes_after_reinit_imm() out of main [#2972]

2018-11-23 Thread thuan.tran
--- src/amf/amfd/imm.cc | 4 src/amf/amfd/main.cc | 2 ++ 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/amf/amfd/imm.cc b/src/amf/amfd/imm.cc index e990288..82d2b13 100644 --- a/src/amf/amfd/imm.cc +++ b/src/amf/amfd/imm.cc @@ -41,7 +41,6 @@ #include "amf/common/amf_def

[devel] [PATCH 0/1] Review Request for amf: should not run check_nodes_after_reinit_imm() out of main [#2972]

2018-11-23 Thread thuan.tran
revision 689ebdc5ba1f1dac118eb554929940dda5c97ca6 Author: thuan.tran Date: Fri, 23 Nov 2018 17:54:24 +0700 amf: should not run check_nodes_after_reinit_imm() out of main [#2972] Complete diffstat: -- src/amf/amfd/imm.cc | 4 src/amf/amfd/main.cc | 2 ++ 2 files changed, 2 insert

[devel] [PATCH 1/1] amf: check node before handling node failover [#2971]

2018-11-23 Thread thuan.tran
- Standby amfd may miss node delete apply callback by somehow. Then it will crash when handling event in failover state due to: Assertion 'avnd->list_of_ncs_su.empty() != true' failed in function avd_node_down_mw_susi_failover(). --- src/amf/amfd/ndproc.cc | 6 ++ src/amf/amfd/node.cc | 18

[devel] [PATCH 0/1] Review Request for amf: check node before handling node failover [#2971] V2

2018-11-23 Thread thuan.tran
revision fde7e7a027cfdc2dfbde6304a748f59718dfad23 Author: thuan.tran Date: Fri, 23 Nov 2018 17:39:28 +0700 amf: check node before handling node failover [#2971] - Standby amfd may miss node delete apply callback by somehow. Then it will crash when handling event in failover state due to: Assertion 'avnd->li

[devel] [PATCH 1/1] mdstest: fix tet_svc_subscr_VDEST_11() fail with TIPC transport [#2978]

2018-11-29 Thread thuan.tran
TIPC published event received is not as order MDS service install. Service 600 got published role active before role standby even install role standby before role active. The simplest and safe solution is add sleep 1s before change vdest role to active. --- src/mds/apitest/mdstipc_api.c | 1 + 1 f

[devel] [PATCH 0/1] Review Request for mdstest: fix tet_svc_subscr_VDEST_11() fail with TIPC transport [#2978]

2018-11-29 Thread thuan.tran
-- N/A revision 2074eb468cf8d093f380e8a473f298e884f555f5 Author: thuan.tran Date: Thu, 29 Nov 2018 15:39:33 +0700 mdstest: fix tet_svc_subscr_VDEST_11() fail with TIPC transport [#2978] TIPC published event received is not as order MDS service install. Service 600 got published role active b

[devel] [PATCH 0/1] Review Request for tests: test.sh should checkout release tag of googletest for stable [#2983]

2018-12-12 Thread thuan.tran
revision 72acb5a87a653f172d656963c22c87604d7c077f Author: thuan.tran Date: Wed, 12 Dec 2018 15:08:58 +0700 tests: test.sh should checkout release tag of googletest for stable [#2983] Complete diffstat: -- test.sh | 1 + 1 file changed, 1 insertion(+) Testing Commands: -

[devel] [PATCH 1/1] tests: test.sh should checkout release tag of googletest for stable [#2983]

2018-12-12 Thread thuan.tran
--- test.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/test.sh b/test.sh index daf6293..ce90a62 100755 --- a/test.sh +++ b/test.sh @@ -37,6 +37,7 @@ if [[ ! -f "$OSAF_TEST_WORKDIR/googletest/googlemock/lib/libgmock.la" || fi cd "$OSAF_TEST_WORKDIR/googletest" +git checkou

[devel] [PATCH 1/1] amf: fix Comp stuck in RESTARTING presence state [#3011]

2019-02-24 Thread thuan.tran
During SU (many COMPs) restart recovery, if any COMP finish instantiated then crash while other COMPs are still instantiating, AMF recovery it by restarting but AMF only cleanup without re-instantiation because AMF see the COMP is not eligible for instantiation. The error COMP is stuck in RESTARTIN

[devel] [PATCH 0/1] Review Request for amf: fix Comp stuck in RESTARTING presence state [#3011]

2019-02-24 Thread thuan.tran
revision fb4e32e78372dfb7b138b6cfa4ff8f040b88391d Author: thuan.tran Date: Mon, 25 Feb 2019 09:53:38 +0700 amf: fix Comp stuck in RESTARTING presence state [#3011] During SU (many COMPs) restart recovery, if any COMP finish instantiated then crash while other COMPs are still instantiating, AMF recovery it by restarti

[devel] [PATCH 0/1] Review Request for amf: fix no active assignment even one in-service SU can be assigned [#3020]

2019-03-18 Thread thuan.tran
revision b3997ef6c84729365578c9b86762a5773cfe5c69 Author: thuan.tran Date: Mon, 18 Mar 2019 14:53:37 +0700 amf: fix no active assignment even one in-service SU can be assigned [#3020] AMFD should try assign SI active for other in-service SUs if fail to assign for current in-service SU Complet

[devel] [PATCH 1/1] amf: fix no active assignment even one in-service SU can be assigned [#3020]

2019-03-18 Thread thuan.tran
AMFD should try assign SI active for other in-service SUs if fail to assign for current in-service SU --- src/amf/amfd/sg_2n_fsm.cc | 75 +-- 1 file changed, 46 insertions(+), 29 deletions(-) diff --git a/src/amf/amfd/sg_2n_fsm.cc b/src/amf/amfd/sg_2n_f

[devel] [PATCH 0/1] Review Request for amf: fix container sample build failure [#3032]

2019-04-17 Thread thuan.tran
ERIES HERE *** revision e6cf94a9b03ab4542bb84a0172806f4f2fb86530 Author: thuan.tran Date: Thu, 18 Apr 2019 13:41:46 +0700 amf: fix container sample build failure [#3032] Complete diffstat: -- samples/amf/container/Makefile.am | 4 ++-- 1 file changed, 2 insertions(+), 2

[devel] [PATCH 1/1] amf: fix container sample build failure [#3032]

2019-04-17 Thread thuan.tran
--- samples/amf/container/Makefile.am | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/samples/amf/container/Makefile.am b/samples/amf/container/Makefile.am index 299a947..dc09721 100644 --- a/samples/amf/container/Makefile.am +++ b/samples/amf/container/Makefile.am @@ -19,

[devel] [PATCH 0/1] Review Request for mds: support multicast fragmented messages [#3033]

2019-04-23 Thread thuan.tran
uot; above): - N/A revision 9150ad3b59a86d7e74ebae6431cb5b264765d065 Author: thuan.tran Date: Wed, 24 Apr 2019 11:31:29 +0700 mds: support multicast fragmented messages [#3033] - Sender may send broadcast big messages (> 65K) then small messages (< 65K). Current MDS j

[devel] [PATCH 1/1] mds: support multicast fragmented messages [#3033]

2019-04-23 Thread thuan.tran
- Sender may send broadcast big messages (> 65K) then small messages (< 65K). Current MDS just loop via all destinations to unicast all fragmented messages to one by one destinations. But sending multicast non-fragment messages to all destinations. Therefor, receivers may get messages with incorrec

[devel] [PATCH 1/1] mds: support multicast fragmented messages [#3033]

2019-04-24 Thread thuan.tran
- Sender may send broadcast big messages (> 65K) then small messages (< 65K). Current MDS just loop via all destinations to unicast all fragmented messages to one by one destinations. But sending multicast non-fragment messages to all destinations. Therefor, receivers may get messages with incorrec

[devel] [PATCH 0/1] Review Request for mds: support multicast fragmented messages [#3033] V2

2019-04-24 Thread thuan.tran
uot; above): - N/A revision 18248abbd0235683849b62aba48396bfa18f090e Author: thuan.tran Date: Wed, 24 Apr 2019 14:50:58 +0700 mds: support multicast fragmented messages [#3033] - Sender may send broadcast big messages (> 65K) then small messages (< 65K). Current MDS j

[devel] [PATCH 1/1] mds: support multicast fragmented messages [#3033]

2019-04-24 Thread thuan.tran
- Sender may send broadcast big messages (> 65K) then small messages (< 65K). Current MDS just loop via all destinations to unicast all fragmented messages to one by one destinations. But sending multicast non-fragment messages to all destinations. Therefor, receivers may get messages with incorrec

[devel] [PATCH 0/1] Review Request for mds: support multicast fragmented messages [#3033] V3

2019-04-24 Thread thuan.tran
uot; above): - N/A revision 568f09774f936506f5e05e03813fa572af0fe0d3 Author: thuan.tran Date: Wed, 24 Apr 2019 17:54:25 +0700 mds: support multicast fragmented messages [#3033] - Sender may send broadcast big messages (> 65K) then small messages (< 65K). Current MDS j

[devel] [PATCH 0/1] Review Request for amf: fix SU get stuck in INSTANTIATING presence state [#3047]

2019-06-03 Thread thuan.tran
THE PATCH SERIES HERE *** revision 6df3282de69eab4e24db965b6082609bde7c3743 Author: thuan.tran Date: Mon, 3 Jun 2019 13:57:38 +0700 amf: fix SU get stuck in INSTANTIATING presence state [#3047] COMP restart recovery during SU restart recovery can lead to SU stuck in INSTANTIATING without furt

[devel] [PATCH 1/1] amf: fix SU get stuck in INSTANTIATING presence state [#3047]

2019-06-03 Thread thuan.tran
COMP restart recovery during SU restart recovery can lead to SU stuck in INSTANTIATING without further action. Because COMP instaniated event in RESTARTING does not trigger avnd_su_pres_fsm_run(). --- src/amf/amfnd/clc.cc | 4 src/amf/amfnd/susm.cc | 4 +++- 2 files changed, 7 insertions(+),

[devel] [PATCH 1/1] amf: fix SU get stuck in INSTANTIATING presence state [#3047]

2019-06-13 Thread thuan.tran
COMP restart recovery during SU restart recovery can lead to SU stuck in INSTANTIATING without further action. Because COMP instaniated event in RESTARTING does not trigger avnd_su_pres_fsm_run(). --- src/amf/amfnd/clc.cc | 11 ++- src/amf/amfnd/susm.cc | 4 +++- 2 files changed, 13 inse

[devel] [PATCH 0/1] Review Request for amf: fix SU get stuck in INSTANTIATING presence state [#3047] V2

2019-06-13 Thread thuan.tran
revision e2acdc147e11bf594492163af7e2ea7e5df8713a Author: thuan.tran Date: Fri, 14 Jun 2019 10:16:11 +0700 amf: fix SU get stuck in INSTANTIATING presence state [#3047] COMP restart recovery during SU restart recovery can lead to SU stuck in INSTANTIATING without further action. Because COMP instaniate

[devel] [PATCH 0/1] Review Request for mds: fix mdstest 13 12, 13 13, 6 12, 6 13, 7 12, 7 13 [#3059]

2019-07-16 Thread thuan.tran
IN/COMMENT THE PATCH SERIES HERE *** revision 626a6ae762f478f38a972832f004c58cebf33a45 Author: thuan.tran Date: Tue, 16 Jul 2019 16:38:41 +0700 mds: fix mdstest 13 12, 13 13, 6 12, 6 13, 7 12, 7 13 [#3059] - sleep(1) before changing vdest role active -> standby/quiesced Comp

[devel] [PATCH 1/1] mds: fix mdstest 13 12, 13 13, 6 12, 6 13, 7 12, 7 13 [#3059]

2019-07-16 Thread thuan.tran
- sleep(1) before changing vdest role active -> standby/quiesced --- src/mds/apitest/mdstipc_api.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/mds/apitest/mdstipc_api.c b/src/mds/apitest/mdstipc_api.c index 34dcd3b..b5547e3 100644 --- a/src/mds/apitest/mdstipc_api.c +++ b/src/mds

[devel] [PATCH 1/1] rde: missing comma between elements in array [#3069]

2019-08-14 Thread thuan.tran
--- src/rde/rded/rde_main.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/rde/rded/rde_main.cc b/src/rde/rded/rde_main.cc index 1a7e58792..6594b3d49 100644 --- a/src/rde/rded/rde_main.cc +++ b/src/rde/rded/rde_main.cc @@ -53,7 +53,7 @@ const char *rde_msg_name[] = {"-",

[devel] [PATCH 0/1] Review Request for rde: missing comma between elements in array [#3069]

2019-08-14 Thread thuan.tran
revision f9570070a9846e8a532025ef415a9f62800aa738 Author: thuan.tran Date: Wed, 14 Aug 2019 16:29:05 +0700 rde: missing comma between elements in array [#3069] Complete diffstat: -- src/rde/rded/rde_main.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Testing Commands: - N/

[devel] [PATCH 1/1] mbc: fix some coding errors [#3070]

2019-08-14 Thread thuan.tran
--- src/mbc/mbcsv_api.c | 6 +++--- src/mbc/mbcsv_peer.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mbc/mbcsv_api.c b/src/mbc/mbcsv_api.c index 84a2b8771..3a84fdfda 100644 --- a/src/mbc/mbcsv_api.c +++ b/src/mbc/mbcsv_api.c @@ -619,7 +619,7 @@ uint32_t mbcsv_proces

[devel] [PATCH 0/1] Review Request for mbc: fix some coding errors [#3070]

2019-08-14 Thread thuan.tran
b41980dacf Author: thuan.tran Date: Wed, 14 Aug 2019 17:16:17 +0700 mbc: fix some coding errors [#3070] Complete diffstat: -- src/mbc/mbcsv_api.c | 6 +++--- src/mbc/mbcsv_peer.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) Testing Commands: - N/

[devel] [PATCH 1/1] base: add serial number arithmetic (RFC1982) [#3074]

2019-08-26 Thread thuan.tran
--- src/base/Makefile.am | 6 +- src/base/sna.h | 108 src/base/tests/sna_test.cc | 109 + 3 files changed, 221 insertions(+), 2 deletions(-) create mode 100755 src/base/sna.h create mode 100755 src/base

[devel] [PATCH 0/1] Review Request for base: add serial number arithmetic (RFC1982) [#3074]

2019-08-26 Thread thuan.tran
revision 4f76a7cc3d5f895f881cb683e1f723c750d75acd Author: thuan.tran Date: Mon, 26 Aug 2019 15:27:07 +0700 base: add serial number arithmetic (RFC1982) [#3074] Added Files: src/base/sna.h src/base/tests/sna_test.cc Complete diffstat: -- src/base/Makefile.am | 6 ++- src/

[devel] [PATCH 1/1] base: add serial number arithmetic (RFC1982) [#3074]

2019-08-26 Thread thuan.tran
--- src/base/Makefile.am | 6 +- src/base/sna.h | 108 src/base/tests/sna_test.cc | 109 + 3 files changed, 221 insertions(+), 2 deletions(-) create mode 100644 src/base/sna.h create mode 100644 src/base

[devel] [PATCH 0/1] Review Request for base: add serial number arithmetic (RFC1982) [#3074]

2019-08-26 Thread thuan.tran
revision 343d46ca2c1fc4371369e58059188aeb8999aff8 Author: thuan.tran Date: Mon, 26 Aug 2019 16:22:25 +0700 base: add serial number arithmetic (RFC1982) [#3074] Added Files: src/base/sna.h src/base/tests/sna_test.cc Complete diffstat: -- src/base/Makefile.am | 6 ++- src/

[devel] [PATCH 0/1] Review Request for amfd: ignore amfnd down event if node state is absent [#3015] V3

2019-09-23 Thread thuan.tran
revision 3edf127a81b0672b4f535e7e729fdc63910848ca Author: thuan.tran Date: Mon, 23 Sep 2019 16:29:56 +0700 amfd: ignore amfnd down event if node state is absent [#3015] When the PBE hung, amfd can process the events with below order when a node was started then stop then started - clm_track_cb for node

[devel] [PATCH 1/1] amfd: ignore amfnd down event if node state is absent [#3015]

2019-09-23 Thread thuan.tran
When the PBE hung, amfd can process the events with below order when a node was started then stop then started - clm_track_cb for node down event - clm_track_cb for second node up event - avd_mds_avnd_down_evh was called to process amfnd down event And it cause the node can not join the cluster. -

[devel] [PATCH 0/1] Review Request for mds: optimize mdstest suite 27 [#3087]

2019-09-23 Thread thuan.tran
N/A revision 0abe23db468440e4b674d2f94196edc626527ac2 Author: thuan.tran Date: Mon, 23 Sep 2019 16:52:22 +0700 mds: optimize mdstest suite 27 [#3087] - Just allocate a small buffer instead of huge buffer Complete diffstat: -- src/mds/apitest/mdstipc_a

[devel] [PATCH 1/1] mds: optimize mdstest suite 27 [#3087]

2019-09-23 Thread thuan.tran
- Just allocate a small buffer instead of huge buffer --- src/mds/apitest/mdstipc_api.c | 102 +++--- 1 file changed, 45 insertions(+), 57 deletions(-) diff --git a/src/mds/apitest/mdstipc_api.c b/src/mds/apitest/mdstipc_api.c index 805728464..663d70369 100644 --- a/sr

[devel] [PATCH 1/1] mds: optimize mdstest suite 27 [#3087]

2019-09-23 Thread thuan.tran
- Just allocate a small buffer instead of huge buffer --- src/mds/apitest/mdstipc_api.c | 116 +++--- 1 file changed, 52 insertions(+), 64 deletions(-) diff --git a/src/mds/apitest/mdstipc_api.c b/src/mds/apitest/mdstipc_api.c index 805728464..33e7d6c12 100644 --- a/sr

[devel] [PATCH 0/1] Review Request for mds: optimize mdstest suite 27 [#3087] V2

2019-09-23 Thread thuan.tran
N/A revision 22991cd5be7cec3ac568ee49efb4850a9ca6ab8b Author: thuan.tran Date: Tue, 24 Sep 2019 09:45:47 +0700 mds: optimize mdstest suite 27 [#3087] - Just allocate a small buffer instead of huge buffer Complete diffstat: -- src/mds/apitest/mdstipc_a

[devel] [PATCH 0/1] Review Request for amfd: ignore amfnd down event if node state is absent [#3015] V4

2019-09-24 Thread thuan.tran
revision 4373797b6af262aaf22a6667267f27368fb7352a Author: thuan.tran Date: Tue, 24 Sep 2019 13:35:26 +0700 amfd: ignore amfnd down event if node state is absent [#3015] When the PBE hung, amfd can process the events with below order when a node was started then stop then started - clm_track_cb for node

[devel] [PATCH 1/1] amfd: ignore amfnd down event if node state is absent [#3015]

2019-09-24 Thread thuan.tran
When the PBE hung, amfd can process the events with below order when a node was started then stop then started - clm_track_cb for node down event - clm_track_cb for second node up event - avd_mds_avnd_down_evh was called to process amfnd down event And it cause the node can not join the cluster. -

[devel] [PATCH 0/1] Review Request for mds: optimize mdstest suite 27 [#3087] V3

2019-09-24 Thread thuan.tran
N/A revision ec7cb197fb600b5d18e8044053b8ed723c47987f Author: thuan.tran Date: Wed, 25 Sep 2019 10:58:11 +0700 mds: optimize mdstest suite 27 [#3087] - Just allocate a small buffer instead of huge buffer Complete diffstat: -- src/mds/apitest/mdstipc_a

[devel] [PATCH 1/1] mds: optimize mdstest suite 27 [#3087]

2019-09-24 Thread thuan.tran
- Just allocate a small buffer instead of huge buffer --- src/mds/apitest/mdstipc_api.c | 119 +++--- 1 file changed, 53 insertions(+), 66 deletions(-) diff --git a/src/mds/apitest/mdstipc_api.c b/src/mds/apitest/mdstipc_api.c index 805728464..f667d7385 100644 --- a/sr

[devel] [PATCH 1/1] mds: add more tests for mds flow control [#3091]

2019-09-27 Thread thuan.tran
mdstest for overload - 2 senders overload one receivers - one sender overloads 2 receivers mdstest for SNA (Serial Number Arithmetic) - without overload, mds sender gradually sends more than 65535 messages and receivers should receive them all - with overload, mds sender sends a burst of greater

[devel] [PATCH 0/1] Review Request for mds: add more tests for mds flow control [#3091]

2019-09-27 Thread thuan.tran
revision ad270f55a0dcde87e89a6f5ae0e4c15bf812733c Author: thuan.tran Date: Fri, 27 Sep 2019 16:13:44 +0700 mds: add more tests for mds flow control [#3091] mdstest for overload - 2 senders overload one receivers - one sender overloads 2 receivers mdstest for SNA (Serial Number Arithmetic) - without overload, mds sender gradu

[devel] [PATCH 1/1] base: add serial number arithmetic (RFC1982) [#3074]

2019-09-30 Thread thuan.tran
- Adapt MDS with this SNA implementation. --- src/base/Makefile.am | 6 +- src/base/sna.h | 123 +++ src/base/tests/sna_test.cc | 117 + src/mds/mds_tipc_fctrl_portid.cc | 39 +- src/mds/mds_tipc

[devel] [PATCH 0/1] Review Request for base: add serial number arithmetic (RFC1982) [#3074] V2

2019-09-30 Thread thuan.tran
revision 99daaadecda6174bef3c3488b46064fd36912141 Author: thuan.tran Date: Mon, 30 Sep 2019 15:20:35 +0700 base: add serial number arithmetic (RFC1982) [#3074] - Adapt MDS with this SNA implementation. Added Files: src/base/sna.h src/base/tests/sna_test.cc Complete diffstat: --

[devel] [PATCH 0/1] Review Request for mds: add more tests for mds flow control [#3091] V2

2019-09-30 Thread thuan.tran
revision 3eb74b688a9426c58a16fa557505917515e35134 Author: thuan.tran Date: Tue, 1 Oct 2019 13:37:08 +0700 mds: add more tests for mds flow control [#3091] mdstest for overload - 2 senders overload one receivers - one sender overloads 2 receivers mdstest for SNA (Serial Number Arithmetic) - without overload, mds sender gradu

[devel] [PATCH 1/1] mds: add more tests for mds flow control [#3091]

2019-09-30 Thread thuan.tran
mdstest for overload - 2 senders overload one receivers - one sender overloads 2 receivers mdstest for SNA (Serial Number Arithmetic) - without overload, mds sender gradually sends more than 65535 messages and receivers should receive them all - with overload, mds sender sends a burst of greater

[devel] [PATCH 0/1] Review Request for mds: add more tests for mds flow control [#3091] V3

2019-10-10 Thread thuan.tran
revision 94ea409e087bd4fc8ab2d242c39c06c8e3e06250 Author: thuan.tran Date: Fri, 11 Oct 2019 09:39:07 +0700 mds: add more tests for mds flow control [#3091] mdstest for overload - 2 senders overload one receivers - one sender overloads 2 receivers mdstest for SNA (Serial Number Arithmetic) - without overload, mds sender gradu

[devel] [PATCH 1/1] mds: add more tests for mds flow control [#3091]

2019-10-10 Thread thuan.tran
mdstest for overload - 2 senders overload one receivers - one sender overloads 2 receivers mdstest for SNA (Serial Number Arithmetic) - without overload, mds sender gradually sends more than 65535 messages and receivers should receive them all - with overload, mds sender sends a burst of greater

  1   2   3   4   >