Dear All,
As you all know, yesterday was my last day of Active Participation in
OpenSAF project.
The day, I joined `The OpenSAF Community; an open source project was new
to me,
but the OpenSAF Community Openness allowed me to discuss freely and
participate in technical discussions
and the
Hi Vijay,
ACK.
This is better than previous patch by doing recycle of time wait , but
this is not final solution,
so you write an enhancement ticket to fix the issue with a solution like ,
smf (imm application) may get callback or notified by
IMM/some-other-way after completing sync
On 8/18/2017 8:43 AM, A V Mahesh wrote:
Hi Vijay Roy ,
If i have larger imm db to sync , you will end up with same problem
again.
One more point , if I have multiple node in queue waiting for sync
, again you will end up with same problem .
-AVM
On 8/17/2017 5:34 PM, Vijay Roy wrote
ACK, Not tested.
-AVM
On 8/17/2017 6:33 PM, Zoran Milinkovic wrote:
In #2491, the log message if logged always with error log level.
If a cluster goes headless, this case is very likely to be happen
with ERR_TRY_AGAIN, but that's expected behavior when the cluster
goes headless.
---
Hi Vijay Roy ,
If i have larger imm db to sync , you will end up with same problem again.
-AVM
On 8/17/2017 5:34 PM, Vijay Roy wrote:
---
src/smf/smfd/SmfUpgradeStep.cc | 31 +++
1 file changed, 27 insertions(+), 4 deletions(-)
diff --git
Hi Anders Widell,
ACK, over all changes looks good .
Patch can be pushed now , if we found any issues on top of this patch
can be addressable later .
-AVM
On 8/16/2017 3:49 PM, Anders Widell wrote:
Re-factor the inter-node poll loop by replacing the 100 entry fixed size poll
vector with
Time = 60
2017-08-15 10:41:20.570 PL-4 opensaf_reboot: Rebooting local node;
timeout=60
On 08/16/2017 10:11 AM, A V Mahesh wrote:
Hi Anders,
Can you share the logs .
-AVM
On 8/16/2017 1:33 PM, Anders Widell wrote:
The problem seems to happen with a low probability when I reboot a
nod
Hi Zoran ,
ACK , not tested.
-AVM
On 8/14/2017 6:08 PM, Zoran Milinkovic wrote:
In verifyClassPBE(), the patch makes distinguish between IMM issue and database
corruption.
For IMM issue, PBE will not be regenerated, while for database corruption, PBE
will be regenerated.
---
nly one
configuration option and enable this new continuous broadcast mode by
setting that option to zero as you suggest, we would need to hard-code
the length of the initial phase (to five seconds?) as well as the
interval between broadcasts (30 seconds?) after the initial phase.
Since
we anyhow inten
Hi Zoran,
ACK, not tested.
-AVM
On 8/7/2017 8:33 PM, Zoran Milinkovic wrote:
CLM selection object is initially set to -1. Included CLM selection
object in poll will be ignored until CLM selection object is created
and set to fds[FD_CLM].
---
src/imm/immnd/immnd_main.c | 4 +---
1 file
Hi Zoran ,
ACK , with following , not tested.
Please check that the `immnd_cb->clm_hdl` cleared on Headless case.
-AVM
On 8/9/2017 5:14 PM, Zoran Milinkovic wrote:
Initially CLM handle is set to 0. When CLM handle is initialized,
it can be initialized again only when saClmDispatch returns
Hi Alex Jones,
I don't think you required an additional configuration (CONT_BCAST_INT)
for continuing dtm discovery,
you can utilize the DTM_INI_DIS_TIMEOUT_SECS=5 (
dtm_discovery_timeout_secs ), it self like :
Just by adding additional comment saying :
"# Comment the next line
Hi Ale,
ACK, with following ( not tested).
Please take care of alignment.
-AVM
On 8/9/2017 8:14 PM, Alex Jones wrote:
return failure when unable to add new node
---
src/dtm/dtmnd/dtm_node.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git
Hi Canh Van,
ACK, with Same comment as Lennart:
Change `SaAisErrorT om_rc` similar in `static void
read_logsv_config_obj_2()` ,
as you already did in `static SaAisErrorT
amf_quiescing_state_handler()` in this patch it self.
Hi Alex ,
ACK, Not tested.
-AVM
On 8/9/2017 12:02 AM, Alex Jones wrote:
==27393== Thread 4:
==27393== Conditional jump or move depends on uninitialised value(s)
==27393==at 0x4C2F336: __memcmp_sse4_1 (in
/usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==27393==by 0x4E64ADF:
Hi Alex,
You removed osafassert(0); and event `rc` is not updated to
NCSCC_RC_FAILURE; why you what proceed for when node_id=0.
node->node_id can be zero because of other factors, please check.
-AVM
On 8/8/2017 11:42 PM, Alex Jones wrote:
Sep 13 14:00:52 SC-2 local0.err osafdtmd[378]:
Hi Vu,
ACK.
-AVM
On 8/8/2017 3:01 PM, Vu Minh Nguyen wrote:
Log application got coredump due to failed assertion in Log agent.
The problem was caused by referring to uninitialized variable `bool updated`.
Previously, `updated` variable was initialized when the method
Hi Anders & praveen,
On 8/7/2017 1:35 PM, Anders Widell wrote:
A node can have more than one single network address. If you run the
ifconfig command, you get a list of network interfaces. Each one of
these interfaces can have several address assigned to it: IPv4
addresses, IPv6 addresses, and
Hi Anders,
ACK not tested.
-AVM
On 7/28/2017 1:45 PM, Anders Widell wrote:
The osaf_get_boot_time function returns the time stamp when the node was booted.
The osaf_timespec_average function returns the average of two time stamps.
---
src/base/Makefile.am | 12 ++-
Hi Anders Widell ,
I will review and ACK by EOD.
-AVM
On 8/3/2017 2:08 PM, Anders Widell wrote:
Hi Mahesh!
I intend to push this tomorrow unless there are any comments.
thanks,
Anders Widell
On 07/28/2017 10:15 AM, Anders Widell wrote:
Summary: base: Add osaf_get_boot_time and
Hi Vu,
ACK , Not tested.
-AVM
On 7/25/2017 1:39 PM, Vu Minh Nguyen wrote:
Fix coredump generated by referencing to un-initialized pointer `o_msg`
in LogAgent::saLogInitialize().
---
src/log/agent/lga_agent.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Hi Canh ,
ACK , Not tested.
-AVM
On 7/12/2017 1:40 PM, Canh Van Truong wrote:
Currently, log support maximum 2047 characters for long DN. it should support
maximum 2048 characters.
The patch also fixes to check SA_AMF_COMPONENT_NAME maximum 2048 characters
and refactor encode and decode for
Hi Zoran,
ACK, Not tested.
Sorry for the delay I was out of office.
-AVM
On 7/12/2017 5:37 PM, Zoran Milinkovic wrote:
PBE will be regenerated on SQL constraint error code.
---
src/imm/common/immpbe_dump.cc | 17 +
1 file changed, 17 insertions(+)
diff --git
Hi Hans N,
ACK, Not tested.
-AVM
On 7/4/2017 7:53 PM, Hans Nordeback wrote:
---
src/nid/nodeinit.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/nid/nodeinit.cc b/src/nid/nodeinit.cc
index 2f9c785cc..9eddd743d 100644
--- a/src/nid/nodeinit.cc
+++
that, you will not be able to set a new implementer with the same name.
BR,
Zoran
-Original Message-
From: A V Mahesh [mailto:mahesh.va...@oracle.com]
Sent: den 29 juni 2017 05:39
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Cc: opensaf-devel@lists.sourceforge.net
Subje
Hi Zoran,
How you are able to catch this bug ?
Jut by manually seeing IMMND run-time size growing , while running
threaded application !
-AVM
On 6/28/2017 7:32 PM, Zoran Milinkovic wrote:
Send IMM_FINALIZE message to immnd when dispatch functions returns
ERR_BAD_HANDLE.
IMM_FINALIZE will
Hi Anders,
ACK, not tested ( need to setup GCC 7.1.1).
-AVM
On 6/20/2017 2:27 PM, Anders Widell wrote:
Fix build problems caused by the following warnings:
* -Werror=format-overflow=
* -Werror=parentheses
* -Werror=unused-variable
---
src/amf/amfd/imm.cc|
yet exist.
Thanks
Gary
-Original Message-
From: A V Mahesh <mahesh.va...@oracle.com>
Organization: Oracle Corporation
Date: Thursday, 22 June 2017 at 12:32 pm
To: gary <gary@dektech.com.au>
Cc: praveen malviya <praveen.malv...@oracle.com>, <hans.nordeb...@ericsson
can
initiated admin op earlier than the IMM object sync
why because AMF messages are having higher priority (MDS).
Can you please explore option of both object create & admin operation
can occur on same AMFND node ( not ‘forwarding’ )
-AVM
Thanks
Gary
On 21/6/17, 5:14 pm, "A
Hi Pravee/Gary,
On 6/21/2017 12:13 PM, praveen malviya wrote:
Hi Gary,
Is there any ticket in IMM for any related issue?
Both creation of SU and admin operation on it will go through IMM only.
I do not know how IMM handles it and how IMM spec talks about it.
[AVM] Even we have problem of
Hi Hung Nguyen,
Ok, ACK from me.
-AVM
On 6/15/2017 12:03 PM, Hung Nguyen wrote:
Hi Mahesh,
Stale clients are clients that are not discarded (yet) due to problem with
sending messages to IMMD.
In case of headless, we don't care about IMMD, we just want to get grid of all
clients locally,
Hi Hung,
Thanks for the explaining , still didn't get the advantage of unset the
mIsStale flag for headless case,
can you please clarify below taged with [AVM]
On 6/15/2017 10:03 AM, Hung Nguyen wrote:
Hi Mahesh,
In imma_discard_connection(), we mark the client as stale when having problem
Hi Hung,
Jut trying to syncup the ligic of unsets the mIsStale flag of the
clients before immnd do invoking immnd_proc_imma_discard_connection() ,
immnd in multiple other cases also invoking
immnd_proc_imma_discard_connection() for exaple immnd_proc_imma_down()
as well, in addition to
not 0 (FALSE), and IF block will be executed.
I don't see problem here.
Thanks,
Zoran
-Original Message-----
From: A V Mahesh [mailto:mahesh.va...@oracle.com]
Sent: den 14 juni 2017 12:13
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Cc: opensaf-devel@lists.sourceforge.net
Subject:
Hi Zora,
ACK form me.
Note : osaf_timespec_compare() will also returns -1 , please cross
check once the logic
at very fist if() condition of void ImmModel::getOldCriticalCcbs() looks
OK to me .
-AVM
On 6/14/2017 3:03 PM, Zoran Milinkovic wrote:
The patch fix counting timeouts for old
Hi Canh Van,
ACK , form me.
Sorry for the delay, I was out of office last week
-AVM
On 5/24/2017 5:29 PM, Canh Van Truong wrote:
When log agent recover the client, it uses the highest version that log agent
supported to re-intialize client.
It should use the client version to re-initialize
Hi Hung Nguyen,
Ok , ACK from me.
-AVM
On 6/7/2017 10:19 AM, Hung Nguyen wrote:
Hi Mahesh,
Because the longDn testsuite use the same implementer for the testcases and the
other testsuites don't.
So we don't have this problem in other testsuites.
BR,
Hung Nguyen - DEK Technologies
Hi Hung Nguyen,
ACK with following :
The saImmOiFinalize() function does not release the objects and the
implementer name that will still be associated with the immOiHandle,
that is why we now Explicitly called saImmOiImplementerClear(), if that
is the case why only long DN testcases ?
ing the sync, IMM DB is locked. Veteran nodes are read-only (R_AVAILABLE
state), and syncing nodes are write-only (W_AVAILABLE state).
While veteran nodes are in R_AVAILABLE state, they only check their data with
syncing data, but do not update any data.
BR,
Zoran
-Original Message--
that vector on each sync object, and reexecuting
discard node is not possible when sync is done.
The same is for dead implementers and admin owners.
Thanks,
Zoran
-Original Message-
From: A V Mahesh [mailto:mahesh.va...@oracle.com]
Sent: den 5 juni 2017 07:13
To: Zoran Milinkovic
Hi Zoran,
On 6/2/2017 8:45 PM, Zoran Milinkovic wrote:
After removing the clearing of dead implementer, node and admin owner vectors,
re-executing on vectors will be done after the node is fully synced.
Just Trying to understand the problem more , I understand problem as
follows please
uot; above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision 9fc4e0c96a82b5670408747b06d38a22c0f967fd
Author: A V Mahesh <mahesh.va...@oracle.com>
Date: Thu, 1 Jun 2017 14:22:30 +0530
mds: clear mds lib valgrind warning [#2474]
Fixed MDS valgrind-3.12.0 report
C
Hi Hung Nguyen,
On 5/17/2017 1:10 PM, Hung Nguyen wrote:
> + /* Discard Adm Impl continuation */
> + for (ci3 = sAdmImplContinuationMap.begin();
> + ci3 != sAdmImplContinuationMap.end();) {
If possible convert iterator ci3 to auto.
-AVM
On 5/17/2017 1:10 PM, Hung Nguyen wrote:
> Discard
Hi Canh Van,
ACK, not tested.
-AVM
On 5/8/2017 1:08 PM, Canh Van Truong wrote:
> Re-write again in case test cases receive write ack with TRY AGAIN
> error
> ---
> src/log/apitest/tet_saLogStreamOpen_2.c | 1 -
> src/log/apitest/tet_saLogWriteLogCallbackT.c | 49
>
issue : logd is crashing becuse unlocking a mutex twice with out lock
fix :corrected lgs_ftcom_mutexmutex lock and unlock sequence
---
src/log/logd/lgs_filehdl.cc | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/log/logd/lgs_filehdl.cc b/src/log/logd/lgs_filehdl.cc
THE PATCH SERIES HERE ***
revision ea3ba1360df02fe44e3b472daed5beebfcbb8d65
Author: A V Mahesh <mahesh.va...@oracle.com>
Date: Thu, 11 May 2017 10:28:36 +0530
log: correct mutex lock and unlock sequence in logd [#2452]
issue : logd is crashing becuse unlocking a mutex twice with out loc
;no active" check in
> the agent.
> Note: This will only work if there is a "graceful" role change meaning that
> the server leaving its active role is still working.
[AVM] why we want give different reply to Agent graceful (TRY AGAIN) &
no-graceful (TIMEOUT)
Hi Canh Van,
Please check my comments as [AVM].
-AVM
On 5/10/2017 12:06 PM, Canh Van Truong wrote:
>
> Hi Mahesh,
>
> Thanks for your update.
>
> Please check my comments.
>
> Regards
>
> Canh
>
> -----Original Message-
> From: A V Mahesh [mailto:mah
Hi Canh Van,
The update one:
On 5/5/2017 6:37 PM, Canh Van Truong wrote:
> During testing, e.g: use saflogger in loop to send a log record to log service
> during failover, we frequently encounter saLogStreamClose() or saLogFinalize()
> get SA_AIS_ERR_TIMEOUT as active LOG service is shutdown
Hi Canh Van,
On 5/5/2017 6:37 PM, Canh Van Truong wrote:
> During testing, e.g: use saflogger in loop to send a log record to log service
> during failover, we frequently encounter saLogStreamClose() or saLogFinalize()
> get SA_AIS_ERR_TIMEOUT as active LOG service is shutdown while agent
; The patch looks ok to me.
>>
>> Thanks
>> -Nagu
>>
>>> -Original Message-
>>> From: minh chau [mailto:minh.c...@dektech.com.au]
>>> Sent: 28 April 2017 15:24
>>> To: A V Mahesh; Suryanarayana.Garlapati; hans.nordeb...@ericsson.c
Hi Vu,
I did ACK today early hrs , you haven't received ?
On 5/2/2017 12:32 PM, A V Mahesh wrote:
> Hi Vu,
>
> Ack.
>
> -AVM
>
>
> On 4/26/2017 12:25 PM, Vu Minh Nguyen wrote:
>> rfc5424_msgid is only referred when streaming and
>> having destination name
Hi Vu,
Ack.
-AVM
On 4/26/2017 12:25 PM, Vu Minh Nguyen wrote:
> rfc5424_msgid is only referred when streaming and
> having destination name set on that log stream.
>
> It means it does meaningless job sometimes,
> that is do hash calculation even there is no destination name set.
>
> This
Original Message-
>> From: A V Mahesh [mailto:mahesh.va...@oracle.com]
>> Sent: Friday, April 28, 2017 4:56 AM
>> To: Canh Van Truong <canh.v.tru...@dektech.com.au>;
>> lennart.l...@ericsson.com; vu.m.ngu...@dektech.com.au
>> Cc: opensaf-devel@lists.sourc
laces. Maybe we could
> refactor to handle in one place to make clean code.
> But it is not related to this ticket. We could refactor it in later ?
>
> Regards
> Canh
>
> -Original Message-
> From: Canh Van Truong [mailto:canh.v.tru...@dektech.com.au]
> Sent: Th
Hi Hans N,
ACK .
This patch will also resolve My another problem , which ia have been
debugging related to clock_gettime(CLOCK_MONOTONIC)
-AVM
On 4/27/2017 7:25 PM, Hans Nordeback wrote:
> ---
> src/base/sysf_tmr.c | 20 +---
> 1 file changed, 17 insertions(+), 3
iated with the stream. The
> cold sync is the same reason.
>
> I am not sure if I understand your question? Could you clear it to me?
>
> Thanks
>
> Canh
>
> -Original Message-
> From: A V Mahesh [mailto:mahesh.va...@oracle.com]
> Sent: Thursday, April 27, 2017 8:
Hi Canh Van,
As if you are updating client_id while lgs_ckpt_stream_open() checkpoint
is client_id not required as reference to while ckpt_stream_close()
checkpoint ?
currently this assigned to -1.
-AVM
On 4/25/2017 6:58 PM, Canh Van Truong wrote:
> Handling of checkpoint for stream open is
t;143>1 2017-04-26T21:16:52.955775+10:00 PL-4 osafimmnd 395 mds.log
> [meta sequenceId="30060"] << mds_mcm_await_active_tmr_expiry
>
> I guess the other node-director services also receive the 2nd
> NCSMDS_DOWN(Vdest), but those services have no problem because of
gs.
>
> Dear Zoran,
>
> Do you have any extra comment about this patch?
> If not, I will request pushing it at start of next week.
>
> Sincerely,
> Hoang
>
> -Original Message-
> From: A V Mahesh [mailto:mahesh.va...@oracle.com]
> Sent: Thursda
dant call .
-AVM
On 4/12/2017 2:19 PM, A V Mahesh wrote:
> Hi Hoang,
>
> On 2/10/2017 3:09 PM, Vo Minh Hoang wrote:
>> If cpnd is temporary down only, we don't need clean up anything.
>> If cpnd is permanently down, the bad effect of this proposal is that
>> rep
0cf0, arg=0x7f86f0501ef0
===
-AVM
On 4/12/2017 11:08 AM, A V Mahesh wrote:
> Hi Hoang,
>
> On 2/10/2017 3:09 PM, Vo Minh Hoang wrote:
>> Dear Mahesh,
>>
>> Based on what I saw, in this case, retention time cannot detect CPND
>>
ider it.
>
> Thank you and best regards,
> Hoang
>
> -Original Message-
> From: A V Mahesh [mailto:mahesh.va...@oracle.com]
> Sent: Friday, February 10, 2017 10:40 AM
> To: Hoang Vo <hoang.m...@dektech.com.au>; zoran.milinko...@ericsson.com
> Cc: opensaf-devel@list
Hi Canh Van,
ACK not tested.
-AVM
On 3/22/2017 8:26 PM, Canh Van Truong wrote:
> src/log/apitest/tet_LogOiOps.c | 92
> ++
> src/log/logd/lgs_stream.cc | 3 +
> 2 files changed, 95 insertions(+), 0 deletions(-)
>
>
> When updating attributes
Hi Anders Widell,
ACK not tested .
-AVM
On 4/8/2017 2:39 PM, Anders Widell wrote:
> src/ckpt/ckptnd/cpnd_main.c | 18 ++
> 1 files changed, 18 insertions(+), 0 deletions(-)
>
>
> The CKPT node director needs one file descriptor per open replica. Since the
> maximum number
Ok, ACK.
-AVM
On 4/7/2017 1:05 PM, Anders Widell wrote:
> See reply below.
>
> thanks,
>
> Anders Widell
>
>
> On 04/07/2017 05:17 AM, A V Mahesh wrote:
>> Hi Anders Widell,
>>
>> Ack with following comments :
>>
>> On
One more comment added to previous mail.
On 4/7/2017 8:47 AM, A V Mahesh wrote:
> Hi Anders Widell,
>
> Ack with following comments :
>
> On 4/6/2017 4:55 PM, Anders Widell wrote:
>> The setting OSAF_CKPT_SHM_ALLOC_GUARANTEE=0 results in increased
>> memory us
Hi Anders Widell,
Ack with following comments :
On 4/6/2017 4:55 PM, Anders Widell wrote:
> The setting OSAF_CKPT_SHM_ALLOC_GUARANTEE=0 results in increased memory usage,
> whereas the setting OSAF_CKPT_SHM_ALLOC_GUARANTEE=1 results in lower
> performance. Thus, there was no way to configure
Hi Vu,
I don't think fix is required in LOG , unless we have BUG in IMM
saImmOmInitialize()
According to IMM spec the saImmOmFinalize() function closes the
association represented by the
immHandle parameter between the invoking process and the IMM Service.
If the saImmOmFinalize() function
Hi Vu,
I don't think fix is required in LOG , unless we have BUG in IMM
saImmOmInitialize()
According to IMM spec the saImmOmFinalize() function closes the
association represented by the
immHandle parameter between the invoking process and the IMM Service.
If the saImmOmFinalize() function
n
Comments (indicate scope for each "y" above):
-
changeset 6155b9372e7d740761052e7d26722bc7ff40b3b5
Author: A V Mahesh <mahesh.va...@oracle.com>
Date: Fri, 31 Mar 2017 09:59:32 +0530
smf: Fix all Cppcheck 1.77 issues [#2342]
Hi Vu,
ACK not tested .
-AVM
On 3/24/2017 2:05 PM, Vu Minh Nguyen wrote:
> src/log/logd/lgs_dest.cc | 4 +---
> src/log/logd/lgs_dest.h | 1 +
> src/log/logd/lgs_evt.cc | 1 +
> src/log/logd/lgs_imm.cc | 10 ++
> src/log/logd/lgs_mbcsv.cc | 5 +
>
s ensured that just the stream in one node open the log file.
>
> Thanks
> Canh
>
> -Original Message-
> From: A V Mahesh [mailto:mahesh.va...@oracle.com]
> Sent: Thursday, March 23, 2017 4:40 AM
> To: Canh Van Truong <canh.v.tru...@dektech.com.au>;
> lenn
Hi AMF dev,
A gentle reminder for review.
So far I have received comments for Gary , If you guys doesn't have any
other comments , I will push by tomorrow EOD.
-AVM
On 3/20/2017 10:49 AM, A V Mahesh wrote:
> Summary:amf: Fix all Cppcheck 1.77 issues [#2341] V3
> Review request fo
src/amf/amfd/app.cc|4 +-
src/amf/amfd/apptype.cc| 21 ++
src/amf/amfd/chkop.cc |3 +-
src/amf/amfd/ckpt_dec.cc | 15 ++---
src/amf/amfd/ckpt_edu.cc |4 +-
src/amf/amfd/ckpt_enc.cc | 60
src/amf/amfd/clm.cc
n
Comments (indicate scope for each "y" above):
-
changeset efb3364a0779447b858cbd0cdae1b92f0a2d2716
Author: A V Mahesh <mahesh.va...@oracle.com>
Date: Mon, 20 Mar 2017 10:33:35 +0530
amfd: Fix all Cppcheck 1.77 issues [#2341
src/amf/amfnd/amfnd.cc | 16 ++--
src/amf/amfnd/cbq.cc | 10 --
src/amf/amfnd/chc.cc | 30 --
src/amf/amfnd/clc.cc | 38 +++---
src/amf/amfnd/comp.cc| 9 -
src/amf/amfnd/compdb.cc |
src/amf/agent/ava_hdl.cc | 14 ++
src/amf/agent/ava_mds.cc | 13 +
src/amf/agent/ava_op.cc | 12 +---
src/amf/amfwd/amf_wdog.c | 3 ++-
src/amf/common/d2nmsg.c | 8 +++-
src/amf/common/n2avamsg.c | 2 +-
src/amf/tools/amf_pm.c| 5 ++---
7
n
Comments (indicate scope for each "y" above):
-
changeset 13f8239a95e09caaf2a92cdf716fc08c4511ab8c
Author: A V Mahesh <mahesh.va...@oracle.com>
Date: Thu, 16 Mar 2017 14:35:53 +0530
smf: Fix all Cppcheck 1.77 issues [#2342]
rresponding element from mon_req list */
rc = avnd_mon_req_del(cb, pid);
=
-AVM
On 3/15/2017 10:00 AM, A V Mahesh wrote:
> Summary:amf: Fix all Cppcheck 1.77 issues [#2341] V2
> Review request for Tra
if (NCSCC_RC_SUCCESS != rc) {
> LOG_NO("PM Rec doesn't exist in Comp '%s' of pid %llu",
> comp->name.c_str(), pid);
> }
> -rec = nullptr; /* rec is no more, dont use it */
> +
> +delete rec;
haps it's easier if you pushed V1 first. Otherwise the patches get even
> bigger and harder to review. I was referring to regression tests failing
> without the changes I proposed, when I said legacy tests failed.
>
> thanks
>
>> On 14 Mar 2017, at 6:01 pm, A V Mahesh &
src/amf/agent/ava_hdl.cc | 13 +
src/amf/agent/ava_mds.cc | 12
src/amf/agent/ava_op.cc | 11 ---
src/amf/amfwd/amf_wdog.c | 2 +-
src/amf/common/d2nmsg.c | 7 ++-
src/amf/common/n2avamsg.c | 1 -
src/amf/tools/amf_pm.c| 4 +---
7 files
src/amf/amfd/app.cc|3 +-
src/amf/amfd/apptype.cc| 20 ++
src/amf/amfd/chkop.cc |3 +-
src/amf/amfd/ckpt_dec.cc | 15 ++---
src/amf/amfd/ckpt_edu.cc |3 +-
src/amf/amfd/ckpt_enc.cc | 60
src/amf/amfd/clm.cc
n
Comments (indicate scope for each "y" above):
-
changeset 9401812b47ad5a079e6e82daad0ff83c1cf635f2
Author: A V Mahesh <mahesh.va...@oracle.com>
Date: Wed, 15 Mar 2017 09:51:41 +0530
amfd: Fix all Cppcheck 1.77 issues [#2341] V
src/amf/amfnd/amfnd.cc | 15 +--
src/amf/amfnd/cbq.cc | 9 +++--
src/amf/amfnd/chc.cc | 29 +++--
src/amf/amfnd/clc.cc | 37 ++---
src/amf/amfnd/comp.cc| 8 +++-
src/amf/amfnd/compdb.cc | 17
Hi Gary,
Previously you found some old application issue and you resolved it is
that related to this path or different issue ?
-AVM
On 3/14/2017 12:20 PM, A V Mahesh wrote:
> Hi Gar,
>
> Thanks for the review.
>
> On 3/14/2017 11:47 AM, Gary Lee wrote:
>> By the way,
> comp->name.c_str(), pid);
> }
>
> - delete rec; /* rec is no more, dont use it */
> + rec = nullptr; /* rec is no more, dont use it */
>
> /* remove the corresponding element from mon_req list */
> rc = avnd_mon_req_d
Hi Hans N,
It seems in some flavors of linux `gettid` is available, so dose it be
under #ifndef ?
-AVM
On 3/13/2017 5:46 PM, Hans Nordeback wrote:
> src/base/logtrace.c | 7 ++-
> 1 files changed, 6 insertions(+), 1 deletions(-)
>
>
> Even though not being LSB it would be good to use
Hi Can,
ACK for series, not tested
-AVM
On 3/8/2017 6:43 PM, Canh Van Truong wrote:
> src/log/logd/lgs_fmt.cc | 3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
>
> When sending a log record which is longer than limited quota,
> there will be a double quotation mark although
Hi Can,
ACK not tested.
-AVM
On 3/10/2017 9:04 PM, Canh Van Truong wrote:
> src/log/logd/lgs_filehdl.cc | 12 ++--
> 1 files changed, 6 insertions(+), 6 deletions(-)
>
>
> The cause of issue is free cfg_namelist while struct dirent **cfg_namelist
> unallocated
>
> diff --git
AmfContainedComponentCleanupCallback =
cbk->saAmfContainedComponentCleanupCallback;
+ osaf_cbk->osafCsiAttributeChangeCallback =
cbk->osafCsiAttributeChangeCallback;
}
=======
-AVM
On 3/10/2017 1:
wrote:
> Hi Mahesh
>
> Some of our legacy tests are failing after applying this series.
>
> I will do some debugging and send back details.
>
> Thanks
> Gary
>
> -Original Message-
> From: A V Mahesh <mahesh.va...@oracle.com>
> Date: Wednesd
d <lennart.l...@ericsson.com>; Canh Van Truong
> <canh.v.tru...@dektech.com.au>; 'A V Mahesh'
> <mahesh.va...@oracle.com>; opensaf-devel@lists.sourceforge.net
> *Subject:* RE: Review request log: Update LOG PR document with version
> 5.2 enhancements [#2200]
>
Other n
Comments (indicate scope for each "y" above):
-
changeset c94257bb379abeed0b989653052f2fc3790490cb
Author: A V Mahesh <mahesh.va...@oracle.com>
Date: Fri, 10 Mar 2017 10:39:21 +0530
cpd: update mis
src/ckpt/ckptd/cpd_sbevt.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
Fixed the missed-out/introduced issue of ticket #1669 patch node_users_cnt
variable
diff --git a/src/ckpt/ckptd/cpd_sbevt.c b/src/ckpt/ckptd/cpd_sbevt.c
--- a/src/ckpt/ckptd/cpd_sbevt.c
+++
Hi Hans N,
On 3/10/2017 11:49 AM, Hans Nordebäck wrote:
> Hi Mahesh,
>
> Yes, I think 'TIPC_RETDATA' can have INFO, and TIPC_ERR_OVERLOAD as is, i.e.
> ERROR. /Regards Hans
can I change and directly push that Ok ?
-AVM
>
> -Original Message-
> From: A V Mah
Hi Hans N,
>>I think we should lower it to IN
what do you prefer to have for `TIPC_RETDATA` , do you mean INFO ?
-AVM
On 3/9/2017 8:20 PM, Hans Nordebäck wrote:
> Hi Mahesh,
>
> I missed that this patch also changes TIPC_RETDATA from CR to ER, I think we
> should lower it to IN as the
ACK.
While fixing cppcheck 1.77 I missed ` src/log/tests/` directory ,
sorry for that.
[/avm/staging-publish/src/log/tests/lgs_dest_test.cc:36]: (performance)
Function parameter 'attribute_name' should be passed by reference.
[/avm/staging-publish/src/log/tests/lgs_dest_test.cc:37]:
n
Comments (indicate scope for each "y" above):
-
changeset b8e7593cf4eadaa6169fe635ac0df67560ea875a
Author: A V Mahesh <mahesh.va...@oracle.com>
Date: Wed, 08 Mar 2017 17:52:21 +0530
amfd: Fix all Cppcheck
1 - 100 of 568 matches
Mail list logo
