Ack with minor comments:
1) When adding new files, don't add "(C) Copyright 20xx The OpenSAF
Foundation" at the top of the file. Also, you don't need the Author(s):
line.
2) You can use base::MillisToTimespec for converting milliseconds to a
timespec structure.
/ Anders Widell
mån
revision f96770047a083748056200e8ae4f9c4e898f8ee0
Author: Anders Widell
Date: Mon, 20 May 2019 13:05:03 +0200
uml: Update to Linux 4.18.20, iproute2 5.1.0 and busybox 1.30.1 [#3042]
Uplift the Linux kernel version for UML to 4.18.20, to make it possible to build
UML with newer glibc version (e.g. on Ub
Uplift the Linux kernel version for UML to 4.18.20, to make it possible to build
UML with newer glibc version (e.g. on Ubuntu 18.04).
---
tools/cluster_sim_uml/README | 2 +
tools/cluster_sim_uml/uml/bin/uml_start | 2 +-
tools/cluster_sim_uml/uml/build_uml |
Ack.
regards,
Anders Widell
mån 2018-07-02 klockan 16:15 +0700 skrev Vu Minh Nguyen:
> When user enters subject having slash (/) in, submit-review.sh won't
> work
> with error message: sed: -e expression #1, char 78: unknown option to
> `s'
>
> This patch ensures that all sl
may not
work if the program crashed due to memory corruption.
regards,
Anders Widell
tis 2018-06-12 klockan 07:16 +1000 skrev Minh Chau:
> This ticket support the tracing buffer per thread. If enabled,
> each thread has it own buffer which the trace is written to.
> The thread t
Ok, ack with the comment that a we should mention this potential problem in a
code comment.
regards,
Anders Widell
fre 2018-06-08 klockan 08:13 +0200 skrev Hans Nordeback:
Hi Anders,
yes these functions are not "async signal safe", but if we do encounter
functions "han
Hi!
Could you check if there is some alternative way that doesn't use system(),
syslog() and fgets() from within the signal handler?
regards,
Anders Widell
Från: Ravi Sekhar Reddy Konda
Skickat: den 30 maj 2018 08:10:56
Till: Hans Nordebäck; Anders Widell
Ok.
Ack with the comment that I think you should keep the pkill -STOP commands.
regards,
Anders Widell
On 04/16/2018 11:41 AM, Ravi Sekhar Reddy Konda wrote:
HI Anders,
In the opensaf_reboot script we added these commands as safe mechanism, so
that we won't see issues like AMF taking
Ack for the series.
regards,
Anders Widell
On 04/13/2018 01:50 PM, Gary Lee wrote:
Summary: split-brain: select active SC from largest network partition V4 [#2795]
Review request for Ticket(s): 2795
Peer Reviewer(s): Hans, Ravi, Anders
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS
n
OpenSAF servicesy
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
revision ac0eada7b92e78ac7b804ed108a20d8d4442fb8f
Auth
Make it possible to delete log streams in the internal OpenSAF log server. This
will free up resources for log streams that are no longer used, as well as make
it possible to create a new log stream with the same name but different
configuration options (max file size and number of backups).
---
OpenSAF servicesy
Core libraries y
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
revision 5dcaf67087e852a9682d00c481351fd51faef268
Author: And
Allow OpenSAF agent libraries running in application processes to send trace
messages to osaftransportd, regardless of what user-id and group-id the
application process is running with.
---
src/dtm/transport/log_server.cc | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
---
src/base/unix_server_socket.cc | 14 +++---
src/base/unix_server_socket.h | 7 +--
2 files changed, 16 insertions(+), 5 deletions(-)
diff --git a/src/base/unix_server_socket.cc b/src/base/unix_server_socket.cc
index 620efce9f..8a5290d24 100644
---
A question: why did you remove the "pkill -STOP osafamfwd" etc commands?
regards,
Anders Widell
On 04/12/2018 03:29 PM, ravi-sekhar wrote:
---
scripts/opensaf_reboot | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git a/scripts/opensaf_reboot
ing NTP). Would it be possible to use an expiration time for
the etcd key instead of writing a time stamp in the value, so that etcd
automatically deletes the takeover request when it expires? That way we
would not require synchronized clocks.
regards,
Anders Widell
On 04/11/2018 09:35 AM, G
Core libraries y
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
revision 49be7d5f610fb7e23d8df575007fa3b21a5e0946
Author: Anders Widell &
Ack with comments:
1) You must replace the turtle example with something that you have
written yourself, to avoid potential license problems.
2) One inline comment below, marked AndersW>
regards,
Anders Widell
On 04/03/2018 01:05 PM, Hans Nordeback wrote:
---
00-README.unitt
Ack with minor comment: instead of calling access(), you could maybe
simply check for the ENOENT errno value from unlink()?
regards,
Anders Widell
On 04/05/2018 11:53 AM, Hans Nordeback wrote:
---
src/nid/agent/nid_ipc.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff
td::string and resize() it to emulate
malloc/realloc? You don't have to do it now but think about it as an
improvement.
regards,
Anders Widell
On 04/03/2018 01:42 PM, Hans Nordebäck wrote:
Hi Vu,
few minor comments below.
/Thanks HansN
On 04/03/2018 11:43 AM, Vu Minh Nguyen wrote:
The
Ack with comments, marked AndersW> below.
regards,
Anders Widell
On 03/27/2018 02:26 PM, syam-talluri wrote:
modified: 00-README.conf
modified: src/dtm/README
---
00-README.conf | 15 +++
src/dtm/README | 23 +++
2 files changed,
OpenSAF servicesy
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
revision 86b331dfcf59d9559b86d52763290d5df3479205
Auth
Use the function base::StrToUint64 to pass command-line option arguments. This
gives us error checking, and support for the k, M and G suffixes.
---
src/dtm/tools/osaflog.cc| 44 +
src/dtm/transport/log_server.cc | 44
The new functions StrToInt64 and StrToUint64 parse a string as a signed and
unsigned 64-bit integer, respectively. Prefixes 0 for octal and 0x for
hexadecimal are supported, as well as suffixes k, M and G for kilobytes,
megabytes and gigabytes, respectively.
---
src/base/Makefile.am
servicesn
Core libraries y
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
revision d4126e16159bbfdc495389b17fbe570b0e889931
Author: And
Fix the remaining review comment for ticket [#2731]: revert back to a text-based
protocol between osaflog command and osaftransportd. Also fix the osaflog
--flush command, that stopped working after ticket [#2731].
---
src/dtm/common/osaflog_protocol.h | 7 -
src/dtm/tools/osaflog.cc
OpenSAF servicesy
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
revision e867918ebf9cdff9080c94e960cd531429932ada
Auth
Ack with minor comments, marked AndersW> below.
regards,
Anders Widell
On 03/19/2018 04:36 AM, Minh Chau wrote:
---
src/base/os_defs.c | 32 +++-
1 file changed, 27 insertions(+), 5 deletions(-)
diff --git a/src/base/os_defs.c b/src/base/os_defs.c
in
Hi!
See my comments below, marked AndersW2>.
regards,
Anders Widell
On 03/16/2018 12:39 PM, Hans Nordebäck wrote:
Hi Minh, ack with some comments, (on top of AndersW comments).
/Thanks HansN
On 03/15/2018 07:50 AM, Minh Chau wrote:
---
src/base/os_defs.c |
Ack with minor comments, marked AndersW> below.
regards,
Anders Widell
On 03/15/2018 07:50 AM, Minh Chau wrote:
---
src/base/os_defs.c | 25 -
1 file changed, 20 insertions(+), 5 deletions(-)
diff --git a/src/base/os_defs.c b/src/base/os_defs.c
index 6f9e
Ack.
regards,
Anders Widell
On 03/09/2018 02:30 PM, Hans Nordeback wrote:
---
tools/devel/dot/trace2dot | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/tools/devel/dot/trace2dot b/tools/devel/dot/trace2dot
index 160617c7a..1977276ea 100755
Ack.
regards,
Anders Widell
On 03/09/2018 06:57 AM, Gary Lee wrote:
If we have a 'tied election' and split-brain prevention is enabled,
then the 'old active' is fenced, or the 'old active' will self-reboot
when it is notified a new node is active.
We need to disable this redundant check
cket,
so that we get some progress on this issue.
3) Please read the style guide. A lot of my comments are about
whitespace and naming of structures and variables.
4) See more comments inline in the code below, marked AndersW>. Fix them
before pushing.
regards,
Anders Widell
On 03/14/2
comments to the squashed patch as a reply to this mail.
regards,
Anders Widell
---
opensaf.spec.in | 2 +
src/dtm/Makefile.am | 3 +
src/dtm/common/osaflog_protocol.h | 13 +++
src/dtm/tools/osaflog.cc
Ack with minor comment: Return type from strlen() is size_t, and return
type from send() is ssize_t. So a more type-correct way to implement
this is outlined in my inlined comments in the code below.
regards,
Anders Widell
On 03/09/2018 02:44 AM, Gary Lee wrote:
---
src/rde/agent
Fix the following false warning produced by "make checkpatch":
WARNING: struct should normally be const
---
Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile.am b/Makefile.am
index 8f2687314..b3d6553c1 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -431,7
uot; above):
-
revision b323a0be9d7d60f74f8985c9088204099c297396
Author: Anders Widell <anders.wid...@ericsson.com>
Date: Mon, 12 Mar 2018 14:52:20 +0100
build: Fix false checkpatch warning about struct should normally be const
[#2807]
Fix the following false warning produced by "make checkpat
Ack. Note that you ought to send the document as an E-mail attachment
along with the review request, and then update it with review comments
(if any) before pushing it.
regards,
Anders Widell
On 03/05/2018 11:14 AM, Srinivas Mangipudy wrote:
Hi Vu,
I updated OpenSAF_IMMsv_PR.odt
Ack.
regards,
Anders Widell
On 03/01/2018 08:30 AM, srinivas wrote:
---
src/imm/README | 9 ++---
src/imm/immloadd/imm_loader.cc | 2 +-
src/imm/immnd/immnd.conf| 2 +-
src/imm/immpbed/immpbe.cc | 2 +-
src/imm/tools/imm_dumper.cc | 2 +-
src
Ack with minor comment: explain in the (long) commit message why this
change was needed, i.e. since etcdctl otherwise could otherwise try to
contact unavailable etcd servers which would cause delays.
regards,
Anders Widell
On 03/07/2018 05:37 AM, Gary Lee wrote:
---
src/osaf/consensus
Ack with comment: I think the file should be called README.etcd instead
of etcd.readme. Shouldn't it be added to the Makefile as well?
regards,
Anders Widell
On 03/07/2018 04:42 AM, Gary Lee wrote:
---
src/osaf/consensus/plugins/etcd.readme | 32
1 file
servicesn
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
revision 87ab31a75d166d003287b3ddc5547c6c7223928d
Author: And
Always delete the generated file /var/lib/opensaf/node_id when stopping OpenSAF.
Previously, it was only deleted when using TIPC transport and TIPC was managed
by OpenSAF. For consistent behaviour, we shall always clean away generated files
when stopping OpenSAF.
---
src/nid/opensafd.in | 7
When using systemd version 227 or later, set the option TasksMax for OpenSAF to
inifinity. This option specifies the maximum number of processes and threads
within the control group for the OpenSAF service. The reason why OpenSAF needs a
large number of processes and threads is that all
n
OpenSAF servicesy
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
revision 6d50f95338496e3d7b17749e9ae9853e044aa33b
Auth
Hi!
See comment below, marked AndersW>
regards,
Anders Widell
On 02/27/2018 09:07 AM, Hans Nordebäck wrote:
Hi Anders, a question below. /Regards Hans
On 02/26/2018 02:47 PM, Anders Widell wrote:
When using systemd version 227 or later, set the option TasksMax for
OpenSAF to
inifin
49fbc2c742
Author: Anders Widell <anders.wid...@ericsson.com>
Date: Wed, 21 Feb 2018 13:17:12 +0100
pyosaf: Fix broken imports in imm-listener and imm-listener-inheritance-impl
[#2786]
Complete diffstat:
--
python/samples/imm-listener | 3 ++-
py
---
python/samples/imm-listener | 3 ++-
python/samples/imm-listener-inheritance-impl | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/python/samples/imm-listener b/python/samples/imm-listener
index 2e0dbdd00..40cfc7571 100755
---
---
python/pyosaf/utils/immoi/implementer.py | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/python/pyosaf/utils/immoi/implementer.py
b/python/pyosaf/utils/immoi/implementer.py
index db44b4f3c..f7f7a83ad 100755
--- a/python/pyosaf/utils/immoi/implementer.py
+++
0fae0ebc70
Author: Anders Widell <anders.wid...@ericsson.com>
Date: Wed, 21 Feb 2018 13:16:41 +0100
pyosaf: Handle SA_AIS_ERR_BAD_HANDLE in pyosaf Implementer dispatch loop [#2785]
Complete diffstat:
--
python/pyosaf/utils/immoi/implementer.py | 7 ++-
1 file changed, 6
Ack.
regards,
Anders Widell
On 11/24/2017 03:30 PM, Hans Nordeback wrote:
---
src/base/daemon.c | 19 +++
1 file changed, 15 insertions(+), 4 deletions(-)
diff --git a/src/base/daemon.c b/src/base/daemon.c
index 27170d779..bfb605093 100644
--- a/src/base/daemon.c
+++ b
Ack.
regards,
Anders Widell
On 02/13/2018 05:02 AM, Gary Lee wrote:
Summary: fmd: prevent data races between MDS and main threads V2 [#2763]
Review request for Ticket(s): 2763
Peer Reviewer(s): Anders
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
" to the server, and the server could reply back
with "!max-file-size 1000" when the operation has completed (1000 here
would mean that the new file size limit is now 1000 - i.e. the operation
was successful).
See more comments inline below, marked AndersW>
regards,
Anders Widell
On
Hi!
This first patch is identical to the previous review request. When
sending out a new review request, please don't send out the new updated
patch (only). You can merge commits in git using e.g. "git commit
--amend" or "git rebase -i"
regards,
Anders Widell
On 02/12
Ack with minor comments marked AndersW> below.
regards,
Anders Widell
On 02/09/2018 12:36 PM, srinivas wrote:
---
src/imm/README | 12 +++-
src/imm/immloadd/imm_loader.cc | 2 +-
src/imm/immnd/immnd.conf| 5 +++--
src/imm/immpbed/immpbe.cc |
See my comments inline, marked AndersW>
regards,
Anders Widell
On 02/08/2018 10:36 AM, Ravi Sekhar Reddy Konda wrote:
Hi Gary,
Have query regarding quorum selection when raft servers are external to the
OpenSAF Cluster
In the document we are saying "The consensus service use
Ack with minor comments inline, marked AndersW>.
regards,
Anders Widell
On 02/06/2018 03:43 AM, Gary Lee wrote:
---
src/fm/fmd/fm_cb.h| 89 ++-
src/fm/fmd/fm_main.cc | 32 +-
src/fm/fmd/fm_mds.cc |
Ack with minor comments, marked AndersW> below.
regards,
Anders Widell
On 02/07/2018 11:19 AM, Vu Minh Nguyen wrote:
Only run the slow test case if the OSAF_SLOW_UNITTESTS enviroment
variable is defined.
---
src/ais/tests/try_again_decorator_test.cc | 18 ++
1 file chan
path.
Should we also update the variable name to "IMMSV_TRACE_FILENAME" from
"IMMSV_TRACE_PATHNAME"?
Please let me know your thoughts about this.
thank you
-Original Message-
From: Anders Widell [mailto:anders.wid...@ericsson.com]
Sent: Tuesday, February 6, 2018 4:
Hi!
Is it a problem that trace files are stored under /var/log/opensaf ? The
trace functionality has been implemented like this on purpose.
/ Anders Widell
On 02/06/2018 11:00 AM, srinivas wrote:
Summary: imm: changes to generate trace files in configured dir [#2776]
Review request
servicesy
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
revision 53b428f3fe263d8a82d08f86d1253b59691bd97e
Author: Anders Widell &
When using IPv6, we must re-try bind() to handle the potential IPv6 DAD
(duplicate address detection) race condition.
After an IPv6 address has been added to an interface, there will be a short
period when the address is considered tentative and bind() will fail with
EADDRNOTAVAIL.
This commit
Ack.
regards,
Anders Widell
On 01/31/2018 07:02 AM, Gary Lee wrote:
Sometimes a set fails if the underlying key-value store
is 'busy', particuarly when there are network topology changes
occurring. We should retry a few times, before returning
not writable.
---
src/osaf/consensus
954
Author: Anders Widell <anders.wid...@ericsson.com>
Date: Tue, 30 Jan 2018 14:26:22 +0100
clm: Convert CLM to C++ [#2721]
To support future implementation of tickets [#2618], [#2693] and [#2694], fully
convert CLM to C++. This will also make it possible to remove the C++ wrappers
in th
Ack.
regards,
Anders Widell
On 01/29/2018 11:36 PM, Gary Lee wrote:
Summary: fmd: indent to Google style guide [#2763]
Review request for Ticket(s): 2763
Peer Reviewer(s): Anders, Ravi
Pull request to:
Affected branch(es): develop
Development branch: ticket-2763
Base revision
Ack.
regards,
Anders Widell
On 01/26/2018 06:57 AM, Gary Lee wrote:
Hi
I have updated the OpenSAF Overview PR document for ticket #64.
Please have a look.
https://sourceforge.net/p/opensaf/tickets/_discuss/thread/0d47d4b9/5489/attachment/OpenSAF_Overview_PR.odt
Thanks
Gary
Ack for the patch, with the comment that Makefile.am should be updated
in the patch where the new files are introduced (as mentioned in the
comments for that patch).
regards,
Anders Widell
On 01/23/2018 09:06 AM, Gary Lee wrote:
---
00-README.conf | 56
Ack with comments, marked AndersW> below.
regards,
Anders Widell
On 01/23/2018 09:06 AM, Gary Lee wrote:
---
src/fm/Makefile.am| 1 +
src/fm/fmd/fm_main.cc | 37 +++--
src/fm/fmd/fm_rda.cc | 13 +
src/fm/fmd/fmd.conf | 6 ++
Ack for the patch.
regards,
Anders Widell
On 01/23/2018 09:06 AM, Gary Lee wrote:
When a node goes down and split-brain prevention is enabled,
check that we still have write access to the consensus service.
If not and fencing is disabled, reboot the node to prevent
split brain.
---
src/amf
uld be renamed to key_value.h so that we have consistent
naming of files. Of course, service.cc and keyvalue.cc should be renamed
as well, and the header guards.
regards,
Anders Widell
On 01/24/2018 06:31 AM, Gary Lee wrote:
Hi Anders
Will change according to your comments, one comment be
Ack for this patch with comments, marked AndersW>
regards,
Anders Widell
On 01/23/2018 09:06 AM, Gary Lee wrote:
* consult with consensus service before promoting node to active
* add watch thread and self-fence if it detects active controller
has been changed (if remote fenc
.am updates should be moved to this patch.
regards,
Anders Widell
On 01/23/2018 09:06 AM, Gary Lee wrote:
---
src/osaf/consensus/Makefile | 18 +++
src/osaf/consensus/keyvalue.cc | 221 ++
src/osaf/consensus/keyvalue.h|
n
OpenSAF servicesn
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
revision 0131fd2425dfcac9a9428f453d6d3d76cea65655
Auth
Treat the value zero in /etc/opensaf/slot_id in the same way as if the file is
missing, i.e. use the TIPC address or IPv4 address as node ID.
---
00-README.conf | 15 ---
Makefile.am | 2 +-
src/nid/opensafd.in | 3 +++
3 files changed, 12 insertions(+), 8 deletions(-)
See one comment below, marked AndersW2>
regards,
Anders Widell
On 01/22/2018 07:56 AM, Gary Lee wrote:
HI Anders/Hans
On 20/01/18 00:56, Anders Widell wrote:
Ack from me also, with comments:
* I think my major comment is that I had originally envisioned that
you would use the "
s in some
directory in the etcd database, so that the same database can be used
for other purposes as well. I think the plugin (shell script) should add
a directory prefix to the key.
Also see one comment inline below, marked AndersW>
regards,
Anders Widell
On 01/19/2018 01:47 PM, Hans Nordebä
are used.
regards,
Anders Widell
On 01/19/2018 09:57 AM, Ravi Sekhar Reddy Konda wrote:
Hi Anders,
Ack, reviewed & tested (combinations also)
Update the README(if you are pushing #2759 immediately, you can do after #2759)
one minor comment, in generate_nodeid you hardcoded chassis_id & su
Ack.
regards,
Anders Widell
On 01/16/2018 12:53 PM, Hans Nordeback wrote:
---
src/fm/fmd/fmd.conf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/fm/fmd/fmd.conf b/src/fm/fmd/fmd.conf
index 63950ef8e..4924abfd9 100644
--- a/src/fm/fmd/fmd.conf
+++ b/src/fm/fmd
s/service.cc:203: { should almost always be at the end
of the previous line [whitespace/braces] [4]
src/osaf/consensus/service.cc:207: { should almost always be at the end
of the previous line [whitespace/braces] [4]
src/osaf/consensus/service.cc:224: { should almost always be at the end
of the
Ack.
regards,
Anders Widell
On 01/15/2018 01:03 PM, Hans Nordeback wrote:
---
CPPLINT.cfg | 1 +
1 file changed, 1 insertion(+)
create mode 100644 CPPLINT.cfg
diff --git a/CPPLINT.cfg b/CPPLINT.cfg
new file mode 100644
index 0..532509cd0
--- /dev/null
+++ b/CPPLINT.cfg
@@ -0,0
---
src/msg/apitest/tet_mqa.c | 4 ++--
src/msg/apitest/tet_mqsv.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/msg/apitest/tet_mqa.c b/src/msg/apitest/tet_mqa.c
index b73e7567e..bd38d94ee 100644
--- a/src/msg/apitest/tet_mqa.c
+++ b/src/msg/apitest/tet_mqa.c
@@
The files chassis_id, slot_id and subslot_id in /etc/opensaf no longer have to
be present. When they are missing, OpenSAF will derive the Node ID from the TIPC
address or the IPv4 address of the node.
---
src/nid/opensafd.in | 49 +++--
1 file changed,
Also fix the CLM API tests so that they longer assume that there is a node with
node ID 0x2010f in the cluster.
---
src/clm/apitest/clmtest.cc | 6 ++
src/clm/apitest/tet_saClmClusterNodeGet.cc | 23 ---
---
src/ckpt/apitest/test_cpsv.h | 2 +-
src/ckpt/ckptnd/cpnd_res.c | 18 +-
src/ckpt/common/cpsv_evt.c | 2 +-
3 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/src/ckpt/apitest/test_cpsv.h b/src/ckpt/apitest/test_cpsv.h
index 27d7c8076..97c78f256 100644
---
---
src/lck/apitest/tet_gla.c | 4 ++--
src/lck/apitest/tet_gld.c | 4 ++--
src/lck/apitest/tet_glnd.c | 2 +-
src/lck/apitest/tet_glsv.h | 2 +-
4 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/lck/apitest/tet_gla.c b/src/lck/apitest/tet_gla.c
index b6c3c4725..deff6e91f
If the /var/lib/opensaf/node_id file doesn't exist when DTM starts, DTM will
create the file and use the IPv4 address as node ID. When using IPv6, the file
must still be configured manually. IPv6 support may be added in a future ticket.
---
src/dtm/dtmnd/dtm.h | 1 +
Core libraries y
Samples n
Tests y
Other n
Comments (indicate scope for each "y" above):
-
revision c9161898793a57ce1db18be5343b9ea2a372271e
Author: Anders Widell <anders.wid...
. :-)
regards,
Anders Widell
On 01/09/2018 09:15 AM, Mathi N P wrote:
This is a good change, long pending.
The patches look okay. Iam thinking about in-service upgradeability of
especially IMM(FEVS) and CKPT!
Cheers,
Mathi.
On Thu, Dec 21, 2017 at 11:25 AM, Anders Widell
<anders.
Ok, I will remove them before pushing!
Does anyone have more comments? I will push this on Wednesday if no more
comments are posted.
regards,
Anders Widell
On 01/02/2018 04:10 PM, Alex Jones wrote:
As far as I can see, plms_self_id and plms_remote_id aren't used at all.
Let's just get
Ack.
regards,
Anders Widell
On 12/28/2017 09:42 AM, Gary Lee wrote:
Source files renamed to .cc
Apply changes required to compile succesfully with g++
---
src/fm/Makefile.am | 8
src/fm/fmd/fm.h | 2 +-
src/fm/fmd/{fm_amf.c => fm_amf
unchanged).
* Please comment out (insert hash characters before) the two options in
transportd.conf, since they have the default values.
regards,
Anders Widell
On 12/27/2017 12:25 PM, syam-talluri wrote:
---
opensaf.spec.in| 2 +
src/dtm/M
n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
revision 7191b00d311d2112af3743a5e8ace1a2de1f8096
Author: Anders Widell &
In a parallel build, the $(top_builddir)/lib may not yet exist when building
the all-local target. Make sure the directory exists using mkdir -p
---
Makefile.am | 1 +
1 file changed, 1 insertion(+)
diff --git a/Makefile.am b/Makefile.am
index 45fc5c207..bcfd844cd 100644
--- a/Makefile.am
+++
---
src/imm/immd/immd_cb.h| 4 ++--
src/imm/immd/immd_db.c| 21 -
src/imm/immd/immd_evt.c | 32
src/imm/immd/immd_mds.c | 3 +--
src/imm/immd/immd_proc.c | 9 +++--
src/imm/immd/immd_proc.h | 3 +--
---
src/base/ncs_main_papi.h | 8
src/base/ncsgl_defs.h| 7 ---
2 files changed, 15 deletions(-)
diff --git a/src/base/ncs_main_papi.h b/src/base/ncs_main_papi.h
index 8f8f909a5..c3255d14f 100644
--- a/src/base/ncs_main_papi.h
+++ b/src/base/ncs_main_papi.h
@@ -87,14 +87,6 @@
---
src/msg/agent/mqa_api.cc | 10 +-
src/msg/agent/mqa_db.h | 4 ++--
src/msg/agent/mqa_init.cc| 14 +++---
src/msg/agent/mqa_mds.cc | 14 +++---
src/msg/common/mqsv_common.c | 8
src/msg/common/mqsv_common.h | 2 +-
src/msg/msgd/mqd_mds.c
-
We move towards a flat addressing scheme by using Node ID instead of the legacy
slot-id and subslot-id to identify nodes in the cluster.
revision 80a9c99e61bb5fd0ba9be11b8dbbd883e679ebf2
Author: Anders Widell <anders.wid...@ericsson.com>
Date: Thu, 21 Dec 2017 11:15:30 +0100
fm: Rem
---
src/fm/fmd/fm_mds.c | 2 +-
src/fm/fmd/fmd.conf | 6 --
2 files changed, 1 insertion(+), 7 deletions(-)
diff --git a/src/fm/fmd/fm_mds.c b/src/fm/fmd/fm_mds.c
index 44d272f13..c1b0d9200 100644
--- a/src/fm/fmd/fm_mds.c
+++ b/src/fm/fmd/fm_mds.c
@@ -681,7 +681,7 @@ static uint32_t
---
src/msg/Makefile.am | 10 +-
src/msg/agent/{mqa_api.c => mqa_api.cc} | 231 ++--
src/msg/agent/{mqa_clbk.c => mqa_clbk.cc} | 38 +++--
src/msg/agent/mqa_def.h | 13 +-
src/msg/agent/{mqa_init.c => mqa_init.cc} |
---
src/plm/common/plms.h | 4 ++--
src/plm/plmd/plms_mds.c | 15 +--
2 files changed, 3 insertions(+), 16 deletions(-)
diff --git a/src/plm/common/plms.h b/src/plm/common/plms.h
index d550ea06d..6523a92d6 100644
--- a/src/plm/common/plms.h
+++ b/src/plm/common/plms.h
@@ -257,8
1 - 100 of 823 matches
Mail list logo
