Re: [devel] [PATCH 1/1] plmd: fix crash when saPlmReadinessTrack is called in error [#2919]

2018-08-28 Thread Ravi Sekhar Reddy Konda
Hi Alex, Ack for the patch, review only Regards, Ravi - Original Message - From: ajo...@rbbn.com To: mathi.np@gmail.com, ravisekhar.ko...@oracle.com Cc: opensaf-devel@lists.sourceforge.net, ajo...@rbbn.com Sent: Tuesday, August 28, 2018 2:09:19 AM GMT +05:30 Chennai, Kolkata, Mumbai,

Re: [devel] [PATCH 1/1] imm: correct data size mismatches in pbe code [#2770]

2018-05-31 Thread Ravi Sekhar Reddy Konda
Hi VuMinh, Ack for the patch Regards, Ravi -Original Message- From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] Sent: Thursday, January 25, 2018 5:22 PM To: zoran.milinko...@ericsson.com; ravisekhar.ko...@oracle.com Cc: opensaf-devel@lists.sourceforge.net; Vu Minh Nguyen

Re: [devel] [PATCH 1/1] base: Improve backtrace print in daemon.c [#2853]

2018-05-30 Thread Ravi Sekhar Reddy Konda
Hi Hans, Ack, code review only Regards, Ravi -Original Message- From: Hans Nordeback [mailto:hans.nordeb...@ericsson.com] Sent: Wednesday, May 16, 2018 12:54 PM To: anders.wid...@ericsson.com; Ravi Sekhar Reddy Konda ; gary@dektech.com.au Cc: opensaf-devel@lists.sourceforge.net

Re: [devel] [PATCH 1/1] rded: run controller promotion code in new thread [#2857]

2018-05-23 Thread Ravi Sekhar Reddy Konda
Hi Gary, Ack, code review only Regards, Ravi - Original Message - From: gary@dektech.com.au To: hans.nordeb...@ericsson.com, ravisekhar.ko...@oracle.com, anders.wid...@ericsson.com Cc: opensaf-devel@lists.sourceforge.net, gary@dektech.com.au Sent: Friday, May 18, 2018 11:20:34

Re: [devel] [PATCH 1/1] lck: fix errors when displaying SaLckResource class [#2070]

2018-05-15 Thread Ravi Sekhar Reddy Konda
Hi Alex, Ack, code review only Regards, Ravi -Original Message- From: Alex Jones [mailto:ajo...@rbbn.com] Sent: Monday, May 07, 2018 8:13 PM To: Ravi Sekhar Reddy Konda <ravisekhar.ko...@oracle.com> Cc: opensaf-devel@lists.sourceforge.net; Alex Jones <ajo...@rbbn.com> Subje

Re: [devel] [PATCH 1/1] plm: don't instantiate child EEs twice when unlocking parent EE [#2846]

2018-05-09 Thread Ravi Sekhar Reddy Konda
Hi Alex, Ack for the patch, code review only Regards, Ravi -Original Message- From: Alex Jones [mailto:ajo...@rbbn.com] Sent: Thursday, May 03, 2018 9:08 PM To: mathi.np@gmail.com; Ravi Sekhar Reddy Konda <ravisekhar.ko...@oracle.com> Cc: opensaf-devel@lists.sourceforge.net

Re: [devel] [PATCH 1/1] clmd: Increase message priority of CLMSV_CLMS_MDS_NODE_EVT to be sent to main thread [#2842]

2018-04-25 Thread Ravi Sekhar Reddy Konda
Hi Minh, Ack for the patch, code review only Regards, Ravi -Original Message- From: Minh Chau [mailto:minh.c...@dektech.com.au] Sent: Thursday, April 26, 2018 4:52 AM To: anders.wid...@ericsson.com; hans.nordeb...@ericsson.com; ravisekhar.ko...@oracle.com Cc:

Re: [devel] [PATCH 1/1] dtm: Add --delete option to osaflog command for deleting log streams [#2837]

2018-04-18 Thread Ravi Sekhar Reddy Konda
HI Anders, Ack, please update the pr doc while pushing to the repo Thanks, Ravi -Original Message- From: Anders Widell [mailto:anders.wid...@ericsson.com] Sent: Friday, April 13, 2018 9:02 PM To: Ravi Sekhar Reddy Konda <ravisekhar.ko...@oracle.com> Cc: opensaf

Re: [devel] [PATCH 0/1] Review Request for base: Re-factor the timer implementation [#2440]

2018-04-17 Thread Ravi Sekhar Reddy Konda
complete the review, can you provide the PR doc update also Thanks, Ravi -Original Message- From: Anders Widell [mailto:anders.wid...@ericsson.com] Sent: Monday, April 09, 2018 10:00 PM To: Ravi Sekhar Reddy Konda <ravisekhar.ko...@oracle.com> Cc: opensaf-devel@lists.sourcefor

Re: [devel] [PATCH 1/1] imm: make version parameter in immutil_xxx non-const [#2830]

2018-04-16 Thread Ravi Sekhar Reddy Konda
Hi Vu, Ack with a comment, make sure to reset local_version wherever API is called in a loop Thanks, Ravi -Original Message- From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] Sent: Thursday, April 05, 2018 4:09 PM To: ravisekhar.ko...@oracle.com; hans.nordeb...@ericsson.com;

Re: [devel] [PATCH 1/1] osaf: Isolate the node in the opensaf_reboot [#2833]

2018-04-16 Thread Ravi Sekhar Reddy Konda
5:08 PM To: Ravi Sekhar Reddy Konda <ravisekhar.ko...@oracle.com>; Anders Widell <anders.wid...@ericsson.com> Cc: opensaf-devel@lists.sourceforge.net Subject: Re: SV: [PATCH 1/1] osaf: Isolate the node in the opensaf_reboot [#2833]   Hi Ravi,   stonith is not only valid for

Re: [devel] [PATCH 1/1] osaf: Isolate the node in the opensaf_reboot [#2833]

2018-04-16 Thread Ravi Sekhar Reddy Konda
HI Anders, In the opensaf_reboot script we added these commands as safe mechanism, so that we won't see issues like AMF taking Active role and start assigning. But as part of this patch we are bringing down the communication mechanism, prior to killing these core saf services. So I thought

Re: [devel] [PATCH 1/1] osaf: Isolate the node in the opensaf_reboot [#2833]

2018-04-13 Thread Ravi Sekhar Reddy Konda
HI Hans,   The use case that we are addressing here is link flickering  when remote fencing is not enabled, Also remote fencing using Stonith is valid only in Virtualization environments. I have not tested using Stonith enabled as the use case is in the case where remote fencing is disabled.

Re: [devel] [PATCH 1/1] amfnd: unlock before releasing the monitoring thread to avoid deadlock [#2818]

2018-04-04 Thread Ravi Sekhar Reddy Konda
Hi Minh, Did you get time to look at this patch, please consider reviewing it with priority Thanks, Ravi -Original Message- From: ravi-sekhar [mailto:ravisekhar.ko...@oracle.com] Sent: Thursday, March 29, 2018 11:30 AM To: hans.nordeb...@ericsson.com; minh.c...@dektech.com.au;

Re: [devel] [PATCH 1/1] imm: improve cascade delete [#2667]

2018-03-29 Thread Ravi Sekhar Reddy Konda
Hi Vu, Ack, tested the functionality coding wise, I don't have any new comments other then what Hans has given please address them before pushing one generic comment, you added lot of new routines, please add function headers for them Thanks, Ravi -Original Message- From: Vu

Re: [devel] [PATCH 1/1] dtm: Fix the osaflog --flush command, and revert osaflog protocol [#2812]

2018-03-26 Thread Ravi Sekhar Reddy Konda
Hi Anders, Ack, code review only Regards, Ravi -Original Message- From: Anders Widell [mailto:anders.wid...@ericsson.com] Sent: Monday, March 19, 2018 8:38 PM To: Ravi Sekhar Reddy Konda <ravisekhar.ko...@oracle.com> Cc: opensaf-devel@lists.sourceforge.net; Anders Widell <a

Re: [devel] [PATCH 1/1] imm: fix race-condition in imm agent [#2810]

2018-03-20 Thread Ravi Sekhar Reddy Konda
Hi Vu, Ack, code review only not tested Thanks, Ravi -Original Message- From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] Sent: Friday, March 16, 2018 2:51 PM To: ravisekhar.ko...@oracle.com; hans.nordeb...@ericsson.com; zoran.milinko...@ericsson.com;

Re: [devel] [PATCH 1/1] amfd: Trigger dependent SI assignment if currActiveAssignment is less than preferred active assignment [#2803]

2018-03-18 Thread Ravi Sekhar Reddy Konda
Hi Minh, Ack, reviewed & tested Thanks, Ravi -Original Message- From: Minh Chau [mailto:minh.c...@dektech.com.au] Sent: Wednesday, March 14, 2018 5:23 AM To: hans.nordeb...@ericsson.com; ravisekhar.ko...@oracle.com; gary@dektech.com.au Cc:

Re: [devel] [PATCH 1/1] amf: do not dereference null pointer [#2791]

2018-03-18 Thread Ravi Sekhar Reddy Konda
age- From: Gary Lee [mailto:gary@dektech.com.au] Sent: Friday, March 16, 2018 6:24 PM To: Ravi Sekhar Reddy Konda <ravisekhar.ko...@oracle.com> Cc: hans.nordeb...@ericsson.com; minh.c...@dektech.com.au; opensaf-devel@lists.sourceforge.net Subject: Re: [PATCH 1/1] amf: do not derefer

Re: [devel] [PATCH 1/1] imm: coredump during scale-in on large configuration [#2794]

2018-03-15 Thread Ravi Sekhar Reddy Konda
Hi Vu, Ack for the patch, code review only Thanks, Ravi -Original Message- From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] Sent: Monday, March 12, 2018 12:43 PM To: ravisekhar.ko...@oracle.com; hans.nordeb...@ericsson.com; zoran.milinko...@ericsson.com;

Re: [devel] [PATCH 1/1] imm: fix unknown event type in imma_proc_free_pointers [#2779]

2018-03-13 Thread Ravi Sekhar Reddy Konda
Hi Vu, Ack, code review only Regards, Ravi -Original Message- From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] Sent: Tuesday, March 13, 2018 12:50 PM To: ravisekhar.ko...@oracle.com; hans.nordeb...@ericsson.com; zoran.milinko...@ericsson.com; anders.wid...@ericsson.com;

Re: [devel] [PATCH 1/1] osaf: add example config for etcd [#2784]

2018-03-11 Thread Ravi Sekhar Reddy Konda
p; 3 are not specific to etcd, they are genric for any plugin, you can update in the PR doc Thanks, Ravi -Original Message- From: Gary Lee [mailto:gary@dektech.com.au] Sent: Wednesday, March 07, 2018 9:13 AM To: Ravi Sekhar Reddy Konda <ravisekhar.ko...@oracle.com>;

Re: [devel] [PATCH 1/1] plmd: enable dynamic tracing [#2796]

2018-03-08 Thread Ravi Sekhar Reddy Konda
Hi Alex, I think that is enough, I am fine as long as user has option to use the routine for debugging Thanks, Ravi From: Jones, Alex [mailto:ajo...@rbbn.com] Sent: Thursday, March 08, 2018 6:00 PM To: Ravi Sekhar Reddy Konda <ravisekhar.ko...@oracle.com> Cc: opensaf

Re: [devel] [PATCH 1/1] plmd: enable dynamic tracing [#2796]

2018-03-07 Thread Ravi Sekhar Reddy Konda
the code Thanks, Ravi -Original Message- From: Alex Jones [mailto:ajo...@rbbn.com] Sent: Thursday, March 08, 2018 2:09 AM To: Ravi Sekhar Reddy Konda <ravisekhar.ko...@oracle.com> Cc: opensaf-devel@lists.sourceforge.net; Alex Jones <ajo...@rbbn.com> Subject: [PATCH 1/1]

Re: [devel] [PATCH 1/1] amfd: Handle su_cnt_adm_opr properly in Nodegroup adm resp procesing [#2588]

2018-02-22 Thread Ravi Sekhar Reddy Konda
Hi Minh, Can you review this patch, its simple fix only. Thanks, Ravi -Original Message- From: ravi-sekhar [mailto:ravisekhar.ko...@oracle.com] Sent: Thursday, February 22, 2018 4:07 PM To: minh.c...@dektech.com.au; hans.nordeb...@ericsson.com; gary@dektech.com.au Cc:

Re: [devel] [PATCH 1/1] amfnd: remove duplicate log entry [#2783]

2018-02-19 Thread Ravi Sekhar Reddy Konda
Ack, code review only Regards, Ravi - Original Message - From: gary@dektech.com.au To: hans.nordeb...@ericsson.com, minh.c...@dektech.com.au, ravisekhar.ko...@oracle.com Cc: opensaf-devel@lists.sourceforge.net, gary@dektech.com.au Sent: Monday, February 19, 2018 7:42:15 AM GMT

Re: [devel] Review Request for doc: update overview PR for split brain prevention with consensus service [#64]

2018-02-15 Thread Ravi Sekhar Reddy Konda
Thanks Gary, Also I asked for the sample configuration of raft cluster when raft servers are part of OpenSAF cluster A Raft(etcd) cluster should use different interface other then what OpenSAF is using, so it will better to document this. In general it will be good to have sample

Re: [devel] Review Request for doc: update overview PR for split brain prevention with consensus service [#64]

2018-02-15 Thread Ravi Sekhar Reddy Konda
: update overview PR for split brain prevention with consensus service [#64] See my comments inline, marked AndersW> regards, Anders Widell On 02/08/2018 10:36 AM, Ravi Sekhar Reddy Konda wrote: > Hi Gary, > > Have query regarding quorum selection when raft servers are external to th

Re: [devel] Review Request for doc: update overview PR for split brain prevention with consensus service [#64]

2018-02-08 Thread Ravi Sekhar Reddy Konda
- From: Gary Lee [mailto:gary@dektech.com.au] Sent: Friday, January 26, 2018 11:28 AM To: Hans Nordebäck <hans.nordeb...@ericsson.com>; Anders Widell <anders.wid...@ericsson.com>; Ravi Sekhar Reddy Konda <ravisekhar.ko...@oracle.com> Cc: opensaf-devel@lists.sourceforge.n

Re: [devel] [PATCH 1/1] amfnd: Discard new assignment while su is under failover [#2773]

2018-02-07 Thread Ravi Sekhar Reddy Konda
Hi Minh, Ack, code review only Thanks, Ravi -Original Message- From: Minh Chau [mailto:minh.c...@dektech.com.au] Sent: Tuesday, February 06, 2018 11:45 AM To: hans.nordeb...@ericsson.com; gary@dektech.com.au; ravisekhar.ko...@oracle.com Cc: opensaf-devel@lists.sourceforge.net;

Re: [devel] [PATCH 0/5] Review Request for Add support for split brain prevention V2 [#64]

2018-01-26 Thread Ravi Sekhar Reddy Konda
:26 PM To: Ravi Sekhar Reddy Konda <ravisekhar.ko...@oracle.com> Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [devel] [PATCH 0/5] Review Request for Add support for split brain prevention V2 [#64] Hi Ravi The test cases are basically from Anders' design proposal. Eg. - election c

Re: [devel] [PATCH 1/1] imm: fix wrong printouts and incorrect behavior of immadm/immcfg [#2751]

2018-01-24 Thread Ravi Sekhar Reddy Konda
Hi Vu, Ack for the patch Regards, Ravi -Original Message- From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] Sent: Wednesday, January 24, 2018 7:32 PM To: zoran.milinko...@ericsson.com; ravisekhar.ko...@oracle.com Cc: opensaf-devel@lists.sourceforge.net; Vu Minh Nguyen

Re: [devel] [PATCH 0/6] Review Request for dtm: Derive Node ID from IPv4 address [#2758]

2018-01-19 Thread Ravi Sekhar Reddy Konda
ing them as config values, but better to define them in #defines Thanks, Ravi -Original Message- From: Anders Widell [mailto:anders.wid...@ericsson.com] Sent: Friday, January 12, 2018 5:54 PM To: Ravi Sekhar Reddy Konda <ravisekhar.ko...@oracle.com> Cc: opensaf-devel@lists.sourcefor

Re: [devel] [PATCH 1/1] imm: immnd asserts at veterans due to mismatched data during sync [#2748]

2018-01-15 Thread Ravi Sekhar Reddy Konda
Hi Vu, Ack, code review only Thanks, Ravi -Original Message- From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] Sent: Tuesday, January 09, 2018 6:54 PM To: ravisekhar.ko...@oracle.com; zoran.milinko...@ericsson.com Cc: opensaf-devel@lists.sourceforge.net; Vu Minh Nguyen

Re: [devel] [PATCH 1/1] amfd: Avoid IMM reinitialization in OpenSAF components termination phase V2 [#2737]

2018-01-04 Thread Ravi Sekhar Reddy Konda
Hi Minh, Ack for the patch Regards, Ravi -Original Message- From: Minh Chau [mailto:minh.c...@dektech.com.au] Sent: Friday, December 29, 2017 2:02 PM To: hans.nordeb...@ericsson.com; ravisekhar.ko...@oracle.com; gary@dektech.com.au Cc: opensaf-devel@lists.sourceforge.net; Minh

Re: [devel] [PATCH 1/1] amfd: Avoid IMM reinitialization in OpenSAF components termination phase V2 [#2737]

2018-01-04 Thread Ravi Sekhar Reddy Konda
Hi Minh, Started reviewing, will get back to you by tomorrow Regards, Ravi -Original Message- From: Minh Hon Chau [mailto:minh.c...@dektech.com.au] Sent: Thursday, January 04, 2018 4:27 PM To: hans.nordeb...@ericsson.com; Ravi Sekhar Reddy Konda <ravisekhar.ko...@oracle.com>

Re: [devel] [PATCH 1/1] fmd: convert to C++ [#2750]

2018-01-04 Thread Ravi Sekhar Reddy Konda
Hi Gary, Ack (Code review only) Regards, Ravi -Original Message- From: Gary Lee [mailto:gary@dektech.com.au] Sent: Thursday, December 28, 2017 2:12 PM To: ravisekhar.ko...@oracle.com; anders.wid...@ericsson.com Cc: opensaf-devel@lists.sourceforge.net; Gary Lee

Re: [devel] [PATCH 1/1] imm: fix IMMND assert at veteran nodes during SYNC [#2748]

2018-01-03 Thread Ravi Sekhar Reddy Konda
Hi Vu, Ack with minor comments inline I have not tested as I am not able to reproduce the scenario Thanks, Ravi - Original Message - From: vu.m.ngu...@dektech.com.au To: ravisekhar.ko...@oracle.com, zoran.milinko...@ericsson.com Cc: opensaf-devel@lists.sourceforge.net,

Re: [devel] [PATCH 1/1] amfd: Change LOG_ER to LOG_WA if nodeid is not found in node shutting down [#2737]

2017-12-27 Thread Ravi Sekhar Reddy Konda
Hi Minh, I think its better to notify using LOG_NO, instead of just log warning and return. Because its not only during Shutting Down, this routine is being called in many flows Thanks, Ravi -Original Message- From: Minh Chau [mailto:minh.c...@dektech.com.au] Sent: Thursday,

Re: [devel] [PATCH 1/1] amfd: Avoid IMM reinitialization in OpenSAF components termination phase [#2737]

2017-12-20 Thread Ravi Sekhar Reddy Konda
Ack, reviewed & tested Regards, Ravi -Original Message- From: Minh Chau [mailto:minh.c...@dektech.com.au] Sent: Tuesday, December 19, 2017 7:39 AM To: hans.nordeb...@ericsson.com; ravisekhar.ko...@oracle.com; gary@dektech.com.au Cc: opensaf-devel@lists.sourceforge.net; Minh Chau

Re: [devel] [PATCH 1/1] clmd: add dynamically created EEs to PLM entity group on standby [#2730]

2017-12-12 Thread Ravi Sekhar Reddy Konda
Hi Alex, Ack, Code review only Regards, RAvi -Original Message- From: Alex Jones [mailto:alex.jo...@genband.com] Sent: Wednesday, December 06, 2017 10:45 PM To: anders.wid...@ericsson.com; hans.nordeb...@ericsson.com; mathi.np@gmail.com; Ravi Sekhar Reddy Konda <ravisekhar

Re: [devel] [PATCH 1/1] clmd: add dynamically created EEs to PLM entity group on standby [#2730]

2017-12-11 Thread Ravi Sekhar Reddy Konda
HI Alex,   sorry for the delay, will review today and let you know   Thanks, Ravi From: Alex Jones [mailto:alex.jo...@genband.com] Sent: Monday, December 11, 2017 9:01 PM To: Anders Widell <anders.wid...@ericsson.com>; hans.nordeb...@ericsson.com; mathi.np@gmail.com; Ravi Sekhar

Re: [devel] [PATCH 1/1] dtm: Support pretty-printing OpenSAF logs using the osaflog command [#2709]

2017-12-10 Thread Ravi Sekhar Reddy Konda
Hi Anders, Ack, Code review only Regards, Ravi -Original Message- From: Anders Widell [mailto:anders.wid...@ericsson.com] Sent: Friday, December 01, 2017 3:26 PM To: Ravi Sekhar Reddy Konda <ravisekhar.ko...@oracle.com> Cc: opensaf-devel@lists.sourceforge.net; Anders

Re: [devel] [PATCH 1/1] plmd: fix mbc in PLM [#2724]

2017-12-03 Thread Ravi Sekhar Reddy Konda
Hi Alex, Ack, reviewed & tested Thanks, Ravi - Original Message - From: alex.jo...@genband.com To: mathi.np@gmail.com, ravisekhar.ko...@oracle.com Cc: opensaf-devel@lists.sourceforge.net, alex.jo...@genband.com Sent: Saturday, December 2, 2017 1:17:54 AM GMT +05:30 Chennai, Kolkata,

Re: [devel] [PATCH 1/1] plm: setup immutil wrapper profile [#2708]

2017-11-28 Thread Ravi Sekhar Reddy Konda
Hi Alex, Ack, Code review only Regards, Ravi - Original Message - From: alex.jo...@genband.com To: mathi.np@gmail.com, ravisekhar.ko...@oracle.com Cc: opensaf-devel@lists.sourceforge.net, alex.jo...@genband.com Sent: Tuesday, November 28, 2017 10:34:48 PM GMT +05:30 Chennai, Kolkata,

Re: [devel] [PATCH 1/1] clm: WA Two active controllers observed at cluster [#2677]

2017-11-15 Thread Ravi Sekhar Reddy Konda
Hi Hans, Ack, reviewed and tested Thanks, Ravi -Original Message- From: Hans Nordeback [mailto:hans.nordeb...@ericsson.com] Sent: Friday, November 10, 2017 1:59 PM To: anders.wid...@ericsson.com; Ravi Sekhar Reddy Konda <ravisekhar.ko...@oracle.com> Cc: opensaf

Re: [devel] [PATCH 1/1] plm: terminate child EEs when parent is terminated [#2572]

2017-11-12 Thread Ravi Sekhar Reddy Konda
s existing code only, as you are modifying its better to correct it. Thanks, Ravi -Original Message- From: Alex Jones [mailto:alex.jo...@genband.com] Sent: Friday, November 10, 2017 7:55 PM To: mathi.np....@gmail.com; Ravi Sekhar Reddy Konda <ravisekhar.ko...@oracle.com> Cc: opensaf-d

Re: [devel] [PATCH 1/1] amfnd: Return TRY_AGAIN for pg track start/stop during headless sync [#2660]

2017-11-05 Thread Ravi Sekhar Reddy Konda
Hi Minh, Ack, Reviewed & Tested. Regards, Ravi -Original Message- From: Minh Chau [mailto:minh.c...@dektech.com.au] Sent: Monday, November 06, 2017 8:15 AM To: hans.nordeb...@ericsson.com; ravisekhar.ko...@oracle.com; gary@dektech.com.au Cc: opensaf-devel@lists.sourceforge.net;

Re: [devel] [PATCH 1/1] amfd: Add retry mechanism for ClmTrackStart/Stop as job queue V2 [#2631]

2017-11-03 Thread Ravi Sekhar Reddy Konda
Hi Minh, Ack, reviewed and tested Thanks, Ravi -Original Message- From: Minh Chau [mailto:minh.c...@dektech.com.au] Sent: Friday, November 03, 2017 12:28 PM To: hans.nordeb...@ericsson.com; ravisekhar.ko...@oracle.com; gary@dektech.com.au Cc: opensaf-devel@lists.sourceforge.net;

Re: [devel] [PATCH 1/1] amfnd: do not refresh opensaf components [#2627]

2017-11-03 Thread Ravi Sekhar Reddy Konda
Hi Gary, Ack for the patch Thanks, Ravi -Original Message- From: Gary Lee [mailto:gary@dektech.com.au] Sent: Wednesday, October 25, 2017 12:22 PM To: Ravi Sekhar Reddy Konda <ravisekhar.ko...@oracle.com>; Hans Nordeback <hans.nordeb...@ericsson.com>; Minh Hon

Re: [devel] [PATCH 1/1] amfd: Add retry mechanism for ClmTrackStart/Stop as job queue [#2631]

2017-10-31 Thread Ravi Sekhar Reddy Konda
Hi Minh, I am fine with the patch, but have couple of queries, please see my comments inline Regards, Ravi -Original Message- From: Minh Chau [mailto:minh.c...@dektech.com.au] Sent: Friday, October 20, 2017 4:06 AM To: hans.nordeb...@ericsson.com; ravisekhar.ko...@oracle.com;

Re: [devel] [PATCH 1/1] amfnd: fix segv in ncs_tmr_stop V2 [#2658]

2017-10-30 Thread Ravi Sekhar Reddy Konda
Hi Hans, Ack (Code review only) Regards, Ravi - Original Message - From: hans.nordeb...@ericsson.com To: gary@dektech.com.au, ravisekhar.ko...@oracle.com Cc: opensaf-devel@lists.sourceforge.net, hans.nordeb...@ericsson.com Sent: Monday, October 30, 2017 8:27:49 PM GMT +05:30 Chennai,

Re: [devel] [PATCH 1/1] amf: Buffer and resend data req messages in Headless state [#2601]

2017-10-25 Thread Ravi Sekhar Reddy Konda
ype of > information is sync’ed with AVSV_N2D_ND_CSICOMP_STATE_INFO_MSG and > AVSV_N2D_ND_SISU_STATE_INFO_MSG. > > Thanks > Gary > > On 24/10/17, 11:14 pm, "Ravi Sekhar Reddy Konda" > <ravisekhar.ko...@oracle.com> wrote: > > Hi Gary, >

Re: [devel] [PATCH 1/1] amf: Buffer and resend data req messages in Headless state [#2601]

2017-10-24 Thread Ravi Sekhar Reddy Konda
Hi Gary, There are some messages which does not required to be queued like PG_TRACK & NODE_DOWN messages During SC absence period, we are returning SA_AMF_ERROR_TRY_AGAIN for PG Track operations Currently along with this Fix we are queuing the following messages

Re: [devel] [PATCH 1/1] amfnd: store pid before sending event [#2650]

2017-10-23 Thread Ravi Sekhar Reddy Konda
Ack ( Code review only) Regards, Ravi -Original Message- From: Gary Lee [mailto:gary@dektech.com.au] Sent: Monday, October 23, 2017 8:48 AM To: hans.nordeb...@ericsson.com; minh.c...@dektech.com.au; ravisekhar.ko...@oracle.com Cc: opensaf-devel@lists.sourceforge.net; Gary Lee

[devel] CLM issue #2088 not oserved now

2017-10-20 Thread Ravi Sekhar Reddy Konda
Hi Mathi & Anders, Regarding CLM issue #2088 "saClmClusterNodeGetAsync returns OK on a non member node" I am not observing this issue now here is the tests performed On two node systems Locked the CLM Node SC-2 and then invoked the async API returns ERR_UNAVAILABLE root@SC-2:~# clmprint

Re: [devel] develop branch build is failing

2017-10-20 Thread Ravi Sekhar Reddy Konda
Hi All, Its building fine after doing make uninstall and then make I think its problem with old .so Thanks, Ravi - Original Message - From: ravisekhar.ko...@oracle.com To: opensaf-devel@lists.sourceforge.net Sent: Friday, October 20, 2017 2:03:17 PM GMT +05:30 Chennai, Kolkata, Mumbai,

[devel] develop branch build is failing

2017-10-20 Thread Ravi Sekhar Reddy Konda
Hi All, Make is failing with following error CCLD bin/immadm /usr/local/lib/opensaf/libimm_common.so.0: undefined reference to `_logtrace_trace' /usr/local/lib/opensaf/libimm_common.so.0: undefined reference to `_logtrace_log' collect2: error: ld returned 1 exit status make[2]: ***

[devel] develop branch build is failing

2017-10-20 Thread Ravi Sekhar Reddy Konda
Hi All, Make is failing with following error commit 1c58a2106a55ad212a8e296424b1f20508eeb9cd Author: Lennart Lund Date: Thu Oct 19 15:17:27 2017 +0200 -- Check out the vibrant tech

Re: [devel] [PATCH 2/2] amf: improve error checking and display [#2628]

2017-10-17 Thread Ravi Sekhar Reddy Konda
Ack, Code review only Thanks, RAvi -Original Message- From: Gary Lee [mailto:gary@dektech.com.au] Sent: Tuesday, October 17, 2017 12:44 PM To: hans.nordeb...@ericsson.com; ravisekhar.ko...@oracle.com; minh.c...@dektech.com.au Cc: opensaf-devel@lists.sourceforge.net; Gary Lee

Re: [devel] [PATCH 1/1] amf: Allow SI and SI Dependency object to be deleted in same ccb [#2585]

2017-10-10 Thread Ravi Sekhar Reddy Konda
Hi Minh, Ack for the patch as well AMF PR doc update Thanks, Ravi -Original Message- From: Minh Chau [mailto:minh.c...@dektech.com.au] Sent: Thursday, September 28, 2017 6:24 PM To: hans.nordeb...@ericsson.com; gary@dektech.com.au; praveen.malv...@oracle.com;

Re: [devel] [PATCH 1/1] amfd: remove node_up variable from AVD_AVND [#2595]

2017-09-28 Thread Ravi Sekhar Reddy Konda
Ack, Code review only Thanks, Ravi - Original Message - From: gary@dektech.com.au To: hans.nordeb...@ericsson.com, minh.c...@dektech.com.au, ravisekhar.ko...@oracle.com, praveen.malv...@oracle.com Cc: opensaf-devel@lists.sourceforge.net, gary@dektech.com.au Sent: Wednesday,

Re: [devel] [PATCH 1/1] amfd: choose unlocked instantiable SU for instantiation [#2462]

2017-09-25 Thread Ravi Sekhar Reddy Konda
Hi Minh, Addressed your comments, please find the attached patch(this is on top of the original patch). If you are fine, I will push the patch Thanks, Ravi - Original Message - From: minh.c...@dektech.com.au To: ravi.sek...@oracle.com, hans.nordeb...@ericsson.com,

Re: [devel] [PATCH 1/1] amf: Fix amf_demo program compilation error [#2578]

2017-09-12 Thread Ravi Sekhar Reddy Konda
Hi Hans, Ack Regards, Ravi - Original Message - From: hans.nordeb...@ericsson.com To: gary@dektech.com.au, ravisekhar.ko...@oracle.com Cc: opensaf-devel@lists.sourceforge.net, hans.nordeb...@ericsson.com Sent: Friday, September 8, 2017 6:23:28 PM GMT +05:30 Chennai, Kolkata, Mumbai,