Re: [devel] [PATCH 1/1] log: fix cppcheck, cpplint and reorganize headers - part 1 [#2445]

2017-08-09 Thread Vu Minh Nguyen
Hi Canh, Ack with comments, with [Vu]. Regards, Vu > -Original Message- > From: Canh Van Truong [mailto:canh.v.tru...@dektech.com.au] > Sent: Thursday, July 20, 2017 1:31 PM > To: lennart.l...@ericsson.com; vu.m.ngu...@dektech.com.au; > mahesh.va...@oracle.com > Cc:

Re: [devel] [PATCH 1/1] log: fix cppcheck, cpplint and reorganize headers - part 1 [#2445]

2017-08-08 Thread A V Mahesh
Hi Canh Van, ACK, with Same comment as Lennart: Change `SaAisErrorT om_rc` similar in `static void read_logsv_config_obj_2()` , as you already did in `static SaAisErrorT amf_quiescing_state_handler()` in this patch it self.