Re: [devel] [PATCH 1 of 1] imm:allow augumentCcbInit with ROF as false in completed callback[#1956] V2

Hi Neel, I agree with your comments. Please send new patch for review since there are many fixes. Thanks, Hung Nguyen - DEK Technologies From: Neelakanta Reddy reddy.neelaka...@oracle.com Sent: Thursday, December

Re: [devel] [PATCH 1 of 1] imm:allow augumentCcbInit with ROF as false in completed callback[#1956] V2

Hi Hung, comments inline. On 2016/12/01 03:07 PM, Hung Nguyen wrote: > Hi Neel, > > Besides Zoran's comment, I have 2 more comments inline. > > BR, > Hung Nguyen - DEK Technologies > > > From: Neelakanta

Re: [devel] [PATCH 1 of 1] imm:allow augumentCcbInit with ROF as false in completed callback[#1956] V2

Hi Neel, Besides Zoran's comment, I have 2 more comments inline. BR, Hung Nguyen - DEK Technologies From: Neelakanta Reddy reddy.neelaka...@oracle.com Sent: Wednesday, November 30, 2016 12:39PM To: Zoran

Re: [devel] [PATCH 1 of 1] imm:allow augumentCcbInit with ROF as false in completed callback[#1956] V2

Hi Neelakanta, Ack from me when the code is fixed. Thanks, Zoran From: Neelakanta Reddy [mailto:reddy.neelaka...@oracle.com] Sent: den 1 december 2016 10:35 To: Zoran Milinkovic ; Hung Duc Nguyen Cc:

Re: [devel] [PATCH 1 of 1] imm:allow augumentCcbInit with ROF as false in completed callback[#1956] V2

Hi zoran, Yes, the code needs to be corrected for IMMA_CALLBACK_OI_CCB_COMPLETED. Thanks, Neel. On 2016/12/01 02:42 PM, Zoran Milinkovic wrote: > > Hi Hung, > > Then the code needs to be fixed, and objectName variable can remain in > the code. > > Otherwise I don’t see the purpose of the

Re: [devel] [PATCH 1 of 1] imm:allow augumentCcbInit with ROF as false in completed callback[#1956] V2

Hi Hung, Then the code needs to be fixed, and objectName variable can remain in the code. Otherwise I don't see the purpose of the variable. Thanks, Zoran From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au] Sent: den 1 december 2016 10:04 To: Zoran Milinkovic

Re: [devel] [PATCH 1 of 1] imm:allow augumentCcbInit with ROF as false in completed callback[#1956] V2

Hi Zoran, It's still needed, Neel just forgot to pass the 'object' param to immsv_om_augment_ccb_get_admo_name() when it's IMMA_CALLBACK_OI_CCB_COMPLETED. 'cbi->name' is not set (not usable) when it's a CcbCompletedCallback and we have to use 'object' param instead. BR, Hung Nguyen - DEK

Re: [devel] [PATCH 1 of 1] imm:allow augumentCcbInit with ROF as false in completed callback[#1956] V2

Hi Neelakanta, I still don't see where you use the new objectName variable. The only place where the variable is used is: + if((cbi->type == IMMA_CALLBACK_OI_CCB_CREATE)|| ((cbi->type == IMMA_CALLBACK_OI_CCB_COMPLETED) && +

Re: [devel] [PATCH 1 of 1] imm:allow augumentCcbInit with ROF as false in completed callback[#1956] V2

Hi Neelakanta, The new objectName variable is not used in the code. I would rather like to see adminOwnerName as some sort of string type than using SaNameT. This is not an issue in the patch, only the suggestion. The reason for this is to try to avoid using SaNameT type as much as possible,