Summary: dtm: Re-try binding to handle IPv6 DAD race condition [#2596]
Review request for Ticket(s): 2596
Peer Reviewer(s): Hans
Pull request to:
Affected branch(es): develop
Development branch: ticket-2596
Base revision: 808c8d4df92958b95169ab0d30b5d074b1fbf9f0
Personal repository: git://git.code.sf.net/u/anders-w/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services y
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
revision 53b428f3fe263d8a82d08f86d1253b59691bd97e
Author: Anders Widell <anders.wid...@ericsson.com>
Date: Thu, 1 Feb 2018 10:47:16 +0100
dtm: Re-try binding to handle IPv6 DAD race condition [#2596]
When using IPv6, we must re-try bind() to handle the potential IPv6 DAD
(duplicate address detection) race condition.
After an IPv6 address has been added to an interface, there will be a short
period when the address is considered tentative and bind() will fail with
EADDRNOTAVAIL.
This commit also fixes a race in between the creation of the TCP listening
socket and the node discovery broadcast, by moving the socket creation to the
main thread.
Added Files:
------------
src/base/osaf_socket.c
src/base/osaf_socket.h
Complete diffstat:
------------------
src/base/Makefile.am | 2 ++
src/base/osaf_socket.c | 37 ++++++++++++++++++++++++++
src/base/osaf_socket.h | 55 +++++++++++++++++++++++++++++++++++++++
src/dtm/dtmnd/dtm_main.cc | 8 ++++++
src/dtm/dtmnd/dtm_node.cc | 8 ------
src/dtm/dtmnd/dtm_node_sockets.cc | 5 ++--
src/dtm/dtmnd/multicast.cc | 10 ++++---
7 files changed, 111 insertions(+), 14 deletions(-)
Testing Commands:
-----------------
Start OpenSAF in with TCP transport and IPv6 addresses.
Testing, Expected Results:
--------------------------
OpenSAF shall start successfully.
Conditions of Submission:
-------------------------
Ack from reviewer(s)
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
