Summary: utils: Use a fence daemon as an alternative to payload reboot fencing
[#3048]
Review request for Ticket(s): 3048
Peer Reviewer(s): Duc, Gary, Anders
Pull request to:
Affected branch(es): develop
Development branch: ticket-3048
Base revision: 3895c7a88bdb3c6f86da1083ea0fd9e2cd642d01
Personal repository: git://git.code.sf.net/u/hansnordeback/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services n
Core libraries n
Samples n
Tests n
Other y
NOTE: Patch(es) contain lines longer than 80 characers
Comments (indicate scope for each "y" above):
---------------------------------------------
revision 810b5dc5ce2f1e8830c157b09f2649e47a8ea070
Author: Hans Nordeback <hans.nordeb...@ericsson.com>
Date: Wed, 5 Jun 2019 10:22:30 +0200
utils: Use a fence daemon as an alternative to payload reboot fencing [#3048]
Added Files:
------------
src/fm/fmd/tipc_server.cc
src/fm/fmd/tipc_server.h
tools/devel/fenced/command.cc
tools/devel/fenced/command.h
tools/devel/fenced/cpp_macros.h
tools/devel/fenced/fenced.conf
tools/devel/fenced/fenced_main.cc
tools/devel/fenced/Makefile
tools/devel/fenced/node_state_file.cc
tools/devel/fenced/node_state_file.h
tools/devel/fenced/node_state_hdlr.cc
tools/devel/fenced/node_state_hdlr_factory.cc
tools/devel/fenced/node_state_hdlr_factory.h
tools/devel/fenced/node_state_hdlr.h
tools/devel/fenced/node_state_hdlr_pl.cc
tools/devel/fenced/node_state_hdlr_pl.h
tools/devel/fenced/node_state_hdlr_sc.cc
tools/devel/fenced/node_state_hdlr_sc.h
tools/devel/fenced/osaffenced.service
tools/devel/fenced/README_TOOLS
tools/devel/fenced/service.cc
tools/devel/fenced/service.h
tools/devel/fenced/timer.cc
tools/devel/fenced/timer.h
tools/devel/fenced/watchdog.cc
tools/devel/fenced/watchdog.h
Complete diffstat:
------------------
src/fm/Makefile.am | 6 +-
src/fm/fmd/fm_amf.cc | 14 ++
src/fm/fmd/tipc_server.cc | 93 ++++++++
src/fm/fmd/tipc_server.h | 45 ++++
tools/devel/fenced/Makefile | 63 ++++++
tools/devel/fenced/README_TOOLS | 15 ++
tools/devel/fenced/command.cc | 134 ++++++++++++
tools/devel/fenced/command.h | 43 ++++
tools/devel/fenced/cpp_macros.h | 33 +++
tools/devel/fenced/fenced.conf | 17 ++
tools/devel/fenced/fenced_main.cc | 179 ++++++++++++++++
tools/devel/fenced/node_state_file.cc | 87 ++++++++
tools/devel/fenced/node_state_file.h | 41 ++++
tools/devel/fenced/node_state_hdlr.cc | 54 +++++
tools/devel/fenced/node_state_hdlr.h | 45 ++++
tools/devel/fenced/node_state_hdlr_factory.cc | 66 ++++++
tools/devel/fenced/node_state_hdlr_factory.h | 35 +++
tools/devel/fenced/node_state_hdlr_pl.cc | 292 ++++++++++++++++++++++++++
tools/devel/fenced/node_state_hdlr_pl.h | 60 ++++++
tools/devel/fenced/node_state_hdlr_sc.cc | 42 ++++
tools/devel/fenced/node_state_hdlr_sc.h | 41 ++++
tools/devel/fenced/osaffenced.service | 14 ++
tools/devel/fenced/service.cc | 53 +++++
tools/devel/fenced/service.h | 42 ++++
tools/devel/fenced/timer.cc | 62 ++++++
tools/devel/fenced/timer.h | 53 +++++
tools/devel/fenced/watchdog.cc | 37 ++++
tools/devel/fenced/watchdog.h | 39 ++++
28 files changed, 1703 insertions(+), 2 deletions(-)
Testing Commands:
-----------------
At tools/devel/fenced run make ; make install to build and install fenced on a
payload.
enable 'headless' via enabling export IMMSV_SC_ABSENCE_ALLOWED=900 in immd.conf.
osaffenced on the payload will stop opensaf if the node becomes 'isolated',
i.e. no active SC.
opensaf will be started by osaffenced when the node is 'not isolated', i.e.
active SC.
A file will also be dropped to 'expose' the node isolated/not isolated state.
Testing, Expected Results:
--------------------------
*** PASTE COMMAND OUTPUTS / TEST RESULTS ***
Conditions of Submission:
-------------------------
*** HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC ***
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
