Re: [devel] [PATCH 0 of 1] Review Request for smf: retry of ccb operations when failed with resouce abort[#2389]
ACK, tested. Had some issues but they were unrelated. On 03/21/2017 01:36 PM, reddy.neelaka...@oracle.com wrote: > Summary:smf: retry of ccb operations when failed with resouce abort[#2389] > Review request for Trac Ticket(s): 2389 > Peer Reviewer(s): Rafael, Leenart > Affected branch(es): 5.0.x, 5.1.x,default > Development branch: defult > > > Impacted area Impact y/n > > Docsn > Build systemn > RPM/packaging n > Configuration files n > Startup scripts n > SAF servicesy > OpenSAF servicesn > Core libraries n > Samples n > Tests n > Other n > > > Comments (indicate scope for each "y" above): > - > > changeset 6ffd3463b3f705e334e39ce8584006c7811f37f1 > Author: Neelakanta Reddy> Date: Tue, 21 Mar 2017 18:00:36 +0530 > > smf: retry of ccb operations when failed with resouce abort[#2389] > > > Complete diffstat: > -- > src/smf/smfd/SmfImmOperation.cc| 37 > - > src/smf/smfd/SmfUpgradeCampaign.cc | 3 +-- > src/smf/smfd/SmfUtils.cc | 17 - > 3 files changed, 53 insertions(+), 4 deletions(-) > > > Testing Commands: > - > when the SMF upgrade is running, kill the IMMND in any node of the cluster > which will lead to sync and aborts the ccb > > Testing, Expected Results: > -- > SMF should TRY_AGAIN the ccb operation, if the ccb operation > is failed/aborted with RESOUCE ABORT > > Conditions of Submission: > - > Ack from reviewers > > Arch Built StartedLinux distro > --- > mipsn n > mips64 n n > x86 n n > x86_64 y y > powerpc n n > powerpc64 n n > > > Reviewer Checklist: > --- > [Submitters: make sure that your review doesn't trigger any checkmarks!] > > > Your checkin has not passed review because (see checked entries): > > ___ Your RR template is generally incomplete; it has too many blank entries > that need proper data filled in. > > ___ You have failed to nominate the proper persons for review and push. > > ___ Your patches do not have proper short+long header > > ___ You have grammar/spelling in your header that is unacceptable. > > ___ You have exceeded a sensible line length in your headers/comments/text. > > ___ You have failed to put in a proper Trac Ticket # into your commits. > > ___ You have incorrectly put/left internal data in your comments/files > (i.e. internal bug tracking tool IDs, product names etc) > > ___ You have not given any evidence of testing beyond basic build tests. > Demonstrate some level of runtime or other sanity testing. > > ___ You have ^M present in some of your files. These have to be removed. > > ___ You have needlessly changed whitespace or added whitespace crimes > like trailing spaces, or spaces before tabs. > > ___ You have mixed real technical changes with whitespace and other > cosmetic code cleanup changes. These have to be separate commits. > > ___ You need to refactor your submission into logical chunks; there is > too much content into a single commit. > > ___ You have extraneous garbage in your review (merge commits etc) > > ___ You have giant attachments which should never have been sent; > Instead you should place your content in a public tree to be pulled. > > ___ You have too many commits attached to an e-mail; resend as threaded > commits, or place in a public tree for a pull. > > ___ You have resent this content multiple times without a clear indication > of what has changed between each re-send. > > ___ You have failed to adequately and individually address all of the > comments and change requests that were proposed in the initial review. > > ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) > > ___ Your computer have a badly configured date and time; confusing the > the threaded patch review. > > ___ Your changes affect IPC mechanism, and you don't present any results > for in-service upgradability test. > > ___ Your changes affect user manual and documentation, your patch series > do not contain the patch that updates the Doxygen manual. > -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
Re: [devel] [PATCH 0 of 1] Review Request for smf: retry of ccb operations when failed with resouce abort[#2389]
ACK, not tested On 03/21/2017 01:36 PM, reddy.neelaka...@oracle.com wrote: > Summary:smf: retry of ccb operations when failed with resouce abort[#2389] > Review request for Trac Ticket(s): 2389 > Peer Reviewer(s): Rafael, Leenart > Affected branch(es): 5.0.x, 5.1.x,default > Development branch: defult > > > Impacted area Impact y/n > > Docsn > Build systemn > RPM/packaging n > Configuration files n > Startup scripts n > SAF servicesy > OpenSAF servicesn > Core libraries n > Samples n > Tests n > Other n > > > Comments (indicate scope for each "y" above): > - > > changeset 6ffd3463b3f705e334e39ce8584006c7811f37f1 > Author: Neelakanta Reddy> Date: Tue, 21 Mar 2017 18:00:36 +0530 > > smf: retry of ccb operations when failed with resouce abort[#2389] > > > Complete diffstat: > -- > src/smf/smfd/SmfImmOperation.cc| 37 > - > src/smf/smfd/SmfUpgradeCampaign.cc | 3 +-- > src/smf/smfd/SmfUtils.cc | 17 - > 3 files changed, 53 insertions(+), 4 deletions(-) > > > Testing Commands: > - > when the SMF upgrade is running, kill the IMMND in any node of the cluster > which will lead to sync and aborts the ccb > > Testing, Expected Results: > -- > SMF should TRY_AGAIN the ccb operation, if the ccb operation > is failed/aborted with RESOUCE ABORT > > Conditions of Submission: > - > Ack from reviewers > > Arch Built StartedLinux distro > --- > mipsn n > mips64 n n > x86 n n > x86_64 y y > powerpc n n > powerpc64 n n > > > Reviewer Checklist: > --- > [Submitters: make sure that your review doesn't trigger any checkmarks!] > > > Your checkin has not passed review because (see checked entries): > > ___ Your RR template is generally incomplete; it has too many blank entries > that need proper data filled in. > > ___ You have failed to nominate the proper persons for review and push. > > ___ Your patches do not have proper short+long header > > ___ You have grammar/spelling in your header that is unacceptable. > > ___ You have exceeded a sensible line length in your headers/comments/text. > > ___ You have failed to put in a proper Trac Ticket # into your commits. > > ___ You have incorrectly put/left internal data in your comments/files > (i.e. internal bug tracking tool IDs, product names etc) > > ___ You have not given any evidence of testing beyond basic build tests. > Demonstrate some level of runtime or other sanity testing. > > ___ You have ^M present in some of your files. These have to be removed. > > ___ You have needlessly changed whitespace or added whitespace crimes > like trailing spaces, or spaces before tabs. > > ___ You have mixed real technical changes with whitespace and other > cosmetic code cleanup changes. These have to be separate commits. > > ___ You need to refactor your submission into logical chunks; there is > too much content into a single commit. > > ___ You have extraneous garbage in your review (merge commits etc) > > ___ You have giant attachments which should never have been sent; > Instead you should place your content in a public tree to be pulled. > > ___ You have too many commits attached to an e-mail; resend as threaded > commits, or place in a public tree for a pull. > > ___ You have resent this content multiple times without a clear indication > of what has changed between each re-send. > > ___ You have failed to adequately and individually address all of the > comments and change requests that were proposed in the initial review. > > ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) > > ___ Your computer have a badly configured date and time; confusing the > the threaded patch review. > > ___ Your changes affect IPC mechanism, and you don't present any results > for in-service upgradability test. > > ___ Your changes affect user manual and documentation, your patch series > do not contain the patch that updates the Doxygen manual. > -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
[devel] [PATCH 0 of 1] Review Request for smf: retry of ccb operations when failed with resouce abort[#2389]
Summary:smf: retry of ccb operations when failed with resouce abort[#2389] Review request for Trac Ticket(s): 2389 Peer Reviewer(s): Rafael, Leenart Affected branch(es): 5.0.x, 5.1.x,default Development branch: defult Impacted area Impact y/n Docsn Build systemn RPM/packaging n Configuration files n Startup scripts n SAF servicesy OpenSAF servicesn Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): - changeset 6ffd3463b3f705e334e39ce8584006c7811f37f1 Author: Neelakanta ReddyDate: Tue, 21 Mar 2017 18:00:36 +0530 smf: retry of ccb operations when failed with resouce abort[#2389] Complete diffstat: -- src/smf/smfd/SmfImmOperation.cc| 37 - src/smf/smfd/SmfUpgradeCampaign.cc | 3 +-- src/smf/smfd/SmfUtils.cc | 17 - 3 files changed, 53 insertions(+), 4 deletions(-) Testing Commands: - when the SMF upgrade is running, kill the IMMND in any node of the cluster which will lead to sync and aborts the ccb Testing, Expected Results: -- SMF should TRY_AGAIN the ccb operation, if the ccb operation is failed/aborted with RESOUCE ABORT Conditions of Submission: - Ack from reviewers Arch Built StartedLinux distro --- mipsn n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: --- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel