Summary: Merge rolling to singlestep procedures for several nodes Review request for Trac Ticket(s): #1685 Peer Reviewer(s): lennart Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): <<LIST ALL AFFECTED BRANCH(ES)>> Development branch: <<IF ANY GIVE THE REPO URL>>
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services y Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- <<EXPLAIN/COMMENT THE PATCH SERIES HERE>> changeset 3850c8ad75dcb065cb6eddf94f50958fcce63e60 Author: Rafael Odzakow <rafael.odza...@ericsson.com> Date: Mon, 05 Sep 2016 09:47:53 +0200 smfd: Merge rolling to singlestep procedures for several nodes [#1685] Enables the balanced mode feature. This mode changes the execution of rolling procedures to be merged into one or several single steps that are spread out across the cluster nodes. This feature is used to give a faster upgrade time compared to rolling one node at a time, possibly several times for each node. By splittting the procedures it into several single steps across the nodes a total service outage can be avoided. changeset 9b8d7458afe23b3ad57a7552ac128ea519a57ace Author: Rafael Odzakow <rafael.odza...@ericsson.com> Date: Fri, 09 Sep 2016 15:27:39 +0200 fix segfault changeset a3b28459cdcbd62917cbb0d252cbaa086e475324 Author: Rafael Odzakow <rafael.odza...@ericsson.com> Date: Mon, 12 Sep 2016 00:13:06 +0200 uniqe actions and assert if controller in nodesForSingleStep Added Files: ------------ osaf/services/saf/smfsv/smfd/SmfExecControl.cc osaf/services/saf/smfsv/smfd/SmfExecControl.h osaf/services/saf/smfsv/smfd/SmfExecControlHdl.cc osaf/services/saf/smfsv/smfd/SmfExecControlHdl.h Complete diffstat: ------------------ osaf/services/saf/smfsv/config/smfsv_classes.xml | 1084 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------------------------------------------------------------------------------- osaf/services/saf/smfsv/smfd/Makefile.am | 8 +- osaf/services/saf/smfsv/smfd/SmfCampState.cc | 151 ++++-------------------- osaf/services/saf/smfsv/smfd/SmfCampaign.cc | 77 +++++++----- osaf/services/saf/smfsv/smfd/SmfCampaign.hh | 1 + osaf/services/saf/smfsv/smfd/SmfExecControl.cc | 334 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ osaf/services/saf/smfsv/smfd/SmfExecControl.h | 58 +++++++++ osaf/services/saf/smfsv/smfd/SmfExecControlHdl.cc | 506 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ osaf/services/saf/smfsv/smfd/SmfExecControlHdl.h | 126 ++++++++++++++++++++ osaf/services/saf/smfsv/smfd/SmfProcState.cc | 25 +++- osaf/services/saf/smfsv/smfd/SmfUpgradeCampaign.cc | 40 +++-- osaf/services/saf/smfsv/smfd/SmfUpgradeCampaign.hh | 35 ++--- osaf/services/saf/smfsv/smfd/SmfUpgradeProcedure.cc | 64 ++++++++-- osaf/services/saf/smfsv/smfd/SmfUpgradeProcedure.hh | 20 ++- osaf/services/saf/smfsv/smfd/SmfUpgradeStep.cc | 4 + osaf/services/saf/smfsv/smfd/SmfUpgradeStep.hh | 13 +- osaf/services/saf/smfsv/smfd/smfd.h | 2 +- osaf/services/saf/smfsv/smfd/smfd_campaign_oi.cc | 32 ----- osaf/services/saf/smfsv/smfd/smfd_cb.h | 5 - 19 files changed, 1792 insertions(+), 793 deletions(-) Testing Commands: ----------------- <<LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES>> Testing, Expected Results: -------------------------- <<PASTE COMMAND OUTPUTS / TEST RESULTS>> Conditions of Submission: ------------------------- <<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>> Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel