Summary: amfd: SI refactoring part 2 [#713]
Review request for Trac Ticket(s): 713
Peer Reviewer(s): AMF maintainers
Pull request to:
Affected branch(es): default
Development branch: default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
This is the 2nd set of patches for refactoring SI.
The majority of changes relate to conversion of static
functions to member functions of AVD_SI.
changeset f2fc5daa57a35215f3a3b7489acfcdb88748395d
Author: Gary Lee <gary....@dektech.com.au>
Date: Wed, 11 Jun 2014 15:19:19 +1000
amfd: Convert various SI static functions to class member functions
[#713]
Convert various increment and decrement static functions to class member
functions.
changeset e9fa0d9f2cda7a41768e5409625951f8b92d4065
Author: Gary Lee <gary....@dektech.com.au>
Date: Wed, 11 Jun 2014 15:19:27 +1000
amfd: Change avd_si_adjust_si_assignments to a member function [#713]
Make avd_si_adjust_si_assignments a class member function of AVD_SI
changeset aaa8b697076cf3c9c37f515c5ca1ae2ef6941cf3
Author: Gary Lee <gary....@dektech.com.au>
Date: Wed, 11 Jun 2014 15:19:31 +1000
amfd: Change si_update_ass_state() from a static to a member function
of SI
[#713]
changeset d5efa483f3685b6af807898112fdfd28b0ee828c
Author: Gary Lee <gary....@dektech.com.au>
Date: Wed, 11 Jun 2014 15:19:37 +1000
amfd: Remove unused function avd_si_remove_rankedsu() [#713]
Complete diffstat:
------------------
osaf/services/saf/amf/amfd/include/si.h | 18 ++++--
osaf/services/saf/amf/amfd/sgproc.cc | 2 +-
osaf/services/saf/amf/amfd/si.cc | 220
++++++++++++++++++++++++++++++++++++++++-------------------------------------------------
osaf/services/saf/amf/amfd/siass.cc | 22 ++++----
4 files changed, 121 insertions(+), 141 deletions(-)
Testing Commands:
-----------------
Testing, Expected Results:
--------------------------
Conditions of Submission:
-------------------------
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions
Find What Matters Most in Your Big Data with HPCC Systems
Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.
Leverages Graph Analysis for Fast Processing & Easy Data Exploration
http://p.sf.net/sfu/hpccsystems
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
