Re: [devel] [PATCH 1/1] imm: Allow stale clients to be discarded when going to headless [#2487]

Hi Hung Nguyen, Ok, ACK from me. -AVM On 6/15/2017 12:03 PM, Hung Nguyen wrote: Hi Mahesh, Stale clients are clients that are not discarded (yet) due to problem with sending messages to IMMD. In case of headless, we don't care about IMMD, we just want to get grid of all clients locally,

Re: [devel] [PATCH 1/1] imm: Allow stale clients to be discarded when going to headless [#2487]

Hi Mahesh, Stale clients are clients that are not discarded (yet) due to problem with sending messages to IMMD. In case of headless, we don't care about IMMD, we just want to get grid of all clients locally, so all clients should be considered*not stale *and the flag must be cleared. BR,

Re: [devel] [PATCH 1/1] imm: Allow stale clients to be discarded when going to headless [#2487]

Hi Hung, Thanks for the explaining , still didn't get the advantage of unset the mIsStale flag for headless case, can you please clarify below taged with [AVM] On 6/15/2017 10:03 AM, Hung Nguyen wrote: Hi Mahesh, In imma_discard_connection(), we mark the client as stale when having problem

Re: [devel] [PATCH 1/1] imm: Allow stale clients to be discarded when going to headless [#2487]

Hi Mahesh, In imma_discard_connection(), we mark the client as stale when having problem sending messages to IMMD. That happens when IMMD fails over or the cluster goes to headless. In case of failing over, when the new ACTIVE IMMD is available, imma_discard_stales() is invoked to clean up

Re: [devel] [PATCH 1/1] imm: Allow stale clients to be discarded when going to headless [#2487]

Hi Hung, Jut trying to syncup the ligic of unsets the mIsStale flag of the clients before immnd do invoking immnd_proc_imma_discard_connection() , immnd in multiple other cases also invoking immnd_proc_imma_discard_connection() for exaple immnd_proc_imma_down() as well, in addition to

Re: [devel] [PATCH 1/1] imm: Allow stale clients to be discarded when going to headless [#2487]

Hi Hung, Reviewed the code. Ack from me. Thanks, Zoran -Original Message- From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au] Sent: den 9 juni 2017 08:41 To: Zoran Milinkovic ; mahesh.va...@oracle.com Cc: opensaf-devel@lists.sourceforge.net; Hung Duc

[devel] [PATCH 1/1] imm: Allow stale clients to be discarded when going to headless [#2487]

Just like immnd_proc_imma_discard_stales(), in immnd_proc_discard_other_nodes() we should unset the mIsStale flag of the clients. So that the clients can be discarded. --- src/imm/immnd/immnd_proc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/imm/immnd/immnd_proc.c