Hi Canh,
Ack with minor comments.
Regards, Vu
> -Original Message-
> From: Canh Van Truong
> Sent: Friday, June 14, 2019 10:21 PM
> To: lennart.l...@ericsson.com; vu.m.ngu...@dektech.com.au
> Cc: opensaf-devel@lists.sourceforge.net; Canh Van Truong
>
> Subject: [PATCH 1/1] log: Delete
Hi Canh,
Ack with minor comments. See [Lennart] below.
Note: It is very important to also update the "OpenSAF_LOGSv_PR.odt" document
with the new admin operation
Thanks
Lennart
Från: Canh Van Truong
Skickat: den 14 juni 2019 14:20
Till: Lennart Lund; Vu Minh
Hi Canh
I have written some new comments below.
I have also taken a quick look at the patch you attached. It seems to contain
changes according to the discussion below and it seems to be correct. I have
not tested but the test cases seems to cover what's needed to test.
A detail that I have
Hi Canh
I think you can send the new version for review
Thanks
Lennart
From: Canh Van Truong
Sent: den 14 juni 2019 13:31
To: Lennart Lund ; Vu Minh Nguyen
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [PATCH 1/1] log: Delete the older file without closing current log
file via admin
Thanks Lennart
Please see my reply comments and the updated patch in attachment
Thanks
Canh
From: Lennart Lund
Sent: Thursday, June 13, 2019 11:02 PM
To: Canh Van Truong ; Vu Minh Nguyen
Cc: opensaf-devel@lists.sourceforge.net
Subject: Sv: [PATCH 1/1] log: Delete the older file
Hi Canh
Comments:
* The name of function lgs_admin_rotate_log_file() is misleading. If
numberOfFilesToRemove is given no file rotation is done.
* Also the name of function rotate_if_needed() is misleading. This function
can also be used to just remove the oldest file without rotation.
Improve the enhancement of ticket #3022, the user can rotate (delete) older log
files without closing current log file.
LOG add new parameter (numberOfFilesToRemove) to admin op command with id = 2.
- If parameter exists, LOGD remove number of older file base on parameter value
- If parameter
