Re: [devel] [PATCH 1/1] log: Handling of IMM OI BAD HANDLE in log server is incorrect [#2799]

Hi Canh, I will do a small change based on the comment before pushing. Also see my comment [Lennart] Thanks Lennart From: Canh Van Truong [mailto:canh.v.tru...@dektech.com.au] Sent: den 6 april 2018 08:29 To: Lennart Lund ; Vu Minh Nguyen

Re: [devel] [PATCH 1/1] log: Handling of IMM OI BAD HANDLE in log server is incorrect [#2799]

Hi Lennart, Ack with one comment [Canh] Thanks Canh -Original Message- From: Lennart Lund [mailto:lennart.l...@ericsson.com] Sent: Thursday, April 5, 2018 7:38 PM To: vu.m.ngu...@dektech.com.au; canh.v.tru...@dektech.com.au Cc: opensaf-devel@lists.sourceforge.net; Lennart

[devel] [PATCH 1/1] log: Handling of IMM OI BAD HANDLE in log server is incorrect [#2799]

Recovery of OI handle shall be started in all places where BAD HANDLE can be returned. Creation of OI must be done in background thread. Ongoing creation must be possible to stop e.g if server is becoming standby --- src/log/Makefile.am | 3 + src/log/logd/lgs.h | 24 ---

Re: [devel] [PATCH 1/1] log: Handling of IMM OI BAD HANDLE in log server is incorrect [#2799]

Hi Canh, A. +++ b/src/log/logd/lgs_config.cc @@ -1810,18 +1810,20 @@ void conf_runtime_obj_handler(SaImmOiHandleT immOiHandle, } else { TRACE("%s: unknown attribute %s", __FUNCTION__, attributeName); } +// [Canh] I see that you remove lgsOiCreateBackground() here in case

Re: [devel] [PATCH 1/1] log: Handling of IMM OI BAD HANDLE in log server is incorrect [#2799]

Hi Vu, See my comments/Answers below [Lennart] Thanks Lennart > -Original Message- > From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] > Sent: den 4 april 2018 12:10 > To: Lennart Lund ; Canh Van Truong > > Cc:

Re: [devel] [PATCH 1/1] log: Handling of IMM OI BAD HANDLE in log server is incorrect [#2799]

Hi Canh, See my comments below [Lennart] I have attached the fixes I have made for these comments Thanks Lennart From: Canh Van Truong [mailto:canh.v.tru...@dektech.com.au] Sent: den 4 april 2018 06:55 To: Lennart Lund ; Vu Minh Nguyen

Re: [devel] [PATCH 1/1] log: Handling of IMM OI BAD HANDLE in log server is incorrect [#2799]

Hi Lennart, Ack (code review only) with few comments inline, tagged [Vu] Regards, Vu > -Original Message- > From: Lennart Lund [mailto:lennart.l...@ericsson.com] > Sent: Tuesday, April 3, 2018 9:59 PM > To: vu.m.ngu...@dektech.com.au; canh.v.tru...@dektech.com.au > Cc:

Re: [devel] [PATCH 1/1] log: Handling of IMM OI BAD HANDLE in log server is incorrect [#2799]

Hi Lennart, + // [Canh] below function is just called when ais_rc is 'SA_AIS_ERR_NO_OP' (stop_oi_create) + // or 'SA_AIS_OK'. In case 'SA_AIS_ERR_NO_OP', this function should not be called, + // because the old oi_handle_ will be used to finalize in lgsOiStop() I think that this my comment is

Re: [devel] [PATCH 1/1] log: Handling of IMM OI BAD HANDLE in log server is incorrect [#2799]

Hi Lennart, Please see my comments with tag [Canh] Thanks Canh -Original Message- From: Lennart Lund [mailto:lennart.l...@ericsson.com] Sent: Tuesday, April 3, 2018 9:59 PM To: vu.m.ngu...@dektech.com.au; canh.v.tru...@dektech.com.au Cc: opensaf-devel@lists.sourceforge.net;

[devel] [PATCH 1/1] log: Handling of IMM OI BAD HANDLE in log server is incorrect [#2799]

Recovery of OI handle shall be started in all places where BAD HANDLE can be returned. Creation of OI must be done in background thread. Ongoing creation must be possible to stop e.g if server is becoming standby --- src/log/Makefile.am | 3 + src/log/logd/lgs.h | 24 ---

Re: [devel] [PATCH 1/1] log: Handling of IMM OI BAD HANDLE in log server is incorrect [#2799]

Hi Canh + // [Canh] How about the return of immutil_update_one_rattr() is BAD_HANDLE? + // There are many times that this function is called in lgs Yes, this is missing in conf_runtime_obj_handler() +// [Canh] Should not call 'lgsOiCreateBackground' here because this function

Re: [devel] [PATCH 1/1] log: Handling of IMM OI BAD HANDLE in log server is incorrect [#2799]

Hi Vu, See my comments/answers below [Lennart] Thanks Lennart > -Original Message- > From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] > Sent: den 30 mars 2018 10:27 > To: Lennart Lund ; Canh Van Truong > > Cc:

Re: [devel] [PATCH 1/1] log: Handling of IMM OI BAD HANDLE in log server is incorrect [#2799]

Hi Lennart, Please see my comments in attached file Thanks Canh -Original Message- From: Lennart Lund [mailto:lennart.l...@ericsson.com] Sent: Thursday, March 29, 2018 9:04 PM To: vu.m.ngu...@dektech.com.au; canh.v.tru...@dektech.com.au Cc: opensaf-devel@lists.sourceforge.net; Lennart

Re: [devel] [PATCH 1/1] log: Handling of IMM OI BAD HANDLE in log server is incorrect [#2799]

Hi Lennart, I have some comments: #1) If ` lgsOiStop` is called while the OI creation thread is running, there is possibility the OI implementer will not be cleared. Here is the sequence: 1) lgsOiStop() is called --> stop_oi_create = true 2) In OI creation thread, look at below code line: it

[devel] [PATCH 1/1] log: Handling of IMM OI BAD HANDLE in log server is incorrect [#2799]

Recovery of OI handle shall be started in all places where BAD HANDLE can be returned. Creation of OI must be done in background thread. Ongoing creation must be possible to stop e.g if server is becoming standby --- src/log/Makefile.am | 3 + src/log/logd/lgs.h | 24 ---

Re: [devel] [PATCH 1/1] log: Handling of IMM OI BAD HANDLE in log server is incorrect [#2799]

Hi Canh I have answered your comments. See attached patch. I have also done some reviewing myself and found some issues. I will submit a new review where all comments are handled including from Vu and myself Thanks Lennart > -Original Message- > From: Canh Van Truong

Re: [devel] [PATCH 1/1] log: Handling of IMM OI BAD HANDLE in log server is incorrect [#2799]

Hi Lennart, Please see my comments in the attached diff file. Thanks Canh -Original Message- From: Lennart Lund [mailto:lennart.l...@ericsson.com] Sent: Wednesday, March 28, 2018 9:34 PM To: vu.m.ngu...@dektech.com.au; canh.v.tru...@dektech.com.au Cc:

Re: [devel] [PATCH 1/1] log: Handling of IMM OI BAD HANDLE in log server is incorrect [#2799]

Hi Vu, Yes, you are right. I will fix this Thanks Lennart > -Original Message- > From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] > Sent: den 29 mars 2018 10:05 > To: Lennart Lund ; Canh Van Truong > > Cc:

Re: [devel] [PATCH 1/1] log: Handling of IMM OI BAD HANDLE in log server is incorrect [#2799]

Hi Lennart, I see you make `oiCreationThread_` as a joinable thread, it means `joinable()` always returns true until the thread has been joined (when switch-over). So, if LOGsv gets SA_AIS_BAD_HANDLE returned by IMM APIs second time, the recovery job will not be activated due to below

[devel] [PATCH 1/1] log: Handling of IMM OI BAD HANDLE in log server is incorrect [#2799]

Recovery of OI handle shall be started in all places where BAD HANDLE can be returned. Creation of OI must be done in background thread. Ongoing creation must be possible to stop e.g if server is becoming standby --- src/log/Makefile.am | 3 + src/log/logd/lgs.h | 24 ---