Re: [devel] [PATCH 1/1] smf: fix to avoid core dump during smf upgrade while imm sync [#2550]

2017-08-28 Thread A V Mahesh
Hi Vijay, ACK. This is better than previous patch by doing recycle of time wait , but this is not final solution, so you write an enhancement ticket to fix the issue with a solution like , smf (imm application) may get callback or notified by IMM/some-other-way  after completing  sync

[devel] [PATCH 1/1] smf: fix to avoid core dump during smf upgrade while imm sync [#2550]

2017-08-28 Thread Vijay Roy
--- src/smf/smfd/SmfUpgradeStep.cc | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/src/smf/smfd/SmfUpgradeStep.cc b/src/smf/smfd/SmfUpgradeStep.cc index 909fe12..ddd96a0 100644 --- a/src/smf/smfd/SmfUpgradeStep.cc +++ b/src/smf/smfd/SmfUpgradeStep.cc

Re: [devel] [PATCH 1/1] smf: fix to avoid core dump during smf upgrade while imm sync [#2550]

2017-08-24 Thread Lennart Lund
Hi Vijay, I agree that changing the behavior of SmfImmUtils::doImmOperations requires some more analyzing. A new ticket can be written for this. I suggest that you keep the new try again loop but change it to a timed loop and set the timeout time to one minute. Also introduce a delay time

Re: [devel] [PATCH 1/1] smf: fix to avoid core dump during smf upgrade while imm sync [#2550]

2017-08-24 Thread Vijay Roy
Hi Lennart & Zoran, As an quick/instant/work around fix can we offer the given solution to as FIX for #2550. Since refactoring the SmfImmUtils::doImmOperations is a behavioral change so that requires a through testing with all possible use cases and we better take this as future enhancement.

Re: [devel] [PATCH 1/1] smf: fix to avoid core dump during smf upgrade while imm sync [#2550]

2017-08-22 Thread Zoran Milinkovic
Hi, Loading and sync should be done in one minute. BR, Zoran -Original Message- From: Vijay Roy [mailto:vijay@oracle.com] Sent: den 22 augusti 2017 14:20 To: Lennart Lund ; Rafael Odzakow ; Reddy Neelakanta Reddy Peddavandla

Re: [devel] [PATCH 1/1] smf: fix to avoid core dump during smf upgrade while imm sync [#2550]

2017-08-21 Thread Lennart Lund
Hi Vijay When I look at the ticket I can see that the CCB is aborted (because IMM starts a synch). The actual return code from IMM is then SA_AIS_ERR_FAILED_OPERATION but in the case the failed operation is caused by a "resource abort" the return code is changed by the doImmOperations()

Re: [devel] [PATCH 1/1] smf: fix to avoid core dump during smf upgrade while imm sync [#2550]

2017-08-17 Thread A V Mahesh
On 8/18/2017 8:43 AM, A V Mahesh wrote: Hi Vijay Roy , If i have larger imm db to sync , you will end up with same problem again. One more point , if I have multiple node in queue waiting for sync , again you will end up with same problem . -AVM On 8/17/2017 5:34 PM, Vijay Roy wrote:

Re: [devel] [PATCH 1/1] smf: fix to avoid core dump during smf upgrade while imm sync [#2550]

2017-08-17 Thread A V Mahesh
Hi Vijay Roy , If i have larger imm db to sync , you will end up with same problem again. -AVM On 8/17/2017 5:34 PM, Vijay Roy wrote: --- src/smf/smfd/SmfUpgradeStep.cc | 31 +++ 1 file changed, 27 insertions(+), 4 deletions(-) diff --git

Re: [devel] [PATCH 1/1] smf: fix to avoid core dump during smf upgrade while imm sync [#2550]

2017-08-17 Thread Anders Widell
Hi! Just some minor style-related comments: 1) Please don't add code comments referring to SourceForge (or other) tickets. 2) Please check that the indentation conforms to the coding style (see the OpenSAF wiki). You can also get sample configurations for Emacs, Eclipse and NetBeans from

[devel] [PATCH 1/1] smf: fix to avoid core dump during smf upgrade while imm sync [#2550]

2017-08-17 Thread Vijay Roy
--- src/smf/smfd/SmfUpgradeStep.cc | 31 +++ 1 file changed, 27 insertions(+), 4 deletions(-) diff --git a/src/smf/smfd/SmfUpgradeStep.cc b/src/smf/smfd/SmfUpgradeStep.cc index 909fe12..ebf94ca 100644 --- a/src/smf/smfd/SmfUpgradeStep.cc +++