Re: [devel] [PATCH 1 of 1] amfd: Invalid read when deleting a node from a node group [#719]

2014-01-15 Thread Hans Feldt
Hi, Although the change is trivial I have some comments: - the commit message, it should start off with a verb and describe what the patch is doing e.g. in this case: "amfd: fix out-of-bounds read from nodelist array [#719]" - It seems like the logic in ng_ccb_apply_modify_hdlr can only handle

[devel] [PATCH 1 of 1] amfd: Invalid read when deleting a node from a node group [#719]

2014-01-15 Thread Gary Lee
osaf/services/saf/avsv/avd/avd_nodegroup.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) don't read beyond the end of saAmfNGNodeList, if the node to be removed from node group is at the end of the array. diff --git a/osaf/services/saf/avsv/avd/avd_nodegroup.c b/osaf/services/saf/

[devel] [PATCH 1 of 1] amfd: Invalid read when deleting a node from a node group [#719]

2014-01-15 Thread Gary Lee
osaf/services/saf/amf/amfd/nodegroup.cc | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) don't read beyond the end of saAmfNGNodeList, if the node to be removed from node group is at the end of the array. diff --git a/osaf/services/saf/amf/amfd/nodegroup.cc b/osaf/services/saf/amf/am