Re: [devel] [PATCH 1 of 1] log: fix failure to create directory when changing logRootDirectory [#2054]

Hi Vu, If possible use global `lgs_conf.logRootDirectory` after the call `lgs_rootpathconf_set(new_logRootDirectory)` instead of passed `new_logRootDirectory` parameter. -AVM On 10/12/2016 12:39 PM, Vu Minh Nguyen wrote: > Hi Mahesh, > > See my comment inline. > > Regards, Vu > >>

Re: [devel] [PATCH 1 of 1] log: fix failure to create directory when changing logRootDirectory [#2054]

Hi Mahesh, See my comment inline. Regards, Vu > -Original Message- > From: A V Mahesh [mailto:mahesh.va...@oracle.com] > Sent: Wednesday, October 12, 2016 1:52 PM > To: Lennart Lund ; Vu Minh Nguyen > > Cc:

Re: [devel] [PATCH 1 of 1] log: fix failure to create directory when changing logRootDirectory [#2054]

Hi VU, ACK with following : Not an issue but It is good to use lgs_conf.logRootDirectory insted of new_logRootDirectory for the remaining part of logRootDirectory_filemove() , because mutex_unlocked for lgs_conf.logRootDirectory -AVM On 10/10/2016 4:48 PM, Lennart Lund wrote: > Hi Vu > >

Re: [devel] [PATCH 1 of 1] log: fix failure to create directory when changing logRootDirectory [#2054]

Hi Vu Ack with comment. See below /*** * Support older check-point protocols prior to version 5 */ /** * Used for updating logRootDirectory on standby when check-pointed * * Set the logRootDirectory parameter in the lgs_conf struct * Used for holding data from config object * * @param

[devel] [PATCH 1 of 1] log: fix failure to create directory when changing logRootDirectory [#2054]

osaf/services/saf/logsv/lgs/lgs_imm.cc | 3 + tests/logsv/tet_LogOiOps.c | 82 ++ 2 files changed, 85 insertions(+), 0 deletions(-) When changing `logRootDirectory`, the new directory was not updated to global `lgs_conf.logRootDirectory`, therefore