Re: [devel] [PATCH 1 of 4] amfd: Convert avd_si_admin_state_set to a AVD_SI member function [#713]

2014-06-16 Thread Hans Nordebäck
ack/Regards HansN On 06/12/14 08:52, Gary Lee wrote: > osaf/services/saf/amf/amfd/include/si.h | 3 +- > osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 17 +++--- > osaf/services/saf/amf/amfd/sg_nored_fsm.cc | 14 ++-- > osaf/services/saf/amf/amfd/sg_npm_fsm.cc |

Re: [devel] [PATCH 1 of 4] amfd: Convert avd_si_admin_state_set to a AVD_SI member function [#713]

2014-06-13 Thread Nagendra Kumar
My bad, overlooked. Ack. -Nagu > -Original Message- > From: Gary Lee [mailto:gary@dektech.com.au] > Sent: 13 June 2014 15:15 > To: Nagendra Kumar; hans.fe...@ericsson.com; > hans.nordeb...@ericsson.com; Praveen Malviya > Cc: opensaf-devel@lists.sourceforge.net > Subject: Re: [PATCH 1

Re: [devel] [PATCH 1 of 4] amfd: Convert avd_si_admin_state_set to a AVD_SI member function [#713]

2014-06-13 Thread Gary Lee
HI Nagu I don't think I modified any functionality or tracing. I just removed "si->" from the TRACE call. + TRACE_ENTER2("%s AdmState %s => %s", name.value, + avd_adm_state_name[saAmfSIAdminState], avd_adm_state_name[state]); Thanks Gary On 13/06/14 19:46, Nagendra Kuma

Re: [devel] [PATCH 1 of 4] amfd: Convert avd_si_admin_state_set to a AVD_SI member function [#713]

2014-06-13 Thread Nagendra Kumar
You can print si name also. Is there any reason to delete it from : - TRACE_ENTER2("%s AdmState %s => %s", si->name.value, - avd_adm_state_name[si->saAmfSIAdminState], avd_adm_state_name[state]); Thanks -Nagu > -Original Message- > From: Gary Lee [mailto:gary@

[devel] [PATCH 1 of 4] amfd: Convert avd_si_admin_state_set to a AVD_SI member function [#713]

2014-06-11 Thread Gary Lee
osaf/services/saf/amf/amfd/include/si.h | 3 +- osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 17 +++--- osaf/services/saf/amf/amfd/sg_nored_fsm.cc | 14 ++-- osaf/services/saf/amf/amfd/sg_npm_fsm.cc | 10 osaf/services/saf/amf/amfd/sg_nway_fsm.cc| 10