Re: [devel] [PATCH 2 of 3] amfnd: Fix all Cppcheck 1.77 issues [#2341] V2

2017-03-14 Thread A V Mahesh
Hi Gary, Sorry I over looked it , will see and fix it , while fixing other Amf Dev review comments ( may be in V3 ). -AVM On 3/15/2017 11:01 AM, Gary Lee wrote: > Hi Mahesh > > Did you see my proposed change? > > The ‘delete rec’ statement below will cause a double free, unless I’m >

Re: [devel] [PATCH 2 of 3] amfnd: Fix all Cppcheck 1.77 issues [#2341] V2

2017-03-14 Thread Gary Lee
Hi Mahesh Did you see my proposed change? The ‘delete rec’ statement below will cause a double free, unless I’m mistaken. Thanks Gary void avnd_comp_pm_rec_del(AVND_CB *cb, AVND_COMP *comp, AVND_COMP_PM_REC *rec) { - uint32_t rc = NCSCC_RC_SUCCESS; SaUint64T pid =

[devel] [PATCH 2 of 3] amfnd: Fix all Cppcheck 1.77 issues [#2341] V2

2017-03-14 Thread A V Mahesh
src/amf/amfnd/amfnd.cc | 15 +-- src/amf/amfnd/cbq.cc | 9 +++-- src/amf/amfnd/chc.cc | 29 +++-- src/amf/amfnd/clc.cc | 37 ++--- src/amf/amfnd/comp.cc| 8 +++- src/amf/amfnd/compdb.cc | 17