osaf/services/saf/amf/amfd/nodegroup.cc | 12 ++--
osaf/services/saf/amf/amfd/ntf.cc | 4 ++--
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/nodegroup.cc
b/osaf/services/saf/amf/amfd/nodegroup.cc
---
Summary: amfd: add long DN support [#1642]
Review request for Trac Ticket(s): 1642
Peer Reviewer(s): <>
Pull request to: <>
Affected branch(es): default
Development branch: default
Impacted area Impact y/n
Docs
Hi Mahesh,
there is a problem that TIPC may silently drop messages at overload
situations, as MDS uses the SOCK_RDM option.
At least it has to be logged when messages are dropped. It is allowed in
TIPC to set TIPC_DROPPABLE=false and also
use multicast. The concern may be that the send buffer
Summary: MDS: Log TIPC dropped messages V2
Review request for Trac Ticket(s): #1957
Peer Reviewer(s): Mahesh, Mathi, AndersW
Pull request to:
Affected branch(es): default
Development branch: default
Impacted area Impact y/n
osaf/libs/core/mds/mds_dt_tipc.c | 36 +++-
1 files changed, 23 insertions(+), 13 deletions(-)
diff --git a/osaf/libs/core/mds/mds_dt_tipc.c b/osaf/libs/core/mds/mds_dt_tipc.c
--- a/osaf/libs/core/mds/mds_dt_tipc.c
+++ b/osaf/libs/core/mds/mds_dt_tipc.c
@@
Ok
I need some time to re-check the TIPC code , will back to you soon.
-AVM
On 8/19/2016 1:46 PM, Hans Nordebäck wrote:
> Hi Mahesh,
>
> there is a problem that TIPC may silently drop messages at overload
> situations, as MDS uses the SOCK_RDM option.
>
> At least it has to be logged when
osaf/services/saf/amf/amfnd/util.cc | 546
1 files changed, 0 insertions(+), 546 deletions(-)
diff --git a/osaf/services/saf/amf/amfnd/util.cc
b/osaf/services/saf/amf/amfnd/util.cc
--- a/osaf/services/saf/amf/amfnd/util.cc
+++
Summary: amfnd: remove used code in util.cc [#1642]
Review request for Trac Ticket(s): 1642
Peer Reviewer(s): AMF devs
Pull request to: AMF maintainers
Affected branch(es): default
Development branch: default
Impacted area Impact y/n
osaf/libs/agents/saf/amfa/amf_agent.cc | 1 +
osaf/libs/agents/saf/amfa/ava_hdl.cc | 2 --
2 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/osaf/libs/agents/saf/amfa/amf_agent.cc
b/osaf/libs/agents/saf/amfa/amf_agent.cc
--- a/osaf/libs/agents/saf/amfa/amf_agent.cc
+++
Summary: amfa: fixed freeing notification buff [#1642]
Review request for Trac Ticket(s): 1642
Peer Reviewer(s): AMF devs
Pull request to: Amf maintainers
Affected branch(es): default
Development branch: default
Impacted area Impact y/n
Hi Minh,
Thanks for reviewing.
I will change Error to Warning before pushing.
Thanks,
Praveen
On 09-Aug-16 4:48 AM, minh chau wrote:
> Hi Praveen,
>
> This patch has also fixed the coredump in the other tests are failing in
> test report of #1725 part 1, which are 14, 64, 68, 84, 124, 128
> In
Hi Anders,
Comments inline.
On 2016/08/19 03:55 PM, anders.bjornerst...@telia.com wrote:
> Hi Neel,
>
> I just have two comments:
>
> 1) You say in a comment below: "saImmOiAugmentCcbInitialize is allowed in
> completed callback, but it should be mainly used for calling
> saImmOmCcbObjectRead"
Hi Praveen,
Please see my answers marked with [Long].
Best regards,
Long Nguyen.
On 8/19/2016 6:01 PM, praveen malviya wrote:
> Hi Long,
>
> I see one problem if B.01.01 application frees the memory in pg
> tracking callback.
> Please see inline.
>
> Thanks,
> Praveen
> On 19-Aug-16 12:00 PM,
Hi Minh,
All patches are not received.
Please attached them in the ticket.
Thanks,
Praveen
On 18-Aug-16 5:45 AM, Minh Hon Chau wrote:
> osaf/services/saf/amf/amfd/include/sg.h | 4 +-
> osaf/services/saf/amf/amfd/include/susi.h | 2 +
> osaf/services/saf/amf/amfd/ndfsm.cc | 15
Summary:imm: Allow saImmOmCcbObjectRead in completed callback when ROF is set
to false [#1956]
Review request for Trac Ticket(s): 1956
Peer Reviewer(s): Zoran, Hung
Affected branch(es): 5.0.x,default
Development branch: default
Impacted area Impact y/n
osaf/libs/agents/saf/imma/imma_oi_api.c | 3 ++-
osaf/services/saf/immsv/README | 6 ++
2 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/osaf/libs/agents/saf/imma/imma_oi_api.c
b/osaf/libs/agents/saf/imma/imma_oi_api.c
--- a/osaf/libs/agents/saf/imma/imma_oi_api.c
Hi Long,
I see one problem if B.01.01 application frees the memory in pg tracking
callback.
Please see inline.
Thanks,
Praveen
On 19-Aug-16 12:00 PM, Long HB Nguyen wrote:
> osaf/libs/agents/saf/amfa/amf_agent.cc | 1 +
> osaf/libs/agents/saf/amfa/ava_hdl.cc | 2 --
> 2 files changed, 1
Hi Praveen,
I attached them to ticket.
Thanks,
Minh
On 19/08/16 21:08, praveen malviya wrote:
> Hi Minh,
> All patches are not received.
> Please attached them in the ticket.
>
> Thanks,
> Praveen
>
> On 18-Aug-16 5:45 AM, Minh Hon Chau wrote:
>> osaf/services/saf/amf/amfd/include/sg.h | 4
18 matches
Mail list logo
