Re: [devel] Reviewe request for IMMsv PR document [#2024]

2016-09-18 Thread Hung Nguyen
Hi Neel, Reviewed the document. Ack from me. BR, Hung Nguyen - DEK Technologies From: Neelakanta Reddy reddy.neelaka...@oracle.com Sent: Friday, September 16, 2016 5:28PM To: Zoran Milinkovic, Hung Nguyen, Opensaf

Re: [devel] [PATCH 1 of 1] MDS: Log TIPC dropped messages [#1957]

2016-09-18 Thread A V Mahesh
Hi Anders Widell, On 9/16/2016 2:03 PM, Anders Widell wrote: > Another approach we could consider is that MDS retransmits the message > transparently without informing the sender. This would require MDS to > internally store sent messages for a while, so that they can be > retransmitted. It wou

Re: [devel] [PATCH 1 of 1] amfa: fix saAmfProtectionGroupTrackStop [#1991]

2016-09-18 Thread praveen malviya
Ack, code review only. Thanks, Praveen On 16-Sep-16 7:43 AM, Long HB Nguyen wrote: > osaf/libs/agents/saf/amfa/ava_mds.cc | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > > diff --git a/osaf/libs/agents/saf/amfa/ava_mds.cc > b/osaf/libs/agents/saf/amfa/ava_mds.cc > --- a/osaf/l

Re: [devel] [PATCH 1 of 1] NTF: Replace sizeof by strlen in ntftest [#2038]

2016-09-18 Thread praveen malviya
Ack, code review only. Note:In NTFSv spec A.01.01, section "Appendix A API Usage Examples" uses strlen() in all the provided examples while allocating notifications. Thanks, Praveen On 16-Sep-16 4:24 AM, Minh Hon Chau wrote: > osaf/libs/agents/saf/ntfa/ntfa_api.c | 7 --- > test

[devel] [PATCH 1 of 1] cpa: provide support for full range of timeout for CkptSynchronize API [#2044]

2016-09-18 Thread mahesh . valla
osaf/libs/agents/saf/cpa/cpa_api.c | 13 ++--- 1 files changed, 6 insertions(+), 7 deletions(-) saCkptCheckpointSynchronize() API functions that take an explicit timeout parameter are currently expect the user to always set this parameter to MIN timeout value. Now this patch impleme

[devel] [PATCH 0 of 1] Review Request for cpa: provide support for full range of timeout for CkptSynchronize API [#2044]

2016-09-18 Thread mahesh . valla
Summary:cpa: provide support for full range of timeout for CkptSynchronize API [#2044] Review request for Trac Ticket(s): #2044 Peer Reviewer(s): Hoang Pull request to: <> Affected branch(es): 4.7 to default Development branch: default Impacted area Impact

[devel] [PATCH 1 of 1] amfd: do not send duplicate removal of assignment, N-Way model [#2022]

2016-09-18 Thread praveen . malviya
osaf/services/saf/amf/amfd/sg_nway_fsm.cc | 6 -- 1 files changed, 4 insertions(+), 2 deletions(-) AMFD asserted during lock operation on NG when its nodes are deplyed with N-WAY model application. When lock on NG operation is issued, AMFD sends quiesced state to active SIs in all the thr

[devel] [PATCH 0 of 1] Review Request for amfd: do not send duplicate removal of assignment, N-Way model [#2022]

2016-09-18 Thread praveen . malviya
Summary: amfd: do not send duplicate removal of assignment, N-Way model [#2022] Review request for Trac Ticket(s): #2022 Peer Reviewer(s): AMF devs Pull request to: <> Affected branch(es): 5.1 and default. Development branch: <> Impacted area Impact y/n -