Ack(Not tested). Please do mention the test cases in " Testing Commands:"
Thanks
-Nagu
> -Original Message-
> From: Minh Hon Chau [mailto:minh.c...@dektech.com.au]
> Sent: 07 February 2017 08:56
> To: hans.nordeb...@ericsson.com; Nagendra Kumar; Praveen Malviya;
> gary@dektech.com.au;
src/log/Makefile.am| 4 +++-
src/log/apitest/tet_LogOiOps.c | 8
2 files changed, 7 insertions(+), 5 deletions(-)
Major changes:
1) Modify Lennart's test cases because enhancing destination
configuration validation rules.
2) Add test suite #17 to verify alternative dest
src/log/Makefile |4 +
src/log/Makefile.am| 19 +++
src/log/tests/Makefile | 20 +++
src/log/tests/lgs_dest_test.cc | 209 +
4 files changed, 252 insertions(+), 0 deletions(-)
Unit tests to verify major interfaces
src/log/Makefile.am |8 +-
src/log/config/logsv_classes.xml |7 +-
src/log/logd/lgs_config.cc | 193 +++--
src/log/logd/lgs_config.h|3 +-
src/log/logd/lgs_dest.cc | 746 +++
src/log/logd/lgs_dest.h |
Summary: log: add alternative destinations of log records [#2258]
Review request for Trac Ticket(s): #2258
Peer Reviewer(s): Lennart, Mahesh, Canh
Pull request to: <>
Affected branch(es): Default
Development branch: Default
Impacted area Impact y/n
--
Hi Vu
See comments inline tagged [Lennart]
General comments:
Update code and comments regarding changed delimiters in configuration string
from '\n' to ';'
Fix incorrect changes and usage of the configuration handler
Regards
Lennart
> -Original Message-
> From: Vu Minh Nguyen [mailto
Hi Nagu,
This patch is just for a corner case, where failover happens in between
AVD_INIT_DONE and AVD_APP_STATE, we still have to reboot the node if out
of cold sync happens.
So I think we still have to keep that sentence in Compliance Table.
Thanks,
Minh
On 16/02/17 17:24, Nagendra Kumar wro
Hi Nagu,
This patch is not a full solution for loss of RTA, it's only for problem
reported in #2210, so I only tested the scenario described in this ticket.
It's probably hard to see the loss if just following the test scenario.
I had to change AVD_SI::set_admin_state in AMFD code not to update
Ack with one minor comment.
Thanks,
Praveen
On 15-Feb-17 7:50 AM, Gary Lee wrote:
> src/amf/amfd/su.cc | 12 ++--
> 1 files changed, 10 insertions(+), 2 deletions(-)
>
>
> Someone could change saAmfSUMaintenanceCampaign more than once in a CCB.
> We should not assert / cause a node re
Hi Anders Widell,
Can you please clarify below :
1) is this meta sequenceId is rotates after reaching some value ? (
Max value )
2) is this meta sequenceId persistent even after application respawn ?
Hi Minh,
I have started reviewing this patch.
Thanks,
Praveen
On 15-Feb-17 9:22 AM, minh chau wrote:
> Hi all,
>
> Have you had time to review this patch?
> It changes the component failover sequence, so I think we need more time
> to look at it.
>
> Thanks,
> Minh
>
> On 23/01/17 12:28, Minh Ho
Hi Minh,
One quick question:
Ticket description says:
"Si deps safSi=AmfDemoTwon2 depends safSi=AmfDemoTwon1 depends
safSi=AmfDemoTwon"
But logs are related to without SIdep. Also in the configuration
app3_twon3su3si.xml, SI dep classes are commented.
I think ticket description needs correction
Hi Praveen,
Yes, you are right, I will update the description.
Thanks, Minh
Quoting praveen malviya :
> Hi Minh,
>
> One quick question:
> Ticket description says:
> "Si deps safSi=AmfDemoTwon2 depends safSi=AmfDemoTwon1 depends
> safSi=AmfDemoTwon"
> But logs are related to without SIdep. Al
13 matches
Mail list logo
