Re: [devel] [PATCH 1/1] log: Handling of IMM OI BAD HANDLE in log server is incorrect [#2799]

Hi Lennart, Ack with one comment [Canh] Thanks Canh -Original Message- From: Lennart Lund [mailto:lennart.l...@ericsson.com] Sent: Thursday, April 5, 2018 7:38 PM To: vu.m.ngu...@dektech.com.au; canh.v.tru...@dektech.com.au Cc: opensaf-devel@lists.sourceforge.net; Lennart

[devel] [PATCH 1/5] osaf: extend API to include a create key and an enhanced set key function [#2795]

- add create_key function (fails if key already exists) - add setkey_match_prev function (set value if previous value matches) - add missing quotes - add etcd3.plugin --- src/osaf/consensus/plugins/etcd.plugin | 86 +++- src/osaf/consensus/plugins/etcd3.plugin | 355

[devel] [PATCH 2/5] osaf: add lock takeover request fuction [#2795]

- add create and set (if previous value matches) functions to KeyValue class - add Consensus::MonitorTakeoverRequest() function for use by RDE to answer takeover requests - add Consensus::CreateTakeoverRequest() - before a SC is promoted to active, it will create a takeover request in the KV

[devel] [PATCH 3/5] amfd: adapt to new Consensus API [#2795]

--- src/amf/amfd/role.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amf/amfd/role.cc b/src/amf/amfd/role.cc index c8aa9cf1f..790983ee7 100644 --- a/src/amf/amfd/role.cc +++ b/src/amf/amfd/role.cc @@ -1217,7 +1217,7 @@ uint32_t amfd_switch_stdby_actv(AVD_CL_CB *cb) {

[devel] [PATCH 0/5] Review Request for split-brain: select active SC from largest network partition V2 [#2795]

Summary: Split-brain: select active SC from largest network partition V2 [#2795] Review request for Ticket(s): 2795 Peer Reviewer(s): Anders, Hans, Ravi Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2795 Base revision:

[devel] [PATCH 4/5] fmd: adapt to new Consensus API [#2795]

--- src/fm/fmd/fm_main.cc | 26 +- src/fm/fmd/fm_mds.cc | 2 ++ src/fm/fmd/fm_rda.cc | 15 +-- 3 files changed, 20 insertions(+), 23 deletions(-) diff --git a/src/fm/fmd/fm_main.cc b/src/fm/fmd/fm_main.cc index 73c9b9ccd..3371ec5e8 100644 ---

[devel] [PATCH 5/5] rded: adapt to new Consensus API [#2795]

- add 3 new internal message: RDE_MSG_NODE_UP RDE_MSG_NODE_DOWN RDE_MSG_TAKEOVER_REQUEST_CALLBACK - subscribe to AMFND service up events to keep track of the number of cluster members - listen for takeover requests in KV store --- src/rde/rded/rde_cb.h| 12 ++--

Re: [devel] [PATCH 1/1] log: Handling of IMM OI BAD HANDLE in log server is incorrect [#2799]

Hi Canh, I will do a small change based on the comment before pushing. Also see my comment [Lennart] Thanks Lennart From: Canh Van Truong [mailto:canh.v.tru...@dektech.com.au] Sent: den 6 april 2018 08:29 To: Lennart Lund ; Vu Minh Nguyen

Re: [devel] [PATCH 1/1] base: Check return code from unlink in nid_create_ipc [#2829]

Ack with minor comment: instead of calling access(), you could maybe simply check for the ENOENT errno value from unlink()? regards, Anders Widell On 04/05/2018 11:53 AM, Hans Nordeback wrote: --- src/nid/agent/nid_ipc.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff