Re: [devel] [PATCH 0/5] Review Request for split-brain: select active SC from largest network partition V3 [#2795]

2018-04-13 Thread Hans Nordebäck
Hi, On 04/12/2018 04:15 PM, Gary Lee wrote: Hi On 12/04/18 23:34, Anders Widell wrote: Ack with comments: * There is no need to use "const" when passing function arguments by value. E.g. the argument "const uint64_t cluster_size" should be "uint64_t cluster_size". [GL] Sure, but it

Re: [devel] [PATCH 1/1] imma: Do not finalize previously instialized privateOmHandle in saImmOiAugmentCcbInitialize [#2827]

2018-04-13 Thread Vu Minh Nguyen
Hi Hoa, Ack from me with minor suggestion, started with [Vu]. Regards, Vu > -Original Message- > From: Hoa Le [mailto:hoa...@dektech.com.au] > Sent: Friday, April 6, 2018 10:52 AM > To: ravisekhar.ko...@oracle.com; vu.m.ngu...@dektech.com.au; > zoran.milinko...@ericsson.com > Cc:

Re: [devel] [PATCH 0/5] Review Request for split-brain: select active SC from largest network partition V3 [#2795]

2018-04-13 Thread Gary Lee
Hi Hans Yes, they could be declared const member functions, as they generally don't change anything in the object. The changes are actually in the KV store. But I guess we could potentially mislead callers about the intentions of the functions though. What do you think? /Gary On

Re: [devel] [PATCH 1/1] osaf: Isolate the node in the opensaf_reboot [#2833]

2018-04-13 Thread Ravi Sekhar Reddy Konda
HI Hans,   The use case that we are addressing here is link flickering  when remote fencing is not enabled, Also remote fencing using Stonith is valid only in Virtualization environments. I have not tested using Stonith enabled as the use case is in the case where remote fencing is disabled.

[devel] [PATCH 1/1] dtm: Add --delete option to osaflog command for deleting log streams [#2837]

2018-04-13 Thread Anders Widell
Make it possible to delete log streams in the internal OpenSAF log server. This will free up resources for log streams that are no longer used, as well as make it possible to create a new log stream with the same name but different configuration options (max file size and number of backups). ---

[devel] [PATCH 0/1] Review Request for dtm: Add --delete option to osaflog command for deleting log streams [#2837]

2018-04-13 Thread Anders Widell
Summary: dtm: Add --delete option to osaflog command for deleting log streams [#2837] Review request for Ticket(s): 2837 Peer Reviewer(s): Ravi Pull request to: Affected branch(es): develop Development branch: ticket-2837 Base revision: b13a65123bfddcc6f5105fe340131e3bd8a5ac70 Personal

Re: [devel] [PATCH 0/6] Review Request for split-brain: select active SC from largest network partition V4 [#2795]

2018-04-13 Thread Anders Widell
Ack for the series. regards, Anders Widell On 04/13/2018 01:50 PM, Gary Lee wrote: Summary: split-brain: select active SC from largest network partition V4 [#2795] Review request for Ticket(s): 2795 Peer Reviewer(s): Hans, Ravi, Anders Pull request to: *** LIST THE PERSON WITH PUSH ACCESS

Re: [devel] [PATCH 1/1] osaf: Isolate the node in the opensaf_reboot [#2833]

2018-04-13 Thread Anders Widell
A question: why did you remove the "pkill -STOP osafamfwd" etc commands? regards, Anders Widell On 04/12/2018 03:29 PM, ravi-sekhar wrote: --- scripts/opensaf_reboot | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/scripts/opensaf_reboot

Re: [devel] [PATCH 1/1] osaf: Isolate the node in the opensaf_reboot [#2833]

2018-04-13 Thread Hans Nordebäck
Hi Ravi, stonith is not only valid for virutalized environment, I assume stonith supports other e.g. ipmi in a legacy environment. The probability for "flickering" may be higher in a virtualized environment, but for redundancy there should be two interfaces configured, which is the normal

Re: [devel] [PATCH 0/6] Review Request for split-brain: select active SC from largest network partition V4 [#2795]

2018-04-13 Thread Gary Lee
Sorry, it should read: Note: Patches 1 to 5 are identical to V3. Patch 6 (osaf: remove timestamp from takeover request) is the diff between V3 and V4. On 13/04/18 21:50, Gary Lee wrote: Summary: split-brain: select active SC from largest network partition V4 [#2795] Review request for

[devel] [PATCH 1/6] osaf: extend API to include a create key and an enhanced set key function [#2795]

2018-04-13 Thread Gary Lee
- add create_key function (fails if key already exists) - add setkey_match_prev function (set value if previous value matches) - add missing quotes - add etcd3.plugin --- src/osaf/consensus/plugins/etcd.plugin | 86 +++- src/osaf/consensus/plugins/etcd3.plugin | 366

[devel] [PATCH 3/6] amfd: adapt to new Consensus API [#2795]

2018-04-13 Thread Gary Lee
--- src/amf/amfd/role.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amf/amfd/role.cc b/src/amf/amfd/role.cc index c8aa9cf1f..790983ee7 100644 --- a/src/amf/amfd/role.cc +++ b/src/amf/amfd/role.cc @@ -1217,7 +1217,7 @@ uint32_t amfd_switch_stdby_actv(AVD_CL_CB *cb) {

[devel] [PATCH 4/6] fmd: adapt to new Consensus API [#2795]

2018-04-13 Thread Gary Lee
--- src/fm/fmd/fm_cb.h| 2 +- src/fm/fmd/fm_main.cc | 26 +- src/fm/fmd/fm_mds.cc | 2 ++ src/fm/fmd/fm_rda.cc | 27 ++- 4 files changed, 30 insertions(+), 27 deletions(-) diff --git a/src/fm/fmd/fm_cb.h b/src/fm/fmd/fm_cb.h index

[devel] [PATCH 5/6] rded: adapt to new Consensus API [#2795]

2018-04-13 Thread Gary Lee
- add 3 new internal message: RDE_MSG_NODE_UP RDE_MSG_NODE_DOWN RDE_MSG_TAKEOVER_REQUEST_CALLBACK - subscribe to AMFND service up events to keep track of the number of cluster members - listen for takeover requests in KV store --- src/rde/rded/rde_cb.h| 12 ++--

[devel] [PATCH 6/6] osaf: remove timestamp from takeover request [#2795]

2018-04-13 Thread Gary Lee
* update create() in the plugins to include a timeout parameter * remove timestamp from the takeover request and utilise the built-in timeout functionality in the KV store --- src/osaf/consensus/consensus.cc | 165 --- src/osaf/consensus/consensus.h

[devel] [PATCH 2/6] osaf: add lock takeover request fuction [#2795]

2018-04-13 Thread Gary Lee
- add create and set (if previous value matches) functions to KeyValue class - add Consensus::MonitorTakeoverRequest() function for use by RDE to answer takeover requests - add Consensus::CreateTakeoverRequest() - before a SC is promoted to active, it will create a takeover request in the KV

[devel] [PATCH 0/6] Review Request for split-brain: select active SC from largest network partition V4 [#2795]

2018-04-13 Thread Gary Lee
Summary: split-brain: select active SC from largest network partition V4 [#2795] Review request for Ticket(s): 2795 Peer Reviewer(s): Hans, Ravi, Anders Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2795 Base revision:

[devel] [PATCH 1/2] base: Add support for setting UnixServerSocket file permissions [#2838]

2018-04-13 Thread Anders Widell
--- src/base/unix_server_socket.cc | 14 +++--- src/base/unix_server_socket.h | 7 +-- 2 files changed, 16 insertions(+), 5 deletions(-) diff --git a/src/base/unix_server_socket.cc b/src/base/unix_server_socket.cc index 620efce9f..8a5290d24 100644 ---

[devel] [PATCH 0/2] Review Request for dtm: Make the osaftransportd socket world-writable [#2838]

2018-04-13 Thread Anders Widell
Summary: base: Add support for setting UnixServerSocket file permissions [#2838] Review request for Ticket(s): 2838 Peer Reviewer(s): Ravi Pull request to: Affected branch(es): develop Development branch: ticket-2838 Base revision: b13a65123bfddcc6f5105fe340131e3bd8a5ac70 Personal repository:

[devel] [PATCH 2/2] dtm: Make the osaftransportd socket world-writable [#2838]

2018-04-13 Thread Anders Widell
Allow OpenSAF agent libraries running in application processes to send trace messages to osaftransportd, regardless of what user-id and group-id the application process is running with. --- src/dtm/transport/log_server.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git