Re: [devel] [PATCH 1/1] rded: run controller promotion code in new thread [#2857]

Hi Gary, Ack, code review only Regards, Ravi - Original Message - From: gary@dektech.com.au To: hans.nordeb...@ericsson.com, ravisekhar.ko...@oracle.com, anders.wid...@ericsson.com Cc: opensaf-devel@lists.sourceforge.net, gary@dektech.com.au Sent: Friday, May 18, 2018 11:20:34

[devel] [PATCH 1/1] rded: run controller promotion code in new thread [#2857]

Currently, the consensus code relating to node promotion is run from the main thread. We can improve rded's responsiveness by moving this code into another thread. --- src/rde/rded/rde_cb.h| 3 +- src/rde/rded/rde_main.cc | 6 +++- src/rde/rded/role.cc | 83

[devel] [PATCH 0/1] Review Request for rded: run controller promotion code in new thread V2 [#2857]

Summary: rded: run controller promotion code in new thread V2 [#2857] Review request for Ticket(s): 2857 Peer Reviewer(s): Hans, Ravi Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2857 Base revision:

Re: [devel] [PATCH 1/1] base: Destructor of TraceLog causes coredump V2 [#2860]

Hi Minh, yes you are right about the possibility for a segv, but using a std::shared_ptr instead of the naked ptr may be an option ? /Thanks Hans Från: Minh Hon Chau Skickat: den 24 maj 2018 02:34:13 Till: Hans Nordebäck; Anders

[devel] [PATCH 1/1] base: Destructor of TraceLog causes coredump V2 [#2860]

Change Mutex class to make it possible for caller to decide if abort --- src/base/logtrace_client.cc | 5 - src/base/mutex.cc | 2 +- src/base/mutex.h| 22 +- 3 files changed, 18 insertions(+), 11 deletions(-) diff --git

[devel] [PATCH 0/1] Review Request for base: Destructor of TraceLog causes coredump V2 [#2860]

Summary: base: Destructor of TraceLog causes coredump V2 [#2860] Review request for Ticket(s): 2860 Peer Reviewer(s): Minh, Gary, AndersW Pull request to: Affected branch(es): develop Development branch: ticket-2860 Base revision: e0bcf786e0b3417d31b767073bb789ef150eb2ad Personal repository:

Re: [devel] [PATCH 1/1] base: Destructor of TraceLog causes coredump V2 [#2860]

Hi Hans, It is good to give an option to Mutex class not to abort. We can avoid the abort in mutex_unlock (as reported in coredump), but I feel the issue is still there. We may hit a problem (segv?) with "mutex_->good()" since the other thread is wiping out the mutex_ in destructor, it is a