[devel] [PATCH 0/1] Review Request for dtm: Fix dtm close socket due to duplication of adding node IP info [#2984]

2018-12-17 Thread Canh Van Truong
Summary: dtm: Fix dtm close socket due to duplication of adding node IP info [#2984] Review request for Ticket(s): 2984 Peer Reviewer(s): Gary, Minh, Ander, Hans Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2984 Base

[devel] [PATCH 1/1] dtm: Fix dtm close socket due to duplication of adding node IP info [#2984]

2018-12-17 Thread Canh Van Truong
During cluster start, one node (node 1) broadcast up msg to other node. The remote node (node 2) get this msg and send the connection to node 1 (connect()). Similarly node 1 send the connection to node 2 after node 2 broadcast up msg to. Beside of node 2 connect() to node 1, node 2 also add the

[devel] [PATCH 1/1] dtm: Fix dtm close socket due to duplication of adding node IP info [#2984]

2018-12-17 Thread Canh Van Truong
During cluster start, one node (node 1) broadcast up msg to other node. The remote node (node 2) get this msg and send the connection to node 1 (connect()). Similarly node 1 send the connection to node 2 after node 2 broadcast up msg to. Beside of node 2 connect() to node 1, node 2 also add the

[devel] [PATCH 0/1] Review Request for dtm: Fix dtm close socket due to duplication of adding node IP info [#2984]

2018-12-17 Thread Canh Van Truong
Summary: dtm: Fix dtm close socket due to duplication of adding node IP info [#2984] Review request for Ticket(s): 2984 Peer Reviewer(s): Gary, Minh, Ander, Hans Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2984 Base

Re: [devel] [PATCH 1/1] evt: resurrect apitests [#2974]

2018-12-17 Thread Mathi N P
Hi, A couple of comments: 1) Is the redefinition of ncs_task_release necessary? It's already defined in sysf_tsk.c? +#define m_NCS_TASK_RELEASE(t_handle) ncs_task_release(t_handle) ... + +uint32_t ncs_task_release(void *task_handle) +{ + NCS_OS_TASK task; + memset(, 0, sizeof(task));

Re: [devel] [PATCH 1/1] imm: initialize attrDefinitionsOut with NULL [#2987]

2018-12-17 Thread Vu Minh Nguyen
Ack. Thanks. I am going to push this today. Regards, Vu > -Original Message- > From: Mohan Kanakam > Sent: Monday, December 17, 2018 3:16 PM > To: vu.m.ngu...@dektech.com.au; hans.nordeb...@ericsson.com > Cc: opensaf-devel@lists.sourceforge.net; Mohan Kanakam > > Subject: [PATCH 1/1]

[devel] [PATCH 0/1] Review Request for imm: initialize attrDefinitionsOut with NULL [#2987]

2018-12-17 Thread Mohan Kanakam
Summary: imm: initialize attrDefinitionsOut with NULL [#2987] Review request for Ticket(s): 2987 Peer Reviewer(s):vu.m.nguyen, Hans Nordeb??ck Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2987 Base revision:

[devel] [PATCH 1/1] imm: initialize attrDefinitionsOut with NULL [#2987]

2018-12-17 Thread Mohan Kanakam
--- src/imm/apitest/management/test_saImmOmClassDescriptionGet_2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/imm/apitest/management/test_saImmOmClassDescriptionGet_2.c b/src/imm/apitest/management/test_saImmOmClassDescriptionGet_2.c index 1d4e8eb..be512f6 100644 ---