[devel] [PATCH 3/9] mds: Add implementation for TIPC buffer overflow solution [#1960]

This is a collaborative patch of two participants: - Tran Thuan - Minh Chau Main changes: - Add mds_tipc_fctrl_intf.h, mds_tipc_fctrl_intf.cc: These two files introduce new functions which are called in mds_dt_tipc.c if the flow control is enabled - Add mds_tipc_fctrl_portid.h,

[devel] [PATCH 0/9] Review Request for mds: Add solution for TIPC buffer overflow [#1960]

Summary: mds: Add solution of TIPC buffer overflow at MDS [#1960] Review request for Ticket(s): 1960 Peer Reviewer(s): Anders, HansN, Lennart, Gary, Vu, Thuan Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-1960 Base revision:

[devel] [PATCH 2/9] mds: Resolve c/c++ linking issue [#1960]

(Sending on behalf of Thuan) This patch solves the linking issue if mds_dt.h or mds_core.h is included in c++ sources. --- src/mds/mds_core.h| 74 +++ src/mds/mds_dt.h | 4 +-- src/mds/mds_dt2c.h| 67

[devel] [PATCH 5/9] mds: Add state machine for tipc portid instance [#1960]

This patch adds state machine to support tx probation timer. --- src/mds/mds_tipc_fctrl_intf.cc | 47 +++-- src/mds/mds_tipc_fctrl_msg.h | 1 + src/mds/mds_tipc_fctrl_portid.cc | 109 +++ src/mds/mds_tipc_fctrl_portid.h | 22 4

[devel] [PATCH 1/9] mds: Add README for solution of TIPC buffer overflow at MDS [#1960]

--- src/mds/README | 221 + 1 file changed, 221 insertions(+) create mode 100644 src/mds/README diff --git a/src/mds/README b/src/mds/README new file mode 100644 index 000..1b94632 --- /dev/null +++ b/src/mds/README @@ -0,0 +1,221 @@

[devel] [PATCH 9/9] mds: Add TIPC buffer overflow for mdstest [#1960]

(Sending on behalf of Thuan) --- src/mds/apitest/mdstest.c | 5 +- src/mds/apitest/mdstipc.h | 6 +- src/mds/apitest/mdstipc_api.c | 237 + src/mds/apitest/mdstipc_conf.c | 19 ++-- 4 files changed, 253 insertions(+), 14 deletions(-) diff

[devel] [PATCH 7/9] mds: Add configurable parameters [#1960]

This patch makes the solution of TIPC buffer overflow configurable, as well as the ack timeout/ack size. For example: The service config file can export the following environment variables export MDS_TIPC_FCTRL_ENABLED=1 export MDS_TIPC_FCTRL_ACKTIMEOUT=1000 export MDS_TIPC_FCTRL_ACKSIZE=1 If

[devel] [PATCH 3/9] mds: Add implementation for TIPC buffer overflow solution [#1960]

This is a collaborative patch of two participants:Thuan, Minh. Main changes: - Add mds_tipc_fctrl_intf.h, mds_tipc_fctrl_intf.cc: These two files introduce new functions which are called in mds_dt_tipc.c if the flow control is enabled - Add mds_tipc_fctrl_portid.h, mds_tipc_fctrl_portid.cc: These

[devel] [PATCH 0/9] Review Request for mds: Add solution for TIPC buffer overflow [#1960]

Summary: mds: Add solution for TIPC buffer overflow at MDS [#1960] Review request for Ticket(s): 1960 Peer Reviewer(s): Anders, HansN, Lennart, Gary, Vu, Thuan Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-1960 Base revision:

[devel] [PATCH 4/9] mds: Add timeout for ack message [#1960]

If the ack size is configured greater than 1, there should be a timeout at receiver ends to send the ack message back to senders. The ack message timeout utilizes the poll timeout in flow control thread to make mds lightweight (in contrast to additional timer threads). ---

[devel] [PATCH 6/9] mds: Implement kRcvBuffOverflow state [#1960]

This patch implements the kRcvBuffOverflow state machine as described in README file. --- src/mds/mds_tipc_fctrl_intf.cc | 6 +- src/mds/mds_tipc_fctrl_msg.h | 1 + src/mds/mds_tipc_fctrl_portid.cc | 137 ++- src/mds/mds_tipc_fctrl_portid.h | 5 +-

[devel] [PATCH 8/9] mds: Apply serial number arithmetic for sequence counter [#1960]

This patch applies the serial number arithmetic for the flow control sequence number, referenced to RFC1982. This is only temporary patch, a proper one could be made in /base with template for others type, e.g uint32. Then mds reuses it from /base. --- src/mds/mds_tipc_fctrl_portid.cc | 53

Re: [devel] [PATCH 0/9] Review Request for mds: Add solution for TIPC buffer overflow [#1960]

Hi all, Please ignore this patch series, the patch 2/9 and 9/9 committed under Thuan name/email, have been dropped (for some reason :) ) when sending for review. I am sending again. Thanks Minh On 14/8/19 4:01 pm, Minh Chau wrote: Summary: mds: Add solution of TIPC buffer overflow at MDS

Re: [devel] [PATCH 1/9] mds: Add README for solution of TIPC buffer overflow at MDS [#1960]

Hi Minh, ack, some minor comments below/Thanks Hans On 2019-08-14 08:38, Minh Chau wrote: > --- > src/mds/README | 221 > + > 1 file changed, 221 insertions(+) > create mode 100644 src/mds/README > > diff --git a/src/mds/README

[devel] [PATCH 1/9] mds: Add README for solution of TIPC buffer overflow at MDS [#1960]

--- src/mds/README | 221 + 1 file changed, 221 insertions(+) create mode 100644 src/mds/README diff --git a/src/mds/README b/src/mds/README new file mode 100644 index 000..1b94632 --- /dev/null +++ b/src/mds/README @@ -0,0 +1,221 @@

[devel] [PATCH 2/9] mds: Resolve c/c++ linking issue [#1960]

From: Tran Thuan This patch solves the linking issue if mds_dt.h or mds_core.h is included in c++ sources. --- src/mds/mds_core.h| 74 +++ src/mds/mds_dt.h | 4 +-- src/mds/mds_dt2c.h| 67

[devel] [PATCH 9/9] mds: Add TIPC buffer overflow for mdstest [#1960]

From: Tran Thuan --- src/mds/apitest/mdstest.c | 5 +- src/mds/apitest/mdstipc.h | 6 +- src/mds/apitest/mdstipc_api.c | 237 + src/mds/apitest/mdstipc_conf.c | 19 ++-- 4 files changed, 253 insertions(+), 14 deletions(-) diff --git

[devel] [PATCH 6/9] mds: Implement kRcvBuffOverflow state [#1960]

This patch implements the kRcvBuffOverflow state machine as described in README file. --- src/mds/mds_tipc_fctrl_intf.cc | 6 +- src/mds/mds_tipc_fctrl_msg.h | 1 + src/mds/mds_tipc_fctrl_portid.cc | 137 ++- src/mds/mds_tipc_fctrl_portid.h | 5 +-

[devel] [PATCH 5/9] mds: Add state machine for tipc portid instance [#1960]

This patch adds state machine to support tx probation timer. --- src/mds/mds_tipc_fctrl_intf.cc | 47 +++-- src/mds/mds_tipc_fctrl_msg.h | 1 + src/mds/mds_tipc_fctrl_portid.cc | 109 +++ src/mds/mds_tipc_fctrl_portid.h | 22 4

[devel] [PATCH 7/9] mds: Add configurable parameters [#1960]

This patch makes the solution of TIPC buffer overflow configurable, as well as the ack timeout/ack size. For example: The service config file can export the following environment variables export MDS_TIPC_FCTRL_ENABLED=1 export MDS_TIPC_FCTRL_ACKTIMEOUT=1000 export MDS_TIPC_FCTRL_ACKSIZE=1 If

[devel] [PATCH 8/9] mds: Apply serial number arithmetic for sequence counter [#1960]

This patch applies the serial number arithmetic for the flow control sequence number, referenced to RFC1982. This is only temporary patch, a proper one could be made in /base with template for others type, e.g uint32. Then mds reuses it from /base. --- src/mds/mds_tipc_fctrl_portid.cc | 53

[devel] [PATCH 4/9] mds: Add timeout for ack message [#1960]

If the ack size is configured greater than 1, there should be a timeout at receiver ends to send the ack message back to senders. The ack message timeout utilizes the poll timeout in flow control thread to make mds lightweight (in contrast to additional timer threads). ---

[devel] [PATCH 1/1] rde: missing comma between elements in array [#3069]

--- src/rde/rded/rde_main.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/rde/rded/rde_main.cc b/src/rde/rded/rde_main.cc index 1a7e58792..6594b3d49 100644 --- a/src/rde/rded/rde_main.cc +++ b/src/rde/rded/rde_main.cc @@ -53,7 +53,7 @@ const char *rde_msg_name[] = {"-",

[devel] [PATCH 0/1] Review Request for rde: missing comma between elements in array [#3069]

Summary: rde: missing comma between elements in array [#3069] Review request for Ticket(s): 3069 Peer Reviewer(s): Gary, Minh Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-3069 Base revision:

[devel] [PATCH 1/1] mbc: fix some coding errors [#3070]

--- src/mbc/mbcsv_api.c | 6 +++--- src/mbc/mbcsv_peer.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mbc/mbcsv_api.c b/src/mbc/mbcsv_api.c index 84a2b8771..3a84fdfda 100644 --- a/src/mbc/mbcsv_api.c +++ b/src/mbc/mbcsv_api.c @@ -619,7 +619,7 @@ uint32_t

[devel] [PATCH 0/1] Review Request for mbc: fix some coding errors [#3070]

Summary: mbc: fix some coding errors [#3070] Review request for Ticket(s): 3070 Peer Reviewer(s): Gary, Minh Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-3070 Base revision: 2d85d5d9264c6a7d1c6601b900fb810facbee3ac Personal