[devel] [PATCH 04 of 15] amfd: Correct a number of issues identified by Coverity [#680]

2014-01-02 Thread Gary Lee
osaf/services/saf/amf/amfd/ndfsm.cc| 4 +++- osaf/services/saf/amf/amfd/ndproc.cc | 5 - osaf/services/saf/amf/amfd/node.cc | 12 osaf/services/saf/amf/amfd/nodegroup.cc| 18 +++--- osaf/services/saf/amf/amfd/nodeswbundle.cc | 2 +-

[devel] [PATCH 06 of 15] amfd: Correct a number of issues identified by Coverity [#680]

2014-01-02 Thread Gary Lee
osaf/services/saf/amf/amfd/si.cc | 24 osaf/services/saf/amf/amfd/si_dep.cc | 11 --- osaf/services/saf/amf/amfd/siass.cc | 4 ++-- osaf/services/saf/amf/amfd/sirankedsu.cc | 15 --- 4 files changed, 30 insertions(+), 24

[devel] [PATCH 02 of 15] amfd: Correct a number of issues identified by Coverity [#680]

2014-01-02 Thread Gary Lee
osaf/services/saf/amf/amfd/cluster.cc| 3 +-- osaf/services/saf/amf/amfd/comp.cc | 17 ++--- osaf/services/saf/amf/amfd/compcstype.cc | 5 + osaf/services/saf/amf/amfd/comptype.cc | 7 +-- osaf/services/saf/amf/amfd/csi.cc| 20 ++--

[devel] [PATCH 03 of 15] amfd: Correct a number of issues identified by Coverity [#680]

2014-01-02 Thread Gary Lee
osaf/services/saf/amf/amfd/hlt.cc | 1 + osaf/services/saf/amf/amfd/imm.cc | 1 + osaf/services/saf/amf/amfd/include/ntf.h | 4 ++-- osaf/services/saf/amf/amfd/include/sg.h | 1 - osaf/services/saf/amf/amfd/include/susi.h | 4 ++-- 5 files changed, 6 insertions(+), 5

[devel] [PATCH 07 of 15] amfd: Correct a number of issues identified by Coverity [#680]

2014-01-02 Thread Gary Lee
osaf/services/saf/amf/amfd/su.cc | 14 -- osaf/services/saf/amf/amfd/sutcomptype.cc| 4 +++- osaf/services/saf/amf/amfd/sutype.cc | 12 +--- osaf/services/saf/amf/amfd/svctype.cc| 6 +++--- osaf/services/saf/amf/amfd/svctypecstypes.cc |

[devel] [PATCH 00 of 15] Review Request for AMF: Coverity issues in amfd/amfnd [#680]

2014-01-02 Thread Gary Lee
and valgrind have been run. changeset 0b48fcffb4ff4a739e56d33e5780e535cd232d3a Author: Gary Lee gary@dektech.com.au Date: Fri, 03 Jan 2014 16:26:02 +1100 amfd: Correct a number of issues identified by Coverity [#680] * Unnecessary header file (HFA) * Logically dead code

[devel] [PATCH 12 of 15] amfnd: Correct a number of issues identified by Coverity [#680]

2014-01-02 Thread Gary Lee
osaf/services/saf/amf/amfnd/comp.cc | 16 ++-- osaf/services/saf/amf/amfnd/compdb.cc | 20 +--- 2 files changed, 15 insertions(+), 21 deletions(-) * Dereference after null check (FORWARD_NULL) * Logically dead code (DEADCODE) * Uninitialized scalar variable

[devel] [PATCH 09 of 15] amfd: Correct a number of issues identified by Coverity [#680]

2014-01-02 Thread Gary Lee
osaf/services/saf/amf/amfd/util.cc | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) * use delete[] for variables allocated with new[] diff --git a/osaf/services/saf/amf/amfd/util.cc b/osaf/services/saf/amf/amfd/util.cc --- a/osaf/services/saf/amf/amfd/util.cc +++

[devel] [PATCH 08 of 15] amfd: Correct a number of issues identified by Coverity [#680]

2014-01-02 Thread Gary Lee
osaf/services/saf/amf/amfd/compcstype.cc | 5 +++-- osaf/services/saf/amf/amfd/hlt.cc| 2 +- osaf/services/saf/amf/amfd/imm.cc| 9 ++--- 3 files changed, 10 insertions(+), 6 deletions(-) * Calling risky function (SECURE_CODING) replace calls to sprintf with snprintf

[devel] [PATCH 13 of 15] amfnd: Correct a number of issues identified by Coverity [#680]

2014-01-02 Thread Gary Lee
osaf/services/saf/amf/amfnd/di.cc | 5 - osaf/services/saf/amf/amfnd/hcdb.cc | 3 +-- osaf/services/saf/amf/amfnd/main.cc | 2 +- osaf/services/saf/amf/amfnd/pg.cc | 5 ++--- osaf/services/saf/amf/amfnd/sidb.cc | 12 +++- osaf/services/saf/amf/amfnd/sudb.cc | 4 ++--

[devel] [PATCH 14 of 15] amfnd: Correct a number of issues identified by Coverity [#680]

2014-01-02 Thread Gary Lee
osaf/services/saf/amf/amfnd/main.cc | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) * Calling risky function (SECURE_CODING) fix buffer overflow if a string longer than 31 chars is specified for node_type diff --git a/osaf/services/saf/amf/amfnd/main.cc

[devel] [PATCH 01 of 15] amfd: Correct a number of issues identified by Coverity [#680]

2014-01-02 Thread Gary Lee
osaf/services/saf/amf/amfd/app.cc | 27 --- osaf/services/saf/amf/amfd/apptype.cc | 13 - 2 files changed, 16 insertions(+), 24 deletions(-) * Unnecessary header file (HFA) * Logically dead code (DEADCODE) * Dereference null return value (NULL_RETURNS)

[devel] [PATCH 15 of 15] amfnd: Correct a number of issues identified by Coverity [#680]

2014-01-02 Thread Gary Lee
osaf/services/saf/amf/amfnd/ckpt_updt.cc | 4 ++-- osaf/services/saf/amf/amfnd/compdb.cc| 6 +++--- osaf/services/saf/amf/amfnd/sidb.cc | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) * use delete[] for variables allocated with new[] diff --git

[devel] [PATCH 11 of 15] amfnd: Correct a number of issues identified by Coverity [#680]

2014-01-02 Thread Gary Lee
osaf/services/saf/amf/amfnd/clc.cc | 11 --- osaf/services/saf/amf/amfnd/clm.cc | 11 ++- 2 files changed, 10 insertions(+), 12 deletions(-) * Unnecessary header file (HFA) * Unchecked return value (CHECKED_RETURN) * Uninitialized scalar variable (UNINIT) * Out-of-bounds read

Re: [devel] [PATCH 00 of 15] Review Request for AMF: Coverity issues in amfd/amfnd [#680]

2014-01-09 Thread Gary Lee
we have tagg'ed 4.4.FC. /AndersBj -Original Message- From: Hans Feldt [mailto:hans.fe...@ericsson.com] Sent: den 9 januari 2014 13:06 To: Gary Lee; Hans Nordebäck; praveen.malv...@oracle.com; nagendr...@oracle.com Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [devel

[devel] [PATCH 0 of 1] Review Request for AMFD: errors reported in valgrind [#715]

2014-01-12 Thread Gary Lee
, saAmfSIStandbyWeight, saAmfSvcDefActiveWeight and saAmfSvcDefStandbyWeight are deleted in si.cc * fix a few typos where delete is called when delete [] is required changeset 75ebad333d4fe32a2712cec5739c216bf9873385 Author: Gary Lee gary@dektech.com.au Date: Mon, 13 Jan 2014 18:19:19 +1100

[devel] [PATCH 1 of 1] imported patch amfd.patch

2014-01-12 Thread Gary Lee
osaf/services/saf/amf/amfd/csi.cc | 25 - osaf/services/saf/amf/amfd/include/sg.h | 1 - osaf/services/saf/amf/amfd/sgtype.cc| 3 ++- osaf/services/saf/amf/amfd/si.cc| 27 +-- osaf/services/saf/amf/amfd/svctype.cc | 20

[devel] [PATCH 0 of 1] Review Request for AMFD: errors reported in valgrind [#715]

2014-01-13 Thread Gary Lee
6024244cfcc20ae49b9c5d65b3e14f5b0770bd2b Author: Gary Lee gary@dektech.com.au Date: Mon, 13 Jan 2014 21:50:14 +1100 * remove saAmfStgValidSuTypes from 'struct avd_amf_sg_type_tag' as it appears to be a typo of saAmfSGtValidSuTypes * ensure saAmfCSIDependencies is deleted in csi.cc

[devel] [PATCH 1 of 1] * remove saAmfStgValidSuTypes from 'struct avd_amf_sg_type_tag' as it appears to

2014-01-13 Thread Gary Lee
osaf/services/saf/amf/amfd/csi.cc | 25 - osaf/services/saf/amf/amfd/include/sg.h | 1 - osaf/services/saf/amf/amfd/sgtype.cc| 3 ++- osaf/services/saf/amf/amfd/si.cc| 27 +-- osaf/services/saf/amf/amfd/svctype.cc | 20

Re: [devel] [PATCH 1 of 1] * remove saAmfStgValidSuTypes from 'struct avd_amf_sg_type_tag' as it appears to

2014-01-13 Thread Gary Lee
saAmfSIActiveWeight, saAmfSIStandbyWeight, saAmfSvcDefActiveWeight and saAmfSvcDefStandbyWeight are deleted in si.cc * fix a few typos where delete is called when delete [] is requiredOn 13/01/14 21:53, Gary Lee wrote: osaf/services/saf/amf/amfd/csi.cc | 25

[devel] [PATCH 0 of 1] Review Request for AMFND: errors reported by valgrind [#716]

2014-01-13 Thread Gary Lee
n Comments (indicate scope for each y above): - Ran a set of basic tests with valgrind turned on, and the errors reported in the ticket are no longer present. changeset 3299ba6200f9d66580509a2c3a91d2e771550c64 Author: Gary Lee gary

[devel] [PATCH 1 of 1] AMFND: errors reported by valgrind [#716]

2014-01-13 Thread Gary Lee
osaf/services/saf/amf/amfnd/amfnd.cc|4 +- osaf/services/saf/amf/amfnd/cbq.cc |4 +- osaf/services/saf/amf/amfnd/ckpt_updt.cc|4 +- osaf/services/saf/amf/amfnd/comp.cc | 14 +- osaf/services/saf/amf/amfnd/compdb.cc |6 +-

[devel] [PATCH 0 of 1] Review Request for amfd Invalid read when deleting a node from a node group [#719]

2014-01-15 Thread Gary Lee
will be provided shortly. changeset e66b9065269cf7d84921c3581c72b2e72217c5be Author: Gary Lee gary@dektech.com.au Date: Thu, 16 Jan 2014 16:05:59 +1100 amfd: Invalid read when deleting a node from a node group [#719] don't read beyond the end of saAmfNGNodeList, if the node to be removed

[devel] [PATCH 1 of 1] amfd: Invalid read when deleting a node from a node group [#719]

2014-01-15 Thread Gary Lee
osaf/services/saf/amf/amfd/nodegroup.cc | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) don't read beyond the end of saAmfNGNodeList, if the node to be removed from node group is at the end of the array. diff --git a/osaf/services/saf/amf/amfd/nodegroup.cc

[devel] [PATCH 0 of 1] Review Request for amfd: Invalid read when deleting a node from a node group [#719]

2014-01-15 Thread Gary Lee
n Other n Comments (indicate scope for each y above): - changeset 7ace16491a5d95040dd1701c4fd8c081bd6d1d0d Author: Gary Lee gary@dektech.com.au Date: Thu, 16 Jan 2014 16:29:35 +1100 amfd: Invalid read when deleting

[devel] [PATCH 1 of 1] amfd: Invalid read when deleting a node from a node group [#719]

2014-01-15 Thread Gary Lee
osaf/services/saf/avsv/avd/avd_nodegroup.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) don't read beyond the end of saAmfNGNodeList, if the node to be removed from node group is at the end of the array. diff --git a/osaf/services/saf/avsv/avd/avd_nodegroup.c

[devel] [PATCH 1 of 1] amfd: fix out-of-bounds read from nodelist array [#719]

2014-01-23 Thread Gary Lee
osaf/services/saf/amf/amfd/include/node.h | 1 + osaf/services/saf/amf/amfd/nodegroup.cc | 35 ++- osaf/services/saf/amf/amfd/sg.cc | 19 +--- 3 files changed, 36 insertions(+), 19 deletions(-) * fix out-of-bounds read in

[devel] [PATCH 0 of 1] Review Request for amfd: V2 Invalid read when deleting a node from a node group [#719]

2014-01-23 Thread Gary Lee
4826f11b8a7beb9714247454c69c468448e29ce1 Author: Gary Lee gary@dektech.com.au Date: Fri, 24 Jan 2014 16:37:36 +1100 amfd: fix out-of-bounds read from nodelist array [#719] * fix out-of-bounds read in ng_ccb_apply_modify_hdlr() when the node to be deleted is located

[devel] [PATCH 0 of 1] Review Request for amfnd: errors reported by valgrind (V2) [#716]

2014-01-27 Thread Gary Lee
situations, and replaced with osafassert(p != NULL) * added more comments to indicate when free() is used on AVSV_ATTR_NAME_VAL pointers changeset d5b481b75da0ee4518dc65567ee41a4db1974eb1 Author: Gary Lee gary@dektech.com.au Date: Tue, 28 Jan 2014 14:03:21 +1100 amfnd: fix errors reported

[devel] [PATCH 1 of 1] amfnd: fix errors reported by valgrind [#716]

2014-01-27 Thread Gary Lee
osaf/services/saf/amf/amfnd/amfnd.cc|4 +- osaf/services/saf/amf/amfnd/cbq.cc |4 +- osaf/services/saf/amf/amfnd/ckpt_updt.cc| 18 +- osaf/services/saf/amf/amfnd/comp.cc | 11 +- osaf/services/saf/amf/amfnd/compdb.cc |6 +-

[devel] [PATCH 1 of 2] amfd: remove unnecessary #includes [#680]

2014-02-09 Thread Gary Lee
osaf/services/saf/amf/amfd/app.cc| 1 - osaf/services/saf/amf/amfd/apptype.cc| 2 -- osaf/services/saf/amf/amfd/cluster.cc| 1 - osaf/services/saf/amf/amfd/nodegroup.cc | 1 - osaf/services/saf/amf/amfd/nodeswbundle.cc | 1 -

[devel] [PATCH 2 of 2] amfnd: remove unnecessary #includes [#680]

2014-02-09 Thread Gary Lee
osaf/services/saf/amf/amfnd/clm.cc | 2 -- osaf/services/saf/amf/amfnd/main.cc | 1 - 2 files changed, 0 insertions(+), 3 deletions(-) remove unnecessary #includes as reported by Coverity diff --git a/osaf/services/saf/amf/amfnd/clm.cc b/osaf/services/saf/amf/amfnd/clm.cc ---

[devel] [PATCH 0 of 2] Review Request for amf: remove unnecessary #includes [#680]

2014-02-09 Thread Gary Lee
Comments (indicate scope for each y above): - This patch series corrects Unnecessary header file (HFA) errors reported by Coverity. changeset 95725e699d9b738dcad359cac228266e7890220b Author: Gary Lee gary@dektech.com.au Date: Mon, 10 Feb 2014 13

[devel] [PATCH 1 of 2] amfd: fix big parameter passed by value errors

2014-02-10 Thread Gary Lee
osaf/services/saf/amf/amfd/include/ntf.h | 4 ++-- osaf/services/saf/amf/amfd/include/susi.h | 5 +++-- osaf/services/saf/amf/amfd/ntf.cc | 6 +++--- osaf/services/saf/amf/amfd/siass.cc | 2 +- osaf/services/saf/amf/amfd/sirankedsu.cc | 8 5 files changed, 13

[devel] [PATCH 0 of 2] Review Request for amf: Coverity issues in amfd/amfnd

2014-02-10 Thread Gary Lee
: Gary Lee gary@dektech.com.au Date: Tue, 11 Feb 2014 13:43:29 +1100 amfd: fix big parameter passed by value errors this patch fixes Big parameter passed by value (PASS_BY_VALUE) errors reported by Coverity, by coverting pass by value parameters to pass by const

[devel] [PATCH 1 of 1] amfd: Ensure HA state notification is sent when a SI is first assigned to a SU [#544]

2014-02-27 Thread Gary Lee
osaf/services/saf/amf/amfd/siass.cc | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/osaf/services/saf/amf/amfd/siass.cc b/osaf/services/saf/amf/amfd/siass.cc --- a/osaf/services/saf/amf/amfd/siass.cc +++ b/osaf/services/saf/amf/amfd/siass.cc @@ -259,6 +259,7 @@

[devel] [PATCH 0 of 1] Review Request for amfd: Ensure HA state notification is sent when a SI is first assigned to a SU [#544]

2014-02-27 Thread Gary Lee
Tests n Other n Comments (indicate scope for each y above): - changeset c5e9c0567f4236a809d38eee8d6a822dc9c53008 Author: Gary Lee gary@dektech.com.au Date: Fri, 28 Feb 2014 15:12:13 +1100 amfd

Re: [devel] [PATCH 1 of 1] amfd: Ensure HA state notification is sent when a SI is first assigned to a SU [#544]

2014-03-25 Thread Gary Lee
with them? Praveen? Thanks, Hans On 28 February 2014 05:19, Gary Lee gary@dektech.com.au wrote: osaf/services/saf/amf/amfd/siass.cc | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/osaf/services/saf/amf/amfd/siass.cc b/osaf/services/saf/amf/amfd/siass.cc

[devel] [PATCH 1 of 2] amfd: use job queue for IMM admin response [#817]

2014-03-30 Thread Gary Lee
osaf/services/saf/amf/amfd/imm.cc| 40 ++- osaf/services/saf/amf/amfd/include/imm.h | 16 2 files changed, 49 insertions(+), 7 deletions(-) Currently, admin operation responses from amfd are not synchronised with IMM changes that may be

[devel] [PATCH 2 of 2] amfd: Remove unnecessary traces [#817]

2014-03-30 Thread Gary Lee
osaf/services/saf/amf/amfd/imm.cc| 30 ++ osaf/services/saf/amf/amfd/include/imm.h | 2 +- 2 files changed, 3 insertions(+), 29 deletions(-) diff --git a/osaf/services/saf/amf/amfd/imm.cc b/osaf/services/saf/amf/amfd/imm.cc ---

[devel] [PATCH 0 of 2] Review Request for amfd: use job queue for IMM admin response [#817]

2014-03-30 Thread Gary Lee
n Comments (indicate scope for each y above): - changeset cd039d9f162b401419b1b0665190ceec20169846 Author: Gary Lee gary@dektech.com.au Date: Mon, 31 Mar 2014 14:57:48 +1100 amfd: use job queue for IMM admin response [#817

Re: [devel] [PATCH 2 of 2] amfd: Remove unnecessary traces [#817]

2014-04-16 Thread Gary Lee
agree? Thanks, Hans On 31 March 2014 06:32, Gary Lee gary@dektech.com.au wrote: osaf/services/saf/amf/amfd/imm.cc| 30 ++ osaf/services/saf/amf/amfd/include/imm.h | 2 +- 2 files changed, 3 insertions(+), 29 deletions(-) diff --git a/osaf

[devel] [PATCH 0 of 2] Review Request for amfd: use job queue for IMM admin response [#817]

2014-04-16 Thread Gary Lee
n Other n Comments (indicate scope for each y above): - changeset 692778b63490b8a45435dbecbccc56e56b831d1d Author: Gary Lee gary@dektech.com.au Date: Wed, 16 Apr 2014 16:11:25 +1000 amfd: use job queue for IMM admin

[devel] [PATCH 1 of 2] amfd: use job queue for IMM admin response [#817]

2014-04-16 Thread Gary Lee
osaf/services/saf/amf/amfd/imm.cc| 45 +++ osaf/services/saf/amf/amfd/include/imm.h | 16 +++ 2 files changed, 54 insertions(+), 7 deletions(-) Currently, admin operation responses from amfd are not synchronised with IMM changes that may be

[devel] [PATCH 1 of 1] amfd: Respond with TRY_AGAIN to admin ops during a controller switch-over [#821]

2014-04-21 Thread Gary Lee
osaf/services/saf/amf/amfd/imm.cc | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) It has been found that an admin operation (other than controller switch-over) can be started after a controller switch-over has been initiated. The result of this can be that the admin

[devel] [PATCH 0 of 1] Review Request for amfd: Respond with TRY_AGAIN to admin ops during a controller switch-over [#821]

2014-04-21 Thread Gary Lee
n Tests n Other n Comments (indicate scope for each y above): - changeset bb22e56cb9a68cd2230f9eb2dd930d2817750c83 Author: Gary Lee gary@dektech.com.au Date: Tue, 22 Apr 2014 13:25:02 +1000 amfd

[devel] [PATCH 0 of 1] Review Request for amfd: Respond with TRY_AGAIN to admin ops during a controller switch-over V2 [#821]

2014-04-22 Thread Gary Lee
n Tests n Other n Comments (indicate scope for each y above): - EXPLAIN/COMMENT THE PATCH SERIES HERE changeset ed011a4d972f515395c9be7b3ed06b3ffdda5934 Author: Gary Lee gary@dektech.com.au Date: Wed

Re: [devel] [PATCH 1 of 1] amfd: Respond with TRY_AGAIN to admin ops during a controller switch-over [#821]

2014-04-22 Thread Gary Lee
) { LOG_NO(SI Swap not possible, Controller role switch under progress); rc = SA_AIS_ERR_TRY_AGAIN; goto done; } } Thanks -Nagu -Original Message- From: Gary Lee [mailto:gary

[devel] [PATCH 1 of 1] amfnd: Cancel qscing timer on CSI removal [#583]

2014-04-27 Thread Gary Lee
osaf/services/saf/amf/amfnd/cbq.cc | 7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) If a SI is in SHUTTING-down mode and a lock request arrives, the component is required to call saAmfCSIQuiescingComplete() which shouldn't be needed. Therefore we should stop the qscing complete

[devel] [PATCH 0 of 1] Review Request for amfd: Remove asserts from validation routines [#849]

2014-05-08 Thread Gary Lee
Other n Comments (indicate scope for each y above): - changeset b1b63571db541aea1c11ea47fdaef92ce5ac9b08 Author: Gary Lee gary@dektech.com.au Date: Thu, 08 May 2014 15:52:36 +1000 amfd: Remove asserts from validation

[devel] [PATCH 1 of 1] amfd: Remove asserts from validation routines [#849]

2014-05-08 Thread Gary Lee
osaf/services/saf/amf/amfd/app.cc| 18 +++--- osaf/services/saf/amf/amfd/comp.cc | 5 +++-- osaf/services/saf/amf/amfd/compcstype.cc | 5 +++-- osaf/services/saf/amf/amfd/hlt.cc| 10 ++ osaf/services/saf/amf/amfd/sg.cc | 9 +

Re: [devel] [PATCH 1 of 1] amfd: add saflog for admin op response [#817]

2014-05-12 Thread Gary Lee
Ack. Thanks Gary On 12/05/14 19:55, Hans Feldt wrote: osaf/services/saf/amf/amfd/imm.cc | 11 +++ 1 files changed, 7 insertions(+), 4 deletions(-) diff --git a/osaf/services/saf/amf/amfd/imm.cc b/osaf/services/saf/amf/amfd/imm.cc --- a/osaf/services/saf/amf/amfd/imm.cc +++

Re: [devel] [PATCH 1 of 1] amfd: Remove asserts from validation routines [#849]

2014-05-16 Thread Gary Lee
of OpenSAF. But perhaps that is not a valid use case. Thanks Gary On 15/05/14 22:10, Nagendra Kumar wrote: Some comments inlined with Nagu Thanks -Nagu -Original Message- From: Gary Lee [mailto:gary@dektech.com.au] Sent: 08 May 2014 12:14 To: hans.fe...@ericsson.com; hans.nordeb

[devel] [PATCH 0 of 1] Review Request for amfd: use correct SU when calling set_su_failover [#713]

2014-05-22 Thread Gary Lee
n Comments (indicate scope for each y above): - changeset a34d5c6ada7bd10ac0518bb70830bcc9253627f7 Author: Gary Lee gary@dektech.com.au Date: Thu, 22 May 2014 17:17:24 +1000 amfd: use correct SU when calling set_su_failover [#713

[devel] [PATCH 1 of 1] amfd: use correct SU when calling set_su_failover [#713]

2014-05-22 Thread Gary Lee
osaf/services/saf/amf/amfd/su.cc | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) A typo was introduced when some SU logic was moved from comp.cc to su.cc. This may have caused a segfault when set_su_failover() is called on a null pointer. set_su_failover() should be called on this SU

[devel] [PATCH 1 of 2] amfnd: Improve logging for error escalation decisions [#870]

2014-05-25 Thread Gary Lee
osaf/services/saf/amf/amfnd/err.cc| 61 +++--- osaf/services/saf/amf/amfnd/include/avnd_cb.h | 2 + osaf/services/saf/amf/amfnd/include/avnd_su.h | 3 + osaf/services/saf/amf/amfnd/su.cc | 23 ++ 4 files changed, 82 insertions(+), 7

[devel] [PATCH 2 of 2] amfnd: Improve logging for error escalation decisions [#870]

2014-05-25 Thread Gary Lee
osaf/services/saf/amf/amfnd/err.cc | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) * fix spelling mistakes diff --git a/osaf/services/saf/amf/amfnd/err.cc b/osaf/services/saf/amf/amfnd/err.cc --- a/osaf/services/saf/amf/amfnd/err.cc +++ b/osaf/services/saf/amf/amfnd/err.cc @@

[devel] [PATCH 0 of 2] Review Request for amfnd: Improve logging for error escalation decisions [#870]

2014-05-25 Thread Gary Lee
n Other n Comments (indicate scope for each y above): - changeset 48092e505f992410f12cd05b94933917f95dba4b Author: Gary Lee gary@dektech.com.au Date: Mon, 26 May 2014 13:28:06 +1000 amfnd: Improve logging

Re: [devel] [PATCH 1 of 2] amfnd: Improve logging for error escalation decisions [#870]

2014-05-25 Thread Gary Lee
On 26/05/14 13:46, Gary Lee wrote: diff --git a/osaf/services/saf/amf/amfnd/su.cc b/osaf/services/saf/amf/amfnd/su.cc --- a/osaf/services/saf/amf/amfnd/su.cc +++ b/osaf/services/saf/amf/amfnd/su.cc @@ -462,6 +462,8 @@ uint32_t avnd_evt_tmr_su_err_esc_evh(AVN } TRACE('%s

[devel] [PATCH 0 of 2] Review Request for amfnd: V2 Improve logging for error escalation decisions [#870]

2014-05-28 Thread Gary Lee
n Other n Comments (indicate scope for each y above): - This is V2. changeset 24c1b4c093478d6b4b0933e52f9809f60fefa228 Author: Gary Lee gary@dektech.com.au Date: Wed, 28 May 2014 17:25:36 +1000 amfnd

[devel] [PATCH 2 of 2] amfnd: Fix spelling mistakes [#870]

2014-05-28 Thread Gary Lee
osaf/services/saf/amf/amfnd/err.cc | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/osaf/services/saf/amf/amfnd/err.cc b/osaf/services/saf/amf/amfnd/err.cc --- a/osaf/services/saf/amf/amfnd/err.cc +++ b/osaf/services/saf/amf/amfnd/err.cc @@ -1152,7 +1152,7 @@ uint32_t

[devel] [PATCH 1 of 2] amfnd: Improve logging for error escalation decisions [#870]

2014-05-28 Thread Gary Lee
osaf/services/saf/amf/amfnd/err.cc| 77 -- osaf/services/saf/amf/amfnd/include/avnd_cb.h | 2 + osaf/services/saf/amf/amfnd/include/avnd_su.h | 3 + osaf/services/saf/amf/amfnd/su.cc | 23 4 files changed, 98 insertions(+), 7

[devel] [PATCH 1 of 1] amfd: Remove asserts from validation routines [#849]

2014-05-28 Thread Gary Lee
osaf/services/saf/avsv/avd/avd_app.c| 17 - osaf/services/saf/avsv/avd/avd_comp.c | 5 +++-- osaf/services/saf/avsv/avd/avd_compcstype.c | 5 +++-- osaf/services/saf/avsv/avd/avd_csi.c| 3 ++- osaf/services/saf/avsv/avd/avd_csiattr.c| 2 +-

Re: [devel] [PATCH 1 of 2] amfnd: Improve logging for error escalation decisions [#870]

2014-05-29 Thread Gary Lee
Hi again :) On 30/05/14 11:05, Gary Lee wrote: 2. too many times doesn't look good. LOG_NO(components of '%s' restarted too many times (comp restart count: %d) should be changed to LOG_NO(components of '%s' restarted exceeds configured '%u' (comp restart count: %u), su

[devel] [PATCH 1 of 2] amfnd: Improve logging for error escalation decisions [#870]

2014-06-01 Thread Gary Lee
osaf/services/saf/amf/amfnd/err.cc| 48 +++--- osaf/services/saf/amf/amfnd/include/avnd_cb.h | 2 + osaf/services/saf/amf/amfnd/include/avnd_su.h | 3 + osaf/services/saf/amf/amfnd/su.cc | 23 4 files changed, 69 insertions(+), 7

[devel] [PATCH 2 of 2] amfnd: Fix spelling mistakes [#870]

2014-06-01 Thread Gary Lee
osaf/services/saf/amf/amfnd/err.cc | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/osaf/services/saf/amf/amfnd/err.cc b/osaf/services/saf/amf/amfnd/err.cc --- a/osaf/services/saf/amf/amfnd/err.cc +++ b/osaf/services/saf/amf/amfnd/err.cc @@ -1150,7 +1150,7 @@ uint32_t

Re: [devel] [PATCH 1 of 2] amfnd: Improve logging for error escalation decisions [#870]

2014-06-02 Thread Gary Lee
Hi Nagu Sorry, I forgot to change the 3 instances of '%d' below, to '%u'. Can you please change before pushing, or should I send another patch? Thanks Gary On Mon, 2014-06-02 at 13:08 +1000, Gary Lee wrote: + +void su_increment_su_restart_count(AVND_SU su) +{ + su.su_restart_cnt

[devel] [PATCH 2 of 3] amfd: Add constructor for AVD_SI [#713]

2014-06-09 Thread Gary Lee
osaf/services/saf/amf/amfd/include/si.h | 5 +++- osaf/services/saf/amf/amfd/si.cc| 43 ++-- 2 files changed, 38 insertions(+), 10 deletions(-) diff --git a/osaf/services/saf/amf/amfd/include/si.h b/osaf/services/saf/amf/amfd/include/si.h ---

[devel] [PATCH 1 of 3] amfd: Convert AVD_SI from struct to a class [#713]

2014-06-09 Thread Gary Lee
osaf/services/saf/amf/amfd/include/app.h| 6 ++-- osaf/services/saf/amf/amfd/include/sg.h | 31 ++-- osaf/services/saf/amf/amfd/include/si.h | 14 ++-- osaf/services/saf/amf/amfd/include/si_dep.h | 22 ++--

[devel] [PATCH 3 of 3] amfd: Convert SI weights from char** to a vector of strings [#713]

2014-06-09 Thread Gary Lee
osaf/services/saf/amf/amfd/include/si.h | 5 ++- osaf/services/saf/amf/amfd/si.cc| 45 2 files changed, 9 insertions(+), 41 deletions(-) diff --git a/osaf/services/saf/amf/amfd/include/si.h b/osaf/services/saf/amf/amfd/include/si.h ---

[devel] [PATCH 0 of 3] Review Request for amfd: Convert AVD_SI from struct to a class [#713]

2014-06-09 Thread Gary Lee
n Comments (indicate scope for each y above): - changeset da7b0f5e0a729dfcfc5e9674b584a1ceeca3c650 Author: Gary Lee gary@dektech.com.au Date: Tue, 10 Jun 2014 11:26:03 +1000 amfd: Convert AVD_SI from struct to a class [#713

Re: [devel] [users] Upcoming OpenSAF 4.5 Transport (MDS) PerformanceMeasurements

2014-06-09 Thread Gary Lee
Hi You can also get a snapshot of the latest code (not tested / not yet released) from: http://sourceforge.net/p/opensaf/staging/ci/default/tarball On 10/06/14 12:44, Yao Cheng LIANG wrote: Dear AVM, Thanks. But could you tell me the command to download it? I am not familiar with

[devel] [PATCH 1 of 1] amfd: Add constructor for AVD_SI [#713]

2014-06-10 Thread Gary Lee
osaf/services/saf/amf/amfd/include/si.h | 7 - osaf/services/saf/amf/amfd/si.cc| 43 ++-- 2 files changed, 40 insertions(+), 10 deletions(-) diff --git a/osaf/services/saf/amf/amfd/include/si.h b/osaf/services/saf/amf/amfd/include/si.h ---

[devel] [PATCH 0 of 1] Review Request for amfd: Add constructor for AVD_SI V2 [#713]

2014-06-10 Thread Gary Lee
Comments (indicate scope for each y above): - This is V2. The copy constructor and assignment operator are now private. changeset 6495aee4e47c098413c95979378d4de26cbf4537 Author: Gary Lee gary@dektech.com.au Date: Wed, 11 Jun 2014 10:11:05 +1000

[devel] [PATCH 1 of 4] amfd: Convert various SI static functions to class member functions [#713]

2014-06-10 Thread Gary Lee
osaf/services/saf/amf/amfd/include/si.h | 14 +++-- osaf/services/saf/amf/amfd/sgproc.cc| 2 +- osaf/services/saf/amf/amfd/si.cc| 80 osaf/services/saf/amf/amfd/siass.cc | 22 4 files changed, 60 insertions(+), 58 deletions(-)

[devel] [PATCH 0 of 4] Review Request for amfd: SI refactoring part 2 [#713]

2014-06-10 Thread Gary Lee
e9fa0d9f2cda7a41768e5409625951f8b92d4065 Author: Gary Lee gary@dektech.com.au Date: Wed, 11 Jun 2014 15:19:27 +1000 amfd: Change avd_si_adjust_si_assignments to a member function [#713] Make avd_si_adjust_si_assignments a class member function of AVD_SI changeset aaa8b697076cf3c9c37f515c5ca1ae2ef6941cf3 Author

[devel] [PATCH 3 of 4] amfd: Change si_update_ass_state() from a static to a member function of SI [#713]

2014-06-10 Thread Gary Lee
osaf/services/saf/amf/amfd/include/si.h | 1 + osaf/services/saf/amf/amfd/si.cc| 88 2 files changed, 44 insertions(+), 45 deletions(-) diff --git a/osaf/services/saf/amf/amfd/include/si.h b/osaf/services/saf/amf/amfd/include/si.h ---

[devel] [PATCH 4 of 4] amfd: Remove unused function avd_si_remove_rankedsu() [#713]

2014-06-10 Thread Gary Lee
osaf/services/saf/amf/amfd/include/si.h | 1 - osaf/services/saf/amf/amfd/si.cc| 20 2 files changed, 0 insertions(+), 21 deletions(-) diff --git a/osaf/services/saf/amf/amfd/include/si.h b/osaf/services/saf/amf/amfd/include/si.h ---

[devel] [PATCH 2 of 4] amfd: Change avd_si_adjust_si_assignments to a member function [#713]

2014-06-10 Thread Gary Lee
osaf/services/saf/amf/amfd/include/si.h | 2 + osaf/services/saf/amf/amfd/si.cc| 46 +++- 2 files changed, 24 insertions(+), 24 deletions(-) Make avd_si_adjust_si_assignments a class member function of AVD_SI diff --git

[devel] [PATCH 4 of 4] amfd: Convert set_si_switch from a macro to member function [#713]

2014-06-12 Thread Gary Lee
osaf/services/saf/amf/amfd/include/si.h | 7 + osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 2 +- osaf/services/saf/amf/amfd/sg_npm_fsm.cc | 38 +++--- osaf/services/saf/amf/amfd/sg_nway_fsm.cc | 28 +++--- osaf/services/saf/amf/amfd/si.cc

[devel] [PATCH 1 of 4] amfd: Convert avd_si_admin_state_set to a AVD_SI member function [#713]

2014-06-12 Thread Gary Lee
osaf/services/saf/amf/amfd/include/si.h | 3 +- osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 17 +++--- osaf/services/saf/amf/amfd/sg_nored_fsm.cc | 14 ++-- osaf/services/saf/amf/amfd/sg_npm_fsm.cc | 10 osaf/services/saf/amf/amfd/sg_nway_fsm.cc|

[devel] [PATCH 3 of 4] amfd: Convert add_rankedsu and remove_rankedsu to member functions [#713]

2014-06-12 Thread Gary Lee
osaf/services/saf/amf/amfd/include/si.h | 5 +++-- osaf/services/saf/amf/amfd/si.cc | 14 +++--- osaf/services/saf/amf/amfd/sirankedsu.cc | 4 ++-- 3 files changed, 12 insertions(+), 11 deletions(-) diff --git a/osaf/services/saf/amf/amfd/include/si.h

[devel] [PATCH 0 of 3] Review Request for amfd: SI refactoring part 4

2014-06-12 Thread Gary Lee
Comments (indicate scope for each y above): - This patch set is part 4 of SI refactoring. changeset 2c574664d8c2c58b36c962d3f212309ad204b01d Author: Gary Lee gary@dektech.com.au Date: Fri, 13 Jun 2014 15:39:39 +1000 amfd: move svctype

[devel] [PATCH 1 of 3] amfd: move svctype and svctypecstype declarations to separate files [#713]

2014-06-12 Thread Gary Lee
osaf/services/saf/amf/amfd/include/si.h| 34 +-- osaf/services/saf/amf/amfd/include/svctype.h | 38 ++ osaf/services/saf/amf/amfd/include/svctypecstype.h | 35 3 files changed, 75 insertions(+), 32 deletions(-) Move

[devel] [PATCH 3 of 3] amfd: convert remaining macros in si.cc to functions [#713]

2014-06-12 Thread Gary Lee
osaf/services/saf/amf/amfd/include/si.h | 10 +- osaf/services/saf/amf/amfd/sg_nway_fsm.cc| 10 +- osaf/services/saf/amf/amfd/sg_nwayact_fsm.cc | 10 +- osaf/services/saf/amf/amfd/si.cc | 20 4 files changed, 35 insertions(+),

Re: [devel] [PATCH 1 of 4] amfd: Convert avd_si_admin_state_set to a AVD_SI member function [#713]

2014-06-13 Thread Gary Lee
wrote: You can print si name also. Is there any reason to delete it from : - TRACE_ENTER2(%s AdmState %s = %s, si-name.value, - avd_adm_state_name[si-saAmfSIAdminState], avd_adm_state_name[state]); Thanks -Nagu -Original Message- From: Gary Lee [mailto:gary

Re: [devel] [PATCH 3 of 3] amfd: convert remaining macros in si.cc to functions [#713]

2014-06-15 Thread Gary Lee
Hi Hans On 13/06/14 20:49, Hans Feldt wrote: diff --git a/osaf/services/saf/amf/amfd/include/si.h b/osaf/services/saf/amf/amfd/include/si.h --- a/osaf/services/saf/amf/amfd/include/si.h +++ b/osaf/services/saf/amf/amfd/include/si.h @@ -122,6 +122,11 @@ public: void

Re: [devel] [PATCH 1 of 3] amfd: move svctype and svctypecstype declarations to separate files [#713]

2014-06-16 Thread Gary Lee
Thanks Hans. I'll add svctype.h and svctypecstype.h to include/Makefile.am Thanks Gary On 16/06/14 18:36, Hans Nordebäck wrote: ack, minor comment, the Makefile.am should be updated with the new header files. /Regards HansN On 06/13/14 07:48, Gary Lee wrote: osaf/services/saf/amf/amfd

[devel] [PATCH 2 of 4] amfd: Convert si_add_to_model to a member function [#713]

2014-06-25 Thread Gary Lee
osaf/services/saf/amf/amfd/include/si.h | 1 + osaf/services/saf/amf/amfd/si.cc| 34 2 files changed, 18 insertions(+), 17 deletions(-) diff --git a/osaf/services/saf/amf/amfd/include/si.h b/osaf/services/saf/amf/amfd/include/si.h ---

[devel] [PATCH 1 of 4] amfd: Change more SI functions to class member functions [#713]

2014-06-25 Thread Gary Lee
osaf/services/saf/amf/amfd/csi.cc | 4 ++-- osaf/services/saf/amf/amfd/include/si.h | 11 +++ osaf/services/saf/amf/amfd/sg_nway_fsm.cc | 4 ++-- osaf/services/saf/amf/amfd/si.cc | 25 - osaf/services/saf/amf/amfd/si_dep.cc | 2 +- 5

[devel] [PATCH 4 of 4] amfd: replace SI encode routines with simple encode [#713]

2014-06-25 Thread Gary Lee
osaf/services/saf/amf/amfd/ckpt_edu.cc | 64 -- osaf/services/saf/amf/amfd/ckpt_enc.cc | 204 2 files changed, 78 insertions(+), 190 deletions(-) diff --git a/osaf/services/saf/amf/amfd/ckpt_edu.cc b/osaf/services/saf/amf/amfd/ckpt_edu.cc ---

[devel] [PATCH 0 of 1] Review Request for amfd: SI refactoring part 3 [#713]

2014-06-25 Thread Gary Lee
Comments (indicate scope for each y above): - changeset 77a5839859012d839aeb7798b6fa0d8c141d4156 Author: Gary Lee gary@dektech.com.au Date: Thu, 26 Jun 2014 12:08:42 +1000 amfd: Convert remove_csi and add_csi to static member functions [#713

[devel] [PATCH 1 of 1] amfd: Convert remove_csi and add_csi to static member functions [#713]

2014-06-25 Thread Gary Lee
osaf/services/saf/amf/amfd/csi.cc | 4 ++-- osaf/services/saf/amf/amfd/include/si.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) These functions don't operate directly on this SI instance. Let's make them static member functions for now. diff --git

Re: [devel] [PATCH 1 of 1] amfd: Convert remove_csi and add_csi to static member functions [#713]

2014-06-26 Thread Gary Lee
- From: Gary Lee [mailto:gary@dektech.com.au] Sent: den 26 juni 2014 04:11 To: Hans Feldt; Hans Nordebäck; nagendr...@oracle.com Cc: opensaf-devel@lists.sourceforge.net Subject: [PATCH 1 of 1] amfd: Convert remove_csi and add_csi to static member functions [#713] osaf/services/saf/amf/amfd

[devel] [PATCH 0 of 1] Review Request for amfd: SI refactoring part 6 [#713]

2014-06-26 Thread Gary Lee
(indicate scope for each y above): - This should be applied on top of the SI refactoring part 5 patches (25/6/14). changeset d0e41ace78497c11eda3c5e017e51a987b7978d4 Author: Gary Lee gary@dektech.com.au Date: Fri, 27 Jun 2014 15:33:58 +1000

[devel] [PATCH 2 of 2] amfd: change avd_si_add_csi_db to a member function [#713]

2014-07-01 Thread Gary Lee
osaf/services/saf/amf/amfd/include/si.h | 1 + osaf/services/saf/amf/amfd/si.cc| 20 2 files changed, 13 insertions(+), 8 deletions(-) diff --git a/osaf/services/saf/amf/amfd/include/si.h b/osaf/services/saf/amf/amfd/include/si.h ---

[devel] [PATCH 0 of 2] Review Request for amfd: SI Refactoring part 7 [#713]

2014-07-01 Thread Gary Lee
(indicate scope for each y above): - This patchset should be applied on top of part 5 and 6. changeset 79f9022cbad2eb9b51e23455321a76022e1325b4 Author: Gary Lee gary@dektech.com.au Date: Wed, 02 Jul 2014 14:57:03 +1000 amfd: change

[devel] [PATCH 1 of 2] amfd: change avd_si_arrange_dep_csi to a member function [#713]

2014-07-01 Thread Gary Lee
osaf/services/saf/amf/amfd/include/si.h | 2 ++ osaf/services/saf/amf/amfd/si.cc| 10 ++ 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/osaf/services/saf/amf/amfd/include/si.h b/osaf/services/saf/amf/amfd/include/si.h ---

[devel] [PATCH 0 of 1] Review Request for amfd: Change AVD_APP to a class [#713]

2014-07-01 Thread Gary Lee
Comments (indicate scope for each y above): - changeset c3304c85d3aacadf4db8410f9d7d2df8d750e8d6 Author: Gary Lee gary@dektech.com.au Date: Wed, 02 Jul 2014 15:24:46 +1000 amfd: Change AVD_APP to a class [#713] Change AVD_APP from

[devel] [PATCH 0 of 1] Review Request for amfd: Change various AVD_APP functions to member functions [#713]

2014-07-02 Thread Gary Lee
n Comments (indicate scope for each y above): - changeset cb692c0417a755aeb376cdf4e08116c254c13159 Author: Gary Lee gary@dektech.com.au Date: Thu, 03 Jul 2014 11:42:27 +1000 amfd: Change various AVD_APP functions to member

  1   2   3   4   5   6   7   8   9   >