osaf/libs/agents/saf/imma/imma_om_api.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
The fix frees a memory for an object name in saImmOmAccessorGet_2.
diff --git a/osaf/libs/agents/saf/imma/imma_om_api.c
b/osaf/libs/agents/saf/imma/imma_om_api.c
---
n
Comments (indicate scope for each y above):
-
changeset 1e990cf4235cec566e9f093b1331791e475d0ea7
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Wed, 21 Aug 2013 14:11:16 +0200
IMM: fix memory leak
osaf/libs/agents/saf/imma/imma_init.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/osaf/libs/agents/saf/imma/imma_init.c
b/osaf/libs/agents/saf/imma/imma_init.c
--- a/osaf/libs/agents/saf/imma/imma_init.c
+++ b/osaf/libs/agents/saf/imma/imma_init.c
@@ -366,9 +366,7
Tests n
Other n
Comments (indicate scope for each y above):
-
changeset ad9c0007a7bbe0ea58fc692d213f78a002ed5b24
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Wed, 21 Aug 2013 15:00:12 +0200
n
Comments (indicate scope for each y above):
-
changeset 3ee0573bc266a5686c7d590d5f65952cc83fd647
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Tue, 27 Aug 2013 10:38:10 +0200
IMM: fix memory leak
osaf/libs/agents/saf/imma/imma_db.c | 31 +++
osaf/libs/agents/saf/imma/imma_om_api.c | 28 +---
2 files changed, 32 insertions(+), 27 deletions(-)
diff --git a/osaf/libs/agents/saf/imma/imma_db.c
b/osaf/libs/agents/saf/imma/imma_db.c
tests/immsv/common/immtest.c| 4
tests/immsv/implementer/test_SaImmOiRtAttrUpdateCallbackT.c | 2 +-
tests/immsv/implementer/test_cleanup.c | 3 ++-
tests/immsv/management/test_cleanup.c | 3 ++-
n
Comments (indicate scope for each y above):
-
changeset 0cdd2a5765b3dbf0a471ddb0c09bd99587ec1e9d
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Tue, 27 Aug 2013 10:53:50 +0200
IMMTOOL: Cleanup the code and fix
n
Comments (indicate scope for each y above):
-
changeset e4cce0be0c180ff2448e11557defb7d142e30886
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Fri, 06 Sep 2013 16:49:40 +0200
IMMTOOL: add missing library
n
Other n
Comments (indicate scope for each y above):
-
changeset 98d90041a07d10622a16883cdd3d934512401b5e
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Mon, 09 Sep 2013 14:58:45 +0200
IMM: fix
n
Comments (indicate scope for each y above):
-
changeset 6e718b7dfad5d813286331a7498cdc3351591288
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Thu, 12 Sep 2013 04:40:23 -0400
IMMTEST: Cleanup the code and fix
In
@@ -6469,8 +6478,7 @@ SaAisErrorT saImmOmSearchNext_2(SaImmSea
if (m_NCS_LOCK(cb-cb_lock, NCS_LOCK_WRITE) != NCSCC_RC_SUCCESS) {
TRACE_4(ERR_LIBRARY: Lock error);
- return SA_AIS_ERR_LIBRARY;
- /*Error case will leak memory. */
+
NACK from me.
cl_node and NCS_UNLOCK are not related at all, and freeing cl_node before
NCS_UNLOCK does not have any effect on NCS_UNLOCK.
There is a bug in locking/unlocking of the control block lock in #560 that I
missed in the review, and which may cause this assert if a client uses
Ack from me with a minor change.
Checking, if cl_node is NULL, is not necessary.
Best regards,
Zoran
-Original Message-
From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: den 24 oktober 2013 10:43
To: Anders Björnerstedt
Cc: opensaf-devel@lists.sourceforge.net
osaf/libs/agents/saf/imma/imma_om_api.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
Fix free of memory in saImmOmSearchNext_2 when imma type is not
IMMA_EVT_ND2A_SEARCHNEXT_RSP.
diff --git a/osaf/libs/agents/saf/imma/imma_om_api.c
b/osaf/libs/agents/saf/imma/imma_om_api.c
---
Ack from me.
Reviewed and tested.
Zoran
-Original Message-
From: Anders Bjornerstedt [mailto:anders.bjornerst...@ericsson.com]
Sent: den 5 november 2013 07:48
To: reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [devel] [PATCH 0 of 1] Review Request for IMM:
osaf/libs/agents/saf/imma/imma_om_api.c | 36 +--
osaf/libs/common/immsv/include/immpbe_dump.hh | 2 +-
osaf/libs/saf/include/Makefile.am | 3 +-
osaf/libs/saf/include/saImmOm_A_2_12.h| 2 +
osaf/libs/saf/include/saImmOm_A_2_13.h| 60
osaf/tools/safimm/immcfg/imm_import.cc | 2 ++
osaf/tools/safimm/immdump/imm_xmlw_dump.cc | 9 +
osaf/tools/safimm/immlist/imm_list.c | 3 +++
3 files changed, 14 insertions(+), 0 deletions(-)
Support reference integrity (NO_DANGLING flag) to IMM tools
diff --git
osaf/libs/agents/saf/imma/imma_om_api.c | 36 +--
osaf/libs/common/immsv/include/immpbe_dump.hh | 2 +-
osaf/libs/common/immsv/include/immsv_api.h| 9
osaf/libs/saf/include/Makefile.am | 3 +-
osaf/libs/saf/include/saImmOm_A_2_12.h| 2 +
to IMM tools [#49]
Hi Zoran,
make rpm fails after applying this patch series. Entry needs to be added for
saImmOm_A_2_13.h in opensaf.spec file.
Regards,
Sirisha
On 12/05/2013 08:34 PM, Zoran Milinkovic wrote:
osaf/tools/safimm/immcfg/imm_import.cc | 2 ++
osaf/tools/safimm/immdump
. These issues have been already mentioned in earlier review comments.
Thanks,
Zoran
-Original Message-
From: Neelakanta Reddy [mailto:reddy.neelaka...@oracle.com]
Sent: den 12 december 2013 14:20
To: Zoran Milinkovic; Anders Björnerstedt
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 0
n
Comments (indicate scope for each y above):
-
changeset 5581ca82a63f307e4a7e6427fd1d898a9505ea4a
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Sun, 15 Dec 2013 16:42:12 +0100
IMM: Add support for NO_DANGLING flag
osaf/services/saf/immsv/immnd/ImmModel.cc | 101 +-
osaf/services/saf/immsv/immnd/ImmModel.hh |4 +
2 files changed, 103 insertions(+), 2 deletions(-)
diff --git a/osaf/services/saf/immsv/immnd/ImmModel.cc
b/osaf/services/saf/immsv/immnd/ImmModel.cc
---
osaf/libs/agents/saf/imma/imma_om_api.c | 64 +++-
osaf/libs/saf/include/saImmOm_A_2_13.h | 13 ++
2 files changed, 66 insertions(+), 11 deletions(-)
diff --git a/osaf/libs/agents/saf/imma/imma_om_api.c
b/osaf/libs/agents/saf/imma/imma_om_api.c
---
n
Tests n
Other n
Comments (indicate scope for each y above):
-
changeset c1d4723658c97fd09efae45e4ac1efe2dcfc1ae7
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Thu, 02 Jan 2014 13:15
osaf/tools/safimm/immcfg/imm_cfg.c | 36 +++-
1 files changed, 19 insertions(+), 17 deletions(-)
Fix RDN value with a DN of an associated object when a new object is created by
immcfg.
diff --git a/osaf/tools/safimm/immcfg/imm_cfg.c
Hi Mathi,
OpenSAF fails to compile after pushing the patch #219.
CC clmtest-tet_saClmResponse.o
../../tests/clmsv/src/tet_saClmResponse.c: In function 'saClmResponse_01':
../../tests/clmsv/src/tet_saClmResponse.c:94:13: error: variable 'ret' set but
not used
y
Other n
Comments (indicate scope for each y above):
-
changeset 2712ca2144d20f371dc462264ba722e6eb82031f
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Thu, 16 Jan 2014 12:48:29 +0100
IMMTEST: add new
n
Other n
Comments (indicate scope for each y above):
-
changeset 831e17f0116b2b157a14ea8be9f798f5336a8205
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Thu, 16 Jan 2014 13:20:37 +0100
IMM: fix wrong error
osaf/services/saf/immsv/README.NO_DANGLING | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/osaf/services/saf/immsv/README.NO_DANGLING
b/osaf/services/saf/immsv/README.NO_DANGLING
--- a/osaf/services/saf/immsv/README.NO_DANGLING
+++
Hi Anders,
Ack from me,
Zoran
-Original Message-
From: Anders Björnerstedt
Sent: den 30 januari 2014 14:23
To: reddy.neelaka...@oracle.com; Zoran Milinkovic; sirisha.a...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 0 of 1] Review Request for IMM: README clarified
osaf/libs/saf/include/saImmOm_A_2_13.h| 2 +-
osaf/libs/saf/include/saNtf.h | 2 +-
tests/clmsv/src/tet_saClmClusterNodeGet.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/osaf/libs/saf/include/saImmOm_A_2_13.h
b/osaf/libs/saf/include/saImmOm_A_2_13.h
y
Other n
Comments (indicate scope for each y above):
-
changeset dd89c701f85342ff48f64c0e18637dff6cd60ea0
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Mon, 03 Feb 2014 13:12:15 +0100
osaf: fix
osaf/tools/safimm/immcfg/imm_cfg.c | 31 +++-
osaf/tools/safimm/immcfg/imm_import.cc | 196 -
osaf/tools/safimm/immdump/imm_dumper.cc| 170 +++-
osaf/tools/safimm/immdump/imm_dumper.hh|2 +
osaf/services/saf/immsv/immnd/ImmModel.cc | 39
-
osaf/services/saf/immsv/immnd/ImmSearchOp.cc | 2 +-
osaf/services/saf/immsv/immnd/ImmSearchOp.hh | 4 +-
n
Other n
Comments (indicate scope for each y above):
-
changeset 7f121b591dd1c5464ee9f1070058ded74650b913
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Tue, 18 Feb 2014 15:56:38 +0100
IMM: add support
n
Other n
Comments (indicate scope for each y above):
-
changeset 4e107d75f25bb46d71db0de3fd6ca8700be57f61
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Tue, 18 Feb 2014 15:57:23 +0100
IMM: add support
osaf/libs/common/immsv/immpbe_dump.cc |2 +-
osaf/services/saf/immsv/immloadd/imm_loader.cc | 164 -
osaf/services/saf/immsv/immnd/ImmModel.cc | 36 +-
osaf/services/saf/immsv/immnd/ImmSearchOp.cc |2 +-
osaf/tools/safimm/immcfg/imm_cfg.c | 31 +++-
osaf/tools/safimm/immcfg/imm_import.cc | 196 -
osaf/tools/safimm/immdump/imm_dumper.cc| 168 +++-
osaf/tools/safimm/immdump/imm_dumper.hh|2 +
Tests n
Other n
Comments (indicate scope for each y above):
-
changeset 3112b9aeccd503e2f876afb3909480aed2d53bcb
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Tue, 18 Feb 2014 15:57:47 +0100
IMM
n
Other n
Comments (indicate scope for each y above):
-
changeset 5d03eb30ac8a399dfef00880331ac5673c5842ac
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Fri, 21 Feb 2014 17:18:28 +0100
IMM: add support
osaf/tools/safimm/immcfg/imm_cfg.c | 31 -
osaf/tools/safimm/immcfg/imm_import.cc | 178 ++-
osaf/tools/safimm/immlist/imm_list.c|6 -
osaf/tools/safimm/immload/imm_loader.cc | 150 +-
4 files changed, 333 insertions(+), 32
osaf/libs/common/immsv/immpbe_dump.cc |2 +-
osaf/services/saf/immsv/immloadd/imm_loader.cc | 140 -
osaf/services/saf/immsv/immnd/ImmModel.cc | 36 +++--
osaf/services/saf/immsv/immnd/ImmSearchOp.cc |2 +-
n
Other n
Comments (indicate scope for each y above):
-
changeset a4a323a7c56dc5db04cbbf373a7585de0a456074
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Fri, 21 Feb 2014 17:28:23 +0100
IMM: add support
osaf/tools/safimm/immcfg/imm_cfg.c | 31 -
osaf/tools/safimm/immcfg/imm_import.cc | 172 -
2 files changed, 193 insertions(+), 10 deletions(-)
For forwards compatibility, OpenSAF schema, where unknown attribute flags are
defined, must be provided to
Tests n
Other n
Comments (indicate scope for each y above):
-
changeset 4d742de378fe7a3f25f7e80637d4f41be5c29544
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Fri, 21 Feb 2014 17:30:37 +0100
IMM
osaf/tools/safimm/immcfg/imm_cfg.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/osaf/tools/safimm/immcfg/imm_cfg.c
b/osaf/tools/safimm/immcfg/imm_cfg.c
--- a/osaf/tools/safimm/immcfg/imm_cfg.c
+++ b/osaf/tools/safimm/immcfg/imm_cfg.c
@@ -690,7 +690,7 @@ int
n
Tests n
Other n
Comments (indicate scope for each y above):
-
changeset 49265005f0316416e76efec4bfa3eabf5456d8c7
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Tue, 25 Feb 2014 09:58
osaf/services/infrastructure/fm/config/fm_objects.xml | 2 +-
osaf/services/infrastructure/fm/config/fm_sc_template.xml | 2 +-
osaf/services/infrastructure/rde/config/rde_objects.xml | 2 +-
osaf/services/infrastructure/rde/config/rde_sc_template.xml | 2 +-
n
Samples n
Tests n
Other n
Comments (indicate scope for each y above):
-
changeset e392e08b28e60d6ea541a52b50238039cec9f770
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Thu
osaf/services/infrastructure/fm/config/fm_objects.xml | 2 +-
osaf/services/infrastructure/fm/config/fm_sc_template.xml | 2 +-
osaf/services/infrastructure/rde/config/rde_objects.xml | 2 +-
osaf/services/infrastructure/rde/config/rde_sc_template.xml | 2 +-
osaf/libs/common/immsv/immpbe_dump.cc | 2 ++
osaf/tools/safimm/immlist/imm_list.c | 8
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/osaf/libs/common/immsv/immpbe_dump.cc
b/osaf/libs/common/immsv/immpbe_dump.cc
--- a/osaf/libs/common/immsv/immpbe_dump.cc
+++
Hi Neelakanta,
Generally, ack from me, with a comment to Anders's comment.
I think you can use state-attrDefinitions to determine if a class is
persistent runtime or not.
state-attrDefinitions is used just before you add a class name to
runtimeClass set.
Best regards,
Zoran
-Original
osaf/services/saf/immsv/immnd/ImmModel.cc| 49 +++-
osaf/services/saf/immsv/immnd/ImmSearchOp.cc | 1 +
osaf/services/saf/immsv/immnd/ImmSearchOp.hh | 4 ++
3 files changed, 53 insertions(+), 1 deletions(-)
diff --git a/osaf/services/saf/immsv/immnd/ImmModel.cc
Reviewed and tested.
Ack from me.
Regards,
Zoran
-Original Message-
From: Hans Feldt [mailto:osafde...@gmail.com]
Sent: den 31 mars 2014 08:05
To: Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 0 of 1] Review Request for immutil #827
Summary: immutil: change
osaf/services/saf/immsv/immnd/ImmModel.cc| 59 +++-
osaf/services/saf/immsv/immnd/ImmSearchOp.cc | 1 +
osaf/services/saf/immsv/immnd/ImmSearchOp.hh | 4 +
osaf/services/saf/immsv/immnd/immnd_cb.h | 4 +
4 files changed, 67 insertions(+), 1 deletions(-)
n
Comments (indicate scope for each y above):
-
changeset edaff973d0ca8a1d3a5f1466fced05445e2f68a2
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Tue, 01 Apr 2014 10:34:54 +0200
IMM: release inactive search handles
osaf/tools/safimm/immcfg/imm_cfg.c | 69 +++--
1 files changed, 36 insertions(+), 33 deletions(-)
diff --git a/osaf/tools/safimm/immcfg/imm_cfg.c
b/osaf/tools/safimm/immcfg/imm_cfg.c
--- a/osaf/tools/safimm/immcfg/imm_cfg.c
+++
n
Other n
Comments (indicate scope for each y above):
-
changeset a866790f3345c3f99c57d7cb9aa9579a1d5c34ad
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Wed, 02 Apr 2014 15:22:02 +0200
IMM
osaf/services/saf/immsv/immnd/ImmModel.cc | 60 +++
osaf/services/saf/immsv/immnd/ImmModel.hh | 5 ++
osaf/services/saf/immsv/immnd/immnd_evt.c | 27 -
3 files changed, 89 insertions(+), 3 deletions(-)
When an implementer is detached from an
n
Other n
Comments (indicate scope for each y above):
-
changeset cd5fa346756eb5e5d48a9e6345bff5c33136e683
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Thu, 03 Apr 2014 11:13:35 +0200
IMM: fix memory leak
+ typename AmfDbMap::iterator it = db.find(name);
+ db.erase(it);
The code above can be replaced with:
db.erase(name);
So, no extra checks for iterators.
Regards,
Zoran
-Original Message-
From: praveen malviya [mailto:praveen.malv...@oracle.com]
Sent: den 4 april 2014 15:24
To:
The ticket had been written only for the first case ERR_NOT_EXIST: object
'%s' exist but no implementer (which is required).
I'll change the text before I push the code.
Regards,
Zoran
-Original Message-
From: Hans Feldt
Sent: den 7 april 2014 13:49
To: Zoran Milinkovic
n
Other n
Comments (indicate scope for each y above):
-
changeset 4f9d846cfc5c07bbd957a08491c32a3556ccb97f
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Tue, 08 Apr 2014 10:38:16 +0200
IMMTOOLS: fix
I'll change to ULL when I push the code.
Thanks,
Zoran
-Original Message-
From: Hans Nordebäck
Sent: den 8 april 2014 11:00
To: Zoran Milinkovic; reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [devel] [PATCH 1 of 1] IMMTOOLS: fix errors compiled with 32
Ack from me.
Reviewed and tested.
Find minor comments below in the code started with [Zoran]
Best regards,
Zoran
-Original Message-
From: Anders Björnerstedt
Sent: den 4 april 2014 14:53
To: reddy.neelaka...@oracle.com; Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject
is fixed.
Best regards,
Zoran
-Original Message-
From: Anders Björnerstedt
Sent: den 4 april 2014 14:53
To: reddy.neelaka...@oracle.com; Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 2 of 3] IMM: Support for saImmOmCcbValidate API [#798]
osaf/libs/agents/saf/imma
.
where as either in PBE or in dumpcase the precision is not yet followed
(probably a new ticket may be created for fixing at later stage)
/Neel.
On Tuesday 25 March 2014 06:29 PM, Zoran Milinkovic wrote:
Summary: IMMTOOLS: fix printing and dumping for float and double
values [#53] Review
sqlite3 function
for retrieving results.
Best regards,
Zoran
-Original Message-
From: Neelakanta Reddy [mailto:reddy.neelaka...@oracle.com]
Sent: den 9 april 2014 13:15
To: Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 0 of 1] Review Request for IMMTOOLS
osaf/services/saf/immsv/immnd/ImmModel.cc | 66 +++
osaf/services/saf/immsv/immnd/ImmModel.hh | 5 ++
osaf/services/saf/immsv/immnd/immnd_evt.c | 27 +++-
3 files changed, 95 insertions(+), 3 deletions(-)
IMM service should give more information in the
n
Other n
Comments (indicate scope for each y above):
-
changeset c6f33ab8ac26a7f39a4ad270f151b9b42270633e
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Mon, 14 Apr 2014 13:56:55 +0200
IMM
osaf/libs/common/immsv/immpbe_dump.cc | 2 ++
osaf/tools/safimm/immlist/imm_list.c | 8
2 files changed, 6 insertions(+), 4 deletions(-)
Set a correct floating point precision for printed and dumped float and double
values, so that the floating point precision is not lost when the
libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each y above):
-
changeset c59d3d9d25a39fd3325a3f455ac10c551f4b93ad
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date
osaf/tools/safimm/immcfg/imm_cfg.c | 13 +
osaf/tools/safimm/immcfg/imm_import.cc | 34 ++
2 files changed, 31 insertions(+), 16 deletions(-)
For backwards compatibility, it's needed to revert the code for old way of
parsing default values.
Thanks for the comment.
I'll add it to the help before I push the code.
Thanks,
Zoran
-Original Message-
From: Reddy Neelakanta Reddy Peddavandla [mailto:reddy.neelaka...@oracle.com]
Sent: den 24 april 2014 16:07
To: Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re
Hi Neelakanta,
I have few comments to the patch:
1. Why did you disable enabling and disabling notifications in explicit commit
mode ?
2. strcpy() in line 788 is not safe. adminOwnerName may have less allocated
bytes than safImmService. For example: if an application change immcfg name
into
: den 1 maj 2014 11:32
To: Anders Björnerstedt; Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] Imm:Make immcfg aware of safImmService admin owner for
opensafImm=opensafImm, safApp=safImmService [#840]
osaf/tools/safimm/immcfg/imm_cfg.c | 44
Ack from me.
Reviewed the code, but didn't test.
Best regards,
Zoran
-Original Message-
From: Anders Björnerstedt
Sent: den 29 april 2014 16:37
To: reddy.neelaka...@oracle.com; Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 0 of 1] Review Request for imm: Allow
osaf/libs/common/immsv/immsv_evt.c | 56 ++-
osaf/libs/common/immsv/include/immsv_evt.h | 4 +
osaf/libs/common/immsv/include/immsv_evt_model.h | 1 +
osaf/services/saf/immsv/immd/immd_evt.c | 9 ++-
osaf/services/saf/immsv/immnd/ImmModel.cc
tests/immsv/implementer/test_cleanup.c |1 +
tests/immsv/implementer/test_saImmOiImplementerSet.c | 287 +++
2 files changed, 288 insertions(+), 0 deletions(-)
Test cases cover OI callback timeout and timeout on searching for an object
with RTA
diff --git
osaf/libs/agents/saf/imma/imma_cb.h | 1 +
osaf/libs/agents/saf/imma/imma_def.h| 1 +
osaf/libs/agents/saf/imma/imma_oi_api.c | 23 ++-
3 files changed, 24 insertions(+), 1 deletions(-)
IMMA uses IMMA_OI_CALLBACK_TIMEOUT for sending OI timeout to IMM service
Tests n
Other n
Comments (indicate scope for each y above):
-
changeset 174e38438e18982b0433476fdac513a83fa5a8d0
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Tue, 13 May 2014 10:20:48 +0200
Hi Neelakanta,
Find my answers inline.
Best regards,
Zoran
-Original Message-
From: Neelakanta Reddy [mailto:reddy.neelaka...@oracle.com]
Sent: den 15 maj 2014 11:49
To: Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 0 of 3] Review Request for imm: add
n
Other n
Comments (indicate scope for each y above):
-
changeset 49409a21fed3a54a1690d59ac9fd7db421ad83b8
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Tue, 20 May 2014 17:33:02 +0200
imm: fix
osaf/services/saf/immsv/immloadd/imm_pbe_load.cc | 80 +--
1 files changed, 57 insertions(+), 23 deletions(-)
When immload loads data from PBE, in the first loaded value of a double type
attribute, the floating-point precision is not fully supported.
The patch provides the
Hi Neelakanta,
Find comments inline
-Original Message-
From: Neelakanta Reddy [mailto:reddy.neelaka...@oracle.com]
Sent: den 15 maj 2014 17:14
To: Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 0 of 3] Review Request for imm: add support for
configurable
Good work.
Ack from me.
Best regards,
Zoran
-Original Message-
From: mahesh.va...@oracle.com [mailto:mahesh.va...@oracle.com]
Sent: den 27 maj 2014 06:11
To: Anders Björnerstedt; Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 0 of 1] Review Request for imm
y
Other n
Comments (indicate scope for each y above):
-
changeset eaf47d593b82de803a1c174bc0cb1076723735d3
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Thu, 05 Jun 2014 14:32:15 +0200
imm: add support
osaf/libs/common/immsv/immsv_evt.c | 56 +-
osaf/libs/common/immsv/include/immsv_evt.h | 4 +
osaf/libs/common/immsv/include/immsv_evt_model.h | 1 +
osaf/services/saf/immsv/immd/immd_evt.c | 9 ++-
osaf/services/saf/immsv/immnd/ImmModel.cc|
tests/immsv/implementer/test_cleanup.c |1 +
tests/immsv/implementer/test_saImmOiImplementerSet.c | 336 +++
2 files changed, 337 insertions(+), 0 deletions(-)
Test cases cover OI callback timeout and timeout on searching for an object
with RTA
diff --git
Review but didn't test.
Ack from me.
Best regards,
Zoran
-Original Message-
From: Anders Bjornerstedt [mailto:anders.bjornerst...@ericsson.com]
Sent: den 9 juni 2014 08:18
To: reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [devel] [PATCH 0 of 1] Review
Hi,
Find my comments on ntfsv_sanamet_clone_strptr cases inline.
-Original Message-
From: Minh Hon Chau [mailto:minh.c...@dektech.com.au]
Sent: den 2 juli 2014 07:50
To: Anders Widell; mathi.naic...@oracle.com; Hans Feldt;
praveen.malv...@oracle.com
Cc:
Hi,
Find my comments inline started with [Zoran].
-Original Message-
From: Minh Hon Chau [mailto:minh.c...@dektech.com.au]
Sent: den 2 juli 2014 07:50
To: Anders Widell; mathi.naic...@oracle.com; Hans Feldt;
praveen.malv...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject:
tests/immsv/common/immtest.c | 30 +-
tests/immsv/implementer/Makefile.am |1 +
tests/immsv/implementer/applier.c| 24 +-
tests/immsv/implementer/test_cleanup.c | 38 +-
tests/immsv/implementer/test_saImmOiLongDn.c | 621
n
Comments (indicate scope for each y above):
-
changeset 60ba40f3a2b55b564b73630d38bb594ac4eeced7
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Mon, 14 Jul 2014 16:29:00 +0200
imm: add support for long DN to IMM service
Björnerstedt; Hans Feldt; Zoran Milinkovic;
opensaf-devel@lists.sourceforge.net; Anders Widell; praveen.malv...@oracle.com
Subject: Re: [PATCH 2 of 7] NTF: Adapt NTF common library to support long DNs
[#873] v3
Hi,
Could you point out the endianness problem that is mentioned in the review
tests/immsv/implementer/test_cleanup.c |1 +
tests/immsv/implementer/test_saImmOiImplementerSet.c | 336 +++
2 files changed, 337 insertions(+), 0 deletions(-)
Test cases cover OI callback timeout and timeout on searching for an object
with RTA
diff --git
osaf/libs/common/immsv/immsv_evt.c | 54 +++-
osaf/libs/common/immsv/include/immsv_evt.h |4 +
osaf/libs/common/immsv/include/immsv_evt_model.h |1 +
osaf/services/saf/immsv/immd/immd_evt.c |9 +-
osaf/services/saf/immsv/immnd/ImmModel.cc
[mailto:reddy.neelaka...@oracle.com]
Sent: den 23 juli 2014 16:48
To: Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 0 of 4] Review Request for imm: add support for long DN
[#886]
Hi zoran,
Reviewed and tested the patch.
have the same comments as AndersBj.
Regarding the patch 4
n
Comments (indicate scope for each y above):
-
changeset b29dc6b34fa33948bf6e3d390ad908257fa353d6
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Thu, 24 Jul 2014 10:07:37 +0200
imm: add support for long DN to IMM service
1 - 100 of 678 matches
Mail list logo
