Summary: imm: have try again handling in apitest [#2828] Review request for Ticket(s): 2828 Peer Reviewer(s): Hans, Anders W, Lennart, Ravi Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2828 Base revision: b3c8028c3312ffe13c815dbe0249947a5c4947dc Personal repository: git://git.code.sf.net/u/winhvu/review
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services n Core libraries n Samples n Tests y Other n NOTE: Patch(es) contain lines longer than 80 characers Comments (indicate scope for each "y" above): --------------------------------------------- *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** revision 75e4799cee1befd309dc862e921919fc8394630f Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au> Date: Thu, 5 Apr 2018 15:20:16 +0700 imm: have try again handling in apitest [#2828] Use immutil_<xxx> wrappers for try again handling of corresponding <xxx> API. Complete diffstat: ------------------ src/imm/apitest/Makefile | 8 +- src/imm/apitest/immtest.c | 33 +- src/imm/apitest/immtest.h | 1 + src/imm/apitest/implementer/applier.c | 24 +- .../implementer/test_SaImmOiAdminOperation.c | 324 ++++++------ src/imm/apitest/implementer/test_SaImmOiCcb.c | 110 ++-- .../test_SaImmOiRtAttrUpdateCallbackT.c | 48 +- .../implementer/test_saImmOiAugmentCcbInitialize.c | 192 +++---- .../test_saImmOiClassImplementerRelease.c | 46 +- .../implementer/test_saImmOiClassImplementerSet.c | 112 ++-- src/imm/apitest/implementer/test_saImmOiDispatch.c | 17 +- src/imm/apitest/implementer/test_saImmOiFinalize.c | 11 +- .../implementer/test_saImmOiImplementerClear.c | 16 +- .../implementer/test_saImmOiImplementerSet.c | 151 +++--- .../apitest/implementer/test_saImmOiInitialize_2.c | 23 +- src/imm/apitest/implementer/test_saImmOiLongDn.c | 192 +++---- .../test_saImmOiObjectImplementerRelease.c | 118 ++--- .../implementer/test_saImmOiObjectImplementerSet.c | 170 +++--- .../implementer/test_saImmOiRtObjectCreate_2.c | 78 +-- .../implementer/test_saImmOiRtObjectDelete.c | 55 +- .../implementer/test_saImmOiRtObjectUpdate_2.c | 170 +++--- .../apitest/implementer/test_saImmOiSaStringT.c | 374 ++++++------- .../implementer/test_saImmOiSelectionObjectGet.c | 13 +- src/imm/apitest/management/populate.c | 26 +- src/imm/apitest/management/test_cleanup.c | 26 +- .../management/test_saImmOmAccessorFinalize.c | 26 +- .../apitest/management/test_saImmOmAccessorGet_2.c | 92 ++-- .../management/test_saImmOmAccessorInitialize.c | 22 +- .../test_saImmOmAdminOperationContinue.c | 34 +- .../management/test_saImmOmAdminOwnerClear.c | 62 +-- .../management/test_saImmOmAdminOwnerFinalize.c | 38 +- .../management/test_saImmOmAdminOwnerInitialize.c | 56 +- .../management/test_saImmOmAdminOwnerRelease.c | 68 +-- .../apitest/management/test_saImmOmAdminOwnerSet.c | 96 ++-- src/imm/apitest/management/test_saImmOmCcbApply.c | 170 +++--- .../apitest/management/test_saImmOmCcbFinalize.c | 32 +- .../apitest/management/test_saImmOmCcbInitialize.c | 46 +- .../management/test_saImmOmCcbObjectCreate_2.c | 396 +++++++------- .../management/test_saImmOmCcbObjectDelete.c | 336 ++++++------ .../management/test_saImmOmCcbObjectModify_2.c | 578 ++++++++++----------- .../apitest/management/test_saImmOmClassCreate_2.c | 426 +++++++-------- .../apitest/management/test_saImmOmClassDelete.c | 30 +- .../management/test_saImmOmClassDescriptionGet_2.c | 52 +- .../test_saImmOmClassDescriptionMemoryFree_2.c | 26 +- src/imm/apitest/management/test_saImmOmDispatch.c | 16 +- src/imm/apitest/management/test_saImmOmFinalize.c | 10 +- .../apitest/management/test_saImmOmInitialize.c | 32 +- src/imm/apitest/management/test_saImmOmLongDn.c | 118 ++--- src/imm/apitest/management/test_saImmOmSaStringT.c | 186 +++---- .../management/test_saImmOmSearchFinalize.c | 16 +- .../management/test_saImmOmSearchInitialize_2.c | 70 +-- .../apitest/management/test_saImmOmSearchNext_2.c | 32 +- .../management/test_saImmOmSelectionObjectGet.c | 12 +- .../management/test_saImmOmThreadInterference.c | 56 +- 54 files changed, 2739 insertions(+), 2733 deletions(-) Testing Commands: ----------------- Restart one or several nodes during running `immoitest` and `immomtest` Testing, Expected Results: -------------------------- The test applications are not crashed or no test failed due to getting TRY_AGAIN. Conditions of Submission: ------------------------- Get acks from reviewers Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel