[devel] [PATCH 0 of 1] Review Request for amfd: push notification in existing job queue for retries [#314] V2
Summary: amfd: push notification in existing job queue for retries [#314] V2. Review request for Trac Ticket(s): #314 Peer Reviewer(s): AMf devs Pull request to: <> Affected branch(es): ALL Development branch: <> Impacted area Impact y/n Docsn Build systemn RPM/packaging n Configuration files n Startup scripts n SAF servicesy OpenSAF servicesn Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): - V2 version: Includes suggestions given by Gary. changeset 808b682422d2ceb0feb28045a07c83275ba0f687 Author: Praveen Malviya Date: Mon, 24 Oct 2016 12:15:09 +0530 amfd: push notification in existing job queue for retries [#314] V2 V2 version: Includes suggestions given by Gary. Currently if AMFD gets TRY_AGAIN or TIMEOUT it logs notification and frees it. AMFD will push the notification in the existing job queue. Job queue already handles TRY_AGAIN and TIMEOUT. Complete diffstat: -- osaf/services/saf/amf/amfd/imm.cc| 35 +++ osaf/services/saf/amf/amfd/include/imm.h | 26 +++- osaf/services/saf/amf/amfd/include/ntf.h |1 + osaf/services/saf/amf/amfd/main.cc |6 ++-- osaf/services/saf/amf/amfd/ntf.cc| 154 +- osaf/services/saf/amf/amfd/sgproc.cc |2 +- 6 files changed, 145 insertions(+), 79 deletions(-) Testing Commands: - <> Testing, Expected Results: -- <> Conditions of Submission: - <> Arch Built StartedLinux distro --- mipsn n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: --- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot ___ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
[devel] [PATCH 0 of 1] Review Request for amfd: push notification in existing job queue for retries [#314]
Summary: amfd: push notification in existing job queue for retries [#314] Review request for Trac Ticket(s): #314 Peer Reviewer(s): AMF devs Pull request to: <> Affected branch(es): ALL Development branch: <> Impacted area Impact y/n Docsn Build systemn RPM/packaging n Configuration files n Startup scripts n SAF servicesy OpenSAF servicesn Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): - changeset eb3bef9c5bff38d4ccbfc8f22ee664fb2e1b6311 Author: Praveen Malviya Date: Thu, 13 Oct 2016 15:36:45 +0530 amfd: push notification in existing job queue for retries [#314] Currently if AMFD gets TRY_AGAIN or TIMEOUT it logs notification and frees it. With this patch, AMFD will give one try. AMFD will push the notification in the existing job queue if hits with TRY_AGAIN or TIMEOUT in this try. Job queue already handles TRY_AGAIN and TIMEOUT. Complete diffstat: -- osaf/services/saf/amf/amfd/imm.cc| 28 +- osaf/services/saf/amf/amfd/include/imm.h | 14 ++-- osaf/services/saf/amf/amfd/include/ntf.h |9 ++- osaf/services/saf/amf/amfd/main.cc |6 +- osaf/services/saf/amf/amfd/ntf.cc| 182 ++-- osaf/services/saf/amf/amfd/sgproc.cc |2 +- 6 files changed, 164 insertions(+), 77 deletions(-) Testing Commands: - Not tested the test given in the description. Brought up one controller. Brougt up AMF Demo. Testing, Expected Results: -- Got notifications. Conditions of Submission: - Ack from Gary and other reviewers. Arch Built StartedLinux distro --- mipsn n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: --- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot ___ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
