Re: [devel] [PATCH 1 of 1] imm: Dont allow standby IMMD to send fevs if active IMMD is still up [#2029]

Hi Hung, You are right. I was looking at the new IF statement "if (active || !cb->immd_remote_up) {" instead of the old one "if (active || possible_fo || !cb->immd_remote_up) { " Ack from me when you remove IF statement with coord_exists from previous comment. BR, Zoran From: Hung Nguyen

Re: [devel] [PATCH 1 of 1] imm: Dont allow standby IMMD to send fevs if active IMMD is still up [#2029]

Hi Hung, A minor comment inline. -Original Message- From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au] Sent: den 20 september 2016 07:38 To: Zoran Milinkovic ; reddy.neelaka...@oracle.com Cc: opensaf-devel@lists.sourceforge.net Subject: [PATCH 1 of

Re: [devel] [PATCH 1 of 1] imm: Dont allow standby IMMD to send fevs if active IMMD is still up [#2029]

Hi Zoran, In the original code, the conditional statement only checks for 'coord_exists' and 'possible_fo' if (coord_exists) { if (possible_fo) { immd_proc_rebroadcast_fevs(cb, 2); } so we don't need to check 'immd_remote_up' Yes,

Re: [devel] [PATCH 1 of 1] imm: Dont allow standby IMMD to send fevs if active IMMD is still up [#2029]

Hi Hung, Reviewed and tested the patch. Ack. /Neel. On 2016/09/20 11:07 AM, Hung Nguyen wrote: > osaf/services/saf/immsv/immd/immd_amf.c | 1 + > osaf/services/saf/immsv/immd/immd_evt.c | 2 +- > osaf/services/saf/immsv/immd/immd_proc.c | 49 > ++- >

[devel] [PATCH 1 of 1] imm: Dont allow standby IMMD to send fevs if active IMMD is still up [#2029]

osaf/services/saf/immsv/immd/immd_amf.c | 1 + osaf/services/saf/immsv/immd/immd_evt.c | 2 +- osaf/services/saf/immsv/immd/immd_proc.c | 49 ++- osaf/services/saf/immsv/immd/immd_proc.h | 2 +- 4 files changed, 25 insertions(+), 29 deletions(-) During node