[devel] [PATCH 2/2] dtm: Added following options --max-backups and --max-file-size to osaflog tool and in transportd [#2731]

2018-03-09 Thread syam-talluri
--- src/dtm/common/osaflog_protocol.h | 13 +++ src/dtm/tools/osaflog.cc | 168 -- src/dtm/transport/log_server.cc | 74 - src/dtm/transport/log_server.h| 14 ++-- src/dtm/transport/log_writer.cc | 5 +- src/dtm/transport/lo

Re: [devel] [PATCH 2/2] dtm: Added following options --max-backups and --max-file-size to osaflog tool and in transportd [#2731]

2018-02-15 Thread Syam Prasad Talluri
Thanks Anders. Please see my responses inline below marked <> Will fix cpplint warnings while incorporating review comments. regards, Syam. -Original Message- From: Anders Widell [mailto:anders.wid...@ericsson.com] Sent: Tuesday, February 13, 2018 9:38 PM To: syam-talluri Cc: opensaf-d

Re: [devel] [PATCH 2/2] dtm: Added following options --max-backups and --max-file-size to osaflog tool and in transportd [#2731]

2018-02-13 Thread Anders Widell
Hi! General comment: I notice that you have changed the interface between the osaflog command and the osaftransportd server from a simple text-based format into a binary format defined by several structures and enums. This makes the code more complicated and error-prone, so please change it b

[devel] [PATCH 2/2] dtm: Added following options --max-backups and --max-file-size to osaflog tool and in transportd [#2731]

2018-02-12 Thread syam-talluri
--- src/dtm/common/osaflog_protocol.h | 15 +++ src/dtm/tools/osaflog.cc | 262 ++ src/dtm/transport/log_server.cc | 60 - src/dtm/transport/log_server.h| 10 +- src/dtm/transport/main.cc | 5 +- src/dtm/transport/transportd.c