Hi Hoang, ACK Not tested V5 ( tested V4 )
-AVM > > > On 9/19/2016 1:19 PM, Vo Minh Hoang wrote: >> Dear Mahesh, >> >> I run osaftest (ckpttest) with 1 SC is old version and others are new >> version. >> I cannot test for [fail over /switch over] cases in my environment. >> >> Thank you and best regards, >> Hoang >> >> -----Original Message----- >> From: A V Mahesh [mailto:mahesh.va...@oracle.com] >> Sent: Monday, September 19, 2016 1:27 PM >> To: Vo Minh Hoang <hoang.m...@dektech.com.au> >> Subject: Re: [devel] [PATCH 0 of 1] Review Request for cpsv: To update >> checkpoint user number for each node [#1669] V5 >> >> Hi Hoang, >> >> Sure I will do it, can you please send me the list of test you done for >> this patch, >> >> so that I can skip those case , like collected /no-collocated / fail >> over >> /switch over when cktpt was opend/ by closing on some node ect ... >> >> -AVM >> >> >> On 9/19/2016 9:01 AM, Vo Minh Hoang wrote: >>> Dear Mahesh, >>> >>> Would you please help me reviewing this patch. >>> It seems submitted for long. >>> >>> Thank you and best regards, >>> Hoang >>> >>> -----Original Message----- >>> From: Hoang Vo [mailto:hoang.m...@dektech.com.au] >>> Sent: Friday, August 19, 2016 12:30 PM >>> To: mahesh.va...@oracle.com >>> Cc: opensaf-devel@lists.sourceforge.net >>> Subject: [devel] [PATCH 0 of 1] Review Request for cpsv: To update >>> checkpoint user number for each node [#1669] V5 >>> >>> Summary: cpsv: To update checkpoint user number for each node [#1669] >>> V5 Review request for Trac Ticket(s): 1669 Peer Reviewer(s): >>> mahesh.va...@oracle.com; anders.wid...@ericsson.com Pull request to: >>> mahesh.va...@oracle.com; Affected branch(es): default Development >>> branch: >>> default >>> >>> -------------------------------- >>> Impacted area Impact y/n >>> -------------------------------- >>> Docs n >>> Build system n >>> RPM/packaging n >>> Configuration files n >>> Startup scripts n >>> SAF services y >>> OpenSAF services n >>> Core libraries n >>> Samples n >>> Tests n >>> Other n >>> >>> >>> Comments (indicate scope for each "y" above): >>> --------------------------------------------- >>> >>> changeset 09fb5a5a13c8362268fec6059aa997c942b8f257 >>> Author: Hoang Vo <hoang.m...@dektech.com.au> >>> Date: Fri, 19 Aug 2016 12:00:54 +0700 >>> >>> cpsv: To update checkpoint user number for each node [#1669] V5 >>> >>> Problem: >>> ------- The saCkptCheckpointNumOpeners is not updated when a node >>> which has a >>> checkpoint client restarts. >>> >>> Solution: >>> -------- Currently CPD doesn't store number of user on each node. >>> This patch >>> updates CPD to update information about users on each node for each >>> checkpoint. When a node restarts, the CPD update the total >>> number of >>> users >>> for a checkpoint accordingly. This is reflected on >>> saCkptCheckpointNumOpeners attribute correctly. >>> >>> >>> Complete diffstat: >>> ------------------ >>> osaf/libs/common/cpsv/include/cpd_cb.h | 6 +++- >>> osaf/libs/common/cpsv/include/cpd_proc.h | 3 ++ >>> osaf/libs/common/cpsv/include/cpd_red.h | 13 +++++++++++ >>> osaf/libs/common/cpsv/include/cpsv_evt.h | 8 +++++++ >>> osaf/services/saf/cpsv/cpd/cpd_db.c | 14 ++++++++++- >>> osaf/services/saf/cpsv/cpd/cpd_evt.c | 8 +++++++ >>> osaf/services/saf/cpsv/cpd/cpd_mbcsv.c | 97 >>> >> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---- >> >>> ---------- >>> osaf/services/saf/cpsv/cpd/cpd_proc.c | 148 >>> >> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ >> >>> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++ >>> osaf/services/saf/cpsv/cpd/cpd_red.c | 30 >> ++++++++++++++++++++------ >>> osaf/services/saf/cpsv/cpd/cpd_sbevt.c | 57 >>> +++++++++++++++++++++++++++++++++++++++++-------- >>> 10 files changed, 347 insertions(+), 37 deletions(-) >>> >>> >>> Testing Commands: >>> ----------------- >>> >>> 1. Create a checkpoint on PL3 with flag (creation flag >>> SA_CKPT_WR_ALL_REPLICAS) 2. Open this checkpoint on PL4 3. Restart PL3 >>> >>> Testing, Expected Results: >>> -------------------------- >>> After step 3. the saCkptCheckpointNumOpeners is changed. >>> >>> Conditions of Submission: >>> ------------------------- >>> ACK from maintainer >>> >>> Arch Built Started Linux distro >>> ------------------------------------------- >>> mips n n >>> mips64 n n >>> x86 n n >>> x86_64 y y >>> powerpc n n >>> powerpc64 n n >>> >>> >>> Reviewer Checklist: >>> ------------------- >>> [Submitters: make sure that your review doesn't trigger any >>> checkmarks!] >>> >>> >>> Your checkin has not passed review because (see checked entries): >>> >>> ___ Your RR template is generally incomplete; it has too many blank >> entries >>> that need proper data filled in. >>> >>> ___ You have failed to nominate the proper persons for review and push. >>> >>> ___ Your patches do not have proper short+long header >>> >>> ___ You have grammar/spelling in your header that is unacceptable. >>> >>> ___ You have exceeded a sensible line length in your >> headers/comments/text. >>> ___ You have failed to put in a proper Trac Ticket # into your commits. >>> >>> ___ You have incorrectly put/left internal data in your comments/files >>> (i.e. internal bug tracking tool IDs, product names etc) >>> >>> ___ You have not given any evidence of testing beyond basic build >>> tests. >>> Demonstrate some level of runtime or other sanity testing. >>> >>> ___ You have ^M present in some of your files. These have to be >>> removed. >>> >>> ___ You have needlessly changed whitespace or added whitespace crimes >>> like trailing spaces, or spaces before tabs. >>> >>> ___ You have mixed real technical changes with whitespace and other >>> cosmetic code cleanup changes. These have to be separate commits. >>> >>> ___ You need to refactor your submission into logical chunks; there is >>> too much content into a single commit. >>> >>> ___ You have extraneous garbage in your review (merge commits etc) >>> >>> ___ You have giant attachments which should never have been sent; >>> Instead you should place your content in a public tree to be >>> pulled. >>> >>> ___ You have too many commits attached to an e-mail; resend as threaded >>> commits, or place in a public tree for a pull. >>> >>> ___ You have resent this content multiple times without a clear >>> indication >>> of what has changed between each re-send. >>> >>> ___ You have failed to adequately and individually address all of the >>> comments and change requests that were proposed in the initial >> review. >>> ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) >>> >>> ___ Your computer have a badly configured date and time; confusing the >>> the threaded patch review. >>> >>> ___ Your changes affect IPC mechanism, and you don't present any >>> results >>> for in-service upgradability test. >>> >>> ___ Your changes affect user manual and documentation, your patch >>> series >>> do not contain the patch that updates the Doxygen manual. >>> >>> >>> ---------------------------------------------------------------------- >>> ------ >>> -- >>> _______________________________________________ >>> Opensaf-devel mailing list >>> Opensaf-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/opensaf-devel >>> >> > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
