Re: [devel] [PATCH 1 of 1] cpnd: use shared memory based on ckpt name length [#2108] V2

2016-10-27 Thread A V Mahesh
Hi Hoang, ACK form me. Function change looks less and code resignations looks much, to make review easy next time on-words please split the function change & code resignations in to different patches ( 1 of 2 & 2 of 2). Not Tested , in-service upgrade & log DN cases -AVM On 10/27/2016 12:4

Re: [devel] [PATCH 1 of 1] cpnd: use shared memory based on ckpt name length [#2108] V2

2016-10-27 Thread Vo Minh Hoang
Dear Mahesh, I tested with cases: - Old active with new standby - Old standby with new active Each case, create checkpoint, create section, write and read section, close and unlink. Sincerely, Hoang -Original Message- From: A V Mahesh [mailto:mahesh.va...@oracle.com] Sent: Thursday, Oc

Re: [devel] [PATCH 1 of 1] cpnd: use shared memory based on ckpt name length [#2108] V2

2016-10-26 Thread A V Mahesh
Hi Hoang, Have you tested in-service upgrade case ? -AVM On 10/26/2016 2:33 PM, Hoang Vo wrote: > osaf/libs/common/cpsv/include/cpsv_shm.h | 28 +- > osaf/services/saf/cpsv/cpnd/cpnd_res.c | 868 > -- > 2 files changed, 355 insertions(+), 541 deletions(-) >

Re: [devel] [PATCH 1 of 1] cpnd: use shared memory based on ckpt name length [#2108] V2

2016-10-25 Thread A V Mahesh
Hi Hoan, What I tested is a simple default cpsv `small format shm` ( Short-DN) functionality, this `big format shm` (LONG-DN) fix has side-effect/implication on existing functionality and these issue will become more complex to handle bugs, so please test all case as follows with new patch a

Re: [devel] [PATCH 1 of 1] cpnd: use shared memory based on ckpt name length [#2108] V2

2016-10-25 Thread Vo Minh Hoang
Dear Mahesh, Thank you very much for your help. Compared to your test app I found my test stop too soon. After reboot I just check shm existence, did not check to open again. I will send fix patch soon after carefully test it again. Thank you and best regards, Hoang -Original Message- F

Re: [devel] [PATCH 1 of 1] cpnd: use shared memory based on ckpt name length [#2108] V2

2016-10-25 Thread A V Mahesh
Hi Hoang, The attached `test_#2108_app.c` application will generate cpnd shm open request is getting failed case #gcc test_#2108_app.c -o checkpoint -lSaCkpt -AVM On 10/25/2016 12:23 PM, A V Mahesh wrote: Hi Hoang, On 10/25/2016 12:10 PM, Vo Minh Hoang wrote: Would you please tell me the

Re: [devel] [PATCH 1 of 1] cpnd: use shared memory based on ckpt name length [#2108] V2

2016-10-24 Thread A V Mahesh
Hi Hoang, On 10/25/2016 12:10 PM, Vo Minh Hoang wrote: > Would you please tell me the process to reproduce this error? I will write standalone application and will share with you . -AVM On 10/25/2016 12:10 PM, Vo Minh Hoang wrote: > Dear Mahesh, > > Thank you very much for your checking. > It is

Re: [devel] [PATCH 1 of 1] cpnd: use shared memory based on ckpt name length [#2108] V2

2016-10-24 Thread Vo Minh Hoang
Dear Mahesh, Thank you very much for your checking. It is very strangle that I tested with 2 following case: - restart nd by kill -9 - restart node by kill -9 Both cases executed well in my local machine. Would you please tell me the process to reproduce this error? It is very strangle that ER

Re: [devel] [PATCH 1 of 1] cpnd: use shared memory based on ckpt name length [#2108] V2

2016-10-24 Thread A V Mahesh
Hi Hoang, With the patch after CPND restart cpnd shm open request is getting failed please test CPND restart cases. saCkptCheckpointOpen returned checkpointHandle 626040 222 saCkpt

Re: [devel] [PATCH 1 of 1] cpnd: use shared memory based on ckpt name length [#2108]

2016-10-19 Thread Anders Widell
Although it is technically possible to upgrade OpenSAF without rebooting the node, in practice this is neither tested nor recommended anyway. So I don't think you need to support "version 2" in the new code. We do support downgrade of OpenSAF, and I guess it can't be worse than downgrading to a

Re: [devel] [PATCH 1 of 1] cpnd: use shared memory based on ckpt name length [#2108]

2016-10-18 Thread Vo Minh Hoang
Dear Anders and Mahesh, Thank you very much for your comments. I would like to clarify the backward compatible satisfaction in this case. We have `small format shm` that is used from beginning (version 1). We also have `big format shm` that is introduced with Long DN feature (changeset 7949:815c5

Re: [devel] [PATCH 1 of 1] cpnd: use shared memory based on ckpt name length [#2108]

2016-10-18 Thread A V Mahesh
Hi Hoang, Swamping SHM looks more complex logic to me while accessing old & new shm in transit , and it will create more issue and will take some time to stabilize. Let us explore other options like Anders Widell suggested or any other, which can be simple and avoids the SHM swap. I assessed t

Re: [devel] [PATCH 1 of 1] cpnd: use shared memory based on ckpt name length [#2108]

2016-10-18 Thread Anders Widell
Maybe it is better to create a second shm containing a fixed-size record of the remaining 2048-256 bytes of the DN? Then you will not have to convert the shm format and creating a new shm segment should be very quick. regards, Anders Widell On 10/18/2016 09:29 AM, Vo Minh Hoang wrote: > Dear

Re: [devel] [PATCH 1 of 1] cpnd: use shared memory based on ckpt name length [#2108]

2016-10-18 Thread Vo Minh Hoang
Dear Mahesh, Sorry I miss-sending incomplete email. This is full version. -- I would like to send my answer to 2 of your concerning points in compound. Based on my understand, a client command affects shared mem by following behavior: Client --> CPA ==> CPND (1) ==> CPD (active) ==> CPND (ha

Re: [devel] [PATCH 1 of 1] cpnd: use shared memory based on ckpt name length [#2108]

2016-10-18 Thread Vo Minh Hoang
Dear Mahesh, I would like to send my answer to 2 of your concerning points in compound. Based on my understand, a client command affects shared mem by following behavior: Client --> CPA ==> CPND (1) ==> CPD (active) ==> CPND (has replica) (2) > update shm (3) When: --> -Original Mes

Re: [devel] [PATCH 1 of 1] cpnd: use shared memory based on ckpt name length [#2108]

2016-10-17 Thread A V Mahesh
Hi Hoang, On 10/18/2016 11:24 AM, Vo Minh Hoang wrote: > Dear Mahesh, > >>> [AVM] A non-collated Ckpt will have two replicas on both Active and > standby. > Each node will receive one CPND_EVT_D2ND_CKPT_CREATE message so it handles > swapping itself and does not affect each other nor another. [AV

Re: [devel] [PATCH 1 of 1] cpnd: use shared memory based on ckpt name length [#2108]

2016-10-17 Thread Vo Minh Hoang
Dear Mahesh, >> [AVM] A non-collated Ckpt will have two replicas on both Active and standby. Each node will receive one CPND_EVT_D2ND_CKPT_CREATE message so it handles swapping itself and does not affect each other nor another. >> [AVM] piratically we can have large size data & transit time, if

Re: [devel] [PATCH 1 of 1] cpnd: use shared memory based on ckpt name length [#2108]

2016-10-17 Thread A V Mahesh
Hi Hoan, On 10/18/2016 9:59 AM, Vo Minh Hoang wrote: > Dear Mahesh, > > Thank you very much for your comments. > > I would like to explain my understanding and reason for this solution. > Please correct me if I am wrong. > > - This memory swapping works on single node alone, it will occur maximum

Re: [devel] [PATCH 1 of 1] cpnd: use shared memory based on ckpt name length [#2108]

2016-10-17 Thread Vo Minh Hoang
Dear Mahesh, Thank you very much for your comments. I would like to explain my understanding and reason for this solution. Please correct me if I am wrong. - This memory swapping works on single node alone, it will occur maximum once per node in open/create checkpoint process. - This swapping ac

Re: [devel] [PATCH 1 of 1] cpnd: use shared memory based on ckpt name length [#2108]

2016-10-17 Thread A V Mahesh
Hi Hoang, On 10/13/2016 12:44 PM, Vo Minh Hoang wrote: > No, old checkpoint data is converted to `big format`. > So all of them will be stored in `big format`. [AVM] This approach is introducing NEW transit , so far application are aware of switch-over & fail-over transit and TRY-AGAIN is expec

Re: [devel] [PATCH 1 of 1] cpnd: use shared memory based on ckpt name length [#2108]

2016-10-13 Thread Vo Minh Hoang
Dear Mahesh, Because of keeping the consistent working behavior of existing function, only 1 shared memory at a time. If shared memory swapping action occurs, a new shared memory will replace old one. Here is the detailed answers to your questions: >> -The existing `small format shm` will cont

Re: [devel] [PATCH 1 of 1] cpnd: use shared memory based on ckpt name length [#2108]

2016-10-12 Thread A V Mahesh
Hi Hoang, >> - Run time cpnd keep using small format shm until first longDN checkpoint is created. >> After that cpnd use big format shm. While reviewing I am assuming following please confirm : -The existing `small format shm` will continue to be small , is that right ? -Only newly crea